| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The hit-region for windows need to be larger for touch events to allow
resizing windows easily, while continuing to use a smaller hit-region
for mouse-events.
BUG=135187
Review URL: https://chromiumcodereview.appspot.com/10854060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen
Get/Set ParentBounds -> Get/Set BoundsInParent
GetWorkAreaScreenBounds -> GetWorkAreaBoundsInScreen
GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen
GetWindowScreenBounds -> GetWindowBoundsInScreen
GetScreenBounds -> GetBoundsInScreen
GetRootWindowBounds -> GetBoundsInRootWindow
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10795013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When setting widget bounds.
- Workspace Manager
- When resizing
- Restore bounds
* Refactored ScreenPositionClient to manage Screen coordinates for different configurations.
* Renamed GetBounds/SetBounds methods to GetScreen/ParentBounds to make it clear that in which coordinates you're dealing with.
* I used InScreen/InParent for RestoreBounds because RestoreParent/ScreenBounds sounds strange.
Converted Linux/Aura to use ScreenPositionClient.
BUG=123160
TEST=several tests are updated to match VSC. added screen_ash_unittests. I'll update rest of tests when this is enable by default.
Review URL: https://chromiumcodereview.appspot.com/10696023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs:
ui_resources.pak ==> duplicated in each scaled-resource pak
ui_resources_standard.h ==> merged into ui_resources.h
ui_resources_standard_map.h ==> renamed to ui_resources_map.h
ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc
theme_resources.rc ==> merged into theme_resources_standard.rc
theme_resources.pak ==> duplicated in each scaled-resource pak
theme_resources_standard.h ==> merged into theme_resources.h
theme_resources_standard_map.h ==> merged into theme_resources_map.h
theme_resources_standard_map.cc ==> merged into theme_resources_map.cc
The image duplication is intentional; we may revisit this later.
Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL.
TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org
BUG=133570
TEST=Trybots, local build
Review URL: https://chromiumcodereview.appspot.com/10756018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/frame to use ImageSkia
Do conversion using the same sed script as for 10437006
Modified by hand afterwards:
1 chrome/browser/download/download_util.cc
2 chrome/browser/ui/panels/panel_browser_frame_view.cc
3 chrome/browser/ui/panels/panel_browser_frame_view.h
4 chrome/browser/ui/toolbar/wrench_menu_model.cc
5 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc
6 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h
7 chrome/browser/ui/views/constrained_window_views.cc
8 chrome/browser/ui/views/frame/glass_browser_frame_view.cc
9 chrome/browser/ui/views/tab_icon_view.h
10 ui/base/dragdrop/drag_utils.h
11 ui/base/dragdrop/drag_utils_gtk.cc
12 ui/base/dragdrop/drag_utils_win.cc
13 ui/base/native_theme/native_theme_android.cc
14 ui/base/native_theme/native_theme_android.h
15 ui/base/native_theme/native_theme_base.cc
16 ui/base/native_theme/native_theme_base.h
17 ui/views/widget/native_widget_private.h
18 ui/views/window/frame_background.h
19 ui/views/window/window_resources.h
Line wrapping and include fixes
chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc
1 chrome/browser/ui/views/frame/browser_view.cc
2 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
3 ui/base/dragdrop/drag_utils_aura.cc
4 ui/base/dragdrop/os_exchange_data_provider_aura.h
5 ui/base/native_theme/native_theme_aura.cc
6 ui/views/button_drag_utils.h
7 ui/views/painter.cc
8 ui/views/painter.h
9 ui/views/widget/native_widget_aura.cc
10 ui/views/widget/widget_delegate.h
11 ui/views/window/custom_frame_view.cc
12 ui/views/window/custom_frame_view.h
Test=Compiles, Webkit layout tests fast/ pass
Bug=124566
Review URL: https://chromiumcodereview.appspot.com/10447053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first patch that tried to convert oak from static_library to component was
r136217, but later it was reverted in r136229 because it broke the aura
compile on Linux and Windows with the following error:
out/Release/../../third_party/gold/gold64:
out/Release/obj.target/ash/libash.so:error: undefined reference to
'oak::ShowOakWindow()'to...
The only change here from the first patch was the addition of oak.h include in
oak_window.cc, and that addition seems to have fixed the above issue.
I'll make sure it passes linux_aura,win_aura before landing this again.
TEST=run out/Debug/ash_shell --ash-enable-oak, press Ctrl+Shift+F1, the Oak
window should appear and it should work fine.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10453007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben,brettw,hclam
Review URL: https://chromiumcodereview.appspot.com/10391121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current setup, if you have a header file my_class.h
class BASE_EXPORT MyClass {
public:
void MyInlineMethod() { /* do stuff, inline */ }
};
then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.
With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).
Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.
BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan
Review URL: https://chromiumcodereview.appspot.com/10386108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the getter accessor of parent_owned() because it's used only internally by View.
And change the setter accessor from set_parent_owned() to set_owned_by_client().
BUG=122384
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10384068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out/Release/../../third_party/gold/gold64:
out/Release/obj.target/ash/libash.so:error: undefined reference to
'oak::ShowOakWindow()'
Revert 136217 - ui/oak: Build oak as a component library.
And export ShowOakWindow() function.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310050
TBR=tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10389058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And export ShowOakWindow() function.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10375030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104040
R=piman@chromium.org,ben@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen bounds.
- Renames aura::Window::GetScreenBounds() to ::GetBoundsInRootWindow(),
which is what it really does.
- NativeWidgetAura now gives its NativeWidgetHelperAura a chance to
modify those bounds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10210005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced sk_canvas()->drawColor() with DrawColor()
Removed any instances of #include "third_party/skia/include/core/SkCanvas.h"
Replaced DrawPath in touch_selection_controller_impl with DrawCircle call manually
Bug=114665
Test=Compiles
Review URL: http://codereview.chromium.org/10025011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows couldn't be positioned flush with the top edge of the launcher because we were reserving 2 pixels above the launcher to allow the window resize handles to be clicked. When combined with the grid for window sizes this meant windows had to sit 16 pixels above the launcher. I changed the hit test override code to take gfx::Insets so we can have a special hit test inset just for the top of the launcher and status area windows, which allows the windows to sit flush and keeps the resize handle clickable.
BUG=119970
TEST=manual
R=sky@chromium.org
Review URL: http://codereview.chromium.org/9855031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328
Review URL: https://chromiumcodereview.appspot.com/9788001
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run chrome --ash-enable-oak, press Ctrl-Shift-F1, verify properties contains the line "Hit test bounds override"
Review URL: https://chromiumcodereview.appspot.com/9706019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Refactored aura::Window::set_hit_test_bounds_inset() into SetHitTestBoundsOverride() to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126539
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=126544
Review URL: https://chromiumcodereview.appspot.com/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content below the tree view. This will do for now.
http://crbug.com/97266
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9689039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Ctrl+Shift+F1 brings it up.
http://crbug.com/97266
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9662022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126207 0039d316-1c4b-4281-b951-d872f2087c98
|