| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This is a follow up of https://codereview.chromium.org/1408973003/
BUG=524474
Review URL: https://codereview.chromium.org/1412663003
Cr-Commit-Position: refs/heads/master@{#355529}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only visible for WebNotifications for now.
Upon click it takes you to the notification exceptions page in chrome
BUG=524474
TBR=mpearson,oshima
Review URL: https://codereview.chromium.org/1408973003
Cr-Commit-Position: refs/heads/master@{#355279}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in https://codereview.chromium.org/1304833003/ .
This also updates the 32x32 and 64x64 favicons to match the 16x16 one.
BUG=505953
TEST=Open about:blank, the favicon in the tab shouldn't look undersized
TBR=oshima
Review URL: https://codereview.chromium.org/1395273006
Cr-Commit-Position: refs/heads/master@{#353926}
|
|
|
|
|
|
|
|
|
|
| |
Theses are implicitly public today, but I'm going to remove some transitional code that will change the default to be private.
Some template instantiations needed to be updated that themselves expand to groups.
Review URL: https://codereview.chromium.org/1356493004
Cr-Commit-Position: refs/heads/master@{#349747}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just rips out the center and settings component, and does not
refactor any of the delegate/interface classes to match the new reality
(that is to be done later).
Also TODO: removing the entry from the OSX main menu (didn't want
to do xib stuff here), so for now the entry is just disabled.
R=peter,rsesek,oshima,bauerb
TBR=atwilson
BUG=530376
Review URL: https://codereview.chromium.org/1334363002
Cr-Commit-Position: refs/heads/master@{#349425}
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1315793004
Cr-Commit-Position: refs/heads/master@{#347050}
|
|
|
|
|
|
|
|
| |
BUG=527105
Review URL: https://codereview.chromium.org/1316813006
Cr-Commit-Position: refs/heads/master@{#346709}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, these can't be vectorized easily because blink and Chrome
don't support SVG favicons.
BUG=505953
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/1304833003
Cr-Commit-Position: refs/heads/master@{#345949}
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=503224
Review URL: https://codereview.chromium.org/1257223005
Cr-Commit-Position: refs/heads/master@{#344246}
|
|
|
|
|
|
|
|
| |
BUG=520324
Review URL: https://codereview.chromium.org/1292603002
Cr-Commit-Position: refs/heads/master@{#343326}
|
|
|
|
|
|
|
|
|
|
|
| |
//third_party/WebKit is not supported on iOS, so put the deps
behind a is_ios check.
BUG=None
Review URL: https://codereview.chromium.org/1277183002
Cr-Commit-Position: refs/heads/master@{#342356}
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed by the webview Views example, e.g. to get the
user agent CSS.
BUG=None
Review URL: https://codereview.chromium.org/1272993002
Cr-Commit-Position: refs/heads/master@{#342309}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/1262253005
Cr-Commit-Position: refs/heads/master@{#341645}
|
|
|
|
|
|
|
|
| |
BUG=505953
Review URL: https://codereview.chromium.org/1224403004
Cr-Commit-Position: refs/heads/master@{#339097}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1228923002/)
Reason for revert:
Reverting the revert - it turned out the failures weren't caused by the reverted CLs, but a bot configuration change happening at the same time: https://codereview.chromium.org/1212443005
Original issue's description:
> Revert vector icon CLs.
>
> This reverts the following commits:
>
> ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android."
> 5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time."
> 33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets."
>
> Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which
> is one of the suspects for having broken browser_tests on Mac builders:
>
> http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232
> http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313
>
> Log output:
>
> NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1):
> [ RUN ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0
> [7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
> [7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure
> Value of: [color redComponent]
> Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure
> Value of: [color greenComponent]
> Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure
> Value of: [color blueComponent]
> Actual: 0.952941
> Expected: 1
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure
> Value of: [color redComponent]
> Actual: 0.952941
> Expected: 1
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure
> Value of: [color greenComponent]
> Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure
> Value of: [color blueComponent]
> Actual: 0.952941
> Expected: 0
> [ FAILED ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms)
>
> BUG=508389
> TBR=estade@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/17399fb2b0a5fcba7c2dcb76ab2c597e6cf7c0db
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508389
Review URL: https://codereview.chromium.org/1231843002 .
Cr-Commit-Position: refs/heads/master@{#338017}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts the following commits:
ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android."
5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time."
33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets."
Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which
is one of the suspects for having broken browser_tests on Mac builders:
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313
Log output:
NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1):
[ RUN ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0
[7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
[7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure
Value of: [color redComponent]
Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure
Value of: [color greenComponent]
Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure
Value of: [color blueComponent]
Actual: 0.952941
Expected: 1
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure
Value of: [color redComponent]
Actual: 0.952941
Expected: 1
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure
Value of: [color greenComponent]
Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure
Value of: [color blueComponent]
Actual: 0.952941
Expected: 0
[ FAILED ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms)
BUG=508389
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/1228923002 .
Cr-Commit-Position: refs/heads/master@{#338004}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace a couple icons with vector versions (check_circle and photo_camera).
The end result for the camera icon is pixel identical, although the vertical alignment is slightly different. I believe the new vertical alignment is correct (it aligns the center of the camera lens with the center of the user profile photo, instead of ~4px below), so I'm leaving that change in.
The end result for the checkmark icon is pixel identical.
BUG=505953
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1214693005
Cr-Commit-Position: refs/heads/master@{#337893}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of bunching up all resources used by the default views controls into the
common ui_resources pack, move them into views_resources, so that it is possible
for a component to depend on views and pull in the necessary resources without
building ui_resources with |toolkit_views| flag on.
BUG=500004, 503224
TBR=jam@ for content/shell/BUILD.gn and content/browser/webui changes.
Review URL: https://codereview.chromium.org/1199143002
Cr-Commit-Position: refs/heads/master@{#335938}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optimized 463/894 files in 02:55:02s
Result: 267148 => 209096 bytes (58052 bytes: 21%)
BUG=503732
R=sadrul@chromium.org
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/1199353002.
Cr-Commit-Position: refs/heads/master@{#335841}
|
|
|
|
|
|
|
|
| |
BUG=503718
Review URL: https://codereview.chromium.org/1197733008
Cr-Commit-Position: refs/heads/master@{#335746}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
json_schema_api.gni was generating wrong names, this was fixed.
mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
BUG=487897
TBR=dpranke
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Previously landed as https://codereview.chromium.org/1128163007/ the issue there should have been fixed by https://codereview.chromium.org/1148173002/ which has already been landed.
Review URL: https://codereview.chromium.org/1134753011
Cr-Commit-Position: refs/heads/master@{#331625}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Always build Polymer 0.8 and 0.5. Polymer 0.5 should be removed in M45.
BUG=483080
R=jlklein@chromium.org
TEST=manual
Review URL: https://codereview.chromium.org/1134753009
Cr-Commit-Position: refs/heads/master@{#330666}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1128163007/)
Reason for revert:
Broke Windows:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/steps/compile/logs/stdio
Original issue's description:
> Fix missing GN dependencies.
>
> Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
>
> json_schema_api.gni was generating wrong names, this was fixed.
>
> mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
>
> The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
>
> BUG=487897
>
> Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7
> Cr-Commit-Position: refs/heads/master@{#330636}
TBR=dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487897
Review URL: https://codereview.chromium.org/1137693006
Cr-Commit-Position: refs/heads/master@{#330650}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
json_schema_api.gni was generating wrong names, this was fixed.
mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
BUG=487897
Review URL: https://codereview.chromium.org/1128163007
Cr-Commit-Position: refs/heads/master@{#330636}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is part of Aura side of unified touch selection. It adds an
implementation of touch handle drawables to be used on Aura. It also
adds some functions to the public interface of
ui::TouchSelectionController needed for unified touch selection.
COLLABORATOR=mfomitchev
BUG=399721
Review URL: https://codereview.chromium.org/996373002
Cr-Commit-Position: refs/heads/master@{#329191}
|
|
|
|
|
|
|
|
|
|
| |
versions.
BUG=473342, 484780
Review URL: https://codereview.chromium.org/1123743009
Cr-Commit-Position: refs/heads/master@{#328660}
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1118673004/
BUG=483080
Review URL: https://codereview.chromium.org/1120203003
Cr-Commit-Position: refs/heads/master@{#328204}
|
|
|
|
|
|
|
|
| |
BUG=483080
Review URL: https://codereview.chromium.org/1118673004
Cr-Commit-Position: refs/heads/master@{#327959}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we build 'all' in GN, we can end up building targets that are
defined in various build files even if they are not transitively referenced
from 'gn_all' or 'gn_only'. This is undesirable because it makes it harder
to tell when there might be discrepancies between the GN and GYP builds.
Some of these targets may actually be hidden (using the visibility tag)
and only intended to be depended on by other targets that don't work yet.
By making this targets also visible to a top-level "//:gn_visibility"
target we can ensure that we're tracking them properly without breaking
the normal encapsulation rules.
The two targets affected in this patch are
- //build/config/sanitizers:options_sources
- //ui/resources:repack_ui_test_mac_locale_pack
R=brettw@chromium.org
BUG=431177
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1121453004
Cr-Commit-Position: refs/heads/master@{#327922}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1094453003
Cr-Commit-Position: refs/heads/master@{#325691}
|
|
|
|
|
|
|
|
| |
BUG=467712
Review URL: https://codereview.chromium.org/1050583002
Cr-Commit-Position: refs/heads/master@{#323080}
|
|
|
|
|
|
|
|
|
|
| |
Also add a new, prettier checkmark asset. (It doesn't appear this is actually used anywhere else, so no other UIs should be affected.)
BUG=none
Review URL: https://codereview.chromium.org/1005603003
Cr-Commit-Position: refs/heads/master@{#322252}
|
|
|
|
|
|
|
|
|
|
|
| |
This was previously used for the experimental app list, but it was
removed in r306147.
BUG=435951
Review URL: https://codereview.chromium.org/925263002
Cr-Commit-Position: refs/heads/master@{#317259}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new assets have correct colour contrast and more closely match the
Material Design spec. Affects both the classic and experimental
launcher.
The following assets were replaced:
- Microphone (hotword enabled and disabled states).
- Back button.
- Download progress bar.
BUG=457979,456953
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/931483004
Cr-Commit-Position: refs/heads/master@{#316947}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not in gcl, which probably these days nobody working on Chromium uses.
BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/887033002
Cr-Commit-Position: refs/heads/master@{#314039}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a placeholder for a "wants to act" appearance, we've been
using the "hover" assets. Tweak this so that "wants to act"
looks different from hover and has its own assets.
BUG=417441
Review URL: https://codereview.chromium.org/855073004
Cr-Commit-Position: refs/heads/master@{#312482}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toollkit_views=1
When toolkit_views first flips on Mac, ui/views should be "available"
but not actually used by chrome/browser -- it should stay Cocoa. We also
don't want to bloat the release unnecessarily.
Most of the changes are structures along the lines of
if (toolkit_views)
/* */
else if (mac)
/* */
Which we want to change to
if (mac)
/* */
else if (toolkit_views)
/* */
Which looks funny in grd since there is no such thing as "else": E.g.
- expr="toolkit_views" becomes ="toolkit_views and not is_macosx"
- expr="(is_macosx or is_ios) and not toolkit_views" becomes expr="is_macosx or is_ios"
The is_ios is dropped in the first case since toolkit_views is never true
on ios and for grit (but not C source) is_macosx is not also set with is_ios.
A few cases that didn't fit these are called out in comments.
This CL fixes tests such as MacHistorySwiperTest.SwipeLeft on Mac when
toolkit_views=1 which otherwise fail to find the correct resource.
BUG=439882
Review URL: https://codereview.chromium.org/829373004
Cr-Commit-Position: refs/heads/master@{#311133}
|
|
|
|
|
|
|
|
|
| |
BUG=447755
NOTRY=true
Review URL: https://codereview.chromium.org/842333002
Cr-Commit-Position: refs/heads/master@{#310933}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excluded mojo because I think that needs to happen on the other side.
At gn --version = 306668 for which roll is in CQ.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774353003
Cr-Commit-Position: refs/heads/master@{#306708}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No intended functionality change.
(Binary used includes https://codereview.chromium.org/774753004/)
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/776763002
Cr-Commit-Position: refs/heads/master@{#306568}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 3 contents switcher icons were previously used in the experimental
app list, but the switcher panel has been removed in favour of other
buttons, so these resources are no longer used as of r305779.
Follow-up to https://codereview.chromium.org/754933003/.
BUG=425444
Review URL: https://codereview.chromium.org/756223003
Cr-Commit-Position: refs/heads/master@{#306289}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handles that look differently depending if they are located at the left or right edge of the selection, or at the cursor. For web contents, the type of the handle is determined based on the information passed up from Blink in ViewHostMsg_SelectionBounds_Params. For Aura Textfield, it is calculated directly. New image assets (submitted in https://codereview.chromium.org/694873002) are used.
New struct ui::SelectionBound is introduced to encapsulate the information about a selection bound. This struct is purposefully made similar to cc::ViewportSelectionBound which is used by TouchSelectionController, and which we'll likely be using for RenderWidgetHostViewAura once we switch to the unified touch selection implementation between Android and Aura.
Depends on:
https://codereview.chromium.org/686513004/
https://codereview.chromium.org/694873002/
BUG=398053, 419898
Review URL: https://codereview.chromium.org/700563002
Cr-Commit-Position: refs/heads/master@{#304524}
|
|
|
|
|
|
|
|
| |
BUG=430729
Review URL: https://codereview.chromium.org/718923002
Cr-Commit-Position: refs/heads/master@{#303911}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few other things to note:
- updates the 1x and 2x versions of
controlled_setting_mandatory.png.
- adds missing 2x versions of default_favicon_32.png and
default_favicon_64.png
- removes DELETE_ME placeholders now that the directories
are no longer empty.
BUG=423755
Review URL: https://codereview.chromium.org/706723002
Cr-Commit-Position: refs/heads/master@{#303255}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This flag causes GRIT to include the same resources in generated .h
files as are included in the PAK files. This seems like an obvious thing
to do, right? Well, before this CL, *every* resource from the GRD file
was listed in the .h file, even resources inside of <if> statements that
evaluated to false. As a result, it was possible to reference a resource
(e.g. IDS_FOO) in a .cc file, even if IDS_FOO was excluded from the PAK
file. What happened at runtime? Crash!
This change brings compile-time safety to resource loading: the crash
mentioned above would now be a compile failure since IDS_FOO is no
longer in the generated .h file.
BUG=428947
Review URL: https://codereview.chromium.org/692733003
Cr-Commit-Position: refs/heads/master@{#303180}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
proximity detection.
These strings and assets will be updated when the final versions are available.
Use temporary ones for now during development.
BUG=403419
TEST=none
R=tengs@chromium.org
Review URL: https://codereview.chromium.org/702903005
Cr-Commit-Position: refs/heads/master@{#303126}
|
|
|
|
|
|
|
|
|
|
| |
Code changes will be submitted separately.
BUG=398053
Review URL: https://codereview.chromium.org/694873002
Cr-Commit-Position: refs/heads/master@{#302475}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL https://codereview.chromium.org/633373010 added some output files
but did not update the expected output files in the corresponding GN
files.
BUG=429299
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/694853003
Cr-Commit-Position: refs/heads/master@{#302334}
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: Review URL: https://codereview.chromium.org/686503002
BUG=425996
TBR=oshima, sadrul, tbarzic
Review URL: https://codereview.chromium.org/690943003
Cr-Commit-Position: refs/heads/master@{#302142}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c49ac404f05590cd8834c5fe3db7915c02af6910.
TBR=stevenjb@chromium.org
BUG=
Review URL: https://codereview.chromium.org/693493003
Cr-Commit-Position: refs/heads/master@{#302096}
|