summaryrefslogtreecommitdiffstats
path: root/ui/shell_dialogs
Commit message (Collapse)AuthorAgeFilesLines
* ui: Move strings translations out of ui/base.tfarina@chromium.org2014-05-181-1/+1
| | | | | | | | | | | | | | This change is mostly mechanical. There were no functional changes made other than updating the paths to the new location. This moves the translation files (xtb) out of ui/base/ to ui/strings/translations. BUG=369881 TEST=build locally + green trybots, no functional changes. TBR=ben@chromium.org Review URL: https://codereview.chromium.org/269363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271292 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270232 "linux_aura: Compile ash into chrome."erg@chromium.org2014-05-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Reverted once again because because there are two more static initializers. > linux_aura: Compile ash into chrome. > > [This is a reland now that the static initializers should be fixed.] > > Running chrome with the "--open-ash" parameter will create an ash > desktop window. Ash on Linux has some problems, but at least we're now > compiling the code into the binary. > > TODO: The applist isn't positioned correctly, and some details of the > system tray aren't correct. > > BUG=300084, 303862 > TBR=sky@chromium.org > First Review URL: https://codereview.chromium.org/25108005 > > Review URL: https://codereview.chromium.org/270383007 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/287783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270241 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-131-2/+2
| | | | | | | | | | | | | | | | | | | [This is a reland now that the static initializers should be fixed.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Review URL: https://codereview.chromium.org/270383007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 269892 "linux_aura: Compile ash into chrome."erg@chromium.org2014-05-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Major regression in chrome-si/initializers. Reverting for now to fix. > linux_aura: Compile ash into chrome. > > Running chrome with the "--open-ash" parameter will create an ash > desktop window. Ash on Linux has some problems, but at least we're now > compiling the code into the binary. > > TODO: The applist isn't positioned correctly, and some details of the > system tray aren't correct. > > BUG=300084, 303862 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/25108005 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/276773004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-121-2/+2
| | | | | | | | | | | | | | | | Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 R=sky@chromium.org Review URL: https://codereview.chromium.org/25108005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269892 0039d316-1c4b-4281-b951-d872f2087c98
* Remove non USE_AURA code from views files.erg@chromium.org2014-04-251-14/+4
| | | | | | | | BUG=330735 Review URL: https://codereview.chromium.org/246633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266059 0039d316-1c4b-4281-b951-d872f2087c98
* More removal of GTK code.erg@chromium.org2014-04-151-4/+0
| | | | | | | | BUG=297026 Review URL: https://codereview.chromium.org/232773008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263757 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the GTK+ port of Chrome.erg@chromium.org2014-04-106-1268/+0
| | | | | | | | | BUG=297026 R=ben@chromium.org Review URL: https://codereview.chromium.org/231733005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98
* Failsafe in case ui::SelectFileDialog is not implementedtiago.vignatti@intel.com2014-03-201-0/+1
| | | | | | | | | | We need a proper Aura-only ui::SelectFileDialog implementation but in the mean time just failsafe here. In particular this was causing Ozone implementations to crash. BUG=130810 Review URL: https://codereview.chromium.org/200253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258276 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in ui/.pkasting@chromium.org2014-03-181-2/+2
| | | | | | | | | | BUG=346399 TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/202173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257745 0039d316-1c4b-4281-b951-d872f2087c98
* Move ui.gyp into ui/base/ directory.tfarina@chromium.org2014-03-131-2/+2
| | | | | | | | | | | | | | | | This follows the rule we setup for //ui which states that each subdir should be its own component with its own gyp file that lives in its subdir. The 'ui' target was renamed to ui_base to match the convention. BUG=299841 TEST=gyp files. TBR=ben@chromium.org Review URL: https://codereview.chromium.org/198333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256788 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use after release bug.aurimas@chromium.org2014-03-052-10/+2
| | | | | | | | | | | | | | We were writing to is_running_ after SelectFileDialogImpl was released by FileSelectHelper:~FileSelectHelper(). Start using listener_ as a check to see whether SelectFileDialog is running. BUG=342151 NOTRY=true Review URL: https://codereview.chromium.org/184043028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254883 0039d316-1c4b-4281-b951-d872f2087c98
* Window ownership -> WindowTreeHostben@chromium.org2014-03-041-2/+2
| | | | | | | | | | | | | Replaces Window::GetDispatcher with Window::GetHost(). Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/184903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window.* to window_event_dispatcher.*ben@chromium.org2014-02-211-1/+1
| | | | | | | | | http://crbug.com/308843 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/174803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window_host* in aura to window_tree_host*.ben@chromium.org2014-02-141-1/+1
| | | | | | | | | | R=sky@chromium.org TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/160573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing files. TBR=vitalybuka@chromium.org.scottmg@chromium.org2014-02-131-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251070 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 230235 "Use BaseShellDialog for print dialog on Windows"scottmg@chromium.org2014-02-133-144/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per discussion with ananta, opening a system modal dialog from a background thread is a bad idea, so reverting this (from long ago). Windows doesn't preserve the order correctly when the window is not on the main UI thread, and in the bug here, it interacts very badly with the IME toolbar window, causing the modal print dialog to go behind the browser window in Z order making chrome appear to be hung. The original goal was to fix tasks not being dispatched while the dialog was open. We can instead use the ScopedNestedTaskAllower as we've done for other system modal dialogs which I'll do in a separate CL. BUG=342697,180997 > Use BaseShellDialog for print dialog on Windows > > This puts the print dialog on a background thread which is necessary so other > top level windows can keep painting as Aura does the compositor swaps on the > UI thread. > > R=sky@chromium.org,vitalybuka@chromium.org > > > Review URL: https://codereview.chromium.org/27441003 TBR=scottmg@chromium.org,sky@chromium.org,vitalybuka@chromium.org,ananta@chromium.org Review URL: https://codereview.chromium.org/164013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251066 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test target for shell_dialogs module.tfarina@chromium.org2014-02-071-0/+14
| | | | | | | | | | | | | | | | | This is necessary to avoid a circular dependency that on Mac is forbidden: ui_unittests -> shell_dialogs -> aura -> ui_unittests The down side is that momentarily we lose automatic test coverage on the bots for the shell_dialogs. This can be fixed by teaching the buildbot scripts to run it after this lands. BUG=331669, 35878, 299841 TEST=shell_dialogs_unittests R=ben@chromium.org Review URL: https://codereview.chromium.org/151253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249568 0039d316-1c4b-4281-b951-d872f2087c98
* Figure out the display name for a content uri.miguelg@chromium.org2014-02-044-3/+22
| | | | | | | | | | | | Plumb it through the File listener so blink can display the right content on <input type=file> elements. BUG=338929 NOTRY=true Review URL: https://codereview.chromium.org/150283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248707 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NULL deref in SelectFileDialogImpl when a NULL filter is provided.tommi@chromium.org2014-01-231-10/+14
| | | | | | | | | | | | According to the documentation, NULL is a valid value but the code wasn't consistently checking for it. BUG=337068 TEST=See repro steps in the bug. Review URL: https://codereview.chromium.org/139313011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246647 0039d316-1c4b-4281-b951-d872f2087c98
* Convert base::file_util to use File instead of PlatformFile.rvargas@chromium.org2014-01-071-1/+1
| | | | | | | | | | | BUG=322664 R=brettw@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/101143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243235 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in ui/ to use the base:: namespace.avi@chromium.org2013-12-253-11/+11
| | | | | | | | | | BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/106383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242504 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make directory selection work with upload typelazyboy@chromium.org2013-12-131-3/+5
| | | | | | | | | | | | | | | | | (<input webkitdirectory>). Right now it hits NOTREACHED(). uploads have type = SELECT_UPLOAD_FOLDER. They should be treated same as SELECT_OPEN_FILE and SELECT_FOLDER to save the last opened directory path. BUG=None Test=Manually with a packaged app that has input element: <input type="file" webkitdirectory id="directory"/> Review URL: https://codereview.chromium.org/111843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240564 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Remove ui/android entries from DEPS files.tfarina@chromium.org2013-12-111-1/+0
| | | | | | | | | | | | | | This include entry is not necessary anymore because the c++ headers files were moved into ui/base/android in crrev.com/232036, and ui/base include entries already cover that. BUG=None TEST=checkdeps.py TBR=ben@chromium.org Review URL: https://codereview.chromium.org/110823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240036 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath::FinalExtension() to avoid double extensions (.tar.gz) for file ↵davidben@chromium.org2013-12-091-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | selector Windows and OS X file selectors break badly on double-extensions. GTK and Chrome OS handle it slightly better, but CrOS has a slight bug and GTK's handling of file extensions is minimal, so not a whole lot changed. See https://codereview.chromium.org/4883003/#msg14 for full analysis of platform behavior. There is some logic that does benefit from long extensions (renaming "foo.tar.gz" to "foo (1).tar.gz" instead of "foo.tar (1).gz"), and some other callers store state based on extension, so rather than changing FilePath::Extension, add a new FilePath::FinalExtension and change SelectFileDialog callers to use it. Also work around a problem in NSSavePanel when saving "foo.tar.gz" with extensions hidden. TEST=FilePath.Extension, FilePath.Extension2 FilePath.RemoveExtension Enabling "Ask where to save each file before downloading"; saving a tar.gz doesn't result in weird confirmation prompt on OS X, with or without "Show all filename extensions" enabled in Finder. BUG=83084 Review URL: https://codereview.chromium.org/4883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239505 0039d316-1c4b-4281-b951-d872f2087c98
* Move more file_util functions to base namespace.brettw@chromium.org2013-12-041-1/+1
| | | | | | | | | | | | This moves DevicePathToDriveLetterPath, NormalizeToNativeFilePath, IsLink, and GetFileInfo. This also removes some explicit "base::" usage in base files I touched. TBR=jam Review URL: https://codereview.chromium.org/105293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238763 0039d316-1c4b-4281-b951-d872f2087c98
* Add the OFN_NOCHANGEDIR flag when opening the multiple file dialogmmenke@chromium.org2013-12-021-1/+1
| | | | | | | | | | | | | | | | on Windows, to avoid changing the directory. This allows directories to be renamed or deleted after showing the dialog. We already do this for other Windows file dialogs. It looks like the lack of the flag in this dialog was a bug when it was initially added in https://codereview.chromium.org/14907. BUG=238094 R=sky@chromium.org Review URL: https://codereview.chromium.org/89473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238174 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Android changes.tfarina@chromium.org2013-11-151-2/+2
| | | | | | | | | | | | | | | | | | | | A series of changes related to android code organization under ui, that came after the discussion in https://codereview.chromium.org/62203014/. - Rename ui_jni_registrar.* to ui_base_jni_registrar.* - Create a base/ directory under ui/android/java/src/org/chromium/ui, and move some java files there. - Move Surface java files into ui/android/java/src/org/chromium/ui/gl/ directory. - Rename ui_jni_headers to ui_base_jni_headers. - Create a new ui_android.gyp file under ui/android to contain ui_java target. BUG=299841 R=tedchoc@chromium.org, yfriedman@chromium.org TBR=ben Review URL: https://codereview.chromium.org/70843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235369 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some pass-thrus on RootWindow API in favor of exposing the ↵ben@chromium.org2013-11-151-2/+2
| | | | | | | | | | | RootWindowHost again. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/72503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235293 0039d316-1c4b-4281-b951-d872f2087c98
* Make RootWindow not subclass Window.ben@chromium.org2013-11-121-0/+1
| | | | | | | | | | | | | | Removes the #include of window.h from root_window.h too, which makes this CL a little longer bandaiding all those places. The interesting parts of this change are in root_window.* and window.* R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234428 Review URL: https://codereview.chromium.org/68313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234634 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 234428 "Make RootWindow not subclass Window."ben@chromium.org2013-11-121-1/+0
| | | | | | | | | | | | | | | | | | > Make RootWindow not subclass Window. > > Removes the #include of window.h from root_window.h too, which makes this CL a little longer bandaiding all those places. > The interesting parts of this change are in root_window.* and window.* > > R=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/68313003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/70043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234449 0039d316-1c4b-4281-b951-d872f2087c98
* Make RootWindow not subclass Window.ben@chromium.org2013-11-121-0/+1
| | | | | | | | | | | | Removes the #include of window.h from root_window.h too, which makes this CL a little longer bandaiding all those places. The interesting parts of this change are in root_window.* and window.* R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/68313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234428 0039d316-1c4b-4281-b951-d872f2087c98
* Android: moves ui/ to use long for JNI.bulach@chromium.org2013-11-111-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/61733010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234312 0039d316-1c4b-4281-b951-d872f2087c98
* Use title on Mac file select dialog.vandebo@chromium.org2013-11-061-1/+1
| | | | | | | | | | Title is not displayed in the file select dialog, whereas Message is. BUG=NONE Review URL: https://codereview.chromium.org/54493010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233149 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move android C++ source files into base/android directory.tfarina@chromium.org2013-10-311-1/+1
| | | | | | | | | | BUG=299841 TEST=None, no functional changes. R=ben@chromium.org,bulach@chromium.org Review URL: https://codereview.chromium.org/51663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232036 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Have shell_dialogs into its own gyp file under its shell_dialogs/ directory.tfarina@chromium.org2013-10-291-0/+89
| | | | | | | | | | | | | | | This is the pattern we follow for projects under ui/, each top-level directory (app_list, aura, compositor, events) have its own gyp file for its main target (library). BUG=299841 TEST=build/gyp_chromium, ninja -C out/Debug shell_dialogs, and other targets still build. R=ben@chromium.org Review URL: https://codereview.chromium.org/47323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231478 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetRootWindow() return a Window instead of a RootWindow.ben@chromium.org2013-10-251-2/+2
| | | | | | | | | | | | Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/37733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
* Use BaseShellDialog for print dialog on Windowsscottmg@chromium.org2013-10-223-1/+144
| | | | | | | | | | | | | This puts the print dialog on a background thread which is necessary so other top level windows can keep painting as Aura does the compositor swaps on the UI thread. R=sky@chromium.org,vitalybuka@chromium.org BUG=180997 Review URL: https://codereview.chromium.org/27441003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230235 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten DEPS rules further.ben@chromium.org2013-09-241-0/+2
| | | | | | | | | BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/24429002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225089 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten up DEPS rules in src/ui: prevent components from including from each ↵ben@chromium.org2013-09-241-0/+6
| | | | | | | | | | | | | | | other, and drop a bunch of DEPS files in to make checkdeps happy. See https://codereview.chromium.org/24162009/ for try runs. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225020 Review URL: https://codereview.chromium.org/24273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225055 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 225020 "Tighten up DEPS rules in src/ui: prevent componen..."ben@chromium.org2013-09-241-6/+0
| | | | | | | | | | | | | | | > Tighten up DEPS rules in src/ui: prevent components from including from each other, and drop a bunch of DEPS files in to make checkdeps happy. > > BUG=none > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/24273005 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/24257013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225032 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten up DEPS rules in src/ui: prevent components from including from each ↵ben@chromium.org2013-09-241-0/+6
| | | | | | | | | | | other, and drop a bunch of DEPS files in to make checkdeps happy. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/24273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225020 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in DesktopNativeWidgetWin if parent is not in a RootWindow.sky@chromium.org2013-08-231-5/+7
| | | | | | | | | | | | Code needs to NULL check GetRootWindow(). BUG=275762 TEST=covered by unit tests R=ananta@chromium.org Review URL: https://chromiumcodereview.appspot.com/23242018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219301 0039d316-1c4b-4281-b951-d872f2087c98
* Change the meaning of SelectFileDialog.support_drive: it means Drive-aware ↵kinaba@chromium.org2013-08-061-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | callers. Previously, what the |support_drive| flag means is just to show Google Drive tab in the file dialog; it doesn't change other behaviors. Now, we are going to enable the "Google Drive" tab on Chrome OS for all call sites of the dialog, by adding a feature to Drive client to provide local snapshot so that callers need not care about Drive. On the other hand, the "create snapshot" trick is unnecessary for clients like Packaged app or extensions that implement fileBrowserHandler, which access files through HTML5 FileSystem API. So, for those clients I want to leave the |support_drive| flag to indicate that no special handling is needed. Here's the summary: Before: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. Create local snapshot. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : hide Drive tab. - !support_drive, open-dialog : hide Drive tab. (this mode is not used) - !support_drive, save-dialog : hide Drive tab. After: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. No special handling. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : *HIDE* Drive tab. (this is not supported yet) - !support_drive, open-dialog : Show Drive tab. Create local snapshot. - !support_drive, save-dialog : *HIDE* Drive tab. (VERY SOON switch to => "Show Drive tab. Create local snapshot.") BUG=140425 Review URL: https://chromiumcodereview.appspot.com/22165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215922 0039d316-1c4b-4281-b951-d872f2087c98
* Change dialog texts for folder upload to explicitly indicate it's for ↵kinuko@chromium.org2013-07-315-16/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 'Uploading' Currently we show the same dialog title and confirm button ('Select Folder' and 'OK' or 'Open') for folder upload, but it should more clearly tell that it's for 'uploading', so that the user can know s/he is exposing the folder content to the website. This patch makes following UI string changes to make it clear: * "Select a folder to upload" for dialog title on ChromeOS (original text is: "Select a folder to open") * "Select Folder to Upload" for dialog title on other platforms (original text is: "Select Folder") * "Upload" for dialog confirm button (original text is: "Open") The new string texts have gotten LGTM by UI team. BUG=252888 TEST=manual R=avi@chromium.org, jamesr@chromium.org, sky@chromium.org, yoshiki@chromium.org Review URL: https://codereview.chromium.org/18627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214588 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in ui for base/process changes.rsesek@chromium.org2013-07-231-1/+1
| | | | | | | | | BUG=242290 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19781003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213219 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in ui/, part 2.avi@chromium.org2013-07-184-4/+4
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19631002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212291 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual ↵brettw@chromium.org2013-07-153-3/+3
| | | | | | | | | | to the base namespace. TBR=sky Review URL: https://codereview.chromium.org/19052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211675 0039d316-1c4b-4281-b951-d872f2087c98
* Update the HTML Media Capture implementation.raphael.kubo.da.costa@intel.com2013-07-091-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In the latest version of the spec, the `capture' attribute is now a boolean which simply indicates whether the device's capabilities should be used or not (choosing between cameras, microphones etc is up to the user agent based on the contents of the `accept' attribute). This particular patch updates the type of the `capture' member of content::FileChooserParams by passing an std::pair consisting of a vector of MIME types passed to the `accept' attribute of the <input> tag and a boolean corresponding to the `capture' attribute. The behavior in Android has been slightly changed due to how the spec change. Namely: o Sites that specify only the "capture" attribute setting the "accept" attribute will now get a generic picker. o Sites that specify the "capture" attribute and pass "*/*" to "accept" will now get a generic picker. o Sites that specify the "capture" and multiple MIME types for the "accept" attribute will now get a generic picker. R=abarth@chromium.org,beverloo@chromium.org,bulach@chromium.org,tedchoc@chromium.org,eseidel@chromium.org BUG=240252 Review URL: https://chromiumcodereview.appspot.com/14758008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210553 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the FileSelectionCanceled callback is invoked on the ↵ananta@chromium.org2013-07-081-0/+8
| | | | | | | | | | | | | | | | SelectFileDialog::Listener when the operation is canceled on Windows 8 Chrome ASH. Not invoking the FileSelectionCanceled callback causes the file pickers to only work once in Chrome ASH for a session. BUG=257169 R=cpu@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/18648009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210388 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 11:18:58 +0000