| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/638653003/)
This reverts commit 36b7fc7f8b05ea627873e58a162c1c26784e472d.
Reason for revert:
Speculatively reverting as I suspect it may be the cause of test failures like this:
[16079:16079:1009/052004:FATAL:compositor.cc(303)] Check failed: !IsLocked().
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/6451
Original issue's description:
> Make ui::Compositor use ui::Scheduler
>
> Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005.
>
> BUG=329552
>
> Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d
> Cr-Commit-Position: refs/heads/master@{#298779}
TBR=ben@chromium.org,danakj@chromium.org,sky@chromium.org,weiliangc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329552
Review URL: https://codereview.chromium.org/640293003
Cr-Commit-Position: refs/heads/master@{#298919}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623293004
Cr-Commit-Position: refs/heads/master@{#298839}
|
|
|
|
|
|
|
|
|
|
| |
Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005.
BUG=329552
Review URL: https://codereview.chromium.org/638653003
Cr-Commit-Position: refs/heads/master@{#298779}
|
|
|
|
|
|
|
|
| |
This is never used now that aura is enabled.
Review URL: https://codereview.chromium.org/621883004
Cr-Commit-Position: refs/heads/master@{#297755}
|
|
|
|
|
|
|
|
|
| |
BUG=416722
R=sky@chromium.org
Review URL: https://codereview.chromium.org/606453002
Cr-Commit-Position: refs/heads/master@{#296585}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some errors remain but these are circular includes that can't be fixed in the build files only.
Enable views_unittests and wm_unittests now that they compile
BUG=
R=sky@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/513313002
Cr-Commit-Position: refs/heads/master@{#292445}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/496313004
Cr-Commit-Position: refs/heads/master@{#291764}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace me with Jared for ui/ places.
I'm not familiar with what's going on in buildbot anymore.
NOTRY=true
TBR=sky
Review URL: https://codereview.chromium.org/477133005
Cr-Commit-Position: refs/heads/master@{#291295}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome target doesn't link yet so is currently a source set.
This adds some installer util targets and some related targets, as well as fixes up some TODOs referencing completed targets.
Fixes and enables the snapshot unit test.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/489223002
Cr-Commit-Position: refs/heads/master@{#290927}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files provide the implementations of the public Blink API that
bind to the cc implementation. This moves them out of content/ into a
subdirectory of cc/ so that we can reuse these files in mojo which
can depend on cc/ and on blink but not on content/. To make sure we
don't introduce dependencies from cc/ on blink proper, cc/DEPS forbids
including cc/blink/ and cc/blink/DEPS allows using the blink headers.
cc_blink is built as a separate component to avoid linking anything from
blink into targets that don't care about the blink bindings (such as
the browser compositor).
R=darin@chromium.org
Review URL: https://codereview.chromium.org/470983004
Cr-Commit-Position: refs/heads/master@{#290464}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This is a revival/continuation of https://codereview.chromium.org/333723004, which was started by another developer.
The cc:CopyOutputRequest object assumes the src_subrect region is
in DIP space. Thus, all calling code should provide the same.
Fixed tests in render_widget_host_view_browsertest.cc that were
completing successfully, even though the implementation was broken
for the high DPI scenarios.
In addition, I updated a number of interface comments to clarify the
difference between src_subrect being in DIP coordinates versus the
dest_size being in physical pixel coordinates.
Dependent on: https://codereview.chromium.org/311253004 (landed at r276139)
BUG=397708,399349
Review URL: https://codereview.chromium.org/462173002
Cr-Commit-Position: refs/heads/master@{#289509}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r288866 because of crashes.
Old patch: https://codereview.chromium.org/134623005/
NOTRY=true
TBR=danakj@chromium.org,boliu@chromium.org,piman@chromium.org,ben@chromium.org
BUG=402943,403400
Review URL: https://codereview.chromium.org/475483002
Cr-Commit-Position: refs/heads/master@{#289395}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.
Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention. This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.
BUG=329552, 287250
Review URL: https://codereview.chromium.org/134623005
Cr-Commit-Position: refs/heads/master@{#288866}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/134623005/)
Reason for revert:
Broke some layout tests
Original issue's description:
> Make SingleThreadProxy a SchedulerClient
>
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
>
> Other compositors that use SingleThreadProxy are left calling composite
> synchronously and now pass a flag to indicate that this is their
> intention. This patch doesn't remove synchronous composite, but now
> makes it mutually exclusive with scheduling.
>
> BUG=329552, 287250
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287950
NOTRY=true
NOTREECHECKS=true
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/447133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.
Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention. This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.
BUG=329552, 287250
Review URL: https://codereview.chromium.org/134623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative revert to see if issues on Mac bots get resolved.
BrowserTest.WindowOpenClose is e.g. failing on this assert:
ASSERTION FAILED: !active || m_layerTreeView
> Make SingleThreadProxy a SchedulerClient
>
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
>
> Other compositors that use SingleThreadProxy are left calling composite
> synchronously and now pass a flag to indicate that this is their
> intention. This patch doesn't remove synchronous composite, but now
> makes it mutually exclusive with scheduling.
>
> BUG=329552, 287250
>
> Review URL: https://codereview.chromium.org/134623005
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/441343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.
Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention. This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.
BUG=329552, 287250
Review URL: https://codereview.chromium.org/134623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert:
Check if this CL breaks TouchActionBrowserTest.TouchActionNone test http://goo.gl/pwdNwL
Also it was reported that this CL causing a number of crashes on the blink bots, e.g.,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel
> Make SingleThreadProxy a SchedulerClient
>
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
>
> BUG=329552, 287250
>
> Review URL: https://codereview.chromium.org/134623005
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/359103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.
BUG=329552, 287250
Review URL: https://codereview.chromium.org/134623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
May our paths cross again soon!
BUG=
TBR=jochen@chromium.org,thakis@chromium.org
Review URL: https://codereview.chromium.org/343323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Android snapshot was found to be chopping off the bottom content. This is
due to not accounting for the height of the toolbar. This patch enlarges the
snapshot by that offset.
BUG=384551
Review URL: https://codereview.chromium.org/340603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Chrome for Android, the size of the layers correspond to their physical
pixel size. We should scale the copy request subrect by the device scale
factor.
The reason why content/test/gpu/page_sets/pixel_tests.py never failed is
because the test only takes a 300x300 sub-region of the output bitmap; so
as long as the request subrect is greater than that region, the test will
pass through. After this change, ui::GrabViewSnapshot will return a bitmap
of the content in phyiscal pixel size. Should not affect pixel_tests.py.
BUG=384551
Review URL: https://codereview.chromium.org/333413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CopyOutputRequest's area is now in layer's scale factor, not
in pixel.
R=danakj@chromium.org, piman@chromium.org
BUG=381578
TEST=manually, snapshot_unittests succeeds
Review URL: https://codereview.chromium.org/321323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements jar_file_jni_generator.gypi for GN.
Also, add the //ui/gl:surface_jni_headers and enable some targets that
depend on it.
BUG=359249
R=brettw@chromium.org,tfarina@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/294323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename "//ui/base:ui_base" to "//ui/base:base" to make it easier to specify
BUG=
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/306113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way when creating the Compositor we can supply the ContextFactory
from the thread local Env to it. This is part of making aura thread
safe.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/296053009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The android pixel tests use the ui::Snapshot code to get a pixel copy
of the content_shell's output. Make this behaviour match the aura
implementation of ui::Snapshot by returning false in the synchronous
verion, causing callsites to fall back to the async one.
This implements the async snapshots by moving the aura implementation
out into snapshot_async.cc and reusing that code (with one #if for
RGBA vs BGRA ordering).
After this, the pixel tests get a bitmap from cc instead of creating
their own bitmap. The result is that the bitmap has a slightly
different size (384x528) which is the size of the root layer. The
pixel tests were previously trying to crop to 400x300, which is
outside the bounds of this bitmap, so change them to crop to 300x300
instead, and increment their versions to pick up the new pngs.
BUG=252046, 371592
Review URL: https://codereview.chromium.org/281003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
R=sky@chromium.org
http://crbug.com/308710
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975
Review URL: https://codereview.chromium.org/250113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/250113002/)
Reason for revert:
views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip
TooltipControllerTest.ViewTooltip (run #2):
[ RUN ] TooltipControllerTest.ViewTooltip
Xlib: extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run().
Original issue's description:
> Move DefaultActivationClient to wm/core
>
> Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
>
> R=sky@chromium.org
> http://crbug.com/308710
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975
TBR=sky@chromium.org,ben@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/261553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
R=sky@chromium.org
http://crbug.com/308710
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616
Review URL: https://codereview.chromium.org/250113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move DefaultActivationClient to wm/core
>
> Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
>
> R=sky@chromium.org
> http://crbug.com/308710
>
> Review URL: https://codereview.chromium.org/250113002
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/259103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
R=sky@chromium.org
http://crbug.com/308710
Review URL: https://codereview.chromium.org/250113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297026
R=ben@chromium.org
Review URL: https://codereview.chromium.org/231733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move wm/public into wm target
>
> TBR=sky@chromium.org
> http://crbug/com/308710
>
> Review URL: https://codereview.chromium.org/209383003
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/213033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Fix bustage with nested namespace
>
> BUG=
>
> Review URL: https://codereview.chromium.org/212863006
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/212893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> Fix link issue
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/212643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> Fix dep error for non-Aura
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/212893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/212863006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
http://crbug/com/308710
Review URL: https://codereview.chromium.org/209383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the rule we setup for //ui which states that each subdir
should be its own component with its own gyp file that lives in its
subdir.
The 'ui' target was renamed to ui_base to match the convention.
BUG=299841
TEST=gyp files.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/198333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids using WED from a number of places and moves us closer to a world where WED is more of an implementation detail of WTH.
R=sky@chromium.org
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/191153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/174803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some users of the test helper want to use ImageTransportFactory, which
also sets up a ContextFactory, meaning we end up setting up 2
ContextFactories currently for those tests. A DCHECK() added to
ContextFactory::SetInstance() caught this. So I've moved the
ContextFactory setup from AuraTestHelper to each of its owners.
While doing so, the the |allow_test_contexts| flag has been inverted
to |enable_pixel_output| since we'll be removing the concept of
test compositor/contexts from these tests.
R=piman@chromium.org
TBR=ben@chromium.org, piman@chromium.org
BUG=270918
Review URL: https://codereview.chromium.org/173113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put this class in its own files in ui/compositor/test/.
R=enne
TBR=sky
BUG=
Review URL: https://codereview.chromium.org/138903017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that the compositor already takes care of the screen
rotation and scaling. SnapshotAura doesn't need to do that.
Also, snapshot_aura_unittest.cc is not good for rotation and
scaling because the existing test just paint plain red. This
CL changes the paint content to fail if the rotation is not
handled correctly.
BUG=337559
R=piman@chromium.org, enne@chromium.org, sky@chromium.org
TEST=manually && snapshot_unittests
Review URL: https://codereview.chromium.org/137143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move into base/numerics subdirectory.
* Rename files for clarity.
* Add owners.
* Rename checked_numeric_cast to checked_cast.
* Fixup callsites and include paths.
BUG=332611
R=brettw@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/141113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245418 0039d316-1c4b-4281-b951-d872f2087c98
|