| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already have TS/CQ and Waterfall coverage for these two configs, so
it should be fine to make them part of gfx_unittests now that we run
that unit test target in the bots.
BUG=331829
TEST=gfx_unittests
TBR=danakj@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/229373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platforms as well
BUG=333413
Review URL: https://codereview.chromium.org/226163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_locale_test_pak was just doing more things in case the OS was not mac:
1- it outputs a locale.pak on iOS
2- it outputs an en-US.pak for the other platforms besides Mac.
3- in the end it copies ui_resources_100_percent.pak into <(PRODUCT_DIR>/ui
We can 'easily' fold all this into ui_test_pak and that is what we do in this patch, so the clients do not have to worry about. They should not need to decide if they need to depend on ui_locale_test_pak or not. They should depend just on ui_test_pak and everything should be setup for them "automagically".
BUG=355203
TEST=ui_unittests, app_list_unittests, message_center_unittests ...
R=tony@chromium.org,blundell@chromium.org,tapted@chromium.org,oshima@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/209403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That should help clarify what this target is all about and make easier
to reason about the code that relies on it. It now pairs with the
existing ui_test_pak (may be should we merge them in the future?) target.
BUG=349525
TEST=ui_unittests
R=tapted@chromium.org, tony@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/197333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=333413
Review URL: https://codereview.chromium.org/192483007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the rule we setup for //ui which states that each subdir
should be its own component with its own gyp file that lives in its
subdir.
The 'ui' target was renamed to ui_base to match the convention.
BUG=299841
TEST=gyp files.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/198333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows ui_unittests to stop depending on the chrome framework.
On Mac, this creates (e.g.)
- out/ui_unittests Framework.framework/
+-- Resources -> Versions/A/Resources
\-- Versions
\-- A
\-- Resources
+-- Info.plist
+-- am.lproj
| \-- locale.pak
+-- ...
+-- chrome_100_percent.pak -> ui_test.pak
+-- ...
+-- en.lproj
| \-- locale.pak
+-- ...
On other platforms, out/ui_test.pak is loaded directly and
out/ui_unittests_strings/ is set as the locale folder (for tests that
load en-US.pak from there). ui_unittests currently depends on
out/locales/ which is only created when Chrome is built.
Note that ui_unittests does not currently succeed in a clobber build
(crbug.com/347851), so that missing dependency is fixed by this change
as well.
BUG=331669, 35878, 347851
TEST=ui_unittests should build and run after clobbering the build folder
Previously Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255512
Review URL: https://codereview.chromium.org/152543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The linker didn't include the gfx_geometry_unittests symbols in the former state since they were never referenced in ui_unittests.
BUG=331829
Review URL: https://codereview.chromium.org/190763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the chromium.mac bots were happy, but the official builder didn't like it.
> Introduce a mock ui_unittests Framework for loading resources.
>
> This allows ui_unittests to stop depending on the chrome framework.
>
> On Mac, this creates (e.g.)
> - out/ui_unittests Framework.framework/
> +-- Resources -> Versions/A/Resources
> \-- Versions
> \-- A
> \-- Resources
> +-- Info.plist
> +-- am.lproj
> | \-- locale.pak
> +-- ...
> +-- chrome_100_percent.pak -> ui_test.pak
> +-- ...
> +-- en.lproj
> | \-- locale.pak
> +-- ...
>
> On other platforms, out/ui_test.pak is loaded directly and
> out/ui_unittests_strings/ is set as the locale folder (for tests that
> load en-US.pak from there). ui_unittests currently depends on
> out/locales/ which is only created when Chrome is built.
>
> Note that ui_unittests does not currently succeed in a clobber build
> (crbug.com/347851), so that missing dependency is fixed by this change
> as well.
>
> BUG=331669, 35878, 347851
> TEST=ui_unittests should build and run after clobbering the build folder
>
> Review URL: https://codereview.chromium.org/152543005
TBR=tapted@chromium.org
Review URL: https://codereview.chromium.org/190133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows ui_unittests to stop depending on the chrome framework.
On Mac, this creates (e.g.)
- out/ui_unittests Framework.framework/
+-- Resources -> Versions/A/Resources
\-- Versions
\-- A
\-- Resources
+-- Info.plist
+-- am.lproj
| \-- locale.pak
+-- ...
+-- chrome_100_percent.pak -> ui_test.pak
+-- ...
+-- en.lproj
| \-- locale.pak
+-- ...
On other platforms, out/ui_test.pak is loaded directly and
out/ui_unittests_strings/ is set as the locale folder (for tests that
load en-US.pak from there). ui_unittests currently depends on
out/locales/ which is only created when Chrome is built.
Note that ui_unittests does not currently succeed in a clobber build
(crbug.com/347851), so that missing dependency is fixed by this change
as well.
BUG=331669, 35878, 347851
TEST=ui_unittests should build and run after clobbering the build folder
Review URL: https://codereview.chromium.org/152543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port the Android platform's Scroller.java to C++, and wire the code up to
FlingAnimatorImpl. This has several benefits, including:
1) JNI hop and garbage elimination.
2) Fling updates in DIPs.
3) Animation timing independent of the Android view system.
4) Easy access to X and Y velocity components.
This may also prove useful for non-fling related scroll animations, e.g., smooth
scrolling from mousewheel and/or keyboard inputs on the compositor thread.
BUG=344370
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/172933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One is cocoa_events_utils which is moved to ui/events/cocoa and contains
only events related code. The other is cocoa_base_utils which uses code
from ui/base so needs to stay in ui/base/cocoa.
BUG=299841
TEST=ui_unittests, events_unittests
R=sadrul@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/160083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/83293008/)
Reason for revert:
As per http://crbug.com/344243 - this CL makes the App Launcher window invisible under Aero, and packaged app windows invisible under non-Aero (RDP/Classic theme/etc.).
BUG=344243
Original issue's description:
> Fix CreateHRGNFromSkPath to support arbitrary SkPaths.
>
> Also adds tests for CreateHRGNFromSkPath and CreateHRGNFromSkRegion.
>
> BUG=322360
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251555
TBR=ben@chromium.org,wez@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=322360
Review URL: https://codereview.chromium.org/169223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like with recent refactoring those paths are not necessary
anymore. They are also wrong, so they don't have any effect. Removing it
now. These were discovered in r247866
(https://codereview.chromium.org/147803002)
BUG=299841
TEST=ui_unittests
TBR=tony@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/167843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also adds tests for CreateHRGNFromSkPath and CreateHRGNFromSkRegion.
BUG=322360
Review URL: https://codereview.chromium.org/83293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way events can reuse it. This will be necessary to move the
remaining events files from ui/base to ui/events.
BUG=299841
TEST=None
R=sadrul@chromium.org,thakis@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/156053005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to avoid a circular dependency that on Mac is forbidden:
ui_unittests -> shell_dialogs -> aura -> ui_unittests
The down side is that momentarily we lose automatic test coverage on the bots for the shell_dialogs.
This can be fixed by teaching the buildbot scripts to run it after this lands.
BUG=331669, 35878, 299841
TEST=shell_dialogs_unittests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/151253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now it is only possible to move these event files from ui/base to
ui/events, because otherwise a circular dep will arise between ui.gyp ->
events.gyp and ui_unittests.gyp
BUG=299841
TEST=None
R=sadrul@chromium.org,thakis@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/140123007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining pieces in ui/test/ are used only by a unittest in ui/gfx/,
so in this patch we move these files into ui/gfx. This fixes the TODO in
ui/gfx/DEPS that was assigned to Ben.
BUG=None
TEST=ui_unittests
R=tony@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/147803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After r246620 nobody needs or should include ui/test/test_suite.h. That
allow us to concentrate it in ui/base/.
We move the run_all_unittests.cc into ui/base/test and at the same time
fold test_suite.* into run_all_unittests.cc and rename UITestSuite to
UIBaseTestSuite.
BUG=144345,299841
TEST=ui_unittests
R=tony@chromium.org,ben@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/142793006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already load chrome.pak and en-US.pak which includes all the necessary
strings and images for the tests.
This also fixes the following errors I'm seeing in ui_unittests target.
[18617:18617:0104/164229:7580537011:ERROR:memory_mapped_file.cc(23)] Couldn't open /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
[18617:18617:0104/164229:7580537130:ERROR:data_pack.cc(78)] Failed to mmap datapack
[18617:18617:0104/164229:7580537189:ERROR:resource_bundle.cc(607)] Failed to load /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
Some features may not be available.
BUG=144345
TEST=ui_unittests, app_list_unittests, message_center_unittests
R=tony@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/104783007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a few instances where !Windows is assumed to be Linux.
Chang many instances of !USE_GTK_MESSAGE_PUMP &&
!OS_MACOSX && !OS_ANDROID to just USE_AURA (they are
equivalent now).
Add a very minimal RootWindowHostMac.
Of note is that building with Aura requires running
"gyp_chromium --no-circular-check" (the circular
check is only enabled on Mac, and doesn't work with
Aura).
Also note that the demo does not work properly unless BGRA
support is disabled (in FeatureInfo::InitializeBasicState these
extensions can be disabled).
BUG=331669
Review URL: https://codereview.chromium.org/110283005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=299841
TEST=cc_unittests, ui_unittests
R=ben@chromium.org, danakj@chromium.org
Review URL: https://codereview.chromium.org/119473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
http://crbug.com/327489
Review URL: https://codereview.chromium.org/109433013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move events test-related code into a separate target so that these don't get
used in non-test code. Notable changes:
* Move nested TestApi classes out of Event, LocatedEvent and EventTarget,
and into separate classes. The new classes become friends with their old
parents.
* Move events_x_utils out of x/ into test/
R=sky@chromium.org, tfarina@chromium.org
TBR=jam@ for content_tests.gypi and render_view_browsertest.cc changes.
BUG=none
Review URL: https://codereview.chromium.org/82903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The events related tests are currently run in events_unittests in all the bots.
So these can now be removed from ui_unittests.
BUG=316677
R=sky@chromium.org
Review URL: https://codereview.chromium.org/83733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a separate target named 'app_list_test_support', that is
independent from ui_unittests.gyp. This is necessary because we are in
the process of moving ui_unittests.gyp into ui/base, and we will split
ui_unittests into multiple module specific unit tests.
BUG=299841
TEST=None
R=ben@chromium.org,xiyuan@chromium.org
Review URL: https://codereview.chromium.org/80803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need this for the embedded build, otherwise the following tests don't link:
- event_dispatcher_unittest
- ozone/evdev/key_event_converter_unittest
- ozone/evdev/touch_event_converter_unittest
Review URL: https://codereview.chromium.org/79063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was created by the following steps:
1. Create a new directory to move.
mkdir ui/events/keycodes/dom4
2. Move the OWNERS file manually, because the next script supports only source files.
git mv ui/base/keycodes/OWNERS ui/events/keycodes/
3. Use script to move source files.
./tools/git/move_source_file.py ui/base/keycodes/* ui/events/keycodes/dom4
4. Here's the output from the script.
WARNING: Could not successfully update include guard; perhaps old guard is not per style guide?
You will have to update the include guard manually.
(ui/events/keycodes/dom4/keycode_converter.h)
5. modify the header guard of keycode_converter.h
BUG=312218
Review URL: https://codereview.chromium.org/59873007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step for moving ui.gyp into ui/base/
After this lands, Blink will be updated to reference the new file under
ui/resources.
Then the by-pass target will be removed from ui.gyp. And then we can
move it to its finall location.
BUG=299841
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/74853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces AppListSyncableService, but does not implement any
syncing yet. The purpose is to move ownership of AppListModel so that
we can maintain and sync the model state independent of the view. It also
made sense to move ExtensionAppModelBuilder ownership to
AppListSyncableService.
This required a fair bit of (smallish) re-factoring. Here is a simplified
diagram that may help:
https://docs.google.com/a/google.com/drawings/d/1NgaQzdqddTh1W7altZ6P6t4dNxZDRO0e_HgJqa8V36A/edit
BUG=315887
For minor ash/shell/ changes:
R=jennyz@chromium.org, tapted@chromium.org, xiyuan@chromium.org
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/66023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Do the preparation work for enabling HIDPI support on linux aura: enable DIP and calculate device scale factor at DesktopScreenX11.
Review URL: https://codereview.chromium.org/27156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without pango, we have no font rendering. Skip font-related tests for
embedded builds that have no native font support.
BUG=320050, 318413
Review URL: https://codereview.chromium.org/67473010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're frequently using the use_glib gyp variable as a shorthand for:
OS!="win" and OS!="mac" and OS!="ios" and OS!="android"
This should be equivalent to:
desktop_linux == 1 or chromeos == 1
Embedded builds want to remove as many dependencies as possible. This
cleans up uses of the use_glib variable so we can turn it off on linux
without breaking the build.
BUG=316226
Review URL: https://codereview.chromium.org/61923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All ozone configurations currently build DRI support, and therefore
have a dependency on the libdrm system library. This is not needed
except when ozone_platform_dri is enabled.
This allows us to drop the link to libdrm when it is not needed.
Review URL: https://codereview.chromium.org/62953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- events_base (built by most people) - defining some basic utilities.
- events (built by users of aura/views) - the ui::Event type & friends.
Prior to this there was one target, and platforms that did not want ui::Event would exclude those files explicitly, making it hard to build those files on those platforms without breaking other components.
R=sadrul@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/57433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoiding the DRM prefix such that it isn't confused with Digital Rights
Management.
BUG=
Review URL: https://codereview.chromium.org/49303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This is the pattern we follow for projects under ui/, each top-level directory
(app_list, aura, compositor, events) have its own gyp file for its main target
(library).
BUG=299841
TEST=build/gyp_chromium, ninja -C out/Debug shell_dialogs, and other targets
still build.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/47323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231478 0039d316-1c4b-4281-b951-d872f2087c98
|