| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[This reland also fixes an issue with the label drawn on top of the old
profile switching menu. It also expands ExtensionApiTest.Bookmarks
disabling from just Windows to Windows and Linux.]
This also converts the TextButtons in the BookmarkBarView to
LabelButtons, since they need to have the same base class as MenuButton
does. This also standardizes on fade eliding instead of fade eliding
sometimes and ellipsis eliding in other cases.
This patch has the effect that everything on the bookmark bar also
renders with GTK+ borders in GTK theme mode on Linux.
BUG=155363,331924,385934,383452
R=msw@chromium.org, noms@chromium.org
TBR=msw@chromium.org, sky@chromium.org
First Review URL: https://codereview.chromium.org/298813002
Review URL: https://codereview.chromium.org/344643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/298813002/)
Reason for revert:
This is causes ExtensionApiTest.Bookmarks to fail on Linux:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5412
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32272
TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org
NOTRY=true
NOTREECHECKS=true
Original issue's description:
> views: Move MenuButton from TextButton to LabelButton.
>
> This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases.
>
> This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux.
>
> BUG=155363
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277878
Review URL: https://codereview.chromium.org/340003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases.
This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux.
BUG=155363
Review URL: https://codereview.chromium.org/298813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org, tsepez@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/117983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16757004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128820
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10574014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/frame to use ImageSkia
Do conversion using the same sed script as for 10437006
Modified by hand afterwards:
1 chrome/browser/download/download_util.cc
2 chrome/browser/ui/panels/panel_browser_frame_view.cc
3 chrome/browser/ui/panels/panel_browser_frame_view.h
4 chrome/browser/ui/toolbar/wrench_menu_model.cc
5 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc
6 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h
7 chrome/browser/ui/views/constrained_window_views.cc
8 chrome/browser/ui/views/frame/glass_browser_frame_view.cc
9 chrome/browser/ui/views/tab_icon_view.h
10 ui/base/dragdrop/drag_utils.h
11 ui/base/dragdrop/drag_utils_gtk.cc
12 ui/base/dragdrop/drag_utils_win.cc
13 ui/base/native_theme/native_theme_android.cc
14 ui/base/native_theme/native_theme_android.h
15 ui/base/native_theme/native_theme_base.cc
16 ui/base/native_theme/native_theme_base.h
17 ui/views/widget/native_widget_private.h
18 ui/views/window/frame_background.h
19 ui/views/window/window_resources.h
Line wrapping and include fixes
chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc
1 chrome/browser/ui/views/frame/browser_view.cc
2 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
3 ui/base/dragdrop/drag_utils_aura.cc
4 ui/base/dragdrop/os_exchange_data_provider_aura.h
5 ui/base/native_theme/native_theme_aura.cc
6 ui/views/button_drag_utils.h
7 ui/views/painter.cc
8 ui/views/painter.h
9 ui/views/widget/native_widget_aura.cc
10 ui/views/widget/widget_delegate.h
11 ui/views/window/custom_frame_view.cc
12 ui/views/window/custom_frame_view.h
Test=Compiles, Webkit layout tests fast/ pass
Bug=124566
Review URL: https://chromiumcodereview.appspot.com/10447053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
outside of views. I tried to move SetURLAndDragImage as well, but that would cause a lot of code duplication from Views' TextButton class that would make us worse off (things like mirroring and limiting size).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9582041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124923 0039d316-1c4b-4281-b951-d872f2087c98
|