| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux, the OS theme can change, which affects the default background
colour of the avatar bubble. This means that using a frame overlay to
display the profile avatar as an image is not actually feasible.
This also adds a small change to the ClipPath function of gfx::Canvas,
to allow controlling the anti-aliasing option.
BUG=372721
TEST=Start Chrome with --new-profile-management. Click on the avatar button. The avatar should still be displayed as a circle.
Review URL: https://codereview.chromium.org/290333012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to button refactoring patches, we now need to ask views for their
preferred sizes in const methods. Across the entire codebase, the
overwhelming majority of GetPreferredSize() implementations could be
const. There are only a few places where we can't, and they are usually
combining the sizing and layout code.
BookmarksBarView was simple enough to perform this separation. Most of
the other places were solved by adding "mutable" to value caches.
BUG=155363
R=jam@chromium.org, pkasting@chromium.org, scheib@chromium.org, sky@chromium.org, pkasting, sky
TBR=jam, scheib
Review URL: https://codereview.chromium.org/273223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/291843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Was broken by r253207.)
BUG=347450
Review URL: https://codereview.chromium.org/196133012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets rid of the enums defined in accessibility_types.h and switches to the
enums defined in ui/accessibility/ax_enums.h, which are shared by "content".
Eventually, content and views may share more common accessibility code, but
moving to the same enums is a good first step.
BUG=316726
R=piman@chromium.org, sky@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/126763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org, tsepez@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/117983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the 1st patch to add progress bar notification support. It contains:
1) A new progress type is added and a new optional progress value is added.
2) NotificationView creates and adds a NotificationProgressbar child view.
BUG=170924
TEST=manual test by creating a progress bar notification
Review URL: https://chromiumcodereview.appspot.com/18662006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Support one click install from web store search result;
- Support action buttons with a text label in SearchResult;
- Add is_installing and percent_downloaded properties to SearchResult;
- SearchResultView shows blue button for label based action buttons;
- SearchResultView shows progress bar when is_installing is true and use
percent_downloaded for the progress bar;
- Move progress bar drawing code into ProgressBarView to share between
AppListItemView and SearchResultView;
- Move InstallTracker code from webstore private api into WebstoreInstaller
so that the install/download could be observed for both webstore inline
install and WebstoreStandaloneInstaller based install;
BUG=173430
Review URL: https://chromiumcodereview.appspot.com/17854007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mike Reed noted in another CL: Create returns a new xfermode
setXfermode refs that mode (and will call unref when it dies)
... but we still have a dangling owner (Create), so we'll get a leak.
Using a skia::RefPtr and skia::AdoptRef can fix this.
In these cases, it's much simpler to use setXfermodeMode.
BUG=none
TEST=No regressions painting speech bubbles or progress bars.
R=reed@google.com,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17130003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=235984
R=jamescook@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14676008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the discussion in crbug.com/134600, we decide to adopt the new blue progress bar
introduced originally for wallpaper chooser.
BUG=134600
TEST=on device, upload a large file to GoogleDrive from FileManager, open the system tray, and see the progress of upload for GoogleDrive status in the tray.
Review URL: https://chromiumcodereview.appspot.com/11742019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky
BUG=163454
Depends on: https://codereview.chromium.org/11418217/
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11299262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11184023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should not handle DCHECK failures, read
http://dev.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
for more information.
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11155002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=views_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/10950021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced sk_canvas()->drawColor() with DrawColor()
Removed any instances of #include "third_party/skia/include/core/SkCanvas.h"
Replaced DrawPath in touch_selection_controller_impl with DrawCircle call manually
Bug=114665
Test=Compiles
Review URL: http://codereview.chromium.org/10025011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9663077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The final goal is to merge these two classes into a single gfx::Canvas class.
BUG=116572
R=ben@chromium.org,asvitkine@chromium.org
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9562038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
set() function.
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9544001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it manually.
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9517012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9360049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105879
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8909002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8771006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8687031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112014 0039d316-1c4b-4281-b951-d872f2087c98
|