| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=views_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/10950021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Round 2, minus changes to Textfield (since it does some funky text
postproceesing),
Saves a repaint when no change actually occurs.
BUG=chrome-os-partner:13141
TEST=build, run on lumpy, lucas
Change-Id: I8db2384954b2bf2c77ae1685f5db737f417fe312
Review URL: https://chromiumcodereview.appspot.com/10928134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unit tests
Review URL: https://chromiumcodereview.appspot.com/10933129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=149851
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/10916333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
invoked using long press.
BUG=142015
Review URL: https://codereview.chromium.org/10916180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This cl only implements RenderWidgetHostViewWin::ExtendSelectionAndDelete() which is needed to support HANJA key of Korean IME in Metro.
BUG=148355
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/10928199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
placement to TextButton
BUG=147330
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156599
Review URL: https://chromiumcodereview.appspot.com/10933049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ICON_CENTERED placement to TextButton
BUG=147330
Review URL: https://chromiumcodereview.appspot.com/10933049
TBR=yefim@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
placement to TextButton
BUG=147330
Review URL: https://chromiumcodereview.appspot.com/10933049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the views examples app.
http://crbug.com/146077
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156096
Review URL: https://chromiumcodereview.appspot.com/10910144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ RUN ] NativeTextfieldViewsTest.ModelChangesTestLowerCaseWithLocale
controls\textfield\native_textfield_views_unittest.cc(434): error: Value of:
model_->GetText()
Actual: L"\x131"
Expected: WideToUTF16(L"i")
Which is: L"i"
[ FAILED ] NativeTextfieldViewsTest.ModelChangesTestLowerCaseWithLocale (16
ms)
If I had to guess it's that i is considered the same as ı somehow.
Saves a repaint when no change actually occurs.
BUG=chrome-os-partner:13141
TEST=build, run on lumpy, lucas
Change-Id: I6ccb75141b7639571e24b2fbf7e3986d85e98cbc
Review URL: https://chromiumcodereview.appspot.com/10916222
TBR=sheu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Saves a repaint when no change actually occurs.
BUG=chrome-os-partner:13141
TEST=build, run on lumpy, lucas
Change-Id: I6ccb75141b7639571e24b2fbf7e3986d85e98cbc
Review URL: https://chromiumcodereview.appspot.com/10916222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
combobox function in the views examples app.
http://crbug.com/146077
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155832
Review URL: https://chromiumcodereview.appspot.com/10910144
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10933029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the views examples app.
http://crbug.com/146077
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155832
Review URL: https://chromiumcodereview.appspot.com/10910144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point.
[Differences from the first patch: this may fix the pdf tests, but since I have no way to run them locally or on a trybot, this is going in blind.]
BUG=130805
R=jam@chromium.org
TBR=tc,ben,dcheng,kaiwang
First Review URL: https://chromiumcodereview.appspot.com/10911074
Review URL: https://chromiumcodereview.appspot.com/10916214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
combobox function in the views examples app.
http://crbug.com/146077
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910144
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10909156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the views examples app.
http://crbug.com/146077
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread.
Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point.
BUG=130805
TBR=tc (change in webkit/ is trivial)
Review URL: https://chromiumcodereview.appspot.com/10911074
TBR=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10919180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links.
BUG=118317
Review URL: https://chromiumcodereview.appspot.com/10868116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point.
BUG=130805
TBR=tc (change in webkit/ is trivial)
Review URL: https://chromiumcodereview.appspot.com/10911074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does this for content area context menus only. I will send out another CL for same functionality on views controls.
We acheive this as follows: We remember in render_widget_host, which kind of
event is currently in process. When we get a request for showing context menu,
in render_view_host, we check if currently we are processing a gesture event,
and if so, we display the context menu appropriately.
BUG=142015
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10917102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately
describes how its being used in the code. In a followed CL I will add
specific support for startup pages, which was the original intention of
START_PAGE.
This CL is basically a large search and replace and does not change the
behaviour of the code.
BUG=144002
TEST=No user visible change
Review URL: https://chromiumcodereview.appspot.com/10897034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=145570
TEST=none
R=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10920095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10917075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10912063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When TSF awareness is required, we should use Window Class which supports RichEdit 4.1.
BUG=137627
Review URL: https://chromiumcodereview.appspot.com/10823253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit d2287c4694d749d9e0c4095d7b004beee7b27e86.
BUG=105557
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137345
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/10919036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10890023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was not
changing the parent of the attached window. This meant that if the
parent was destroyed the attached window would be destroyed. Fix for
windows was done here: https://chromiumcodereview.appspot.com/10832011
This differs from first patch in that I needed to add checks for
RootWindow in a couple of places.
BUG=132090, 141870
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was not
changing the parent of the attached window. This meant that if the
parent was destroyed the attached window would be destroyed. Fix for
windows was done here: https://chromiumcodereview.appspot.com/10832011
BUG=132090, 141870
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916017
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10912036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changing the parent of the attached window. This meant that if the
parent was destroyed the attached window would be destroyed. Fix for
windows was done here: https://chromiumcodereview.appspot.com/10832011
BUG=132090, 141870
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 819e83e11f734af26da7c0de8c2b0316a35516dc. Revision 153817.
Win compile failures, see http://build.chromium.org/p/tryserver.chromium/builders/win/builds/25344
BUG=105557
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10897037
TBR=tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mnemonic.
This more closely matches the behavior of other Windows browsers and most Windows apps.
BUG=145549
Review URL: https://chromiumcodereview.appspot.com/10890044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 819e83e11f734af26da7c0de8c2b0316a35516dc. Revision 153817.
BUG=105557
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10897037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105557
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10882064
TBR=tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10885028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105557
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10882064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137345
TEST=visual check
Review URL: https://chromiumcodereview.appspot.com/10887013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The empty padding makes it easier to close tabs using touch events.
BUG=144696, 145258
Review URL: https://chromiumcodereview.appspot.com/10879104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105557
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10882047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other operating systems should stay as they are.
Furthermore changed according to specifications which can be seen in the issue.
Cleaned up the menu separator constants.
BUG=137345
TEST=visually checked
Review URL: https://chromiumcodereview.appspot.com/10837317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to do fling scroll in the notification list, or
the network (or bluetooth etc.) lists in the uber tray.
BUG=143536
Review URL: https://chromiumcodereview.appspot.com/10875026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=142992
Review URL: https://chromiumcodereview.appspot.com/10832360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=141177
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10831407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58030
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10824402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageSkia::isNull. Replaced all instances of ImageSkia::empty with ImageSkia::isNull
Removed ImageSkia::extractSubset, and replaced calls to use ImageSkiaOperations::ExtractSubset instead
BUG=None
Test=Compiles, try bots pass.
Review URL: https://chromiumcodereview.appspot.com/10824359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MouseWheelEvent, ScrollEvent and DropTargetEvent, in favor of ui::Event derivatives.
http://crbug.com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122908
TBR=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829176
Patch from Harry McCleave <harrym@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=139822
TEST=Menu item sizes are the same size and match the spec except for touch layout separators.
Review URL: https://chromiumcodereview.appspot.com/10829283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug/com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
|