summaryrefslogtreecommitdiffstats
path: root/ui/views/view_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* views: Allow having a different event handler for scroll-gestures from the ↵sadrul@chromium.org2012-07-161-1/+110
| | | | | | | | | | | | | default gesture handler. This fixes gesture-scrolling in the app-list. BUG=129774 TEST=views_unittests Review URL: https://chromiumcodereview.appspot.com/10786017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146918 0039d316-1c4b-4281-b951-d872f2087c98
* Add and specify Views::Textfield::SelectAll |reversed| flag, etc.msw@chromium.org2012-07-131-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SelectAll should be consistent and explicit with range reversal. This dictates if leading or trailing text is shown when textfields overflow. Currently, NativeTextfield[Win|Views]::SelectAll behavior is implicit and differs. (Windows native reverses the selection, while ChromeOS/Views doesn't) Revise SelectAll in RenderText, NativeTextfieldWin, and OmniboxViewViews. Add the |reversed| parameter and plumbing to related interfaces/functions. Add/update RenderTextTest.SelectAll and TextfieldViewsModelTest.Selection. Specify explicit reversal behavior in all the following cases: 1) Use reversed selection (changes ChromeOS/Views behavior) in: a) BookmarkBubbleView::ShowBubble (focus on bookmark title when shown). b) BookmarkEditorView::Accept (focus on invalid bookmark URL on "Save"). c) BookmarkEditorView::Show (focus on bookmark title when shown). d) FindBarView::UpdateForResult (find bar matches are found/iterated). e) FindBarView::SetFocusAndSelection (find bar shown, etc.). f) FindBarView::SearchTextfieldView::RequestFocus (click find bar parts, etc.). g) EditSearchEngineDialog::Show (focus on search engine title when shown). h) LoginView::OnAutofillDataAvailable (HTTP/FTP auth window shown). i) MessageBoxView::ViewHierarchyChanged (JS dialog with text input shown). 2) Use forward selection (changes Windows native behavior) in: a) NativeTextfieldWin::ExecuteCommand (textfield context menu "Select All"). (note: the Omnibox context menu "Select All" already uses forward selection) b) Textfield::AboutToRequestFocusFromTabTraversal (focus via tab-traversal). (note1: THIS IS CONTENTIOUS! Though OmniBoxViewWin is unaffected) (note2: OmniboxViewViews should be fixed later as per crbug.com/134701#c9) c) TreeView::StartEditing (editing tree view nodes ex/ collected cookies). d) NativeTextfieldViewsTest.* and ViewTest.* (changes inconsequential to tests) 3) Formally specify existing implicit behavior (no behavioral change): a) NativeTextfieldWin::OnAfterPossibleChange (temporary selection is reversed). b) NativeTextfieldViews::OnGestureEvent (double tap is forwards). c) NativeTextfieldViews::ExecuteCommand (context menu "Select All" is forwards). d) NativeTextfieldViews::HandleKeyEvent (CTRL-A is forwards). e) NativeTextfieldViews::HandleMousePressEvent (triple-click is forwards). f) TextfieldViewsModel::SetText (temporary selection is forwards). g) TextfieldViewsModelTest.* is mostly forwards, |Selection| tests reversed. TBR=ben@chromium.org BUG=134762 TEST=New RenderTextTest.SelectAll, updated TextfieldViewsModelTest.Selection, other unit tests, manual. Review URL: https://chromiumcodereview.appspot.com/10693160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146520 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes content scaling when resizingpkotwicz@chromium.org2012-06-131-4/+18
| | | | | | | | | | | | | | Repro steps 1) Run chrome with --default-device-scale-factor=2 2) Maximize window 3) Web content gets scaled to twice the size it was before the window was maximized. Bug=131806 Test=Manual Review URL: https://chromiumcodereview.appspot.com/10533074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141842 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TAP_DOWN gesture event:varunjain@chromium.org2012-06-071-1/+1
| | | | | | | | | | | | | | | | 1. GESTURE_TAP_DOWN should be sent only on the first TOUCH_PRESSED. 2. New gesture GESTURE_BEGIN shuold be sent on all TOUCH_PRESSED. 3. Rename GESTURE_TAP_UP to GESTURE_END. BUG=131007 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140967 Review URL: https://chromiumcodereview.appspot.com/10533029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141011 0039d316-1c4b-4281-b951-d872f2087c98
* It broke win aura botloislo@chromium.org2012-06-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | [ RUN ] WindowTest.TransferCaptureTouchEvents .\window_unittest.cc(700): error: Value of: d1.gesture_event_count() Actual: 2 Expected: 1 .\window_unittest.cc(710): error: Value of: d2.gesture_event_count() Actual: 2 Expected: 1 [ FAILED ] WindowTest.TransferCaptureTouchEvents (0 ms) Revert 140967 - Fix TAP_DOWN gesture event: 1. GESTURE_TAP_DOWN should be sent only on the first TOUCH_PRESSED. 2. New gesture GESTURE_BEGIN shuold be sent on all TOUCH_PRESSED. 3. Rename GESTURE_TAP_UP to GESTURE_END. BUG=131007 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10533029 TBR=varunjain@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TAP_DOWN gesture event:varunjain@chromium.org2012-06-071-1/+1
| | | | | | | | | | | | | | 1. GESTURE_TAP_DOWN should be sent only on the first TOUCH_PRESSED. 2. New gesture GESTURE_BEGIN shuold be sent on all TOUCH_PRESSED. 3. Rename GESTURE_TAP_UP to GESTURE_END. BUG=131007 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10533029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140967 0039d316-1c4b-4281-b951-d872f2087c98
* Gesture related changes for views:sky@chromium.org2012-06-051-0/+13
| | | | | | | | | | | | | | . Makes capture send both gesture and mouse events to the same view. . Makes gesture handling consistant with mouse handling. We only handle targetting a single view and reset the target on touch up. BUG=124277 TEST=none R=ben@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10479010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove post delete accessdavemoore@chromium.org2012-05-251-1/+36
| | | | | | | | | BUG=129745 TEST=Run new ViewTest.DeleteOnPressed test with ASAN enabled. Review URL: https://chromiumcodereview.appspot.com/10445041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139120 0039d316-1c4b-4281-b951-d872f2087c98
* Converts ui/views/controls, ui/views/examples, ui/base/models to use ↵pkotwicz@chromium.org2012-05-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gfx::ImageSkia Converts all instances using an SkBitmap to use a gfx::ImageSkia instead Replaces method names, variables and comments which include "bitmap" to use "image" instead Sed script used for conversion: 1 # Modify comments. 2 /\/\// { 3 # Save line in hold buffer. 4 h 5 # Extract portion of line which represents comment 6 # and put that into pattern space. 7 s|.*//\(.*\)|\1| 8 # Perform changes. 9 s| SkBitmap| ImageSkia|g 10 s| a bitmap| an image|g 11 s| Bitmap| Image|g 12 s| bitmap| image|g 13 # Append hold buffer to pattern space, 14 G 15 # Put everything back together. 16 s|\(.*\)\n\(.*\)//.*|\2//\1| 17 } 18 19 # Modify code. 20 # 21 # Store in hold buffer [code part ]//[comment part(including //)]. 22 # Thus you would get 4 consecutive slashes if the line actually does 23 # have a comment. 24 # Extract portion of line which has code and put that into pattern space. 25 26 # Line has a comment. 27 /\/\// { 28 s|\(.*\)//\(.*\)|\1////\2| 29 h 30 s|\(.*\)//.*|\1| 31 } 32 # No comment on line 33 /\/\// !{ 34 s|\(.*\)|\1//| 35 h 36 s|\(.*\)//|\1| 37 } 38 39 # Perform Changes 40 41 # Delete calls. 42 /buildMipMap(false)/d 43 # Replace includes. 44 s|third_party/skia/include/core/SkBitmap\.h|ui/gfx/image/image_skia\.h|g 45 s|ToSkBitmap|ToImageSkia|g 46 s|GetBitmapNamed|GetImageSkiaNamed|g 47 # Rename variables of type SkBitmap to variables of type gfx::ImageSkia 48 # Try to avoid renaming function names and classes which have 'SkBitmap' 49 # in them. 50 s|SkBitmap\([ (*&>),]\)|gfx::ImageSkia\1|g 51 # Modify variable names. 52 s|_bitmap|_image|g 53 s|bitmap|image_skia|g 54 s|bmp|image_skia|g 55 # Rename functions and classes which have 'SkBitmap' in them to use 'ImageSkia' instead 56 s|SkBitmap|ImageSkia|g 57 s|Bitmap|Image|g 58 # Restore things we didn't mean to change. 59 # SkImageOperations 60 s|ImageSkiaOperations|SkBitmapOperations|g 61 s|SkBitmapOperations::Create\(.*\)Image(|SkBitmapOperations::Create\1Bitmap(|g 62 s|skimage_skia_operations|skbitmap_operations|g 63 # SkPaint 64 s|setFilterImage|setFilterBitmap|g 65 s|isFilterImage|isFilterBitmap|g 66 # gfx::Canvas 67 s|ExtractImage|ExtractBitmap|g 68 # We will want to rename this function after everything else has changed. 69 s|DrawImageInt|DrawBitmapInt|g 70 71 # Append hold buffer to pattern space. 72 # Pattern space will look like: [code part]\n[code part]//[comment part (includi ng //). 73 G 74 # Put everything back together. 75 s|\(.*\)\n\(.*\)//\(.*\)|\1\3| I modified the following files manually afterwards: 1 ash/wm/workspace/frame_maximize_button.cc 2 ash/wm/workspace/frame_maximize_button.h 3 chrome/browser/chromeos/login/helper.cc 4 chrome/browser/chromeos/status/network_menu.cc 5 chrome/browser/cookies_tree_model.cc 6 chrome/browser/cookies_tree_model.h 7 chrome/browser/ui/gtk/gtk_tree.cc 8 chrome/browser/ui/gtk/menu_gtk.cc 9 chrome/browser/ui/search_engines/template_url_table_model.cc 10 chrome/browser/ui/search_engines/template_url_table_model.h 11 chrome/browser/ui/toolbar/back_forward_menu_model.cc 12 chrome/browser/ui/toolbar/back_forward_menu_model.h 13 chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc 14 chrome/browser/ui/toolbar/wrench_menu_model.cc 15 chrome/browser/ui/toolbar/wrench_menu_model.h 16 chrome/browser/ui/views/hung_renderer_view.cc 17 chrome/browser/ui/views/infobars/infobar_button_border.cc 18 chrome/browser/ui/views/infobars/infobar_view.cc 19 chrome/browser/ui/views/task_manager_view.cc 20 chrome/browser/ui/views/web_intent_picker_views.cc 21 chrome/browser/ui/views/wrench_menu.cc 22 chrome/browser/ui/webui/chromeos/login/network_dropdown.cc 23 ui/views/controls/button/image_button.cc 24 ui/views/controls/button/image_button_unittest.cc 25 ui/views/controls/image_view.cc 26 ui/views/controls/image_view.h 27 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 28 ui/views/controls/scrollbar/bitmap_scroll_bar.h 29 ui/views/controls/scrollbar/scroll_bar.h 30 ui/views/controls/table/table_view_win.cc 31 ui/views/controls/tree/tree_view_views.h 32 ui/views/controls/tree/tree_view_win.cc 33 ui/views/examples/table_example.cc 34 ui/views/view_unittest.cc Whitespace changes and changes in includes in: 1 ui/base/models/menu_model.h 2 ui/base/models/table_model.h 3 ui/base/models/tree_model.h 4 ui/views/controls/glow_hover_controller.h 5 ui/views/controls/menu/menu.h 6 ui/views/controls/menu/menu_config_views.cc 7 ui/views/controls/menu/native_menu_win.cc 8 ui/views/controls/message_box_view.h 9 ui/views/controls/table/table_view_views.cc 10 ui/views/controls/throbber.h 11 ui/views/examples/table_example.h TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10437006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138800 0039d316-1c4b-4281-b951-d872f2087c98
* layers: Consolidate the ownership of layers in views::View and aura::Window.sadrul@chromium.org2012-05-231-0/+16
| | | | | | | | | BUG=none TEST=aura_unittests, views_unittests. Review URL: https://chromiumcodereview.appspot.com/10412044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138412 0039d316-1c4b-4281-b951-d872f2087c98
* Pass event bitmask (shift, control, alt) to ui::Accelerator instead of booleans.tfarina@chromium.org2012-05-181-4/+4
| | | | | | | | | | BUG=128242 R=ben@chromium.org TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10399044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137792 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move compositor/ directory out of gfx/, up to ui/.tfarina@chromium.org2012-05-051-3/+3
| | | | | | | | | | BUG=104040 R=piman@chromium.org,ben@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10365007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135560 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix painting views with layers in RTL locale.sadrul@chromium.org2012-04-161-0/+60
| | | | | | | | | | | This fixes RTL painting in the launcher. BUG=112070 TEST=none Review URL: https://chromiumcodereview.appspot.com/10081037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132409 0039d316-1c4b-4281-b951-d872f2087c98
* Removing defunct code around PureViews.saintlou@chromium.org2012-04-151-1/+0
| | | | | | | | | | BUG=117493 TEST=none Review URL: http://codereview.chromium.org/10084020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132357 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move gesture-recognizer into ui/base/.sadrul@chromium.org2012-04-051-1/+1
| | | | | | | | | | | | | | Moving the gesture-recognizer into ui/base/ makes it possible to be used by both aura and views independently. This is the first step: add an interface for touch-events and gesture-events so that the gesture recognizer does not have to depend on aura or views events. BUG=121744 TEST=none Review URL: https://chromiumcodereview.appspot.com/9958136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131023 0039d316-1c4b-4281-b951-d872f2087c98
* ui/gfx: Get rid of CanvasSkia::GetSkCanvas() function.tfarina@chromium.org2012-03-131-1/+1
| | | | | | | | | | BUG=116572 R=asvitkine@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9663077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
* ui/gfx: Make gfx::Canvas inherit from gfx::CanvasSkia.tfarina@chromium.org2012-03-091-1/+1
| | | | | | | | | | | | The final goal is to merge these two classes into a single gfx::Canvas class. BUG=116572 R=ben@chromium.org,asvitkine@chromium.org TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9562038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125735 0039d316-1c4b-4281-b951-d872f2087c98
* views: Allow a View to be notified of mouse-enter/leave events even if the ↵sadrul@chromium.org2012-03-051-0/+137
| | | | | | | | | | | | | mouse 'jumps over' them into/out-of a child View. This allows doing mouse-over styling of container views. BUG=110130 TEST=views_unittests:ViewTest.NotifyEnterExitOnChild Review URL: https://chromiumcodereview.appspot.com/9597023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125016 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Let skia do the conversion work for us by using the integer version of ↵tfarina@chromium.org2012-03-011-12/+3
| | | | | | | | | | | set() function. R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9544001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124416 0039d316-1c4b-4281-b951-d872f2087c98
* views: Migrate view unittests to SetBoundsRect.tfarina@chromium.org2012-02-251-38/+38
| | | | | | | | | R=sky@chromium.org TEST=views_unittests Review URL: https://chromiumcodereview.appspot.com/9447063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123656 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness cleanup: disable remaining flaky tests in src/evan@chromium.org2012-02-151-1/+1
| | | | | | | | | | | See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6 BUG=114386,109405,38404 TBR=sky Review URL: http://codereview.chromium.org/9405024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some memory leaks.sadrul@chromium.org2012-02-071-0/+3
| | | | | | | | | BUG=112803, 112795 TEST=none Review URL: https://chromiumcodereview.appspot.com/9333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120827 0039d316-1c4b-4281-b951-d872f2087c98
* Fold views_compositor=1 into use_aura=1piman@chromium.org2012-01-281-40/+2
| | | | | | | | | | | | | We don't have a use case for views_compositor=1 and use_aura=0 (and it's broken/untested anyway), so this simplifies things a little bit. BUG=None TEST=compiles, tests pass. Review URL: http://codereview.chromium.org/9225038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119583 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old (pre-webkit) compositorpiman@chromium.org2012-01-271-160/+4
| | | | | | | | | BUG=103948 TEST=builds, tests pass Review URL: http://codereview.chromium.org/9288053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when |View::AddChildView()| is called on an existing child.asvitkine@chromium.org2012-01-271-0/+33
| | | | | | | | | | | This was being triggered by views_examples. BUG=none TEST=New ViewTest.AddExistingChild unit test. Review URL: http://codereview.chromium.org/9288066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119328 0039d316-1c4b-4281-b951-d872f2087c98
* Rename visual style "password" to "obscured"benrg@chromium.org2012-01-241-2/+2
| | | | | | | | | | | | | | | This change renames some identifiers to distinguish the visual style of being drawn **** **** from the logical property of being a password. It is split off from issue 8748001 and issue 8747001. See http://codereview.chromium.org/8748001/#msg12 and http://codereview.chromium.org/8748001/#msg14 for discussion of the name. TEXT_INPUT_TYPE_PASSWORD is unchanged; it should perhaps be renamed, but not to OBSCURED since it affects input, not display. BUG=none TEST=It compiles. Ship it. Review URL: http://codereview.chromium.org/9117012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118796 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Move GestureRecognizer from views into aura.sadrul@chromium.org2012-01-191-338/+33
| | | | | | | | | | | Remove deprecated GestureManager, and move the functional GestureRecognizer from views into aura. BUG=110227 TEST=views_unittests:GestureEvent, aura_unittests:GestureRecognizerTest Review URL: https://chromiumcodereview.appspot.com/9255019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118200 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Gesture event plumbing (skeleton).sadrul@chromium.org2012-01-171-0/+1
| | | | | | | | | | | | | Add gesture event plumbing through aura. This is not functional just yet. Subsequent CLs will move the gesture-recognizer from views into aura, which will then generate and deliver aura gesture events. BUG=11024 TEST=no functional changes yet. Tests will be added when GR is moved into aura. Review URL: https://chromiumcodereview.appspot.com/9221014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117911 0039d316-1c4b-4281-b951-d872f2087c98
* Initial views touchui Gesture Recognizer supportvollick@google.com2012-01-171-0/+334
| | | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117869 Review URL: https://chromiumcodereview.appspot.com/9076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117894 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117869 - Initial views touchui Gesture Recognizer supportvollick@google.com2012-01-171-334/+0
| | | | | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Review URL: http://codereview.chromium.org/9076002 TBR=vollick@chromium.org Review URL: https://chromiumcodereview.appspot.com/9231013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117870 0039d316-1c4b-4281-b951-d872f2087c98
* Initial views touchui Gesture Recognizer supportvollick@chromium.org2012-01-171-0/+334
| | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Review URL: http://codereview.chromium.org/9076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117869 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where layers weren't getting reordered correctly in asky@chromium.org2012-01-131-1/+27
| | | | | | | | | | | | | NativeWidgetAura. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/9214003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117715 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CanHandleAccelerators() method to AcceleratorTarget.asanka@chromium.org2011-12-271-10/+8
| | | | | | | | | | | This eliminates the need to register/unregister accelerators based on visibility state changes from views. BUG=105734 TEST=unit tests Review URL: http://codereview.chromium.org/8589007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115837 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ui::EventFlags mouse flags to be more sensibledhollowa@chromium.org2011-12-201-8/+8
| | | | | | | | | | | | | | | | Changes EF_(LEFT|MIDDLE|RIGHT)_BUTTON_DOWN to EF_(LEF|MIDDLE|RIGHT)_MOUSE_BUTTON since these are not specific to "down" button events. This is follow up from review http://codereview.chromium.org/8953037 BUG=none TEST=Compiles. R=ben@chromium.org Review URL: http://codereview.chromium.org/9007016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115188 0039d316-1c4b-4281-b951-d872f2087c98
* views: Rename IsVisibleInRootView() to IsDrawn().tfarina@chromium.org2011-12-141-3/+3
| | | | | | | | | | BUG=105879 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8915007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114506 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert IsVisible() to just visible() since it's just a simple accessor.tfarina@chromium.org2011-12-141-3/+3
| | | | | | | | | | BUG=105879 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8917018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114323 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 3 at:sky@chromium.org2011-12-091-2/+5
| | | | | | | | | | | | | | | | | Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. Attempt 2 failed because of last minute changes to chrome_tests.gypi that I didn't merge properly with. TBRing again. BUG=104360 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8890050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113809 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113676 - Attempt 2 at : Makes tests either use mock compositor or mocksky@chromium.org2011-12-081-5/+2
| | | | | | | | | | | | | | | | | | | | WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. I reverted first attempt as it broke some browser_tests. I've straightened that out in another patch, so this should be good go again. TBR since it's the same patch as before. BUG=104360 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8889022 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/8873037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113683 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at : Makes tests either use mock compositor or mocksky@chromium.org2011-12-081-2/+5
| | | | | | | | | | | | | | | | | WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. I reverted first attempt as it broke some browser_tests. I've straightened that out in another patch, so this should be good go again. TBR since it's the same patch as before. BUG=104360 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8889022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113676 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113470 - Makes tests either use mock compositor or mock ↵sky@chromium.org2011-12-071-5/+2
| | | | | | | | | | | | | | WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. BUG=104360 TEST=none Review URL: http://codereview.chromium.org/8805033 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/8873001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113507 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tests either use mock compositor or mock WebGraphicsContext3D ↵sky@chromium.org2011-12-071-2/+5
| | | | | | | | | | | depending upon which compositor we're running. This is needed to enable ui tests on the bots. BUG=104360 TEST=none Review URL: http://codereview.chromium.org/8805033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113470 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use WebKit compositor by defaultpiman@chromium.org2011-12-071-3/+14
| | | | | | | | | | | | BUG=99524 TEST=compositor_unittests, views_unittests, aura_unittests... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112641 Review URL: http://codereview.chromium.org/8565019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113434 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Desktop->RootWindow.ben@chromium.org2011-12-071-1/+1
| | | | | | | | | BUG=none TEST=compiles TBR=sky Review URL: http://codereview.chromium.org/8771015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113303 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112641 - aura: Use WebKit compositor by defaultkalman@chromium.org2011-12-021-14/+3
| | | | | | | | | | | | | BUG=99524 TEST=compositor_unittests, views_unittests, aura_unittests... Review URL: http://codereview.chromium.org/8565019 TBR=piman@chromium.org Review URL: http://codereview.chromium.org/8775045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112645 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use WebKit compositor by defaultpiman@chromium.org2011-12-021-3/+14
| | | | | | | | | | BUG=99524 TEST=compositor_unittests, views_unittests, aura_unittests... Review URL: http://codereview.chromium.org/8565019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112641 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the remaining file from views/ to ui/views/.tfarina@chromium.org2011-12-011-2/+2
| | | | | | | | | | BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8771006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112469 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move view.h to ui/views/.tfarina@chromium.org2011-11-301-0/+3068
| | | | | | | | | | BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8742030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112333 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/ui/views.tfarina@chromium.org2011-10-261-205/+0
| | | | | | | | | BUG=101590 R=pkasting@chromium.org Review URL: http://codereview.chromium.org/8395036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107428 0039d316-1c4b-4281-b951-d872f2087c98
* ui/views: Fix the signature of View::OnViewAdded/Removed overridden methods.tfarina@chromium.org2011-06-081-5/+6
| | | | | | | | | | | | | | | | | The signature changed from (commit bf2f7326): virtual void OnViewAdded(View* parent, View* child); To: virtual void OnViewAdded(const View& parent, const View& child); BUG=72040 TEST=None R=ben@chromium.org,sky@chromium.org,pkasting@chromium.org Review URL: http://codereview.chromium.org/7104042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88392 0039d316-1c4b-4281-b951-d872f2087c98
* View API/implementation cleanup:pkasting@chromium.org2011-02-221-31/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Don't include the container type ("vector") in the typedef for "a bunch of children". Users generally should not know or care what the container is, so this makes reading easier as the code is not constantly pointing out to you, "hey! I'm a vector!" Added bonus: less verbose, allows condensing a lot of loop declarations onto one line. * Consistently put getters before setters. * Remove 4-arg form of SetBounds() and make people use Rects (we should move the codebase towards Points, Sizes, and Rects wherever possible). * Use "origin" instead of "position" to be consistent with Rect's terminology. * Minor naming changes, e.g. GetViewById() -> GetViewByID(). * Remove const qualifier on member functions that are not logically const. This also got rid of all the const_cast<>()s. * Better comments. * Use const ref args for Views whenever the provided View is not being modified, to make that obvious to the caller. * Turn some accessors into pairs of (non-const, const) accessors. In these cases make the non-const version call the const version. (GetWidget() does this in the header because the const version is virtual; this way people who override the const version can see why they don't need to override the non-const version). * Make RemoveChildView() take a bool for consistency with RemoveAllChildViews() (also eliminates the need to return a View*). * Add STL-style iterators and rename a few accessors to match STL terminology ("size" instead of "count"). * Turn IsFocusable() into a cheap inline getter. * Greatly simplify private tree ops ("NotifyHierarchyChangedXXX()") by realizing that they were always being called with |parent| == |this|. * Declare iterators inside loops, not above them. * Standardize iterator naming to |i|. The existing code wasn't always consistent, and while there's nothing wrong with |it|, using that would have made almost every loop declaration into two lines instead of one. * Simpler code, sometimes by using STL algorithms. * Unindent via early-returns. * Use CHECK_NE() and similar where possible. * Fix memory corruption in RemoveAllChildViews() due to using an iterator after modifying its container. BUG=none TEST=none Review URL: http://codereview.chromium.org/6541030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75642 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 23:50:25 +0000