summaryrefslogtreecommitdiffstats
path: root/ui/views
Commit message (Collapse)AuthorAgeFilesLines
* ui: Move NativeTheme files into ui/base/native_theme/ directory.tfarina@chromium.org2012-05-1533-282/+278
| | | | | | | | | | | | BUG=103304,125844 R=ben@chromium.org TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136996 Review URL: https://chromiumcodereview.appspot.com/10310136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137056 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 137040 - This restores a hack that was in place in the old ↵vrk@google.com2012-05-154-21/+42
| | | | | | | | | | | | | | | NativeTabContentsContainer code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code. http://crbug.com/125976 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10378043 Review URL: https://chromiumcodereview.appspot.com/10378043 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10310162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137046 0039d316-1c4b-4281-b951-d872f2087c98
* This restores a hack that was in place in the old NativeTabContentsContainer ↵ben@chromium.org2012-05-154-42/+21
| | | | | | | | | | | | code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code. http://crbug.com/125976 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10378043 Review URL: https://chromiumcodereview.appspot.com/10378043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137040 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at: Changes RootWindow capture code so that we only have one capturesky@chromium.org2012-05-158-50/+33
| | | | | | | | | | | | | | type. Makes gesture generated mouse events use the right mouse generating code so that we generate the correct enter/exit/moved events and update the appropriate state. BUG=115684 TEST=covered by unit tests TBR=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137030 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify SplitStringIntoParagraphs().asvitkine@chromium.org2012-05-151-42/+10
| | | | | | | | | | | | | The new code simply splits on all paragraph separators instead of keeping some strings containing runs of newlines. This new approach removes the need for the code to workaround http://crbug.com/126297, so that when the CL that fixes that bug lands, it will not break this code. BUG=126297 TEST=No visual change in JS alerts. Review URL: https://chromiumcodereview.appspot.com/10383170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137029 0039d316-1c4b-4281-b951-d872f2087c98
* 1. bottom_view_ is removed.xji@chromium.org2012-05-142-53/+24
| | | | | | | | | | | | | | | | | 2. dialog content view height calculation is fixed. The button height calculation in GetPreferredSize(), LayoutContentsView(), and LayoutDialogButtons() do not match. kButtonVEdgeMargin is missed out in LayoutContentsView() which results in content_view's height is greater than that computed in GetPreferredSize() by kButtonVEdgeMargin. Subsequently, if there are multiple children Views in the dialog content view (such as JS message box), the spacing between children views (in rows) are not evenly distributed in views::GridLayout::SizeRowsAndColumns(). BUG=127698 TEST=manual test a JS alert with multiple lines, the lines should be evenly spaced. Tested other UI that uses DialogClientView, such as about chromium and bookmark edit, no regression. Review URL: https://chromiumcodereview.appspot.com/10384064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137011 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136964 - Change SetImage, SetBackground, and SetToggledImage to take ↵vrk@google.com2012-05-149-52/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in a gfx::ImageSkia The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136996 - ui: Move NativeTheme files into ui/base/native_theme/ directory.tfarina@chromium.org2012-05-1433-276/+285
| | | | | | | | | | | | | BUG=103304,125844 R=ben@chromium.org TBR=tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/10310136 TBR=tfarina@chromium.org Review URL: https://chromiumcodereview.appspot.com/10387121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137003 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move NativeTheme files into ui/base/native_theme/ directory.tfarina@chromium.org2012-05-1433-285/+276
| | | | | | | | | | BUG=103304,125844 R=ben@chromium.org TBR=tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/10310136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136996 0039d316-1c4b-4281-b951-d872f2087c98
* Remove RenderText's dependency on NativeTheme.asvitkine@chromium.org2012-05-141-0/+11
| | | | | | | | | | | | This is a first step towards implementing RenderTextMac. There's no NativeTheme class in the Mac build. BUG=125664 TEST=No change in visual appearance. Review URL: https://chromiumcodereview.appspot.com/10387029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136973 0039d316-1c4b-4281-b951-d872f2087c98
* Make touch-optimized-ui a tri-state flagrbyers@chromium.org2012-05-141-4/+2
| | | | | | | | | | | | | | | | | By default ('auto') touch-optimized-UI will be enabled if any touch screen is present. The user can also manually disable or enable it ('disabled', 'enabled') for testing purposes. Note that for now --enable-touch-events is still required to enable the use of touch screens (and hence impact 'auto' here) since it's still experimental. Also cleans up all the different ways we were trying to read this mode, unifying on ui::GetDisplayLayout(). BUG=124199 TBR=estade@chromium.org (only change in resources is trivial comment change) TEST= Review URL: https://chromiumcodereview.appspot.com/10391035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136968 0039d316-1c4b-4281-b951-d872f2087c98
* Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkiapkotwicz@chromium.org2012-05-149-48/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136964 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136877 - Changes RootWindow capture code so that we only have one capturesky@chromium.org2012-05-148-33/+50
| | | | | | | | | | | | | | | | | type. Makes gesture generated mouse events use the right mouse generating code so that we generate the correct enter/exit/moved events and update the appropriate state. BUG=115684 TEST=covered by unit tests R=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10391079 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10310146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136878 0039d316-1c4b-4281-b951-d872f2087c98
* Changes RootWindow capture code so that we only have one capturesky@chromium.org2012-05-148-50/+33
| | | | | | | | | | | | | | type. Makes gesture generated mouse events use the right mouse generating code so that we generate the correct enter/exit/moved events and update the appropriate state. BUG=115684 TEST=covered by unit tests R=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10391079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136877 0039d316-1c4b-4281-b951-d872f2087c98
* views: Export MessageBoxView::InitParams struct as well.tfarina@chromium.org2012-05-131-1/+1
| | | | | | | | | | This should fix the "unresolved external symbol" found in Win Builder 2010. TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10356147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136805 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add a new ctor to MessageBoxView that takes only a InitParams.tfarina@chromium.org2012-05-133-38/+32
| | | | | | | | | | This simplifies many consumers of this API. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10378086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136804 0039d316-1c4b-4281-b951-d872f2087c98
* views: Have a more accurate name for View parent_owned accessors.tfarina@chromium.org2012-05-127-15/+14
| | | | | | | | | | | | Remove the getter accessor of parent_owned() because it's used only internally by View. And change the setter accessor from set_parent_owned() to set_owned_by_client(). BUG=122384 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136766 0039d316-1c4b-4281-b951-d872f2087c98
* Quote WebPreferences in namespace webkit_glue.wangxianzhu@chromium.org2012-05-112-2/+2
| | | | | | | | | | | | | | To avoid name conflict when linking DumpRenderTree which has its own implementation of the class with the same name. BUG=127811 TEST=Build all without errors TBR=kalman@chromium.org,dpapad@chromium.org,ben@chromium.org,battre@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136707 0039d316-1c4b-4281-b951-d872f2087c98
* Makes View only consume a long press if drag was started.sky@chromium.org2012-05-112-5/+9
| | | | | | | | | | BUG=none TEST=none R=varunjain@chromium.org Review URL: https://chromiumcodereview.appspot.com/10377093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136626 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix SetHotTracked/IsHotTracked issue.tfarina@chromium.org2012-05-116-47/+48
| | | | | | | | | | This was a TODO for @ben in view.h R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10282004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136589 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetImageSkiaNamed to resource_bundle and theme_provider.pkotwicz@chromium.org2012-05-112-0/+6
| | | | | | | | | | | This makes converting use of SkBitmap into ImageSkia easier Bug=124566 Test=Manual Review URL: https://chromiumcodereview.appspot.com/10388064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136470 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes drag and drop crash. The problem was when I madesky@chromium.org2012-05-102-8/+33
| | | | | | | | | | | | | | | | | | | | MenuController::SetExitType do a QuitNow it would prematurely exit out of drag and drop, causing a crash. The fix is to not QuitNow if drag and drop is on going. (Have I mentioned I hate nested message loops?). I also changed DragDropController to QuitNow, this way tests can work and seems like what we want anyway. Lastly I made all the bookmarkbarviewtests work again as they provide coverage of this. BUG=127348 TEST=covered by tests R=ben@chromium.org,varunjain@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136365 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the option of aligning the launcher to the left or right. Theresky@chromium.org2012-05-103-18/+80
| | | | | | | | | | | | | is a ton of rough edges after this patch, but I don't want this patch to get any bigger. BUG=121962 TEST=covered by tests. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136312 0039d316-1c4b-4281-b951-d872f2087c98
* Aura desktop: Don't move the window to the origin when we get an external ↵erg@chromium.org2012-05-091-1/+2
| | | | | | | | | | | | size change. BUG=125106 TEST=none Review URL: https://chromiumcodereview.appspot.com/10377068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136124 - Allow the RWHVW to be focused when a window is restored from ↵ben@chromium.org2012-05-092-17/+0
| | | | | | | | | | | | | | | minimized. This restores a hack that was in place in the old NativeTabContentsContainer code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code. http://crbug.com/125976 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10378043 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10377070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136128 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the RWHVW to be focused when a window is restored from minimized.ben@chromium.org2012-05-092-0/+17
| | | | | | | | | | This restores a hack that was in place in the old NativeTabContentsContainer code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code. http://crbug.com/125976 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10378043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136124 0039d316-1c4b-4281-b951-d872f2087c98
* Added base::win::InitializeWindowClass() wrapper to make sure that window ↵alexeypa@chromium.org2012-05-091-8/+15
| | | | | | | | | | | classes are properly associated with the modules containing their window procedures. TEST=win,win_rel Review URL: https://chromiumcodereview.appspot.com/10315012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136116 0039d316-1c4b-4281-b951-d872f2087c98
* Add new ResourceBundle::Delegate interface.marshall@chromium.org2012-05-092-2/+2
| | | | | | | | | BUG=125351 TEST=ResourceBundle.* Review URL: https://chromiumcodereview.appspot.com/10270023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136039 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135791 - Let Chrome app handle Ash accelerators first if the app is ↵yusukes@google.com2012-05-096-110/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | launched as a window. Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly: 1. If no window is focused, handle an Ash accelerator in ash/accelerators/accelerator_filter.cc in the same way as before. 2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window: 2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc). 2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it. 2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView (without chrome/browser/ layer) can handle Ash accelerators first whenever needed. Other changes: chrome/browser/ui/views/frame/browser_view.cc: Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent(). ui/views/focus/focus_manager.cc: Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly. BUG=123856 TEST=ran aura_shell_unittests TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine. Review URL: https://chromiumcodereview.appspot.com/10134036 TBR=yusukes@google.com Review URL: https://chromiumcodereview.appspot.com/10384074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135978 0039d316-1c4b-4281-b951-d872f2087c98
* Implement par of aura menu spec:jennyz@google.com2012-05-091-1/+7
| | | | | | | | | | | | | Disbled icon opacity: 0.5. http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html BUG=122858 TEST=Disabled menu item icon should look half opaque. Review URL: https://chromiumcodereview.appspot.com/10310064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135954 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the menu size calculation issue button introduced by: ↵jennyz@google.com2012-05-091-6/+6
| | | | | | | | | | | https://src.chromium.org/viewvc/chrome?view=rev&revision=135843 BUG=122858 TEST=Submenu arrow should not overlap with menu label when there is no menu shortcuts. Review URL: https://chromiumcodereview.appspot.com/10388040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135950 0039d316-1c4b-4281-b951-d872f2087c98
* Resets menu show timer only when pending selected item changes.xiyuan@chromium.org2012-05-081-3/+6
| | | | | | | | | BUG=117637 TEST=Verify fix for issue 117637. Review URL: https://chromiumcodereview.appspot.com/10332041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing empty line in JS.xji@chromium.org2012-05-081-11/+41
| | | | | | | | | | | | | | The JS text is divided into paragraphs, and each paragraph is represented as a Label. When split the text, continuous '\n' is ignored previously and causes empty lines are not rendered. BUG=124364 TEST=manual test JS alert with multiple '\n' in begin, middle, and end. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10377019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135899 0039d316-1c4b-4281-b951-d872f2087c98
* Move DIP translation from ui/aura to ui/compositor.oshima@chromium.org2012-05-081-38/+5
| | | | | | | | | | | | | Layer's coordinate system is now in DIP. Added support of dynamic density switching. Removed ENABLE_DIP gyp/macro and added runtime flag "--ui-enable-dip" BUG=105165, 114666 TEST=enabled monitor test. added new tests to compositor_unittests Review URL: https://chromiumcodereview.appspot.com/10221028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135888 0039d316-1c4b-4281-b951-d872f2087c98
* Implement part of aura menu spec described in:jennyz@google.com2012-05-087-19/+45
| | | | | | | | | | | | | | | | | | | | http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html The following are implemented: min distance between item and shortcut: 20px divider 1px solid color #dadada 2px above/below divider 20px right margin: between arrow/shortcut to right edge of menu 28 px left margin: between label and left edge of menu, with or without icon icon/checkmarks: 8 px left margin. submenu: overlap 3 px horizotally, this include the edge of the submenu and parent menu border, which are 1 px each. submenu arrow: 20px right margin. BUG=122858 TEST=Aura menu UI changes conform to aura menu spec as described above. Review URL: https://chromiumcodereview.appspot.com/10387014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135843 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Clean up cpplint warnings.tfarina@chromium.org2012-05-0810-19/+22
| | | | | | | | | | | | | This was found by: python ~/depot_tools/cpplint.py $(find ui/views/examples -type f \( -name "*.cc" -o -name "*.h" \) -print) 2>&1 | grep -v "Done processing" Ignored further (redundant) warnings reported in content_client. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10383034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135829 0039d316-1c4b-4281-b951-d872f2087c98
* Don't activate TYPE_CONTROL on aura only.oshima@chromium.org2012-05-082-3/+3
| | | | | | | | | | | | | Looks like TYPE_CONTROL has to be activatable in order for its parent to be activated on Windows. On aura, this is handled by the aura itself. (Here is the original CL: http://codereview.chromium.org/8872043) BUG=121499 TEST=manually Review URL: https://chromiumcodereview.appspot.com/10382042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135809 0039d316-1c4b-4281-b951-d872f2087c98
* Let Chrome app handle Ash accelerators first if the app is launched as a window.yusukes@google.com2012-05-086-49/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly: 1. If no window is focused, handle an Ash accelerator in ash/accelerators/accelerator_filter.cc in the same way as before. 2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window: 2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc). 2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it. 2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView (without chrome/browser/ layer) can handle Ash accelerators first whenever needed. Other changes: chrome/browser/ui/views/frame/browser_view.cc: Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent(). ui/views/focus/focus_manager.cc: Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly. BUG=123856 TEST=ran aura_shell_unittests TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine. Review URL: https://chromiumcodereview.appspot.com/10134036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135791 0039d316-1c4b-4281-b951-d872f2087c98
* ash: First pass of Applist v2.xiyuan@chromium.org2012-05-072-5/+5
| | | | | | | | | | | | | | - Add an "enable-applist-v2" command line switch and an about flag to trigger v2; - Add paging support to AppListModelView; - Add page switcher buttons for v2 UI; - Add AppListBubbleBorder to paint bubble for v2 UI; BUG=125964, 125044 TEST=Issue 125964 is not ready for test yet. For issue 125044, user can now gets overflown apps via keyboard. Review URL: https://chromiumcodereview.appspot.com/10381018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135729 0039d316-1c4b-4281-b951-d872f2087c98
* Correct handling of multiline text in buttons.antrim@chromium.org2012-05-072-9/+22
| | | | | | | | | | BUG=125897 TEST= Review URL: http://codereview.chromium.org/10382028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135726 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for WM_GETOBJECT for NativeTextfieldWin.tommi@chromium.org2012-05-072-5/+25
| | | | | | | | | This enables accessibility support (OSK) for the Find box. Review URL: http://codereview.chromium.org/10381034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135680 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move compositor/ directory out of gfx/, up to ui/.tfarina@chromium.org2012-05-0510-20/+20
| | | | | | | | | | BUG=104040 R=piman@chromium.org,ben@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10365007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135560 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo: kPriorityXXX -> kXXXPriority. No code change.yusukes@chromium.org2012-05-051-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=ben@chromium.org Review URL: http://codereview.chromium.org/10317035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135538 0039d316-1c4b-4281-b951-d872f2087c98
* Aura Menu Spec: Change the menu top/bottom padding to 2 and left/right ↵jennyz@chromium.org2012-05-048-16/+26
| | | | | | | | | | | | padding to 0 and menu item height to 30 pixels. BUG=122858 TEST=Aura menu UI change according to the details in cl description. Review URL: http://codereview.chromium.org/10376005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135445 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-049-11/+159
| | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135392 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135369 - Re-implement the screensaver to use WebView instead of ↵rkc@chromium.org2012-05-049-159/+11
| | | | | | | | | | | | | | | | | ExtensionDialogHost. Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 TBR=rkc@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135372 0039d316-1c4b-4281-b951-d872f2087c98
* Aura/ash split: Make the omnibox and the status bar part of the main window.erg@google.com2012-05-042-2/+35
| | | | | | | | | | | This makes the omnibox functional in -Duse_aura=1 -Duse_ash=0 builds. BUG=125106 TEST=none Review URL: https://chromiumcodereview.appspot.com/10223017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135371 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-049-11/+159
| | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135369 0039d316-1c4b-4281-b951-d872f2087c98
* views: Mark single-argument constructors as explicit.tfarina@chromium.org2012-05-0414-33/+38
| | | | | | | | | | | | This was reported by cpplint as: python ~/depot_tools/cpplint.py $(find ui/views/ -type f -name \*.cc) 2>&1 | grep -v "Done processing" | grep explicit R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10358013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135365 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135032 (speculative; BookmarkBarViewTest17.ContextMenus3thakis@chromium.org2012-05-038-26/+16
| | | | | | | | | | | | | | | | | | | | started failing on CrOs after this landed) - Implement part of auea menu spec: http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html Menu top/bottom padding: 2 pixels. No left/right padding around menu item, edge to edge hover highlight. Menu item height and hover highlight height: 30 pixels. BUG=122858 TEST=Aura menu UI change according to the details in cl description. Review URL: http://codereview.chromium.org/10330002 TBR=jennyz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10353006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135080 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 12:35:57 +0000