| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
CID=9269,13399,14520
BUG=none
TEST=none
R=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7216031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=8976,8977,8978,8979,8980,8981,8982,17240
BUG=none
TEST=none
R=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7227002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7200045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
CID=8818
Review URL: http://codereview.chromium.org/7217016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=wjmaclean@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/7219010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org
Review URL: http://codereview.chromium.org/7189067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of allocating it on the heap, just allocate it on the stack.
Thus we don't have to delete it manually.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.BasicOperations
R=phajdan.jr@chromium.org,sky@chromium.org
Review URL: http://codereview.chromium.org/7205022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7205044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On linux, CanvasSkia::DrawStringInt() was removing ampersands (when
HIDE_PREFIX flag was set) with gfx::RemoveWindowsStyleAccelerators(),
which has the side effect of doubling underscores. This CL replaces the call
with code that only strips ampersands (turning doubled ampersands into
a single ampersand).
BUG=chromium-os:15823
TEST=observe network menu with SSIDs containing underscores and ampersands
Review URL: http://codereview.chromium.org/7170025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and strong refs.
This deprecates the operator-based conversion methods in favor of To/CopyType().
New callsites should use these methods. Other uses will be converted in a later
CL.
BUG=58030
TEST=ui_unittests
Review URL: http://codereview.chromium.org/7205031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7202014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
predictions.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89716
Review URL: http://codereview.chromium.org/7187029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Autofill field type predictions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7187029
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/7204037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
predictions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7187029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86600
TEST=see bug description for repro step
Review URL: http://codereview.chromium.org/7201017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was the last remaining test to move.
BUG=72317
TEST=ui_unittests
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7201011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7111060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7202003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=TemplateURLParserTest.TestDictionary, TestMSDN, TestWikipedia (as per sadrul)
Note: testing with mobile user-agent will also yield better results: --user-agent=iPhone or similar mobile
Review URL: http://codereview.chromium.org/7065052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views.
BUG=none
TEST=the close button of the rotated window highlights on hover.
Review URL: http://codereview.chromium.org/7193025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=GtkDndUtilTest.*
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7200004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=DataPackTest.*
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7189034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove a few unnecessary includes.
- Add missing OVERRIDE to overridden methods.
- Add missing base:: prefix.
- Include the right mac file.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7185016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7193012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7172028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CrOS network menu shows the associated network in bold face and non-associated networks in regular face. The size of these fonts matches for non-touch builds but are different for touch builds.
BUG=none
TEST=on touch build, open network menu and check if all items are the same size
Review URL: http://codereview.chromium.org/7044121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions were duplicated for both SkCanvas and SkDevice instances.
This CL unifies these calls to only make use of the SkCanvas entries.
This is CL part of a larger goal to remove the PlatformDevice class.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7168022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IOSurfaces and textures by forcing the IOSurface and its associated
texture to have a minimum width and height of 1.
Lie to callers about this fact since such accelerated surfaces'
contents will never be displayed to the screen.
Tested with Gmail; no more warnings. Also tested YouTube with both
Flash and HTML5 videos.
BUG=86326
TEST=none
Review URL: http://codereview.chromium.org/7191025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and renderer process) in the same share group.
This is work towards allowing offscreen canvas contexts to be allocated before compositor view contexts are created. This is a problem because a canvas might be created before the window it will be displayed in exists.
This does not fix the bug on its own.
BUG=80703
Review URL: http://codereview.chromium.org/7104148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tree_node_model_unittest.cc
First reason is because doesn't make sense to continue when the assertions in
question fails. Second reason is because we are already using more ASSERT_* checks
than EXPECT_*. So this change makes everything using ASSERT_* rather than EXPECT_*.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7187016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently ui_unittests runs the unittests for base/, gfx/ and views/ through ui/gfx/run_all_unittests.cc
(which is the only run_all_unittests compiled in the ui_unittests target) and thus can
have only one main() function to run those tests.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7184014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89073
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89298
Review URL: http://codereview.chromium.org/6995096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allocating |root| on the stack and passing to |model|, also on the stack,
does _not_ work, because TreeNodeModel owns the root.
So when the dtor of TreeNodeModel is called, it attempts to free an invalid
pointer, which was already deleted.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7171001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.AddNode
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7166001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is overriding some methods from base::TestSuite but not adding
anything useful, so just get rid of it entirely.
BUG=None
TEST=None
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7191004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7167015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89073
Review URL: http://codereview.chromium.org/6995096
TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/7193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89073
Review URL: http://codereview.chromium.org/6995096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=85845
Review URL: http://codereview.chromium.org/7181002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is overriding some methods from base::TestSuite but not adding anything useful, so just get rid of it entirely.
BUG=None
TEST=ui_unittests
R=rsesek@chromium.org,phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7170024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7168014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=builds on win_shared
BUG=none
Review URL: http://codereview.chromium.org/7167001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Review URL: http://codereview.chromium.org/6995096
TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/7149030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ui::TouchStatus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7147005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Review URL: http://codereview.chromium.org/6995096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ran chrome, ran OpenGL ES 2.0 conformance tests
BUG=none
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7003103
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/7150022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ran chrome, ran OpenGL ES 2.0 conformance tests
BUG=none
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7003103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't use base::SysInfo::OperatingSystemVersionNumbers, because it calls
Gestalt, which has a few bad properties. Introduce new functions that perform
specific version checks.
BUG=85972
TEST=base_unittests MacUtilTest.IsOSEllipsis
Review URL: http://codereview.chromium.org/7144007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7146016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This improves and simplifies the tests covered in GetTotalNodeCount.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.GetTotalNodeCount
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89012 0039d316-1c4b-4281-b951-d872f2087c98
|