| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On confirming a prompt dialog via an "Enter" key press, the dialog may
close and re-focus the element that was active before the dialog opened.
The browser would then take the default action for the event, i.e.
taking the default action on the newly-focused element (such as clicking
the button, opening a combobox menu etc.). This is inappropriate, so
cancel the event to prevent default processing.
BUG=chromium:247646
TEST=Manual: Focus a select element, cause a popup dialog to appear, hit enter. The select dropdown shouldn't open.
Review URL: https://chromiumcodereview.appspot.com/16049018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new one overlaps with the scroll contents.
TBR=sadrul@chromium.org
BUG=239559
R=mukai@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16670002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16757004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16402012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces a hard contract that CC will always call
OutputSurface::SwapBuffers(), and OutputSurface will always respond with
OutputSurfaceClient::OnSwapBuffersComplete(), in all rendering modes. I
deleted the methods SendFrameToParentCompositor, PostSubBuffer, and
OnSendFrameToParentCompositorAck, subsuming them into SwapBuffers. I also
deleted all the settings and capabilities specifying which variant needed to be
called.
This should be a no-op for all graphics modes except for Android WebView, where
it has the benefits of ensuring OnSwapBuffersComplete is called and that
CompositorFrameMetadata is available even though no parent compositor exists.
NOTRY=true
BUG=237006
Review URL: https://chromiumcodereview.appspot.com/16304003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the situation of pressing the Tab key repeatedly, when cr-dialog-frame has
focus, it looks like focus is disappeared. This CL change the tabIndex assigned
to cr-dialog-frame from 0 to -1. Elements that have negative tabIndex can be
focused but are not traversed by Tab key.
BUG=239306
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/16123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the internals of the certificate viewer dialog so it matches the
specs for the new dialog style. Screenshots in bug, specs are here: https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinEUTFOWUJFTWJFSTA&usp=sharing#list
BUG=140561,247772
Review URL: https://chromiumcodereview.appspot.com/15894032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a 'default-button' capability to overlays. If
a button in the button strip has a 'default-button' class,
hitting enter should now activate that button, as long as the
focus is not on another button, textarea or anchor. The default
button will also be styled differently, to indicate to users
which action will be taken when hitting enter.
BUG=116859
TEST=All option dialogs/overlays should still work.
Review URL: https://chromiumcodereview.appspot.com/14361005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
Test=Heap check is happy again
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/16762002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just changes some padding, no functionality change.
http://imgur.com/IlrfuBu
BUG=238247
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16373010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only linked with interactive_ui_tests) ensure that they're only called from test suites that aren't sharded.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/16511008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=rsesek
Review URL: https://codereview.chromium.org/16756008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basic framework for handling events in ozone. Touch events are
recognized and dispatched. Some button events are supported.
BUG=178543
R=sadrul@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/16466003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps the forwarding header, just updates all current callers.
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16514006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To close the settings view, give the back button a key equivalent of \e
(a view controller isn't in the view's responder chain, so implementing
cancelOperation: doesn't help).
To close the tray, override the window's cancelOperation: and order the window
out which will tell the controller that key was resigned, which then informs
the model classes (implementing cancelOperation: on the controller doesn't work
because NSWindow implements cancelOperation: and so won't forward it along the
responder chain).
While here, also remove -forceWindowSizeUpdate which was just another name
for -updateTrayViewAndWindow.
BUG=none
TEST=open tray, open settings. hit esc, settings close. hit esc, tray closes.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16721002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we cannot re-initialize TsfBridge once
TsfBridge::Shutdown is called.
This patch set gets rid of such limitation.
This is mainly for unit test, where TsfBridge::Initialize
is called in its Setup function.
BUG=246534
TEST=Manually done with GoogleJapaneseInput.
Review URL: https://chromiumcodereview.appspot.com/16648002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the current mocks.
1. The settings dialog is now below the control area, rather than on top of it.
2. The back button moves from the settings view to the tray view. It's shown
only when the settings are visible.
3. Disable the "clear all" button while the settings are up.
This completes v1 of the settings view (except for the tests missing from the
last CL, I'll look at that next).
http://imgur.com/XQqapVC
BUG=238247
TEST=Look at settings.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16720003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the notification is visible for one frame at full opacity before
the fade animation starts. Set alpha to 0 explicitly before starting the
animation to fix this. (Others say this is necessary too, e.g.
http://stackoverflow.com/questions/6836827/failing-to-fade-in-window-using-nsviewanimation ).
BUG=238246
TEST=Open an animation. The fade in doesn't look in jumpy. (Slightly more
obvious if you set kAnimationDuration to 2.2 instead of 0.2).
R=jianli@chromium.org
Review URL: https://codereview.chromium.org/15780022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put a number of key trace messages into an "input" category to make
it easy to see how they relate and flow through the system (I'll make
some similar changes on the blink side too).
Add an async trace tracking the TouchEventQueue so that it's easy
to see the latency caused by touch events waiting around in the
queue.
Add a trace near the point when X events first get into Aura, and
include as a parameter the additional latency from the driver timestamp.
BUG=None
R=ben@chromium.org, nduca@chromium.org, sadrul@chromium.org
Review URL: https://codereview.chromium.org/16190012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/15870009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Staged commit of a larger feature to ease review and landing the change.
- New BookmarkModelObserver entries to be alerted before an action is
executed.
- BookmarkModel ability to explicitly reorder all children of a bookmark
tree. Support function also added to TreeNode for this operation.
- Test updated BookmarkModel and BookmarkModelObserver changes.
BUG=126092
Review URL: https://chromiumcodereview.appspot.com/16479003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=246534
Review URL: https://chromiumcodereview.appspot.com/16347004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The controller is being released while it is still on screen, and so it can
be messaged after it is gone. Releasing on the outermost loop ensures that if
the user presses a button, the -release message isn't pumped from a
-mouseDown: nested loop.
BUG=247799
TEST=Fewer crashes on the crash server.
Review URL: https://chromiumcodereview.appspot.com/16637005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks, uhm, "interesting": http://imgur.com/m1Cj5XK
BUG=238247
TEST=Open notification settings. Apps and some websites now have icons.
Click far right edge of checkbox with icon. Hit tests correctly.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16548008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is room.
Fixes a regression from r204993.
BUG=247428
TEST=Have enough menu extras that tray opens to right normally. Pin dock on
left side of the screen, make it large-ish. Tray still opens to the right.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fullscreen window.
BUG=247094
Test=WindowUtilTest.RecreateWindowLayers
Review URL: https://chromiumcodereview.appspot.com/14572005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168162
Review URL: https://chromiumcodereview.appspot.com/16268020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parts of the changes in tray_view_controller.mm and tray_controller.mm
were contributed by Jian Li <jianli@chromium.org>.
The settings UI is functional after this change, but there are still UI tweaks
that need to be done.
BUG=238247
TEST=
* Open tray, click settings bubble, look at settings, close settings.
* Open tray, click settings bubble, look at settings, close tray. Reopen tray,
no settings visible.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16026019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=239097
Review URL: https://chromiumcodereview.appspot.com/16580009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
top left only when invoked by mouse. For everything else, it will be
anchored to bottom center. This is useful to properly position the menu
when invoked for touch selection when there is no gesture or mouse event
in the event stack to dictate the menu position.
BUG=239110
Review URL: https://chromiumcodereview.appspot.com/15715032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/string16.h was moved into base namespace in r191198 by Brett.
BUG=None
TBR=ben@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16051006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- added GL utility functions to create and copy texture for mirroring
- made sure we don't create two compositor for the same display.
- update the mirroring compositor size when the mirror window size
changed.
- fix a bug that was using int for display ID. changed the
initial value for faked display id so that we can catch
such error early in test.
BUG=239776
TEST=added new tests, plus manually on daisy (mirroring now works on daisy)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205044
Review URL: https://chromiumcodereview.appspot.com/16232013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247796
R=dewittj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16675003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes mesa support an subset of the S3TC texture extensions, specifically to pass through compressed textures to the driver.
BUG=245466
Review URL: https://chromiumcodereview.appspot.com/16661002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke CromeOS compile
cc1plus: warnings being treated as errors
../../ash/display/display_info.cc:40:error: this decimal constant is unsigned only in ISO C90
ninja: build stopped: subcommand failed.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/54421
> Compositor reflector, which copies texture onto another compositor.
>
> - added GL utility functions to create and copy texture for mirroring
> - made sure we don't create two compositor for the same display.
> - update the mirroring compositor size when the mirror window size
> changed.
> - fix a bug that was using int for display ID. changed the
> initial value for faked display id so that we can catch
> such error early in test.
>
>
> BUG=239776
> TEST=added new tests, plus manually on daisy (mirroring now works on daisy)
>
> Review URL: https://chromiumcodereview.appspot.com/16232013
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/16434007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Popups stay visible for a short period of time, but that is
not a platform-dependent feature so we can move it out of
views/ code. Mac will then get the dismiss behavior
automatically. This does not cause the Mac version to pause
the timers on mouse hover, that will be done in a different
CL.
BUG=238245
Review URL: https://chromiumcodereview.appspot.com/16271009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- added GL utility functions to create and copy texture for mirroring
- made sure we don't create two compositor for the same display.
- update the mirroring compositor size when the mirror window size
changed.
- fix a bug that was using int for display ID. changed the
initial value for faked display id so that we can catch
such error early in test.
BUG=239776
TEST=added new tests, plus manually on daisy (mirroring now works on daisy)
Review URL: https://chromiumcodereview.appspot.com/16232013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=238755
Review URL: https://chromiumcodereview.appspot.com/16129008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make a checked_numeric_cast to fix a c4267 warning.
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15774023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cc::TextureLayers through cc::TextureMailbox.
BUG=161008
R=piman
TBR=jschuh,ben
Review URL: https://chromiumcodereview.appspot.com/15001027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the right.
BUG=247428
TEST=Have few status items in the menu bar, open the tray. It opens to the left.
Review URL: https://chromiumcodereview.appspot.com/15792027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=238247
TBR=rsesek
Review URL: https://codereview.chromium.org/16673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The flag is currently disabled by default.
BUG=243445
Review URL: https://chromiumcodereview.appspot.com/16196008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up some formatting along the way.
This is an almost-revert of r204171.
BUG=245942
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/16147013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no UI yet to make this view visible, so no visible change.
If this could be toggled on, it'd look like this: http://imgur.com/HWcWru6
BUG=238247
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/16571010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247705
TEST=manaul test by creating lots of notifications and clicking on tray icon
R=dewittj@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/16617003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=yfriedman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15716014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16175008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Introduces a new scrollbar for message_center.
>
> The new one overlaps with the scroll contents.
>
> BUG=239559
> R=sadrul@chromium.org, dewittj@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/16171010
Revert reason: not working on windows, see crbug.com/247401
TBR=mukai@chromium.org
BUG=239559, 247401
Review URL: https://codereview.chromium.org/16434004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204875 0039d316-1c4b-4281-b951-d872f2087c98
|