summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Fix build caused by deleting gfx/* stubssail@chromium.org2011-02-131-0/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6510011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74755 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: Delete stub src/gfx/* headerssail@chromium.org2011-02-135-6/+3
| | | | | | | | | | | The last references to src/gfx/* have been updated so it's safe to delete the stub headers. BUG=None TEST=None Review URL: http://codereview.chromium.org/6474031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74741 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to lockPixels() before reading one in ImageTest.CheckSkiaColor.rsesek@chromium.org2011-02-111-0/+2
| | | | | | | | | BUG=none TEST=Clang gfx_unittest passes Review URL: http://codereview.chromium.org/6502001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74636 0039d316-1c4b-4281-b951-d872f2087c98
* Add ui::gfx::Image to eventually replace gfx::ScopedImage.rsesek@chromium.org2011-02-116-0/+568
| | | | | | | | | | | | | This achieves the same goal as ScopedImage, namely encapsulating the memory management of any image type. But ui::gfx::Image goes further by providing conversion helpers between different image types. BUG=carnitas TEST=gfx_unittests and unit_tests Review URL: http://codereview.chromium.org/6312159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74624 0039d316-1c4b-4281-b951-d872f2087c98
* Make gfx::Rect::CenterPoint() return the correct center point.pkasting@chromium.org2011-02-111-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6474016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74536 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-103-30/+87
| | | | | | | | | | | | | | Re-landing, moving the bits Mac uses to ui/base/events.h BUG=72040 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
* Fix key identifier conversion.bryeung@chromium.org2011-02-093-361/+0
| | | | | | | | | | | | | | | Key identifiers are more expressive than simple key codes. This patch expands the target of the mapping to include modifier keys. This also moves the key identifier conversion into the only directory from which it is used. BUG=none TEST=unit test updated Review URL: http://codereview.chromium.org/6264020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74227 0039d316-1c4b-4281-b951-d872f2087c98
* OSExchangeData: convert filename-related API to FilePathevan@chromium.org2011-02-076-30/+30
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/6368133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74022 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-05105-169/+169
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Menu item titles include Windows-style accelerator marker.rsesek@chromium.org2011-02-042-1/+9
| | | | | | | | | | | | | Macintosh port remove it in runtime, But current implemented logic is not sufficient for non-English locales. BUG=chromium:70765 TEST=add new tests and pass it(app_unittests) Review URL: http://codereview.chromium.org/6409039 Patch from Takashi Toyoshima <toyoshim@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73853 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using FocusEvent for focus change notifications. ben@chromium.org2011-02-0311-374/+175
| | | | | | | | | | | | | I also removed ViewStorage usage for now. Jay described generally the kind of cases where this might be useful but I have not encountered them yet in my current testing. I will reintroduce this code if it becomes necessary. Note that I have not yet verified that this works. That comes next. BUG=none TEST=none Review URL: http://codereview.chromium.org/6368083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73655 0039d316-1c4b-4281-b951-d872f2087c98
* Method sorting.ben@chromium.org2011-02-033-397/+420
| | | | | | | | | | | | | | - Sort focus_manager.cc to match focus_manager.h - Re-sort view.cc so each visibility (public, protected, private, private members) match and are grouped relative to purpose. BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/6250132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73634 0039d316-1c4b-4281-b951-d872f2087c98
* Complete the Focus Manager hookup.ben@chromium.org2011-02-0313-69/+154
| | | | | | | | | | | | | - Temporarily patch in old Focus Sibling initialization code. - Improve the constness of FocusSearch - Simplify ContainsView method in FocusManager BUG=none TEST=none Review URL: http://codereview.chromium.org/6349080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73632 0039d316-1c4b-4281-b951-d872f2087c98
* Verify that:ben@chromium.org2011-02-037-11/+56
| | | | | | | | | | | | - RequestFocus() works. - Removing the focused view from the view hierarchy resets the focused view in the FocusManager. BUG=none TEST=unittest Review URL: http://codereview.chromium.org/6286073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73621 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a build breakmsw@chromium.org2011-02-032-0/+0
| | | | | | | | | BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/6246066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73591 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-034-54/+67
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove --disable-xshm flagevan@chromium.org2011-02-031-5/+0
| | | | | | | | | | This was added for testing. We no longer need it. BUG=46602 Review URL: http://codereview.chromium.org/6368062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73563 0039d316-1c4b-4281-b951-d872f2087c98
* More FocusManager hookup.ben@chromium.org2011-02-0314-37/+179
| | | | | | | | | | | | | | - One focus manager per Widget hierarchy - Create focus manager on widget initialization - Allow focus manager to be obtained from NativeView. - Adds a test to ensure focus manager is only created for the top level widget. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73551 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/gfx/ to src/ui/gfxsail@chromium.org2011-02-0294-1/+15079
| | | | | | | | | | | To reduce the size of this change I've left stub header files in src/gfx/. Once all includes have been updated I'll delete the stub files. BUG=71063 TEST=Still doing test builds. Review URL: http://codereview.chromium.org/6246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkdeps by deleting not-built file.ben@chromium.org2011-02-021-1730/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73519 0039d316-1c4b-4281-b951-d872f2087c98
* Copy more focus manager into V2. Comment out a bunch of stuff and add stub ↵ben@chromium.org2011-02-0215-0/+3462
| | | | | | | | | | | impls of methods with TODOs so that it builds. BUG=none TEST=none Review URL: http://codereview.chromium.org/6334062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73513 0039d316-1c4b-4281-b951-d872f2087c98
* Begin to integrate Focus Manager. Add Windows accelerator handler ↵ben@chromium.org2011-02-028-2/+284
| | | | | | | | | | | implementation (commented out now due to lack of focus manager). Add some utilities to NativeWidget for obtaining NativeWidget from a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/6286035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73479 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder methods in class View to better isolate methods that shouldn't be ↵ben@chromium.org2011-02-014-129/+167
| | | | | | | | | | | | | public. Specifically, move most event handlers and processing functions to protected now that RootView is a friend. BUG=none TEST=compiles, existing unittests Review URL: http://codereview.chromium.org/6286032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73376 0039d316-1c4b-4281-b951-d872f2087c98
* sFirst cut at an experiment with what a simplified View/Widget API would ↵ben@chromium.org2011-02-0141-0/+4138
| | | | | | | | | | | | | | | | | | | | | | | look like. Of note: - Widget is a cross-platform class encapsulating widget-specific state - NativeWidget interface wraps different implementations of a native widget. Starting with HWND. - NativeWidget implementation should eventually be swappable at runtime. - Simpler Event construction directly from a NativeEvent (e.g. MSG struct) - Simpler View API with fewer, more clearly delineated overrides. Notes: - Window* are just empty files for now while I get View/Widget to work. BUG=none TEST=see unittests, in development Review URL: http://codereview.chromium.org/6286013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73353 0039d316-1c4b-4281-b951-d872f2087c98
* Copy binary files from src/gfx to src/gfx/ui/sail@chromium.org2011-02-0117-0/+0
| | | | | | | | BUG=71063 TEST=Compiled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73317 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make ShouldUseVistaFrame a static method of WidgetWin.tfarina@chromium.org2011-01-282-18/+0
| | | | | | | | | | | Move it from hwnd_util.[cc,h] to widget_win.h and rename to IsAeroGlassEnabled. BUG=70143 TEST=trybots Review URL: http://codereview.chromium.org/6348019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72912 0039d316-1c4b-4281-b951-d872f2087c98
* Fix printing PDFs through right click on Mac and Linux. Looks like they ↵jam@chromium.org2011-01-272-1/+19
| | | | | | | | | both give the menu closed notification before the notification about which item was clicked. BUG=70987 Review URL: http://codereview.chromium.org/6336014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72840 0039d316-1c4b-4281-b951-d872f2087c98
* A blind fix for Bug 70870hbono@chromium.org2011-01-261-7/+7
| | | | | | | | | | It seems r72539 <http://crrev.com/72539> changed ui::GetXWindowStack() so it returns false if XGetWindowProperty() returns 0 (Success). This change just compares the return value of XGetWindowProperty() with Success as the function did before r72539. BUG=70870 TEST=make the "Linux Tests (valgrind)(1)" bot green. Review URL: http://codereview.chromium.org/6350017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72608 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show notifications when in fullscreen or screensaver mode.jianli@chromium.org2011-01-252-77/+130
| | | | | | | | | | | | | I add full-screen/presentation mode detection for all 3 platforms. I also add screensaver detection for MacOSX and Linux since it is missing in these 2 platforms. BUG=25061 TEST=Manual test Review URL: http://codereview.chromium.org/6359008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72539 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: make net::GetSuggestedFilename return utf-16evan@chromium.org2011-01-241-2/+2
| | | | | | | | | | | | | | | | | We should only use FilePath when working with real paths on disk. Note: I made a minor semantic change to downloads -- we no longer preserve backslashes in server-suggested paths on non-Windows. I think the previous behavior is crazy but from looking at the blame I'm the one who wrote it originally, so I don't feel bad about changing my mind. BUG=69467 TEST=existing test still passes Review URL: http://codereview.chromium.org/6241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72390 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-2118-10/+2157
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Views-implementation of AutocompleteEditView.oshima@google.com2011-01-211-0/+1
| | | | | | | | | | | | | | | | | | This is based on GTK implementation. Please see the header file for features that are not implemented yet. Textfield changes (files under views/controls/textfield) are being reviewed by Ben in separate CL (http://codereview.chromium.org/6314012/), so you don't have to review them (but you're welcome to do so). * Updated factory method in AutocompleteEditViewGtk to return views-implementation when TextfieldViews is enabled. * Added new option to FillLayout so that it lays out its child inside border. * Added missing GD_PK_Delete to keycode conversion. * Enabled tests in autodomplete_edit_view_browsertests for views-implementation as well. I moved the test body to the class and then called them from each test class to avoid having another test configuration on bots. Let me know if there is better way. BUG=none TEST=Enabled autocomplete_edit_view_browsertest for views-implementation. Review URL: http://codereview.chromium.org/6245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72113 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-215-14/+14
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-2018-0/+1673
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-2023-0/+3473
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Move UI-relevant Windows files to ui/base.ben@chromium.org2011-01-194-0/+574
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6254011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98
* Move more dnd related files to ui/baseben@chromium.org2011-01-1913-4/+1005
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to ↵ben@chromium.org2011-01-196-0/+473
| | | | | | | | | | | | | src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-171-1/+1
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
* Allow printing/saving a plugin through right click menu, even if it's in a ↵jam@chromium.org2011-01-153-0/+15
| | | | | | | | | frame or an embed element. BUG=50285 Review URL: http://codereview.chromium.org/6142013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71519 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71487 - Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-146-477/+0
| | | | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-146-0/+477
| | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
* Add some OWNERS files.ben@chromium.org2011-01-142-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6320004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71484 0039d316-1c4b-4281-b951-d872f2087c98
* Move models from app to ui/base/modelsben@chromium.org2011-01-1419-0/+2277
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-1314-0/+2104
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* Move OSExchangeData from src/app to src/ui/base/dragdropben@chromium.org2011-01-128-0/+2203
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71205 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by adding system dependencies.ben@chromium.org2011-01-101-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70940 0039d316-1c4b-4281-b951-d872f2087c98
* Move clipboard from app/ to ui/baseben@chromium.org2011-01-1012-0/+3101
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6135006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkdeps to account for new "ui" toplevel dir.ben@chromium.org2011-01-071-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70745 0039d316-1c4b-4281-b951-d872f2087c98
* Move animation code to new ui/base/animation directory.ben@chromium.org2011-01-0726-0/+2023
BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6154001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98