summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Supports FontList::DeriveFontListWithSizeDeltaAndStyle, etc.yukishiino@chromium.org2013-08-093-86/+201
| | | | | | | | | | | | | | | This CL improves FontList so the class has useful methods for replacing Font class. Also improves the performance of GetFontStyle() and GetFontSize(). This CL also adds GetAverageCharacterWidth(), GetStringWidth(), and GetExpectedTextWidth(). These methods are supported by Font class, and FontList should implement them for replacing Font. Just FYI, I'm now working on http://crrev.com/21736002 , and these new methods are used there. BUG=265485 TEST=Included in the unittests as ui_unittests. Review URL: https://chromiumcodereview.appspot.com/21868004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216563 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos] Use the correct display's bounds as menu's left boundoshima@chromium.org2013-08-091-0/+10
| | | | | | | | | BUG=269925 TEST=manual. see bug for repro step. Review URL: https://chromiumcodereview.appspot.com/22660002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216554 0039d316-1c4b-4281-b951-d872f2087c98
* Change IME conversion status by focusing input elementyoichio@chromium.org2013-08-081-2/+2
| | | | | | | | | | | | | | | This CL affects Windows except 8. example: When user input focuses <input inputmode="kana" />, IME changes its mode to Hiragana input mode if the IME has. inputmode attribute is specified in HTML5 draft: http://www.w3.org/html/wg/drafts/html/master/single-page.html#input-modalities:-the-inputmode-attribute TEST=manual test using MS-IME and GoogleJapaneseInput BUG=244688 Review URL: https://chromiumcodereview.appspot.com/21189003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216494 0039d316-1c4b-4281-b951-d872f2087c98
* Add profile switcher in notification settings for Mac.jianli@chromium.org2013-08-088-23/+210
| | | | | | | | | | BUG=269073 TEST=new tests added R=dewittj@chromium.org, rsesek@chromium.org Review URL: https://codereview.chromium.org/22653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216459 0039d316-1c4b-4281-b951-d872f2087c98
* aura_demo: Add a focus manager so that we don't crash on key press.tiago.vignatti@intel.com2013-08-081-0/+3
| | | | | | | | | | Just like in aura_bench (commit f7af6e70). BUG=none Review URL: https://chromiumcodereview.appspot.com/21022013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216441 0039d316-1c4b-4281-b951-d872f2087c98
* Enable touch on external touch devices.girard@chromium.org2013-08-081-2/+2
| | | | | | | | BUG=176058 Review URL: https://chromiumcodereview.appspot.com/22264009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216433 0039d316-1c4b-4281-b951-d872f2087c98
* UI tweaks for the message center settings dialog.dewittj@chromium.org2013-08-086-94/+189
| | | | | | | | | | | | | Now that we have the profile switcher, it is necessary to update some of the layout to make it look like our mocks. R=jianli@chromium.org BUG=269757 Review URL: https://chromiumcodereview.appspot.com/22278005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216430 0039d316-1c4b-4281-b951-d872f2087c98
* Remove views/ime/input_method_win.{h,cc}kochi@chromium.org2013-08-083-628/+0
| | | | | | | | | | | These files are no longer used by anyone. BUG=246516 TBR=nona@chromium.org Review URL: https://codereview.chromium.org/22479004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216353 0039d316-1c4b-4281-b951-d872f2087c98
* Do not remove focus ring by mouse click if focus ring is already present.tkent@chromium.org2013-08-081-2/+14
| | | | | | | | | | | | | | Sets the CLASS_NAME when a focusin event is dispatched. This fixes the issue because a focusin event is not dispatched by mouse click on already-focused element. This behavior matches to the default behavior of Blink form controls. BUG=268920 Review URL: https://chromiumcodereview.appspot.com/22521002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216342 0039d316-1c4b-4281-b951-d872f2087c98
* Touch selection: This patch makes following changes to touch selection logic:varunjain@chromium.org2013-08-081-21/+74
| | | | | | | | | | | | | | | | | | | 1. Drag offset calculation: When a handle is dragged, we offset the drag position vertically to target the drag at the cursor rather than the handle. Before this patch, this offset was a constant which is incorrect. The offset should be based on where the user first touch the handle. 2. Hide the handle when it is dragged outside the client view. Ideally, when the handle on a webpage is dragged outside the window, the webpage should scroll. We dont have that functionality yet. So as a temporary solution, we hide the handle if it goes outside the view. This will be reverted once we have the scrolling solution. 3. Increases vertical padding for the touch target of the handle. BUG=263367 Review URL: https://chromiumcodereview.appspot.com/22611003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216324 0039d316-1c4b-4281-b951-d872f2087c98
* don't hack client area, fix last pixel rendering on aurascottmg@chromium.org2013-08-073-18/+28
| | | | | | | | | | | | | | | | | | | | | There's a hack in NCCALCSIZE handling the falsely make the client size smaller than it should be. This is there to workaround a (Windows?) bug when switching from classic->aero which otherwise causes transparency to be lost on the browser frame (transparent areas are painted as solid black instead). However, this causes the client area to be scaled by one pixel on Aura. So, for now, remove that hack when on Aura, and also remove hack which was forcing Aura to paint anyway, even when the aura texture size did not match the expected target size. TBR=ben@chromium.org R=sadrul@chromium.org BUG=172099,267131 Review URL: https://chromiumcodereview.appspot.com/22391005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216315 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mostly unused |allow_default| parameter in ui::ThemeProviderpkotwicz@chromium.org2013-08-073-30/+13
| | | | | | | | | | | | | | | | | | | All the callers of ui::ThemeProvider::GetNSColor(), ui::ThemeProvider::GetNSColorTint(), ui::ThemeProvider::GetNSImageNamed() always pass |allow_default| as true. Some callers of ui::ThemeProvider::GetNSImageColorNamed() pass false. However, those cases can be handled by checking ui::ThemeProvider::HasCustomImage(). R=rsesek TBR=sky (for refactoring changes to ui/base/theme_provider.h and ui/base/default_theme_provider.h) BUG=None Test=None Review URL: https://chromiumcodereview.appspot.com/22524002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216312 0039d316-1c4b-4281-b951-d872f2087c98
* Revives time_format_browsertest.ccmukai@chromium.org2013-08-071-28/+0
| | | | | | | | | | | | | r216230 merges the test case into a single unittest file in ui. It turns out failing (or at least very flaky) in unittests. TBR=pkasting@chromium.org BUG=268688 Review URL: https://codereview.chromium.org/22603006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 216278 "Clean up compositor initialization/destruction."kalman@chromium.org2013-08-0713-153/+179
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | interactive_ui_test failures in TabDragging tests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/17046 > Clean up compositor initialization/destruction. > > Moved from https://codereview.chromium.org/21052007/ > > Currently the ContextFactory is outliving the compositor thread in > tests, which is bad since the contexts in there can be bound to the > compositor thread. Then we end up reusing those contexts and bad > things happen. > > This enforces ordering for initializing and destroying the > compositor as follows: > > Initialize ContextFactory > ..Compositor::Initialize > ....Create Compositor instances > ....Delete Compositor instances > ..Compositor::Terminate > > The Compositor::Terminate call also destroys the ContextFactory. > > The ContextFactory can be initialized in one of two ways: > 1. ImageTransportFactory::Initialize will set up the > ContextFactory. This is used by things that invoke all of > content/browser/. > 2. Compositor::InitializeContextFactoryForTests() must be > explicitly called by any unit tests that create a compositor. > > Since some tests want a real GL context and some don't, this > does away with the misnomer of initializing the Compositor once > for the entire test suite, and then re-initializing somewhere > in the middle of the test suite. Instead, each test must > Initialize/Terminate the compositor with the ContextFactory > type of its choice. > > Incidently, this test enables 20 tests on aura or win_aura that > were previously being skipped. > > TBR=piman@chromium.org > BUG=258625 > > Review URL: https://codereview.chromium.org/22293003 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/22603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216294 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused variable SurfaceTextureBridge::texture_id_sievers@chromium.org2013-08-072-8/+1
| | | | | | | | | | | It wasn't even correctly getting updated in AttachToGLContext(). NOTRY=True TBR=qinmin@chromium.org Review URL: https://chromiumcodereview.appspot.com/22582013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216280 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up compositor initialization/destruction.danakj@chromium.org2013-08-0713-179/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved from https://codereview.chromium.org/21052007/ Currently the ContextFactory is outliving the compositor thread in tests, which is bad since the contexts in there can be bound to the compositor thread. Then we end up reusing those contexts and bad things happen. This enforces ordering for initializing and destroying the compositor as follows: Initialize ContextFactory ..Compositor::Initialize ....Create Compositor instances ....Delete Compositor instances ..Compositor::Terminate The Compositor::Terminate call also destroys the ContextFactory. The ContextFactory can be initialized in one of two ways: 1. ImageTransportFactory::Initialize will set up the ContextFactory. This is used by things that invoke all of content/browser/. 2. Compositor::InitializeContextFactoryForTests() must be explicitly called by any unit tests that create a compositor. Since some tests want a real GL context and some don't, this does away with the misnomer of initializing the Compositor once for the entire test suite, and then re-initializing somewhere in the middle of the test suite. Instead, each test must Initialize/Terminate the compositor with the ContextFactory type of its choice. Incidently, this test enables 20 tests on aura or win_aura that were previously being skipped. TBR=piman@chromium.org BUG=258625 Review URL: https://codereview.chromium.org/22293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216278 0039d316-1c4b-4281-b951-d872f2087c98
* Make menu buttons accesible by enabling TTS on the menu.mtomasz@chromium.org2013-08-072-2/+7
| | | | | | | | | | | Before, menu buttons were not read by ChromeVox. This patch makes ChromeVox read the menu items by adding an appriopriate aria attribute to the parent, and to the button. TEST=Go to Files.app, check if the Gear menu invokes TTS on the menu items. BUG=264897 Review URL: https://chromiumcodereview.appspot.com/21735003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216252 0039d316-1c4b-4281-b951-d872f2087c98
* Allows TimeFormat.DecimalPointNotDot only on Macmukai@chromium.org2013-08-071-6/+6
| | | | | | | | | | | Seems failing on linux too... BUG=268688 TBR=miu@chromium.org Review URL: https://codereview.chromium.org/22460006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216242 0039d316-1c4b-4281-b951-d872f2087c98
* Not to show context menu if there are no visible items to show.yoshiki@chromium.org2013-08-072-1/+17
| | | | | | | | | | | This patch prevents the item-less context menu from being visible. In cr.ui.menu, some menu items may be made hidden by Command.canExecute(). Even if all the menu items were hidden, the menu could be shown and the only the border was visible to user. BUG=none TEST=manual Review URL: https://chromiumcodereview.appspot.com/22154002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216241 0039d316-1c4b-4281-b951-d872f2087c98
* Moves chrome/common/time_format to ui/base/l10n.mukai@chromium.org2013-08-076-0/+1645
| | | | | | | | | BUG=268688 R=sky@chromium.org Review URL: https://codereview.chromium.org/22284005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216230 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply reverted change to not assume windows of TYPE_CONTROL are parented ↵zturner@chromium.org2013-08-072-7/+52
| | | | | | | | | | | | | to the root window. Original review URL: https://codereview.chromium.org/21504003/ BUG=262051 TBR=sky Review URL: https://chromiumcodereview.appspot.com/22314014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216216 0039d316-1c4b-4281-b951-d872f2087c98
* Change showIntent methods to accept resource id as error message.michaelbai@chromium.org2013-08-072-8/+10
| | | | | | | | | BUG=233440 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216212 0039d316-1c4b-4281-b951-d872f2087c98
* Removed deprecated API from SurfaceFactoryOzone.rjkroege@chromium.org2013-08-072-9/+0
| | | | | | | | | | | | | https://chromiumcodereview.appspot.com/19662002 changed the SurfaceFactoryOzone API and deprecated the AcceleratedWidgetCanBeResized method. Now that downstream consumers have bee appropriately adjusted, remove. BUG=none, code cleanup. R=sky@chromium.org Review URL: https://codereview.chromium.org/20635006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216199 0039d316-1c4b-4281-b951-d872f2087c98
* Update notification settings to allow for multiprofile situations.dewittj@chromium.org2013-08-0714-295/+609
| | | | | | | | | | | | | | | This introduces the NotifierGroup concept to ui/message_center, which will correspond directly to Profiles. The user will be able to select a NotifierGroup and then update the notification settings relevant to that group/profile. TBR=sky@chromium.org R=jianli@chromium.org BUG=254511,256415,218402 Review URL: https://chromiumcodereview.appspot.com/20066003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up compositor initialization/destruction."danakj@chromium.org2013-08-0713-153/+179
| | | | | | | | | | | | | This reverts commit d65d6fe3c667835a8a0ddc0b917519115321d605. The CL needs to be rebased. TBR=piman BUG=258625, 266565 Review URL: https://codereview.chromium.org/22570003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leftright padding on OSX App Launcher.tapted@chromium.org2013-08-071-1/+1
| | | | | | | | | | | | | | | | This Changed from 20 -> 16 in http://crrev.com/190320. I think to account for an invisible scrollbar which since got a better fix. But it should be 21 anyway, to match windows more closely, since Windows adds a 1px border around the outside. See bug for comparison shot vs Windows. BUG=269210 TEST=Visual - width should now match screenshot on the bug Review URL: https://chromiumcodereview.appspot.com/22468003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216180 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up compositor initialization/destruction.danakj@chromium.org2013-08-0713-179/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved from https://codereview.chromium.org/21052007/ Currently the ContextFactory is outliving the compositor thread in tests, which is bad since the contexts in there can be bound to the compositor thread. Then we end up reusing those contexts and bad things happen. This enforces ordering for initializing and destroying the compositor as follows: Initialize ContextFactory ..Compositor::Initialize ....Create Compositor instances ....Delete Compositor instances ..Compositor::Terminate The Compositor::Terminate call also destroys the ContextFactory. The ContextFactory can be initialized in one of two ways: 1. ImageTransportFactory::Initialize will set up the ContextFactory. This is used by things that invoke all of content/browser/. 2. Compositor::InitializeContextFactoryForTests() must be explicitly called by any unit tests that create a compositor. Since some tests want a real GL context and some don't, this does away with the misnomer of initializing the Compositor once for the entire test suite, and then re-initializing somewhere in the middle of the test suite. Instead, each test must Initialize/Terminate the compositor with the ContextFactory type of its choice. Incidently, this test enables 20 tests on aura or win_aura that were previously being skipped. TBR=piman@chromium.org BUG=258625, 266565 Review URL: https://codereview.chromium.org/22293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216179 0039d316-1c4b-4281-b951-d872f2087c98
* Also adding compose exception for deadacute-m and deadacute-vnona@chromium.org2013-08-071-0/+2
| | | | | | | | | BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/22364003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216166 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce font size on OSX App Launcher items.tapted@chromium.org2013-08-071-2/+8
| | | | | | | | | | | | On Mac, fonts of the same enum from ResourceBundle are larger. The smallest enum is already used, so it needs to be reduced further to match Windows. BUG=269210 TEST=Visual - font should now match screenshot on the bug. Review URL: https://chromiumcodereview.appspot.com/22545002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216147 0039d316-1c4b-4281-b951-d872f2087c98
* Mark mouse events created for Enter/Leave notify as synthesized as they're ↵oshima@chromium.org2013-08-073-8/+20
| | | | | | | | | | | | | | | | | | | | not real mouse events. This is to prevent showing mouse cursor when a mouse enters into RootWindow when host window is created/deleted. Updated the test to make sure that synthesized events will not change the cursor visibility. The first CL (https://codereview.chromium.org/22051002/) didn't solve all problem because EnterNotify sends chrome MOUSE_MOVE event (which will send ui::ET_MOUSE_ENTERED/ui::ET_MOUSE_EXITED). BUG=None TEST=covered by test. Review URL: https://chromiumcodereview.appspot.com/22264002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix calculating changes in list_selection_model.js and therefore fix flaky ↵mtomasz@chromium.org2013-08-071-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | tests. The ListSelectionModel was miscalculating changes in some cases. Eg. this scenario: beginChange(); Delect 2, Select 2, endChange() would emit an event that the item 2 has been selected, however it is already selected. Such event should not be emited. This patch resolves the issue by ignoring selecting + deselecting an element which wasn't selected before, and similarly ignoring deselecting + selecting an item which was already selected. As for the flakyness, Files.app was recreating the selection object, and therefore recalculating tasks for the selection file twice. When double clicking on an item, the execution invokation is enqueued until the tasks are calculated. However, if the selection is changed, then the pending invocations are removed and the calculation is restarted. As a result, the double click is a no-op in such scenario: 1. Selecting the file 2. Started calculating tasks (async) 3. Double click 4. Enqueuing the default task execution (since tasks are not calculated yet) 5. Spurious selection change event for the actually selected item, which clears the pending tasks. 6. Started calculating tasks (async) 7. Tasks calculated 8. Nothing happens, since the queue of pending default-task executions is empty. TEST=browser_test: BUG=252561 Review URL: https://chromiumcodereview.appspot.com/22368002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216103 0039d316-1c4b-4281-b951-d872f2087c98
* Select a highlighted item on first show of the OSX app launcher.tapted@chromium.org2013-08-074-17/+69
| | | | | | | | | | | | | | | | | | | | | | | | | If the app list has never been shown, it will not observe the ItemHighlightedChanged notification, and so will not have an item highlighted if the app list is invoked by the user after an item install, rather than by the webstore. This only happens on the first item install when the app launcher is not enabled (thereafter the app launcher is enabled, and so invoked by the webstore). Note that there can be multiple _installing_ items on first show, but the AppListModel enforces that only one of them will be _highlighted_, hence the logic is slightly different to ItemIsInstallingChanged notifications. BUG=267814 TEST=When the webstore first enables the app launcher due to an app install, it does not automatically show the app launcher, but if the user clicks it, it should show the installed item; selected if the install is complete (otherwise just showing the correct page). Also added app_list_unittests:AppsGridControllerTest.HighlightedOnFirstShow Review URL: https://chromiumcodereview.appspot.com/22339005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216090 0039d316-1c4b-4281-b951-d872f2087c98
* Settings: A text field in a list item should be focused when selection is ↵tkent@chromium.org2013-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | moved by up/down cursor key. Bug detail: This is a regression caused by Blink r150870 [1]. When selection is moved by up/down cursor key, we set display:none to the previously-focused INPUT element, then show another INPUT element and set focus on it. The current code assumes elements with display:none keep focused, and elements not in the list are never focused in this sequence. However it's a wrong assumption, and Blink r150870 fixed the bug that unfocusable elements keep focused. Fix: A list should not trigger focus cleanup code if any elemnts are focused (activeElement is BODY.) [1] http://src.chromium.org/viewvc/blink?revision=150870&view=revision BUG=268291 Review URL: https://chromiumcodereview.appspot.com/22265004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216081 0039d316-1c4b-4281-b951-d872f2087c98
* Let anyone change gyp files in ui.sky@chromium.org2013-08-071-0/+3
| | | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org R=ben@chromium.org Review URL: https://codereview.chromium.org/22301015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216044 0039d316-1c4b-4281-b951-d872f2087c98
* Send input event's LatencyInfo back from renderer to browser when ackedmiletus@chromium.org2013-08-072-0/+17
| | | | | | | | | | | | | | | | | | | | | | Currently input event and its associated LatencyInfo are sent from browser to renderer together. But the LatencyInfo is not sent back to browser with individual input event, and only at frame swap time the browser will get the aggregated LatencyInfo of all input events during that frame. This makes it difficulte for browser side to track the individual event's latency info if it is modified at renderer side. In this CL we send the input event's LatencyInfo back from renderer to browser when the input event is acked, so that if any update happens to the event's LatencyInfo at renderer side, we can access the update also in browser side. BUG=261388 TEST=Added some latency component in renderer, and check that they can be accessed from browser side. Review URL: https://chromiumcodereview.appspot.com/19670007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216043 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a wrong unread_count_ update.mukai@chromium.org2013-08-062-0/+30
| | | | | | | | | | | | | EraseNotification decrements the update_count_ but sometimes this is not an actual erase but an update, which leads wrong count value. BUG=269020 R=dewittj@chromium.org TEST=message_center_unittests Review URL: https://chromiumcodereview.appspot.com/22421003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216003 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r215683, r215739 and r215736rkc@chromium.org2013-08-063-240/+0
| | | | | | | | | | | | | | | The feedback component app is moved to M31; revert all related changes from M30. This CL reverts, https://codereview.chromium.org/22295003/ https://codereview.chromium.org/22338003/ https://codereview.chromium.org/22253004/ TBR=rkc@chromium.org BUG=269113 Review URL: https://codereview.chromium.org/22267012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215999 0039d316-1c4b-4281-b951-d872f2087c98
* Updating XTBs based on .GRDs from branch 1547kerz@chromium.org2013-08-062-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215994 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore dpi scaling if not in dpi mode.flackr@chromium.org2013-08-061-2/+5
| | | | | | | | | BUG=265766 R=sadrul@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/22381005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215988 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] On calling openNewTab, pass the disposition instead of incognito.kkimlabs@chromium.org2013-08-064-13/+49
| | | | | | | | | | | | | | | | | Currently, when openNewTab is called, we pass a boolean incognito variable that indicates if it should be opened in incognito mode. This was not consistent with the desktop. For example, NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB open incognito tab if the current tab is incognito. So this CL instead passes the actual disposition so that Java side has the full information required to be consistent with the desktop. BUG=268283 BUG=268414 Review URL: https://chromiumcodereview.appspot.com/22314005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215973 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream isKeyboardShowingmiguelg@chromium.org2013-08-061-0/+15
| | | | | | | | BUG=268339 Review URL: https://chromiumcodereview.appspot.com/22200002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215972 0039d316-1c4b-4281-b951-d872f2087c98
* ui/views: Use correct ifdef for X11 only procedurestiago.vignatti@intel.com2013-08-061-2/+2
| | | | | | | | | | We need to remember that Ozone is playing together nowadays and different window systems in Linux might be used. In particular, this changes fix my downstream Ozone-Wayland implementation. BUG= Review URL: https://chromiumcodereview.appspot.com/21144006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215939 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Implement the static part of the dbus menu for Unity.erg@chromium.org2013-08-063-285/+343
| | | | | | | | | | | | | | [Relands r215769, which was reverted in r215780. It passed trybots and was landed by the CQ, and broke some chromeos configuration. This just adds gyp exclude rules for the new files.] BUG=265560 TBR=sky@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22455002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215928 0039d316-1c4b-4281-b951-d872f2087c98
* Change the meaning of SelectFileDialog.support_drive: it means Drive-aware ↵kinaba@chromium.org2013-08-061-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | callers. Previously, what the |support_drive| flag means is just to show Google Drive tab in the file dialog; it doesn't change other behaviors. Now, we are going to enable the "Google Drive" tab on Chrome OS for all call sites of the dialog, by adding a feature to Drive client to provide local snapshot so that callers need not care about Drive. On the other hand, the "create snapshot" trick is unnecessary for clients like Packaged app or extensions that implement fileBrowserHandler, which access files through HTML5 FileSystem API. So, for those clients I want to leave the |support_drive| flag to indicate that no special handling is needed. Here's the summary: Before: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. Create local snapshot. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : hide Drive tab. - !support_drive, open-dialog : hide Drive tab. (this mode is not used) - !support_drive, save-dialog : hide Drive tab. After: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. No special handling. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : *HIDE* Drive tab. (this is not supported yet) - !support_drive, open-dialog : Show Drive tab. Create local snapshot. - !support_drive, save-dialog : *HIDE* Drive tab. (VERY SOON switch to => "Show Drive tab. Create local snapshot.") BUG=140425 Review URL: https://chromiumcodereview.appspot.com/22165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215922 0039d316-1c4b-4281-b951-d872f2087c98
* Add rjkroege to ozone OWNERSrjkroege@chromium.org2013-08-061-0/+1
| | | | | | | | R=sky@chromium.org Review URL: https://codereview.chromium.org/21567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215911 0039d316-1c4b-4281-b951-d872f2087c98
* change tsf_input_scopes::SetInputScopeForTsfUnawareWindow to ↵yoichio@chromium.org2013-08-062-18/+64
| | | | | | | | | | | | | | | | SetInputScopesForTsfUnawareWindow function to set InputScopes representing both TextInputType and TextInputMode. implementation: change GetSetInputScope to GetSetInputScopes function to get SetInputScopes procedure address from msctf.dll. BUG=244688 TEST=Manually done on Windows 8 with on-screen keyboard Review URL: https://chromiumcodereview.appspot.com/21157006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215880 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SetModel in ContentsView and SearchBoxView.calamity@chromium.org2013-08-065-41/+23
| | | | | | | | | | | | | SetModel is only ever used for initialization. Moving the functionality into the constructor allows for easier reasoning about the state of the View. This change is in preparation of the refactor in https://codereview.chromium.org/20656002/. Review URL: https://chromiumcodereview.appspot.com/22354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215861 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup bubble tests.msw@chromium.org2013-08-064-147/+84
| | | | | | | | | | | | | | | | | | Move NonClientHitTest to BubbleDelegateTest. Inline TestBubbleDelegateView function definitions. Add CreateTestWidget helper for anchors/parents/etc. Remove unnecessary Show and RunPendingMessages calls. Enable InitiallyFocusedView, it works fine as-is. (TestBubbleVisibilityAndClose already tests the same) Other misc. cleanup. BUG=NONE TEST=NONE TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/22320003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215860 0039d316-1c4b-4281-b951-d872f2087c98
* Removes unused parameter from RootWindow::OnWindowHidden.sky@chromium.org2013-08-062-11/+6
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/22325002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215849 0039d316-1c4b-4281-b951-d872f2087c98
* Update progress bar notification UI on Windows per latest UI decision.jianli@chromium.org2013-08-061-5/+38
| | | | | | | | | BUG=170924 TEST=Manual test by creating progress notifications Review URL: https://chromiumcodereview.appspot.com/22277003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215827 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 06:54:09 +0000