| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11572045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some optional values like priority can be updated.
BUG=165782
TEST=on goobuntu, push a notification of priority -1, push a replacing notification of priority 0, make sure the old one doesn't appear but new replacement appears in the popup.
Review URL: https://chromiumcodereview.appspot.com/11557023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This necessitated the relocation of the previous chrome::GrabWindowSnapshot code
to ui/snapshot, which has been turned into it's own component to avoid circular dependencies with aura.
A new variant of GrabWindowSnapshot, GrabViewSnapshot, has been added as well to facilitate easier usage by views. chrome::GrabWindowSnapshotForUser was left in place to accomodate existing calls
to the API, but now calls up to the ui/snapshot code.
This is a subset of the prior CL 11362023, which has been broken apart to facilitate easier reviews
BUG=157479
Review URL: https://chromiumcodereview.appspot.com/11399002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> gfx: The destructor of DisplayObserver does not need to be out-of-line.
>
> Just inline it in the header file is fine as we do already for many of our
> Delegates/Observers/Listeners.
>
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/11551004
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/11590003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=165704
Review URL: https://chromiumcodereview.appspot.com/11442058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure X server to use Coordinate Transformation Matrix
on touchscreen input devices for correct positioning of touch events.
This is useful for 2 cases:
1. Mirror mode with aspect preserving scaling,
which leaves blank areas on the screen,
touches in which will be scaled out.
2. Extended desktop mode,
in which a touchscreen occupies only a portion of the desktop,
and thus events coming from it need to be mapped into that portion.
This also requires changes in the analysis of a touch event -
instead of scaling it from desktop into RootWindow,
now it needs to be relocated into RootWindow's origin.
BUG=chrome-os-partner:16192
TEST=Attach a touchscreen to a Chromebook,
verify that touches are positioned correctly
in Extended Desktop and Mirror modes.
Review URL: https://chromiumcodereview.appspot.com/11416390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just inline it in the header file is fine as we do already for many of our
Delegates/Observers/Listeners.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11551004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, LayerAnimationSequences and LayerAnimationElements only know
about the relative offset from the start of the animation. However, for threaded
UI animations, a LayerAnimationElement will need to know its absolute start
time: in order to compute the delay incurred by dispatching the animation to the
compositor thread, it will need to compare its own start time with that of the
dispatched animation.
BUG=164206
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11465026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/11568053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This provides hand-maintained R.java files to enable Webview to provide
resources used in ui, and fix the current webview ToT build break.
BUG=165751
Review URL: https://codereview.chromium.org/11578034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=163618
Review URL: https://codereview.chromium.org/11570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=163618
Review URL: https://codereview.chromium.org/11568006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use more stable |root_location| to calculate drag point on aura when
a scale transform is used on dragged item view;
- Filter out dragging events that jump between last two locations;
Also updated OS_WIN defines to USE_AURA to be more correct.
BUG=159419
TEST=Verify no drag jitter on Link using touchpad or touch and no drag
lagging regressions.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11543024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pixel except for the time display and the small icon which aren't
supported yet. The time display has been laid out to match the mock-up,
it just needs to get the time in an appropriate string format.
BUG=161101
Review URL: https://chromiumcodereview.appspot.com/11434017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This currently covers usb_keycode_map.h, but also provides OWNERS for future
additions such as unit-tests or USB<->mapping helpers.
Review URL: https://chromiumcodereview.appspot.com/11555036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is limited to the ui/surface directory for now, but
the GYP rule and python script are generalizable if we
need to do this elsewhere in the code in the future.
BUG=164714
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/11484003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through to the NotificationDelegate's new ButtonClick() method.
The practical point of this CL is twofold: (1) provide a good stopping point for the larger goal of sending this new ButtonClick event to JavaScript callers, and (2) provide new useful functionality to C++ code that is interested in button-click events.
0. Remove vestigal intents fields, which we're replacing with explicit callbacks.
1. Make BaseFormatView's ButtonPressed() send a new NotificationList::Delegate::OnButtonClicked().
2. MessageCenter passes that through to MessageCenter::Delegate::OnButtonClicked(), which has the same name as the above delegate method but is NOT directly related.
3. BalloonCollectionImplAsh looks up the specific balloon whose button was clicked, then calls the appropriate OnButtonClick() (note the change in tense).
4. chrome/browser/notifications/balloon passes the baton to the Notification that it owns, calling its ButtonClick() method.
5. The Notification's delegate handles ButtonClick(). Again, these two method share the name but are not strictly related.
6. In the case we'll eventually care about, notification_api.cc will implement a functional ButtonClick(). But for now this implementation is a stub.
BUG=164249
Review URL: https://chromiumcodereview.appspot.com/11546003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for Android-style resources in the ui folder and
converts a few hard coded strings into proper localizable strings.
BUG=165751
Review URL: https://chromiumcodereview.appspot.com/11554031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The custom cursor creation code from webcursor_win.cc has been moved to a helper function
CreateCursorFromDIB in the IconUtil class and is used by the webcursor code for windows and for
AURA.
The change in DesktopRootWindowHostWin::SetCursor is to ensure that the custom cursor passed in is
set correctly on the current thread.
The fix in the CursorLoaderWin::SetPlatformCursor function is necessary for custom cursors to get set
correctly. The current implementation was setting the cursor back to an arrow cursor as the GetCursorId
function returns the arrow resource id for unsupported cursor types which includes custom cursors.
BUG=151718
R=jam
Review URL: https://codereview.chromium.org/11549037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ash changes:
. Active RootWindow as tracked by the shell must only be updated when activation isn't being cleared.
. AshFocusRules' method that locates the next window to activate now searches forward and backward from the destroyed window's container. It used to only search forward.
. Some tests test for conditions that are no longer valid with the new focus controller, so we put some conditionals into the tests (PanelLayoutManagerTest and WindowManagerTest).
. ToplevelWindowEventFilterTest had an incomplete ash environment that wasn't getting all the right logic, so changed it to use full-ash.
. BubbleDelegateView needs to remove its observer to avoid a crash.
Core logic changes:
. A window must be focusable for it to be activatable. For some reason this test had eluded earlier incarnations.
. GetActivatableWindow() needs to be able to jump to a modal transient if one is present.
. GetFocusableWindow() needs to be able to hop to the next activatable window if the specified window isn't activatable.
. Prevent recursion in processing focus/activation changes.
. Prevent changing focus to the parent window when a child is focused.
R=sky@chromium.org
http://crbug.com/162100
Review URL: https://codereview.chromium.org/11519040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11550032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11569020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to aggressive inlining, it takes advantage of new SkMatrix44
constructors that allow us to control whether the matrix needs to be
initialized or can be skipped to save computational overhead.
These changes result in approximately 4% performance improvement on cc_perftests.
BUG=163769
Review URL: https://codereview.chromium.org/11553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/11567020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TextButtonBase derived classes like radiobutton or checbox
have the wrong color (blue) for their labels, the problem
is the hardcoded values in native_theme_win.cc
In this change I also consolidated to a single place where
the colors are set for TextButtonBase.
BUG=165615
TEST=see bug
Review URL: https://codereview.chromium.org/11558006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the GestureRecognizer, we previously inititated scrolling when the finger leaves a L1-norm box surrounding the position of the touch down point. As a result, the page would seem to leap by the size of the L1-norm on the first paint after entering a scrolling gesture.
This CL replaces the L1-norm box mechanism with a new mechanism for determining the start of a scroll: watch for the establishment of a consistent velocity trend across multiple touch moves. This permits determining that a scroll should start with a much smaller displacement than is needed with the L1-norm technique and eliminates the "leap" effect.
BUG=141653
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171934
Review URL: https://chromiumcodereview.appspot.com/11469005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the bookmarks drag and drop tests, which I previously ran without glass.
BUG=154081
Review URL: https://codereview.chromium.org/11548043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, use a fontconfig alias 'ui-sans' to get pango's fontfallback
find other fonts with UI-metrics instead of 'body/document metrics'.
The corresponding ChromeOS CL (font update and fontconfig changes) is at
https://gerrit.chromium.org/gerrit/#/c/39414
BUG=164769
TEST=Thai, Hindi, Marathi and Tamil do not have any glyphs truncated in the native UI area.
TBR=sky,cpu
Review URL: https://chromiumcodereview.appspot.com/11469037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=78179
Review URL: https://chromiumcodereview.appspot.com/11529005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the views::ScrollDelegate::OnScroll() interface to return
whether the content was scrolled or not. Use this return value to
determine whether to consume touch-scroll events or not.
BUG=141496
Review URL: https://codereview.chromium.org/11442069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::Image::CreateFrom1xPNGBytes()
Also converts gfx::Image png API to use base::RefCountedMemory instead of base::RefCountedBytes
BUG=160632
Test=None
R=rsesek
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/11415055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add/Use NativeTheme kColorId_WindowBackground.
Nix BubbleDelegateView::kBackgroundColor const.
(this improperly cached the color across theme changes)
UpdateColorsFromTheme on ctor and native theme changes.
Use new ProfileItemView parent arg for listeners/color.
Add local const kHighlightColor; always use a background.
Use default link color for Edit and Add links; misc cleanup.
(link colors were stomped by auto_color_readability_ anyway)
BUG=165596
TEST=Views bubble use the latest system theme background.
R=sky@chromium.org,sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11555006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
DesktopNativeWidgetAura's destructor.
BUG=163931
Review URL: https://codereview.chromium.org/11416381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11316362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the first/last menu item).
BUG=157692
Review URL: https://chromiumcodereview.appspot.com/11553006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds AddSeparatorIfNecessary to SimpleMenuModel.
- Adds DCHECK for duplicate separators in SimpleMenuModel::AddSeparator.
- Updates app-list and launcher to use AddSeparatorIfNecessary.
BUG=158195
Review URL: https://chromiumcodereview.appspot.com/11558008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that this call won't fix the NVIDIA out of memory
because of driver bugs, and it turns out that this is causing
desktop Aura to not render correctly.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11543026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=163931
Review URL: https://codereview.chromium.org/11547027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/162100
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11475045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
store/restore focus if necessary. This is needed for widgets (such as
bubbles) that end up as child Windows with their own
FocusManager.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11525002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/162100
R=sadrul@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172624
Review URL: https://codereview.chromium.org/11537019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have lots of code in chrome which just assumes that it can throw up a dialog
with no context. This will not work correctly in ash/aura combo builds. This is
part 1 of threading context through chrome so each dialog will be displayed
on the correct desktop, which is a subgoal of removing the global
StackingClient.
Widget::CreateWindow() and Widget::CreateWindowWithBounds() will be
transitioned to Widget::CreateWindowWithContext() and
Widget::CreateWindowWithContextAndBounds().
BUG=161882
Review URL: https://codereview.chromium.org/11519022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11537019
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11558027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11537019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ShouldUseNativeFrame()
This is how NativeWidgetWin does it.
R=ben@chromium.org,scottmg@chromium.org
BUG=165181
Review URL: https://chromiumcodereview.appspot.com/11485016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on https://codereview.chromium.org/11471043/.
BUG=164250
Review URL: https://chromiumcodereview.appspot.com/11468034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views::MenuDelegate for opening bookmark in background tab by Ctrl+Click.
BUG=75472
TEST=On folder menu in bookmark bar, Ctrl+Click bookmark menu items
Review URL: https://chromiumcodereview.appspot.com/11485022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11465018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(needed for tables) an in starting to do this I realized the file
could use some cleanup. This patch cleans up the following:
. fixs a couple of const issues.
. inlines a handful of things (GetContents() -> contents() resulted in
a couple of external changes)
. Made a couple of methods private that should not have been public.
. Consolidated override sections.
. Made method ordering in .h/.cc match.
I also added a couple of tests for cases I wanted to make sure I'm not going to break.
I haven't made any behavior changes here.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11528017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172461 0039d316-1c4b-4281-b951-d872f2087c98
|