summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Condense RootView::DispatchGestureEvent() to a single looptdanderson2014-09-031-118/+58
| | | | | | | | | | | | | | Remove the unnecessary code from RootView::DispatchGestureEvent() by condensing it to a single loop and moving parts of the implementation into RootView::PreDispatchEvent() and RootView::PostDispatchEvent(). BUG=404228 TEST=covered by existing unit tests Review URL: https://codereview.chromium.org/517023004 Cr-Commit-Position: refs/heads/master@{#293055}
* MacViews: Support continuous scrolling and horizontal scrollingandresantoso2014-09-034-13/+29
| | | | | | | | | | | | | Add support for continuous devices (Magic Mouse and trackpad) using NSEvent APIs introduced in 10.7. Tweak ScrollView/ScrollBar to allow horizontal scrolling from MouseWheel events. BUG=363529 Review URL: https://codereview.chromium.org/456913002 Cr-Commit-Position: refs/heads/master@{#293038}
* ozone: Remove CursorFactoryOzone::SetCursor, GetCursorWindowspang2014-09-0318-155/+86
| | | | | | | | | | | | | | Use PlatformWindow::SetCursor instead of CursorFactoryOzone::SetCursor. The GetCursorWindow() function becomes an implementation detail of the DRI platform. BUG=none TEST=compile, run on cros link_freon NOTRY=true Review URL: https://codereview.chromium.org/527293002 Cr-Commit-Position: refs/heads/master@{#293033}
* Move basic string operations to ui/app_list/searchmukai2014-09-0214-1/+1179
| | | | | | | | | | BUG=380875 R=xiyuan@chromium.org TEST=build succeeds Review URL: https://codereview.chromium.org/522683003 Cr-Commit-Position: refs/heads/master@{#292990}
* Only target ui::ET_GESTURE_END to the default gesture handlertdanderson2014-09-023-17/+51
| | | | | | | | | | | | | | | | | | If no gesture handler has been established prior to RootView receiving a ui::ET_GESTURE_END event, do not perform any targeting based on the event's location (and therefore do not dispatch this event to any view); GESTURE_END should only ever be targeted and dispatched to the gesture handler set by a previous gesture. BUG=409918 TEST=ViewTargeterTest.ViewTargeterForGestureEvents, WidgetTest.GestureBeginAndEndEvents, WidgetTest.DisabledGestureEventTarget Review URL: https://codereview.chromium.org/533793002 Cr-Commit-Position: refs/heads/master@{#292983}
* Further cleanup of RenderTexttmoniuszko2014-09-022-3/+0
| | | | | | | | | | | Remove redundant data member and include. Followup after https://codereview.chromium.org/493363006 BUG=388084 Review URL: https://codereview.chromium.org/527103003 Cr-Commit-Position: refs/heads/master@{#292982}
* Use standardized and extendable accelerometer update type.flackr2014-09-026-0/+187
| | | | | | | | | | | | | | | Updates the type used when delivering accelerometer updates in ash to: - support a variable number of accelerometers - be measured in m/s^2 - use axes consistent with the web device motion API. BUG=380831 TEST=MaximizeModeController unit tests still pass. TEST=Run on a touchview device and verify that entering / exiting touchview as well as screen rotation still works. Review URL: https://codereview.chromium.org/500613003 Cr-Commit-Position: refs/heads/master@{#292968}
* Fix the issue that GetFrameWindow() may change between AddObserver and ↵shuchen2014-09-022-18/+28
| | | | | | | | | | | RemoveObserver in KeyboardController. BUG=408995 TEST=Verified on linux_chromeos. Review URL: https://codereview.chromium.org/527153002 Cr-Commit-Position: refs/heads/master@{#292949}
* Files.app Test: check the cast icon in drive volumeyoshiki2014-09-022-24/+43
| | | | | | | | | | | This patch introduces the mock cast API which provide a dummy cast list and the cast icon is shown on the window. So we can check if the icon is shown correctly. BUG=405415 TEST=manually tested Review URL: https://codereview.chromium.org/505043002 Cr-Commit-Position: refs/heads/master@{#292944}
* Remove Default Touch Radii in EventGeneratorjonross2014-09-021-1/+1
| | | | | | | | | | EventGenerator creates touch events in two different manners. Those that use TestTouchEvent set touch radii without exposing this to unit test classes. Chrome's gesture recognizer uses these radii when determining touch rects. This can lead to different views being targetting within unittests. Remove the setting of these radii. Tests that wish to use larger can still create TouchEvents and call EventGenerator::Dispatch. Review URL: https://codereview.chromium.org/522453002 Cr-Commit-Position: refs/heads/master@{#292933}
* Make touch orientation attributes visible in Blink.mustaq2014-09-0210-50/+227
| | | | | | | | | | Completed the path for touch orientation attributes (i.e. radiusX, radiusY and rotationAngle of a touch ellipse) from android to Blink. BUG=381394 Review URL: https://codereview.chromium.org/494833003 Cr-Commit-Position: refs/heads/master@{#292923}
* Audio Player: Cancel scheduled advance if the track has been changedyoshiki2014-09-021-1/+15
| | | | | | | | | BUG=348487 TEST=manual Review URL: https://codereview.chromium.org/534493002 Cr-Commit-Position: refs/heads/master@{#292910}
* Remove the apps grid page switcher from the experimental app list.calamity2014-09-021-17/+26
| | | | | | | | | | | This CL removes the page switcher from the experimental app list's apps grid view. The normal app list should be unaffected. BUG=406222 Review URL: https://codereview.chromium.org/521823004 Cr-Commit-Position: refs/heads/master@{#292905}
* Experimental app list: Move custom launcher pages to the end.mgiuca2014-09-021-12/+16
| | | | | | | | | | They now come after the fixed pages (start page and apps grid). BUG=406222 Review URL: https://codereview.chromium.org/526983002 Cr-Commit-Position: refs/heads/master@{#292900}
* Do not release capture when starting a move loop on Desktop Linux.pkotwicz2014-09-015-103/+104
| | | | | | | | | | | | ChromeOS does not release capture when starting a move loop either. This CL fixes http://crbug.com/402301 as a side effect. BUG=392480, 402301 TEST=None Review URL: https://codereview.chromium.org/455553003 Cr-Commit-Position: refs/heads/master@{#292893}
* Video Player: Restyle Files.app Cast Selection Menuyoshiki2014-09-012-4/+31
| | | | | | | | | | | See the issue (http://crbug.com/407392#5) for the image of restyled design. BUG=407392 TEST=manually tested Review URL: https://codereview.chromium.org/528733002 Cr-Commit-Position: refs/heads/master@{#292867}
* Remove "Move window to..." from gear menu.fukino2014-09-012-63/+0
| | | | | | | | | | | | | | | | This CL removes: - "Move window to..." menu item from the gear menu. - Remove APIs fileBrowserPrivate.onProfileAdded and fileBrowserPrivate.onDesktopChanged as they are used only for updating gear menu. - Remove corresponding tests. BUG=408965 TEST=run browser_test, unit_tests TBR=benwells@chromium.org # TBRing for just removing unused events from file_browser_private.idl Review URL: https://codereview.chromium.org/530553006 Cr-Commit-Position: refs/heads/master@{#292860}
* Set tabindex of search box -1 not to be focused by default.fukino2014-09-011-1/+1
| | | | | | | | | BUG=408949 TEST=manually Review URL: https://codereview.chromium.org/529693002 Cr-Commit-Position: refs/heads/master@{#292859}
* [fsp] Generalize fileBrowserPrivate.getEntryProperties().mtomasz2014-09-013-5/+5
| | | | | | | | | | | | | This patch makes the method providing additional metadata for entries available for provided file systems too. NOTRY=True TEST=Tested manually. Files app works as before. BUG=408017 Review URL: https://codereview.chromium.org/515033002 Cr-Commit-Position: refs/heads/master@{#292851}
* gpu: Enable relevant extentions on GLES3.dongseong.hwang2014-09-011-3/+3
| | | | | | | | | | | | | | | | | | | | What’s New in OpenGL ES 3.0 among GL extentions - Vertex array - Element index uint - npot texture - float texture (1)(2) - GLSL standard derivatives - Blend min&max (1) GLES3 supports float and half float texture but only half float texture is filterable and doesn't allow them for color attachment. (2) This CL doesn't enable half_float due to conflicting GL_OES_texture_float BUG=405484 Review URL: https://codereview.chromium.org/489023002 Cr-Commit-Position: refs/heads/master@{#292849}
* Aura: Don't activate menus and other non-activatable widgets on dropmboc2014-09-011-1/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/517103003 Cr-Commit-Position: refs/heads/master@{#292848}
* [fsp] Remove the unused streaming field.mtomasz2014-09-014-45/+9
| | | | | | | | | | | | The field is not used, so it should be removed. NOTRY=True TEST=Tested manually that Files app works correctly. BUG=408017 Review URL: https://codereview.chromium.org/522533003 Cr-Commit-Position: refs/heads/master@{#292846}
* Handle the case when the last selection is not set yet.fukino2014-09-011-1/+1
| | | | | | | | | | | | | When a user starts to drag an item before they haven't selected any item yet, FileTable.lastSelection_ can be undefined and this ends up an incorrect drag image. The existence of lastSelection_ should be checked. BUG=409514 TEST=manually Review URL: https://codereview.chromium.org/532453002 Cr-Commit-Position: refs/heads/master@{#292845}
* Refactor app list scrolling: introduce the PaginationController class.mgiuca2014-09-016-97/+165
| | | | | | | | | | | | | | PaginationController abstracts over mouse wheel, touch screen and touchpad event handling for updating the PaginationModel. This allows any client of PaginationModel (ie, ContentsView) to properly handle scrolling events. It also removes the code duplication in OnMouseWheel and OnScrollEvent. BUG=406222 Review URL: https://codereview.chromium.org/524503003 Cr-Commit-Position: refs/heads/master@{#292843}
* Video Player: Show the appropriate error message on casting unsupported videoyosihki2014-09-011-0/+19
| | | | | | | | | | | | Previously, the error message was 'An error occurred.' This patch changes it to "This file could not be displayed." BUG=405860 TEST=manually tested TBR=fukino@chromium.org Review URL: https://codereview.chromium.org/523663002 Cr-Commit-Position: refs/heads/master@{#292832}
* [fsp] Move thumbnail logic to Drive specific C++ code.mtomasz2014-09-011-7/+0
| | | | | | | | | | | | MetadataCache is soon going to be generalized from Drive to also FSP file systems. So, in the Files app layer, we should not have Drive specific code. TEST=Tested manually. BUG=408017 Review URL: https://codereview.chromium.org/517213002 Cr-Commit-Position: refs/heads/master@{#292829}
* Remove Files.app's own profile badge.fukino2014-09-014-48/+1
| | | | | | | | | | | Now that the Files.app uses default system header, the own profile badge is redundant. BUG=408816 TEST=confirmed manually, ran browser_tests Review URL: https://codereview.chromium.org/520623002 Cr-Commit-Position: refs/heads/master@{#292827}
* Make apps grid view scroll vertically in experimental app list.mgiuca2014-09-012-31/+81
| | | | | | | | | | | | | Scrolling remains horizontal in the normal (and centered) app lists. BUG=406222 TEST=Run with --enable-experimental-app-list --show-app-list. Apps grid view should scroll vertically. Normal app list should still scroll horizontally. Review URL: https://codereview.chromium.org/491973004 Cr-Commit-Position: refs/heads/master@{#292826}
* [Local NTP] Implement style updates for Material Designhuangs2014-08-315-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Applying new styling, with some refactoring and bug fixes. Details: - Sizing and positioning tweaks. - Change of assets for "X" and for default favicon (if it's missing). - Using image as mask, and setting color by CSS (since design uses solid colors). - The new PNG files have been minimized. - Fixed bug: "Undo" and "Restore All" links continue to be selectable via tab after they fades out. - Alternative Google logo (white): using image as mask and setting background color to #eee. Will delete old image for M39. - Theme title color in title.html <iframe>: now injecting it from local NTP in "c=RRGGBBAA" format. The old behavior of reading it from <iframe> and using it to override "c=RRGGBB" are kept, for compatibility with server-side NTP. BUG=407943 NOTRY=1 R=mathp@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/512583002 Cr-Commit-Position: refs/heads/master@{#292820}
* [Win, Linux] Always display the avatar button text at the same size.noms2014-08-293-0/+69
| | | | | | | | | | | | | | | | | | | | The problem is that some locales (Hindi) or platforms (Linux) have a bigger base font size for the default font (crbug.com/405994). If this is the case, we should decrease the font size to the one we expect, so that the font fits in the button correctly. Just adjusting the baseline is not always enough, as the new avatar button has a fixed size, and the text might not fit correctly regardless of the baseline adjustments. Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing BUG=403466 TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button. Review URL: https://codereview.chromium.org/470053004 Cr-Commit-Position: refs/heads/master@{#292715}
* ozone: gbm: Fix missing OVERRIDEspang2014-08-291-1/+2
| | | | | | | | | | | BUG=none TEST=compile TBR=dnicoara NOTRY=true Review URL: https://codereview.chromium.org/518303002 Cr-Commit-Position: refs/heads/master@{#292712}
* Revert of ui: Move ui_unittests.gyp into ui/base. (patchset #5 id:80001 of ↵tfarina2014-08-294-271/+265
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/506483002/) Reason for revert: it breaks clobber build of ios_dbg_simulator. Original issue's description: > ui: Move ui_unittests.gyp into ui/base. > > ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern). > ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi > ui_unittests.isolate -> ui_base_tests.isolate > > Add a TODO assigned to me to rename ui_unittests target to > ui_base_unittests when buildbot is updated. > > BUG=331829,373148,299841,103304 > TEST=ui_unittests > R=sky@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/60f6892f7223f9d6db92314edb5df9b63d25720f TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=331829,373148,299841,103304 Review URL: https://codereview.chromium.org/522843002 Cr-Commit-Position: refs/heads/master@{#292657}
* Remove deferred fade shader workaround from RenderTexttmoniuszko2014-08-292-39/+3
| | | | | | | | BUG=388084 Review URL: https://codereview.chromium.org/493363006 Cr-Commit-Position: refs/heads/master@{#292650}
* Some ui/BUILD.gn fixes.tfarina2014-08-291-6/+2
| | | | | | | | | | | | | This fixes some TODOs in ui/BUILD.gn and add GN build file for third_party/mozilla. BUG=None TEST=None R=brettw@chromium.org Review URL: https://codereview.chromium.org/521553002 Cr-Commit-Position: refs/heads/master@{#292649}
* Video Player: Fix the condition of 'ended' propertyyoshiki2014-08-291-1/+2
| | | | | | | | | | | Once the user tries starting the video, the video should not be 'ended'. BUG=none TEST=none Review URL: https://codereview.chromium.org/517963002 Cr-Commit-Position: refs/heads/master@{#292617}
* Files.app: Move VP/Galllery related files to dedicate foldersyosihki2014-08-2984-8/+8
| | | | | | | | | | | | | | | | | | | - Move file_manager/js/media/media_controls.{css,js} -> video_player/js - Move file_manager/js/media/mouse_inactivity_watcher.js -> file_manager/js (parent directory) - Move file_manager/images/media/* -> video_player/images/media/ - Move file_manager/images/media/error.png -> gallery/images/media/error.png BUG=405838 TEST=compile pasees R=hirono@chromium.org Review URL: https://codereview.chromium.org/504073002 Cr-Commit-Position: refs/heads/master@{#292609}
* Fix for a crash in NativeViewAccessibilityWin.krzysztofc2014-08-291-2/+6
| | | | | | Review URL: https://codereview.chromium.org/521573003 Cr-Commit-Position: refs/heads/master@{#292605}
* Correct cache-size calculation of MetadataCache.fukino2014-08-292-3/+11
| | | | | | | | | | | | - Make sure that the DirectoryContent.dispose() is called when necessary. - Defer dispose() temporarily when we need to replace directory contents. BUG=408893 TEST=watched the cache size manually, and ran browser_tests Review URL: https://codereview.chromium.org/520553002 Cr-Commit-Position: refs/heads/master@{#292593}
* Refactor app list event handling and prerendering.mgiuca2014-08-294-100/+86
| | | | | | | | | | | | | | ContentsView should not be responsible for apps-grid-specific logic. To this end, moved scroll and gesture event handling from ContentsView to AppsGridView, removing the special cases for NAMED_PAGE_APPS. Also moved some of the prerender logic from ContentsView to AppsGridView. BUG=377381 Review URL: https://codereview.chromium.org/497413003 Cr-Commit-Position: refs/heads/master@{#292591}
* Video Player: Close the session when the other device is selected to playyoshiki2014-08-291-3/+9
| | | | | | | | | BUG=408520 TEST=manually tested Review URL: https://codereview.chromium.org/514163002 Cr-Commit-Position: refs/heads/master@{#292580}
* Move gestureCreated, touchMaxDistance and touchDuration UMA logs into ↵lanwei2014-08-296-0/+240
| | | | | | | | | | gesture provider, so that they can also record data from other platforms, such as Android, Windows, not only from ChromeOS. BUG=352654 Review URL: https://codereview.chromium.org/501553004 Cr-Commit-Position: refs/heads/master@{#292570}
* Remove the search icon from the search box in the experimental app list.calamity2014-08-291-4/+8
| | | | | | | | | | | This CL removes the magnifying glass icon from the experimental app list. The normal app list should be unaffected BUG=406222 Review URL: https://codereview.chromium.org/503693002 Cr-Commit-Position: refs/heads/master@{#292569}
* Audio Player: Don't update the track list when the list is not changedyoshiki2014-08-291-5/+12
| | | | | | | | | | | Previously, when user clicked the audio file on Files.app, the track list was updated unexpectedly and the current track index was set to the default (the first file) for a very short time just before the index was updated to the selected file. This unexpected change in short period made the playback time reset and caused the issue (crbug.com/395868). This patch fixes this issue. BUG=395868 TEST=none Review URL: https://codereview.chromium.org/515443002 Cr-Commit-Position: refs/heads/master@{#292565}
* Move StringComparator<string16>::operator() to headerscottmg2014-08-292-15/+11
| | | | | | | | | | | | | | | | | | | | | | | Enabling /Zc:inline on static release build results in FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True chrome.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:chrome.dll.lib /DLL /OUT:chrome.dll @chrome.dll.rsp" 2 mt.exe rc.exe "obj\chrome\chrome_main_dll.chrome.dll.intermediate.manifest" obj\chrome\chrome_main_dll.chrome.dll.generated.manifest ..\..\chrome\app\chrome.dll.manifest browser_2.lib(browser_2.character_encoding.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z) referenced in function "void __cdecl std::_Adjust_heap<struct CharacterEncoding::EncodingInfo *,__int64,struct CharacterEncoding::EncodingInfo,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo> >(struct CharacterEncoding::EncodingInfo *,__int64,__int64,struct CharacterEncoding::EncodingInfo &&,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo>)" (??$_Adjust_heap@PEAUEncodingInfo@CharacterEncoding@@_JU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@std@@YAXPEAUEncodingInfo@CharacterEncoding@@_J1$$QEAU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@Z) browser_1.lib(browser_1.background_application_list_model.obj) : error LNK2001: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z) So, move StringComparator<base::string16>::operator() into header and mark it inline, so that it's available in all translation units where it's used. The previous code was correct, but this makes all compilers happy. /Zc:inline ref: http://msdn.microsoft.com/en-us/library/dn642448.aspx R=rnk@chromium.org TBR=jshin@chromium.org BUG=350018 Review URL: https://codereview.chromium.org/518533002 Cr-Commit-Position: refs/heads/master@{#292559}
* Remove cevans@ from OWNERS files.thestig2014-08-294-5/+0
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/524433003 Cr-Commit-Position: refs/heads/master@{#292549}
* linux: Make RenderTextPango avoid clipping underlines.derat2014-08-293-40/+13
| | | | | | | | | | | | | | | | | | | | | Adjust underline positions so the lines won't get clipped. I think that the inaccuracy may be occurring due to our conversion from PangoFontDescriptions (usually containing a point-based size) to a rounded pixel-based size and then back to a PangoFontDescription. Luckily, RenderTextPango will be replaced by RenderTextHarfBuzz soon. Also delete some dead code in PlatformFontPango for computing underline metrics. BUG=393117 TEST=manual: checked that the "Import bookmarks now..." underline is visible after setting my UI font to "Ubuntu 11" Review URL: https://codereview.chromium.org/509093004 Cr-Commit-Position: refs/heads/master@{#292537}
* Add the actual location coordinates to the touch cancel eventlanwei2014-08-295-60/+91
| | | | | | | | BUG=366603 Review URL: https://codereview.chromium.org/469523003 Cr-Commit-Position: refs/heads/master@{#292523}
* Print information on connected displays to VLOG(1)dnicoara2014-08-281-1/+1
| | | | | | | | | | | Finding the root cause of display configuration bugs is harder without knowing which displays were reported as connected. BUG=none Review URL: https://codereview.chromium.org/518553002 Cr-Commit-Position: refs/heads/master@{#292507}
* Force scales 125% and lower down to 100%Scott Graham2014-08-281-0/+5
| | | | | | | | | | | | | | | 125 comes from: 150% == 144 logpixels 125% == 120 logpixels 100% == 96 logpixels R=cpu@chromium.org, sky@chromium.org, ananta@chromium.org BUG=395425 Review URL: https://codereview.chromium.org/516743002 Cr-Commit-Position: refs/heads/master@{#292494}
* Revert of Revert of Fix assorted issues with remote CoreAnimation (patchset ↵ccameron2014-08-284-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #1 of https://codereview.chromium.org/517733002/) Reason for revert: Patch was reverted in error Original issue's description: > Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/) > > Reason for revert: > Speculatively reverting to see if this helps the mac perf bots: > https://code.google.com/p/chromium/issues/detail?id=408673 > > Original issue's description: > > Fix assorted issues with remote CoreAnimation > > > > These issues came up while running for a few days with the > > flag --enable-remote-core-animation. > > > > Fix flashes of old frames by hooking up the DiscardBackbuffer (which > > happens when being made non-visible) to re-set the CAContext and > > CALayer (so the browser gets a new one with new content for the next > > frame). > > > > Add support for disabling vsync by using setNeedsDisplay to draw. > > > > Change the backpressure mechanism to rely on the browser to apply > > backpressure in its compositor via the cc:: output surface. > > > > Add a ScopedSetGLToRealGLApi structure to ensure that we are talking > > to the real GL API while in the CoreAnimation callback. > > > > BUG=312462 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8 > > TBR=piman@chromium.org,ccameron@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=312462 > > Committed: https://chromium.googlesource.com/chromium/src/+/07539c445c9fa7161b3da9031cf440a2b657dd18 TBR=piman@chromium.org,epenner@chromium.org NOTREECHECKS=true NOTRY=true BUG=312462 Review URL: https://codereview.chromium.org/517143002 Cr-Commit-Position: refs/heads/master@{#292481}
generated by cgit v1.1 at 2025-04-22 14:06:54 +0000