summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* fix for intsafe.h in static_libraryscottmg@chromium.org2013-10-221-9/+9
| | | | | | | | | | | | Was previously inside a link_settings block which seems to work in shared_library but not in static_library (!). TBR=tapted@chromium.org BUG=308740, 310197 Review URL: https://codereview.chromium.org/31373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230190 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up unneeded ownersskyostil@chromium.org2013-10-221-6/+0
| | | | | | | | | | | | Remove owners for *android* files in ui/OWNERS since there are no such files in that directory. Per-file rules aren't recursive. BUG=309856 NOTRY=true Review URL: https://codereview.chromium.org/34873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230174 0039d316-1c4b-4281-b951-d872f2087c98
* [Ozone] Set DPMS to on when starting SSFOdnicoara@chromium.org2013-10-228-40/+106
| | | | | | | | | | | By setting the DPMS property on the connector, the screen will become active and stay active until the HardwareDisplayController is destroyed. BUG= Review URL: https://codereview.chromium.org/33443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230155 0039d316-1c4b-4281-b951-d872f2087c98
* fix intsafe.h compile errors on express/automatic toolchain on windowsscottmg@chromium.org2013-10-224-0/+17
| | | | | | | | | | | | R=nick@chromium.org, robliao@chromium.org TBR=nick@chromium.org, robliao@chromium.org BUG=308740 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229443 Review URL: https://codereview.chromium.org/29273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230115 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: gpu: Add Will/DidUseTexImage to GLImage API.reveman@chromium.org2013-10-2210-27/+90
| | | | | | | | | | | | | | | | | WillUseTexImage/DidUseTexImage is called before/after the image is used for sampling. The result is that the client only has to call bind/releaseTexImage2D when contents have changed, which allows for more efficient GLImage implementations as work required before use can be separated from work required when contents have changed. BUG=261649 TEST=gpu_unittests --gtest_filter=SharedTextureTest.Images && gpu_unittests --gtest_filter=GLES2DecoderWithShaderTest.UseTexImage && cc_unittests --gtest_filter=ResourceProviderTests/ResourceProviderTest.Image_GLTexture* && gl_tests --gtest_filter=MockGpuMemoryBufferTest.Lifecycle Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229532 Review URL: https://codereview.chromium.org/23129010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230093 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229999 "Remove views::InputMethod::On[Focus|Blur] calling..."kouhei@chromium.org2013-10-2210-7/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This may be causing KeyboardInput_0 test regressions on Chrome Frame (ie6). http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%28ie6%29/builds/47846 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&tests=CF/FullTabUITest.KeyboardInput/0 > Remove views::InputMethod::On[Focus|Blur] calling from not top level widgets. > > This patch is a step of refactoring for the IME related focus handling. > > Background issue: > No top level widget can call views::InputMethod::On[Focus|Blur] as documented. > That hack was needed because to create a new widget with a new window handle by a mouse leaving event invoked Aura focus to the widget first and win32 focus next. > InputMethodTSF focusing works on widgets with win32 focus so the first focusing missed TSF focusing. > 2nd focusing by win32 also didn't work because InputMethodBridge > permitted the TextInputClient setting only once. > > Solution: > This patch changes to call OnWillChangeFocusedClientand OnDidChangeFocusedClient whenever a TextInputClinet is set or not. > Then secondary win32 focusing sets InputMethodTSF focus. > > BUG=302229,306368 > TEST=manually done in Windows 8 Aura with or without --enable-text-services-framework flag. > > Review URL: https://codereview.chromium.org/27670002 TBR=yoichio@chromium.org Review URL: https://codereview.chromium.org/34673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230073 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 223149 "add missing #include of <algorithm>, needed on VS..."yukawa@chromium.org2013-10-221-2/+0
| | | | | | | | | | | | | | | | | This change is a duplicate of r222896. > add missing #include of <algorithm>, needed on VS2013 for std::min > > R=nona@chromium.org > BUG=288948 > > Review URL: https://chromiumcodereview.appspot.com/23484040 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/34443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230059 0039d316-1c4b-4281-b951-d872f2087c98
* Add font_scale_factor_quirk pref.skobes@chromium.org2013-10-223-0/+19
| | | | | | | | | | | | | | | | | | This is an Android-specific boolean pref defaulting to true, which indicates whether font_scale_factor includes the 1.05-1.3x multiplier that is currently applied by Clank on startup. The goal is to move this multiplier out of Clank and into the content layer. When font_scale_factor_quirk is false, the multiplier is applied in content::ApplyWebPreferences. This pref can be removed after Clank code is updated. BUG= Review URL: https://codereview.chromium.org/28053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230042 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Rename MockDBusTreadManagerWithoutGMock to FakeDBusThreadManagersatorux@chromium.org2013-10-221-1/+0
| | | | | | | | | | | | | The original name was a misnomer as the class behaves like a fake and hosts fake D-Bus client classes. No semantic changes. BUG=223061 TEST=none R=hashimoto@chromium.org, miket@chromium.org, nona@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/31793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230035 0039d316-1c4b-4281-b951-d872f2087c98
* Mark getter methods in ui::InputMethod as constyukawa@chromium.org2013-10-2212-90/+100
| | | | | | | | | | | | | | | | | | | This CL marks following methods as "const-method" as a preparation to fix issue 164964. - ui::TextInputClient::GetCaretBounds - ui::TextInputClient::GetCompositionCharacterBounds - ui::TextInputClient::HasCompositionText - ui::TextInputClient::GetTextRange - ui::TextInputClient::GetCompositionTextRang - ui::TextInputClient::GetSelectionRange - ui::TextInputClient::GetTextFromRange BUG=164964 TEST=none Review URL: https://codereview.chromium.org/27812003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230001 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Ozone software implementation in GYPdnicoara@chromium.org2013-10-223-1/+30
| | | | | | | | | | | | | | | | | | | | | Depends on: - SoftwareSurfaceFactoryOzone - [closed] https://codereview.chromium.org/26849004/ - [closed] https://codereview.chromium.org/27217009/ - HardwareDisplayControllerOzone - [closed] https://codereview.chromium.org/26538005/ - [closed] https://codereview.chromium.org/27038004/ - SoftwareSurfaceOzone - [closed] https://codereview.chromium.org/26866006/ - [closed] https://codereview.chromium.org/26179005/ - DrmSkBitmapOzone - [closed] https://codereview.chromium.org/26290006/ BUG= Review URL: https://codereview.chromium.org/27764002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230000 0039d316-1c4b-4281-b951-d872f2087c98
* Remove views::InputMethod::On[Focus|Blur] calling from not top level widgets.yoichio@chromium.org2013-10-2210-38/+7
| | | | | | | | | | | | | | | | | | | | | | This patch is a step of refactoring for the IME related focus handling. Background issue: No top level widget can call views::InputMethod::On[Focus|Blur] as documented. That hack was needed because to create a new widget with a new window handle by a mouse leaving event invoked Aura focus to the widget first and win32 focus next. InputMethodTSF focusing works on widgets with win32 focus so the first focusing missed TSF focusing. 2nd focusing by win32 also didn't work because InputMethodBridge permitted the TextInputClient setting only once. Solution: This patch changes to call OnWillChangeFocusedClientand OnDidChangeFocusedClient whenever a TextInputClinet is set or not. Then secondary win32 focusing sets InputMethodTSF focus. BUG=302229,306368 TEST=manually done in Windows 8 Aura with or without --enable-text-services-framework flag. Review URL: https://codereview.chromium.org/27670002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229999 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Background to All Notification Iconsrobliao@chromium.org2013-10-214-4/+5
| | | | | | | | BUG=309167 Review URL: https://codereview.chromium.org/29683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229956 0039d316-1c4b-4281-b951-d872f2087c98
* Move evdev events support into EventFactoryDelegateEvdevspang@chromium.org2013-10-2115-128/+244
| | | | | | | | | | | | | | | | | And introduce a gyp variable use_ozone_evdev to allow this feature to be removed from the build. Additionally, the --ozone-events flag is introduced to select an EventFactoryDelegateOzone implementation to use. If an embedder or out-of-tree EventFactoryDelegateOzone implementation calls SetEventFactoryDelegateOzone during initialization, the flag has no effect. BUG=none TEST=Build & run content_shell, ui_unittests with use_ozone=1 Review URL: https://codereview.chromium.org/28513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229950 0039d316-1c4b-4281-b951-d872f2087c98
* The inactive rendering flag on Windows AURA should be turned off in the ↵ananta@chromium.org2013-10-2111-143/+0
| | | | | | | | | | | | | | | | | | | | | WM_NCACTIVATE handler when the window is activated. Currently this is turned off when the aura Window is deactivated, which occurs when a top level window like a bubble is displayed. This causes the browser frame's caption to be displayed as inactive when a bubble is displayed which is not correct. Removed the NativeWidgetAuraWindowObserver class as it does not do anything useful with the inactive rendering flag setting code taken out. I also removed the SetInactiveRenderingDisabled method from the NativeWidgetPrivate interface as it does not do anything useful. The inactive rendering flag gets reset correctly in the WM_ACTIVATEAPP and WM_NCACTIVATE messages on Windows. BUG=307343 R=sky@chromium.org, sky Review URL: https://codereview.chromium.org/26800010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229945 0039d316-1c4b-4281-b951-d872f2087c98
* gesture-recognizer: Clean up GestureConsumer.sadrul@chromium.org2013-10-215-78/+86
| | | | | | | | | | | | * Remove GestureConsumer::ignores_events_ since it's no longer necessary. * Remove Mirrored and CancelledTouchEvent. BUG=none R=tdresser@chromium.org, varunjain@chromium.org Review URL: https://codereview.chromium.org/28773005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229925 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for sticky modifier keys. This is the first step in adding ↵rsadam@chromium.org2013-10-219-27/+197
| | | | | | | | | | Control and Alt modifiers to the virtual keyboard. BUG=297112 Review URL: https://codereview.chromium.org/26945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229913 0039d316-1c4b-4281-b951-d872f2087c98
* android: Implement screenshots for Content Shell and Chromium Test Shellskyostil@chromium.org2013-10-211-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch implements screenshots for the Android Content Shell. It requires a few improvements to how screenshots work on Android. Most importantly, WindowAndroid.grabSnapshot now takes a screenshot of the root activity view instead of the content view. This is needed because, unlike in Chrome, Content Shell's navigation controls are real Android Views. As before, we need to calculate their geometry in order to crop them out of the screenshot. In Chrome, the browser compositor would do this for us, but with Content Shell we need to query the information from the Android framework. Switching the base screenshot to capture the entire activity establishes a common coordinate system (View.getLocationInWindow) in which we can communicate the position of the content. This patch changes ContentView to report this information to ContentViewCore, which passes it on to WindowAndroid. We also change telemetry's screenshot backend to always assume Content Shell is new enough to support screenshots (if it exposes the right API). This is because the Content Shell doesn't report a meaningful branch number to telemetry. BUG=285932 TEST=content/test/gpu/run_gpu_test --browser=android-content-shell pixel Review URL: https://codereview.chromium.org/28843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229902 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NativeThemeAura's menu background color.msw@chromium.org2013-10-212-9/+5
| | | | | | | | | | | | | | | Fix NativeThemeAura::PaintMenuPopupBackground. (use kColorId_MenuBackgroundColor, not SK_ColorWHITE) Make FallbackTheme::GetSystemColor protected. (base decl in NativeTheme is public...) BUG=292943 TEST=Chrome/Ash menus look good in normal themes, the Windows "High Contrast Black" theme, and similar inverted color themes. R=sky@chromium.org Review URL: https://codereview.chromium.org/29683004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229880 0039d316-1c4b-4281-b951-d872f2087c98
* When a modal window appears, cancel existing touches.tdresser@chromium.org2013-10-211-0/+10
| | | | | | | | | | | | | | | | | | Previously committed (https://codereview.chromium.org/26893004), and then reverted(https://codereview.chromium.org/26731003) due to an unrelated valgrind error. This patch is slightly different from that one, as it prevents the RenderWidgetHostImpl from ignoring touch cancel events. This change was necessary due to jdduke's recent work in simplifying the input router (https://codereview.chromium.org/26775003). BUG=268075 TEST=WindowModalityControllerTest.TouchEvent Review URL: https://codereview.chromium.org/27712002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229879 0039d316-1c4b-4281-b951-d872f2087c98
* rAc: improve appearance of uneditable fieldsestade@chromium.org2013-10-213-5/+7
| | | | | | | | BUG=245140 Review URL: https://codereview.chromium.org/28253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229873 0039d316-1c4b-4281-b951-d872f2087c98
* Renames DNWA::window_ to content_window_sky@chromium.org2013-10-212-110/+113
| | | | | | | | | | | | | Also converts a couple of calls to GetRootWindow() to root_window_.get(). BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/29983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229532 "gpu: Add Will/DidUseTexImage to GLImage API."reveman@chromium.org2013-10-2110-90/+27
| | | | | | | | | | | | | | | | | | | | | | | This is causing webgl_conformance_tests to fail. > gpu: Add Will/DidUseTexImage to GLImage API. > > WillUseTexImage/DidUseTexImage is called before/after the image is > used for sampling. The result is that the client only has to call > bind/releaseTexImage2D when contents have changed, which allows > for more efficient GLImage implementations as work required before > use can be separated from work required when contents have changed. > > BUG=261649 > TEST=gpu_unittests --gtest_filter=SharedTextureTest.Images && gpu_unittests --gtest_filter=GLES2DecoderWithShaderTest.UseTexImage && cc_unittests --gtest_filter=ResourceProviderTests/ResourceProviderTest.Image_GLTexture* && gl_tests --gtest_filter=MockGpuMemoryBufferTest.Lifecycle > > Review URL: https://codereview.chromium.org/23129010 TBR=reveman@chromium.org Review URL: https://codereview.chromium.org/32603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229799 0039d316-1c4b-4281-b951-d872f2087c98
* Gesture recognizer must be a singleton accross all aura::RootWindowsvarunjain@chromium.org2013-10-2113-101/+196
| | | | | | | | | | | | BUG=279317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229753 R=sadrul@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/25350006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229796 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r229753 "Gesture recognizer must be a singleton accross all ↵pfeldman@chromium.org2013-10-2113-196/+101
| | | | | | | | | | | | | aura::RootWindows" Breaks windows bots on chromium.webkit. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/44634 TBR=varunjain Review URL: https://codereview.chromium.org/30813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229761 0039d316-1c4b-4281-b951-d872f2087c98
* Gesture recognizer must be a singleton accross all aura::RootWindowsvarunjain@chromium.org2013-10-2113-101/+196
| | | | | | | | BUG=279317 Review URL: https://codereview.chromium.org/25350006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229753 0039d316-1c4b-4281-b951-d872f2087c98
* Implement rect conversion utility functions in Viewtdanderson@chromium.org2013-10-213-3/+145
| | | | | | | | | | | | | | | Add the following utility functions (similar to their point-based counterparts): View::ConvertRectToTarget() View::ConvertRectToAncestor() View::ConvertRectFromAncestor() BUG=306182 Review URL: https://codereview.chromium.org/26884003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229711 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Allow creating content_shell without views.sadrul@chromium.org2013-10-202-4/+2
| | | | | | | | | | | | | | | | | | | This builds content_shell with use_aura=1 and toolkit_views=0. BUG=none R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org Previously, on this issue: * Landed in r229507 * Speculatively reverted in r229521. * Relanded in r229524, since the revert didn't fix anything. * Reverted in r229525 because it broken win-blink bots. * Committed again in r229671 with an incorrect fix. * Reverted in r229683 Review URL: https://codereview.chromium.org/26695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229704 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r229671 "aura: Allow creating content_shell without views."pfeldman@chromium.org2013-10-202-2/+4
| | | | | | http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28deps%29/builds/74852/steps/compile/logs/stdio git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229683 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Allow creating content_shell without views.sadrul@chromium.org2013-10-202-4/+2
| | | | | | | | | | | | | | | | | This builds content_shell with use_aura=1 and toolkit_views=0. BUG=none R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org Previously, on this issue: * Landed in r229507 * Speculatively reverted in r229521. * Relanded in r229524, since the revert didn't fix anything. * Reverted in r229525 because it broken win-blink bots. Review URL: https://codereview.chromium.org/26695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229671 0039d316-1c4b-4281-b951-d872f2087c98
* Enables system key functionality on the virtual keyboard. Note the power ↵rsadam@chromium.org2013-10-193-20/+36
| | | | | | | | | | button currently does not get propagated correctly. It is blocked due to chromoting (crbug/146609). This will be addressed in a later patch. BUG=297103 Review URL: https://codereview.chromium.org/27721004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229637 0039d316-1c4b-4281-b951-d872f2087c98
* [Ozone] Unit tests for SoftwareSurfaceFactoryOzonednicoara@chromium.org2013-10-191-0/+285
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/27217009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229629 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a separate gyp file for content shell and testsjochen@chromium.org2013-10-191-3/+3
| | | | | | | | | | | | This will make it possible to depend on components from content shell BUG=247431 R=jam@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/28123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229620 0039d316-1c4b-4281-b951-d872f2087c98
* Provide approximate type functions for SkMatrix44.dominikg@chromium.org2013-10-193-0/+108
| | | | | | | | | | | | | | | Skia's SkMatrix44 class provides methods for computing the type of a matrix using exact computations, i.e. matrix values must be of exactly some value. However, in some cases some inaccuracy can be tolerated. This patch provides methods for computing approximate types in a centralized place (cc/base/math_util.c,hh). It replaces any other approximate type computation with calls to the new methods. BUG=293787 Review URL: https://codereview.chromium.org/27223008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229609 0039d316-1c4b-4281-b951-d872f2087c98
* Makes ~RootWindow delete child windowssky@chromium.org2013-10-198-19/+94
| | | | | | | | | | | | | This way any children of the Root can call GetRootWindow() from their destructor and get a valid root. BUG=307369 TEST=covered by unit test R=ben@chromium.org Review URL: https://codereview.chromium.org/27570004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229586 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a hint to the notifications API that a notification is clickable.dewittj@chromium.org2013-10-194-4/+18
| | | | | | | | | | | | | | | | The former behavior was that all notifications would be shown as if they were clickable if the app had any onClick handler installed. This patch changes the behavior - if isClickable is false, then the notification body will not appear clickable even if there is an onClick handler installed. Also fixes a bug where buttons don't appear to have the clickable cursor. BUG=304923 Review URL: https://codereview.chromium.org/27569003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229585 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code added to track crashsky@chromium.org2013-10-191-2/+2
| | | | | | | | | | | | | Crash is the result of bad hook. BUG=294353 TEST=none R=ben@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/28553009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229580 0039d316-1c4b-4281-b951-d872f2087c98
* linux and chromeos: Turn on -Wunused-const-variable.thakis@chromium.org2013-10-1911-32/+7
| | | | | | | | | | BUG=307668 R=hans@chromium.org TBR=oshima Review URL: https://codereview.chromium.org/29263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
* [Ozone] Adding a software rendering implementation of SurfaceFactoryOzonednicoara@chromium.org2013-10-197-26/+381
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/26849004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229575 0039d316-1c4b-4281-b951-d872f2087c98
* Hide touch selection cursor handle when out of client viewmohsen@chromium.org2013-10-192-69/+71
| | | | | | | | | | | | | | | | | | | | | | Selection handles are made hidden when they are out of client view. This was not done for cursor handle. Other than fixing this, a check is added to move the handles only when they're going to be visible. Since hiding a handle fades it out, it is better to have this fade out in the previous handle location which is inside the boundaries of the client view. With this change, handle positions cannot be used as selection end points; so, whenever selection end points are needed, values cached in touch selection controller are used instead of handle positions. Also, IsEmptySelection() function in touch selection controller is not needed anymore; so, it is removed. Previous review URL: https://codereview.chromium.org/25609006/ BUG=289014 Review URL: https://codereview.chromium.org/27485008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229568 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a SetWindowPos(HIDE) to tooltip to avoid flickersky@chromium.org2013-10-191-0/+6
| | | | | | | | | | | | | For some reason without this the tooltip occasionally flickers at 0x0 before snapping to original location. No idea why it's necessary. BUG=307861 TEST=see bug R=ananta@chromium.org Review URL: https://codereview.chromium.org/26852006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229558 0039d316-1c4b-4281-b951-d872f2087c98
* Return blank strings for Views Combobox separator items.msw@chromium.org2013-10-192-2/+18
| | | | | | | | | | | | | | Prevents a DCHECK cited in the bug and follows good practice. (don't ask ComboboxModel impls for separator item names) Add a unit test that fails without the above change. BUG=308666 TEST=No DCHECK on debug build for typing "other" then "book" in bookmark bubble folder combobox. R=sky@chromium.org Review URL: https://codereview.chromium.org/26540004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229550 0039d316-1c4b-4281-b951-d872f2087c98
* gpu: Add Will/DidUseTexImage to GLImage API.reveman@chromium.org2013-10-1910-27/+90
| | | | | | | | | | | | | | | WillUseTexImage/DidUseTexImage is called before/after the image is used for sampling. The result is that the client only has to call bind/releaseTexImage2D when contents have changed, which allows for more efficient GLImage implementations as work required before use can be separated from work required when contents have changed. BUG=261649 TEST=gpu_unittests --gtest_filter=SharedTextureTest.Images && gpu_unittests --gtest_filter=GLES2DecoderWithShaderTest.UseTexImage && cc_unittests --gtest_filter=ResourceProviderTests/ResourceProviderTest.Image_GLTexture* && gl_tests --gtest_filter=MockGpuMemoryBufferTest.Lifecycle Review URL: https://codereview.chromium.org/23129010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229532 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229524 "Revert 229521 "Revert 229507 "aura: Allow creating ↵pfeldman@chromium.org2013-10-192-2/+4
| | | | | | | | content_shell..."" Breaks blink waterfall due to TOOLKIT_VIEWS not defined there. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229525 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229521 "Revert 229507 "aura: Allow creating content_shell..."thakis@chromium.org2013-10-192-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert didn't help, so reland the change. > Revert 229507 "aura: Allow creating content_shell without views." > > Speculative. All windows bots on the main waterfall except for the clobber > builder started timing out during compile during a window that had only this > change and two test-only changes in the range. > > > aura: Allow creating content_shell without views. > > > > This builds content_shell with use_aura=1 and toolkit_views=0. > > > > BUG=none > > R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/26695007 > > TBR=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/30413002 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/27993005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229507 "aura: Allow creating content_shell without views."thakis@chromium.org2013-10-192-2/+4
| | | | | | | | | | | | | | | | | | | | | Speculative. All windows bots on the main waterfall except for the clobber builder started timing out during compile during a window that had only this change and two test-only changes in the range. > aura: Allow creating content_shell without views. > > This builds content_shell with use_aura=1 and toolkit_views=0. > > BUG=none > R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org > > Review URL: https://codereview.chromium.org/26695007 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/30413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229521 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Allow creating content_shell without views.sadrul@chromium.org2013-10-192-4/+2
| | | | | | | | | | | This builds content_shell with use_aura=1 and toolkit_views=0. BUG=none R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/26695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229507 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229455 "Gets hiding animations to work again"sky@chromium.org2013-10-188-32/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > Gets hiding animations to work again > > This broke when bounds changes was consolidated into > DesktopNativeWidgetAura::OnRootWindowHostResized. We can't resize the > child layers when this happens as otherwise we're going to force a > paint of the layers and thus the views. But at this point nothing is > valid and we don't want to paint anyway. > > Also removing a call to Show() early on as it may trigger animations > that we don't want. A Show() at this time is before the creator has > had a chance to turn them off. > > BUG=none > TEST=none > R=ananta@chromium.org, ben@chromium.org, grt@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229285 > > Review URL: https://codereview.chromium.org/27043007 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/30083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229487 0039d316-1c4b-4281-b951-d872f2087c98
* Resort RootWindow methodsben@chromium.org2013-10-185-174/+178
| | | | | | | | | TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/28333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229484 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to re-land FocusManager removal from Aura.ben@chromium.org2013-10-1827-267/+132
| | | | | | | | | | | content_browsertests ContentWindowReparent test was failing, presumably because a focus notification wasn't being broadcast by the new test focus client. R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/29883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229480 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 14:48:12 +0000