| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=72517
TEST=included unit test
Review URL: http://codereview.chromium.org/6625046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just adds '(' and ')' to fix the build break on the clang bot caused by my 77444.
TBR=brettw
BUG=none
TEST=build chrome on clang.
Review URL: http://codereview.chromium.org/6647013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Libjpeg-turbo can use RGBA and BGRA pixels used by Chromium as its input or output. This change uses these converters to avoid memory copies when the output format is RGBA or BGRA.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6603010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add OVERRIDE keyword liberally to some relevant overrides.
Fix copyright dates.
BUG=75366
TEST=Omnibox clicking, etc.
Review URL: http://codereview.chromium.org/6648018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a serie of patches to make the TreeNode API more closer to style
used in the Views Tree API (see views/view.h for reference).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6626076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a serie of patches to make the TreeNode more closer to style
used in the Views Tree API (see views/view.h for reference).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6623037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=Manual mouse event testing.
Review URL: http://codereview.chromium.org/6591120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last param is for languages, which is already a std::string in
most places.
BUG=23581
Review URL: http://codereview.chromium.org/6627061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
Review URL: http://codereview.chromium.org/6541035
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6623055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
Review URL: http://codereview.chromium.org/6541035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugin.
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
X error handlers cannot safely make X calls inside the error handler. To provide more meaningful error messages, it is necessary to query the X server. This patch changes the X error handlers to post a task to decode and log the error message. This has a disadvantage of clearing the call stack,
but given that most X calls are processed asynchronously, the call stack typically isn't meaningful.
BUG=64819
TEST=by hand on Linux
Review URL: http://codereview.chromium.org/6623014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For classes deriving from both View and ContextMenuController, this
makes it clear which of method is overridden.
Rename TabController::ShowContextMenu to ShowContextMenuForTab for the same reason.
No intended functionality change.
BUG=70465,72205
TEST=none
TBR=beng
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They used to have the same name as methods in View. Some views would
derive from both View and DragController, which was confusing. For
example for clang's -Woverride-virtual.
No functionality change.
BUG=70465,72205
TEST=none
Review URL: http://codereview.chromium.org/6609033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6581010
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/6612035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6581010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, we can move the window right away.
BUG=74805
TEST=By hand on Linux with software rendering, WebGL, and 3D CSS.
Review URL: http://codereview.chromium.org/6613020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows loading of icons in the platform format, avoiding unnecessary
conversions if the image is going to be used with the platform toolkit. In other
cases, this just pushes image conversion to the callsite rather than the actual
image load.
BUG=19685
TEST=unit_tests and visual inspection of icons in the download shelf
Review URL: http://codereview.chromium.org/6597043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds streaming for CFStringRefs and CFErrorRefs making it
easier to add them to LOG() type statements.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/6594096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note that I didn't need to adjust many callers on the Windows
side because wstring and string16 are compatible on Windows.)
BUG=23581
Review URL: http://codereview.chromium.org/6596087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70296
TEST=See bug for exact steps.
Review URL: http://codereview.chromium.org/6594087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles; existing unit tests.
Review URL: http://codereview.chromium.org/6602049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
At the time of writing, everything compiles cleanly now.
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6597049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I thought doing a double comparison would work, but instead, switch
the HSL check to use the original RGB values rather than doubles.
This fixes a failure on the official builder:
ColorUtils.SkColorToHSLGrey:
ui/gfx/color_utils_unittest.cc:24: Failure
Value of: 0
Expected: hsl.s
Which is: 7.0206359180926512e-18
BUG=72256
Review URL: http://codereview.chromium.org/6588013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
country.
* Changes the country field to a <select> field.
* Restricts the possible values for the "country" field to a set of known values
* Moves the country field to the top of the Autofill dialog
* Changes the field labels according to the selected country
BUG=56599,56602,56604
TEST=
Review URL: http://codereview.chromium.org/6484022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just adds a virtual destructor to the ui::Transform class so scoped_ptr<ui::Transform>::~scoped_ptr() can call ui::TransformSkia::~TransformSkia().
BUG=74113
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/6595001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor RootView::OnMouseWheel and WidgetGtk::ProcessScroll.
Rename RootView's and MenuHostRootView's ProcessMouseWheelEvent to OnMouseWheel.
Merge event_x's GetMouseEventType into EventTypeFromNative and detect wheel events.
Update NativeWidgetWin::MakeMSG and WidgetWin::MakeMSG.
Add some needed support functions.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6469106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we were truncating the values when we should have
been rounding.
Also loosen some checks for comparing doubles.
BUG=72256
Review URL: http://codereview.chromium.org/6575016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added and updated API for converting points between views' coordinate systems,
taking transformations into consideration. This in turn gives us, for free,
transformation for located events (mouse events, touch events).
BUG=none
TEST=ViewTest.TransformEvent
Review URL: http://codereview.chromium.org/6534015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an NSImage.
This should have marginal performance gains for Mac. Instead of loading into a
Skia-backed gfx::Image, which then converts to get an NSImage representation,
this will load directly to an NSImage-backed gfx::Image.
BUG=carnitas
TEST=All UI images load and look correct.
Review URL: http://codereview.chromium.org/6543016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds the reduced test cases for Bug 72399 to gfx_unittests so we can run them.
BUG=72399
TEST=JPEGCodec.InvalidRead
Review URL: http://codereview.chromium.org/6478021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust the expected result for the display name of es-419. It does not have
'Carribean Islands' any more in the English display name. Also, swap
two parameters of EXPECTED_EQ so that the 1st param is 'expected' and
the 2nd is 'actual' in two tests in l10n_util_unittest.cc
In addition, change icu_string_conversions.cc to fix the failure
of ICUStringConversionsTest.ConvertCodepageUTF8.
The test uses WideToCodepage that calls u_strFromWCS. Where
U_WCHAR_IS_UTF32 is defined, it calls u_strFromUTF32. On Mac,
it's not defined because neither __STDC_ISO_10646__ nor _UCS4_ is defined.
As a result, wcstombs is called, which doesn't work as we want it to.
There are two ways to fix this:
- Directly call u_strFromUTF32 on Mac/Linux. What this CL does.
- Manually define U_WCHAR_IS_UTF32 in icu's pmac.h, which is done
in http://codereview.chromium.org/6578003
We do both to be block wcs*mbs/mbs*wcs from being called in other parts
of ICU when U_WCHAR_IS_UTF32 is not defined.
BUG=61514
TEST=Build goes fine and tests pass.
Review URL: http://codereview.chromium.org/6532030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't include the container type ("vector") in the typedef for "a bunch of children". Users generally should not know or care what the container is, so this makes reading easier as the code is not constantly pointing out to you, "hey! I'm a vector!" Added bonus: less verbose, allows condensing a lot of loop declarations onto one line.
* Consistently put getters before setters.
* Remove 4-arg form of SetBounds() and make people use Rects (we should move the codebase towards Points, Sizes, and Rects wherever possible).
* Use "origin" instead of "position" to be consistent with Rect's terminology.
* Minor naming changes, e.g. GetViewById() -> GetViewByID().
* Remove const qualifier on member functions that are not logically const. This also got rid of all the const_cast<>()s.
* Better comments.
* Use const ref args for Views whenever the provided View is not being modified, to make that obvious to the caller.
* Turn some accessors into pairs of (non-const, const) accessors. In these cases make the non-const version call the const version. (GetWidget() does this in the header because the const version is virtual; this way people who override the const version can see why they don't need to override the non-const version).
* Make RemoveChildView() take a bool for consistency with RemoveAllChildViews() (also eliminates the need to return a View*).
* Add STL-style iterators and rename a few accessors to match STL terminology ("size" instead of "count").
* Turn IsFocusable() into a cheap inline getter.
* Greatly simplify private tree ops ("NotifyHierarchyChangedXXX()") by realizing that they were always being called with |parent| == |this|.
* Declare iterators inside loops, not above them.
* Standardize iterator naming to |i|. The existing code wasn't always consistent, and while there's nothing wrong with |it|, using that would have made almost every loop declaration into two lines instead of one.
* Simpler code, sometimes by using STL algorithms.
* Unindent via early-returns.
* Use CHECK_NE() and similar where possible.
* Fix memory corruption in RemoveAllChildViews() due to using an iterator after modifying its container.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/6526027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the definition of GetNativeImageNamed to return a gfx::Image and
adds GetImageNamed in addition. GetBitmapNamed now goes through that method. On
Linux, GetNativeImageNamed will load directly into a GdkPixbuf-backed Image. Mac
will still first load through Skia (a future CL will load directly into an
NSImage). All other platforms use Skia natively, so GetNativeImageNamed is the
same as GetImageNamed.
Mac was the only platform that used the old GetNativeImageNamed, so this also
transitions a bunch of Mac files by including ui/gfx/image.h.
This also obviates the need for platform-specific image caches in the
ResourceBundle, so there's some additional cleanup around that.
BUG=carnitas
TEST=All UI images in Chromium show up as before.
Review URL: http://codereview.chromium.org/6541031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6537024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
starting with tab_contents directory.In future changes the headers that include these files will be updated. Once all the files are moved (i.e. renderer_host, rest of browser, renderer etc), then refactoring can begin so that content\DEPS doesn't have chrome in it.
Review URL: http://codereview.chromium.org/6537015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having namespaces ui::gfx and just gfx are causing compiler disambiguation
problems. This will resolve that.
BUG=carnitas
TEST=compiles and gfx_unittests
Review URL: http://codereview.chromium.org/6533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the comment in font.h that incorrectly described the Mac memory
management for native font handles.
BUG=73148
TEST=Linux Valgrind
Review URL: http://codereview.chromium.org/6524042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=RectTest.SkRectToRect
Review URL: http://codereview.chromium.org/6525031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do this by adding an extra flag in MenuListExtraParams to
suppress the border in the same case that we don't draw it on
Windows. We also change ButtonExtraParams because paintMenuList
calls into paintButton.
BUG=41729
Review URL: http://codereview.chromium.org/6490014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added to the set of available extension APIs.
I also removed some of the plumbing associated with the popup api:
- Drop-shadow support removed from BrowserBubble. This had only been supported on Windows.
- Removed the ExtensionPopup::PopupChrome type. Only popups from the popup API supported rectangle chrome.
- Removed the activate-on-show parameter from ExtensionPopup. This was only used for the popup API. All popups activate on show, by default.
- Removed the AddRef/Release magic from ExtensionPopup. The API required these semantics because of the complex, asynchronous lifetime management required by the popup API. See ExtensionPopup::Observer::ExtensionPopupClosed.
- Removed unneeded methods from ExtensionPopup::Observer, and ExtensionFunctionDispatcher::Delegate.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6334101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6510011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last references to src/gfx/* have been updated so it's safe to delete the stub headers.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6474031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Clang gfx_unittest passes
Review URL: http://codereview.chromium.org/6502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This achieves the same goal as ScopedImage, namely encapsulating the memory
management of any image type. But ui::gfx::Image goes further by providing
conversion helpers between different image types.
BUG=carnitas
TEST=gfx_unittests and unit_tests
Review URL: http://codereview.chromium.org/6312159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6474016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing, moving the bits Mac uses to ui/base/events.h
BUG=72040
TEST=none
TBR=sky
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Key identifiers are more expressive than simple key codes. This patch
expands the target of the mapping to include modifier keys.
This also moves the key identifier conversion into the only directory from
which it is used.
BUG=none
TEST=unit test updated
Review URL: http://codereview.chromium.org/6264020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74227 0039d316-1c4b-4281-b951-d872f2087c98
|