summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Implement Clipboard::ReadImage on Linux.dcheng@chromium.org2011-04-201-3/+16
| | | | | | | | | | | | | I split the IPC up into two parts on Linux--one that reads the image on the UI thread, and a second part that encodes the image on the file thread before replying. I've also switched it to send the data over shared memory instead of passing a (potentially) huge blob of data over IPC. BUG=75237 TEST=Local testing. Review URL: http://codereview.chromium.org/6871001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82212 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for multi resolution iconssail@chromium.org2011-04-1913-35/+306
| | | | | | | | | | | | | | | | | | | | | | | | To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version. To support this, this change does the following: - split theme_resource.grd into three files: - theme_resources.grd: icons that only have one resolution - theme_resources_standard.grd: low resolution icons - theme_resources_large.grd: high resolution icons - theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms. - theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac) - gfx::Image now support icons with multiple resolution Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go. Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that. BUG=75812 TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed. Review URL: http://codereview.chromium.org/6849030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
* Progress towards fixing 77536backer@chromium.org2011-04-193-2/+27
| | | | | | | | | | | | | This first thing this CL does is plumbs through the surface that the GPU will eventually render to very early on (with the ViewMsg_New and ViewMsg_CreateNew IPCs). Previously, these surfaces were acquired at the time that GPU got a request for a command buffer. This required mediation by the browser UI thread. With this CL, we pre-acquire the surfaces so that they can be passed with the request for the command buffer. This will allow us to handle the request on the browser IO thread. The second thing this CL does is change the surface management a bit. When surfaces were acquired and released when command buffers were created and destroyed, the GPU process host was natural manager of surfaces. This pushes the management further down into the RWHV level and GtkNativeViewManager (on Linux). It fixes a minor resource leak. BUG=first stage of 77536 TEST=By hand WebGL, 3D CSS, Pepper 3D on Linux, Windows, and Mac. Review URL: http://codereview.chromium.org/6840060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82165 0039d316-1c4b-4281-b951-d872f2087c98
* Change Clipboard::ReadImage to return a bitmap.dcheng@chromium.org2011-04-195-81/+41
| | | | | | | | | | | | This allows the PNG compression to be offloaded to another thread as appropriate. BUG=75237 TEST=Local testing. Review URL: http://codereview.chromium.org/6835036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82142 0039d316-1c4b-4281-b951-d872f2087c98
* Centralizes checking for non-null return from CreateWindow.sky@chromium.org2011-04-193-17/+25
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6880034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82137 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens if we fail to mmap resources.pak.tony@chromium.org2011-04-195-4/+51
| | | | | | | | | | | | | | | | | The crash happens if mmap_ is null in DataPack so I just added some null checks. Some features still won't work (inspector, bookmark manager, about:net-internals, etc), but we shouldn't crash. I'm going to write a follow up patch that brings up a dialog asking to reinstall and check for quarantined files if resources.pak fails to load (kind of like the dialog that comes up when the history db can't be loaded). BUG=79252 TEST=covered by app_unittests Review URL: http://codereview.chromium.org/6835034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix osmesa lib path regression in Linux introduced in r82008.zmo@google.com2011-04-191-4/+9
| | | | | | | | | BUG=none TEST=a few webgl tests in linux turns green TBR=evan@chromium.org Review URL: http://codereview.chromium.org/6873060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82043 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 81998 - Split OSMesa implementations of *GLContext into ↵apatrick@chromium.org2011-04-189-240/+210
| | | | | | | | | GLContextOSMesa and *GLSurfaceOSMesa.Surfaces are independent of contexts in GL. To facilitate sharing of surfaces between processes, I have separated them from the notion of contexts because contexts cannot be shared between processes.I started with EGL in r81512 and WGL in r81807. This is the same thing for OSMesa.GLContextOSMesa still has a pointer to a surface and still has some surface specific operations that just forward through to it. Once I have refactored all the GLContext implementations in this way, I will remove these pointers and the surface specific opertations.There will not be "view" and "offscreen" GL contexts. Rather there will be a single context type for each backend which can be made current with a surface that directs output either to a view or offscreen surface.TEST=WebGL locally, tryBUG=noneReview URL: http://codereview.chromium.org/6864031 TBR=kbr@chromium.org Review URL: http://codereview.chromium.org/6882030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82023 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't always print dlopen errors from LoadNativeLibraryevan@chromium.org2011-04-183-28/+26
| | | | | | | | | | | Instead, return them to the caller and let the caller decide whether the error is worth notifying the user about. BUG=79068 Review URL: http://codereview.chromium.org/6864020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82008 0039d316-1c4b-4281-b951-d872f2087c98
* Split OSMesa implementations of *GLContext into GLContextOSMesa and ↵apatrick@chromium.org2011-04-189-210/+240
| | | | | | | | | | | | | | | | | | *GLSurfaceOSMesa. Surfaces are independent of contexts in GL. To facilitate sharing of surfaces between processes, I have separated them from the notion of contexts because contexts cannot be shared between processes. I started with EGL in r81512 and WGL in r81807. This is the same thing for OSMesa. GLContextOSMesa still has a pointer to a surface and still has some surface specific operations that just forward through to it. Once I have refactored all the GLContext implementations in this way, I will remove these pointers and the surface specific opertations. There will not be "view" and "offscreen" GL contexts. Rather there will be a single context type for each backend which can be made current with a surface that directs output either to a view or offscreen surface. TEST=WebGL locally, try BUG=none Review URL: http://codereview.chromium.org/6864031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81998 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 81965 - Progress towards fixing 77536This first thing this CL does is ↵backer@chromium.org2011-04-182-20/+1
| | | | | | | | | plumbs through the surface that the GPU will eventually render to very early on (with the ViewMsg_New and ViewMsg_CreateNew IPCs). Previously, these surfaces were acquired at the time that GPU got a request for a command buffer. This required mediation by the browser UI thread. With this CL, we pre-acquire the surfaces so that they can be passed with the request for the command buffer. This will allow us to handle the request on the browser IO thread.The second thing this CL does is change the surface management a bit. When surfaces were acquired and released when command buffers were created and destroyed, the GPU process host was natural manager of surfaces. This pushes the management further down into the RWHV level and GtkNativeViewManager (on Linux). It fixes a minor resource leak.BUG=first stage of 77536TEST=By hand WebGL, 3D CSS, Pepper 3D on Linux, Windows, and Mac.Review URL: http://codereview.chromium.org/6840060 TBR=backer@chromium.org Review URL: http://codereview.chromium.org/6878021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81974 0039d316-1c4b-4281-b951-d872f2087c98
* Progress towards fixing 77536backer@chromium.org2011-04-182-1/+20
| | | | | | | | | | | | | This first thing this CL does is plumbs through the surface that the GPU will eventually render to very early on (with the ViewMsg_New and ViewMsg_CreateNew IPCs). Previously, these surfaces were acquired at the time that GPU got a request for a command buffer. This required mediation by the browser UI thread. With this CL, we pre-acquire the surfaces so that they can be passed with the request for the command buffer. This will allow us to handle the request on the browser IO thread. The second thing this CL does is change the surface management a bit. When surfaces were acquired and released when command buffers were created and destroyed, the GPU process host was natural manager of surfaces. This pushes the management further down into the RWHV level and GtkNativeViewManager (on Linux). It fixes a minor resource leak. BUG=first stage of 77536 TEST=By hand WebGL, 3D CSS, Pepper 3D on Linux, Windows, and Mac. Review URL: http://codereview.chromium.org/6840060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81965 0039d316-1c4b-4281-b951-d872f2087c98
* Removes code added to track down crash. The crash seems to havesky@chromium.org2011-04-153-19/+1
| | | | | | | | | | | | | | | | | | | | occurred for two reasons: . window class name changing out from under us. . CreateWindow returning NULL because we're out of memory. I've changed the following: . Left in CHECK on return from CreateWindow. . Removed dependency on class name. We don't really need it anyway. I've also changed View::PaintFocusableBorder to check focusable last, as that requires looking up the FocusManager BUG=77651 TEST=none Review URL: http://codereview.chromium.org/6865023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81812 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Clipboard::ReadAvailableTypes for Linux.dcheng@chromium.org2011-04-151-17/+18
| | | | | | | | | BUG=75237 TEST=Local testing. Review URL: http://codereview.chromium.org/6825064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81809 0039d316-1c4b-4281-b951-d872f2087c98
* Split WGL implementations of *GLContext in GLContextWGL and *GLSurfaceWGL.apatrick@chromium.org2011-04-158-474/+567
| | | | | | | | | | | | | Surfaces are independent of contexts in GL. To facilitate sharing of surfaces between processes, I have separated them from the notion of contexts because contexts cannot be shared between processes. I started with EGL in r81512. This is the same thing for WGL. GLContextEGL still has a pointer to a surface and still has some surface specific operations that just forward through to it. Once I have refactored all the GLContext implementations in this way, I will remove these pointers and the surface specific opertations. There will not be "view" and "offscreen" GL contexts. Rather there will be a single context type for each backend which can be made current with a surface that directs output either to a view or offscreen surface. Review URL: http://codereview.chromium.org/6864002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81807 0039d316-1c4b-4281-b951-d872f2087c98
* Some style changes (for readability).sadrul@chromium.org2011-04-141-12/+25
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6675048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81623 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unintended zh_hant_hk in the login language menu: take 2mazda@chromium.org2011-04-142-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | BUG=chromium-os:13117 TEST=at login screen show the language list and check that Chinese(Traditional Han, Hong Kong) is not displayed. In the current version of third_party/icu/source/data/locale/zh*, zh_hant_hk, zh_hant_mo, and zh_hans_sg is aliased in addtion to zh_hans_cn and zh_hant_tw. So this patch adds checks for them in IsDuplicateName. The patch fixes another tiny problem related to locale names; in CheckAndResolveLocale, zh-mk should be zh-mo. See: http://en.wikipedia.org/wiki/ISO_3166-2:MO (Macau) http://en.wikipedia.org/wiki/ISO_3166-2:MK (Macedonia) I'm sorry that the previous patch http://codereview.chromium.org/6835017/ broke an unittest (which asserts zh-mk is resolved to zh-tw, but it shouldn't). This new patch includes an adjustment of the unittest, too. Review URL: http://codereview.chromium.org/6840045 Patch from Kazuhiro Inaba <kinaba@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81534 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Delete unintended occurrence of zh_hant_hk in the login language menu"mazda@chromium.org2011-04-141-5/+2
| | | | | | | | This reverts commit 6060502aa52b752f488f98a800e1f886f3ffd7c1. TBR=kinaba@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81529 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak text with halo to avoid truncated "J".falken@chromium.org2011-04-141-2/+2
| | | | | | | | | BUG=chromium-os:13729 TEST=manually Review URL: http://codereview.chromium.org/6837017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81528 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unintended occurrence of zh_hant_hk in the login language menumazda@chromium.org2011-04-141-2/+5
| | | | | | | | | | | | | | | | | | | BUG=chromium-os:13117 TEST=at login screen show the language list and check that Chinese(Traditional Han, Hong Kong) is not displayed. In the current version of third_party/icu/source/data/locale/zh*, zh_hant_hk, zh_hant_mo, and zh_hans_sg is aliased in addtion to zh_hans_cn and zh_hant_tw. So this patch adds checks for them in IsDuplicateName. The patch fixes another tiny problem related to locale names; in CheckAndResolveLocale, zh-mk should be zh-mo. Review URL: http://codereview.chromium.org/6835017 Patch from Kazuhiro Inaba <kinaba@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81526 0039d316-1c4b-4281-b951-d872f2087c98
* Split EGLContext in GLContextEGL and GLSurfaceEGL.apatrick@chromium.org2011-04-1411-454/+557
| | | | | | | | | | | | | | Surfaces are independent of contexts in GL. To facilitate sharing of surfaces between processes, I have separated them from the notion of contexts because contexts cannot be shared between processes. I have started with EGL. GLContextEGL still has a pointer to a surface and still has some surface specific operations that just forward through to it. Once I have refactored all the GLContext implementations in this way, I will remove these pointers and the surface specific opertations. There will not be "view" and "offscreen" GL contexts. Rather there will be a single context type for each backend which can be made current with a surface that directs output either to a view or offscreen surface. TEST=try, WebGL puppy works BUG=none Review URL: http://codereview.chromium.org/6839008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81512 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Clipboard::ReadImage for Windows.dcheng@chromium.org2011-04-132-0/+75
| | | | | | | | | BUG=75237 TEST=Local HTTP testing with data-transfer-items-image-png.html Review URL: http://codereview.chromium.org/6824063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81508 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in unit test.dcheng@chromium.org2011-04-131-1/+1
| | | | | | | | | | BUG=75237 TEST=ui_unittests --gtest_filter=PNGCodec.* TBR=tony@chromium.org Review URL: http://codereview.chromium.org/6852003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81497 0039d316-1c4b-4281-b951-d872f2087c98
* Allow caller to specify compression level of PNGs.dcheng@chromium.org2011-04-134-9/+86
| | | | | | | | | | | BUG=75237 TEST=ui_unittests --gtest_filter=PNGCodec.EncodeDecodeWithVaryingCompressionLevels Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81481 Review URL: http://codereview.chromium.org/6834011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81495 0039d316-1c4b-4281-b951-d872f2087c98
* [Reason for revert: checkdeps failure in png_codec_unittest.cc]nick@chromium.org2011-04-133-85/+9
| | | | | | | | | | Revert 81481 - Allow caller to specify compression level of PNGs. BUG=75237 TEST=ui_unittests --gtest_filter=PNGCodec.EncodeDecodeWithVaryingCompressionLevelsReview URL: http://codereview.chromium.org/6834011 TBR=dcheng@chromium.org Review URL: http://codereview.chromium.org/6838033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81486 0039d316-1c4b-4281-b951-d872f2087c98
* Allow caller to specify compression level of PNGs.dcheng@chromium.org2011-04-133-9/+85
| | | | | | | | | BUG=75237 TEST=ui_unittests --gtest_filter=PNGCodec.EncodeDecodeWithVaryingCompressionLevels Review URL: http://codereview.chromium.org/6834011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81481 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GLContext::LosesAllContextsOnContextLost.amarinichev@chromium.org2011-04-132-0/+19
| | | | | | | | | | | | | | | GLContext::LosesAllContextsOnContextLost specifies whether or not all contexts need to be destroyed when recovering from lost context condition. GpuCommandBufferStub::OnFlush and GpuCommandBufferStub::OnAsyncFlush will instruct soon-to-be-renamed GpuRenderThread to close all channels when the context is lost and LosesAllContextsOnContextLost returns true. From the EGL 1.4 spec: "...On detection of this error, the application must destroy all contexts (by calling eglDestroyContext for each context). To continue rendering the application must recreate any contexts it requires, and subsequently restore any client API state and objects it wishes to use." However even with this change Angle still doesn't recover correctly. BUG=76753 TEST=breakpoint on eglDestroyContext Review URL: http://codereview.chromium.org/6813010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81437 0039d316-1c4b-4281-b951-d872f2087c98
* Adds yet more debugging code.sky@chromium.org2011-04-131-2/+19
| | | | | | | | | | BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6834006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81363 0039d316-1c4b-4281-b951-d872f2087c98
* Nonelaforge@chromium.org2011-04-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81351 0039d316-1c4b-4281-b951-d872f2087c98
* Nonelaforge@chromium.org2011-04-1351-39/+90
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81345 0039d316-1c4b-4281-b951-d872f2087c98
* Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h.tfarina@chromium.org2011-04-125-23/+23
| | | | | | | | | | | | | | | | | Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
* step 3 of native theme refactoringrogerta@chromium.org2011-04-123-180/+196
| | | | | | | | | | | | | | Moved all calls to old menu drawing api to new NativeTheme::Paint(). Moved all calls to old push/radio/check button api to new NativePaint::Paint(). BUG=None TEST=Affects windows platform only. All menus in chrome, such as wrench menu, should look and behave as before, with no change. All pushbuttons, radiobuttons, and checkbox in web page forms should look and behave as before. Review URL: http://codereview.chromium.org/6825007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in new fade tab title codesail@chromium.org2011-04-121-11/+9
| | | | | | | | | | | | | My fade tab title code was leaking a HFONT everytime a tab title was drawn. I think this leak is what's causing the CreateDIBSection() call to fail. BUG=78857 TEST=Reproduced the original bug by opening lots of tabs. Applied my fix and verified that I could no longer reproduce the bug. Review URL: http://codereview.chromium.org/6813098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81207 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement rough global menu support behind an about:flags flag.erg@google.com2011-04-111-1/+1
| | | | | | | | | | | | | | | This is a super early first cut of global menu support. It works by creating a GtkMenuBar inside chrome, attaching it to the widget hierarchy and then never showing it. This is sufficient for global menu support to detect the menu, at least on the Natty betas. There's a lot to do before this is considered done. I haven't added Bookmark and History menus, which will need custom handling to keep state up to date with the main window. Some items may need to be moved from one menu to another to fit with Linux conventions. Contains a bunch of new strings for global menu support. These need to go in before the M12 branch point. (I can iterate on the design afterwards; strings need translation.) BUG=30213 TEST=Open a window on Unity. A minimal menu is in the menu bar. Review URL: http://codereview.chromium.org/6812037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81170 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Most commonsky@chromium.org2011-04-111-2/+4
| | | | | | | | | | | | | | | | reason for crash appears to be because we can't find the WindowWin for an hwnd. I'm also removing a comment that is no longer relevant, and nuking a call in window_win to ui::SetWindowUserData that is already done in WindowImpl. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6825045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81150 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate skia::PlatformCanvas - Step 1 (linux)alokp@chromium.org2011-04-117-67/+59
| | | | | | | Patch corresponding to r80955 on linux. Review URL: http://codereview.chromium.org/6813050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81099 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in fade tab title changesail@chromium.org2011-04-091-5/+12
| | | | | | | | | | | | | | | | | | The fade tab title change is causing the browser to crash on some computers. It looks like the problem is in BitmapPlatformDevice::create(). For some reason it's returning NULL. This change just adds a NULL check and falls back to the old drawing code. Once this is checked in I'll investigate what the root cause is. BUG=78857 TEST=Compiled and ran. Review URL: http://codereview.chromium.org/6823020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81026 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Clipboard::ReadAvailableTypes for Windows.dcheng@chromium.org2011-04-091-1/+6
| | | | | | | | | BUG=none TEST=manual testing Review URL: http://codereview.chromium.org/6820023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81025 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Clipboard::ReadAvailableTypes for Mac.dcheng@chromium.org2011-04-083-1/+15
| | | | | | | | | BUG=75237 TEST=Local testing. Review URL: http://codereview.chromium.org/6823019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81015 0039d316-1c4b-4281-b951-d872f2087c98
* Retrieve a larger favicon when availablesaintlou@chromium.org2011-04-081-1/+5
| | | | | | | | | | | | | No longer scale/stretch smaller favicons BUG=none TEST=none Review URL: http://codereview.chromium.org/6816031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80979 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate skia::PlatformCanvas, a subclass of SkCanvas. Skia provides ↵alokp@chromium.org2011-04-082-10/+8
| | | | | | | | | | | | | | | | multiple types of SkCanvas classes that we would like to use. Unfortunately these classes are implemented as subclasses of SkCanvas. Subclassing SkCanvas in both Skia and Chromium makes it impossible to dynamically use any SkCanvas. There is also no reason for chromium to subclass SkCanvas. Most of the extra functionalities can be implemented by hanging meta-data from SkCanvas. We cannot eliminate skia::PlatformCanvas in one step due to WebKit's dependency on skia::PlatformCanvas. WebKit::WebCanvas is typedef as skia::PlatformDevice. It should be SkCanvas. So we need to do it in multiple steps: 1. Prepare Chromium tree for the change in WebKit::WebCanvas tyepdef. This basically means adding a couple of static_cast<skia::PlatformCanvas>(WebCanvas). 2. Change WebKit::WebCanvas typedef from skia::PlatformCanvas to SkCanvas 3. Eliminate skia::PlatformCanvas in chromium This CL accomplishes the first step on windows. WebKit BUG=https://bugs.webkit.org/show_bug.cgi?id=57563 Review URL: http://codereview.chromium.org/6783023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80955 0039d316-1c4b-4281-b951-d872f2087c98
* fix titlebar color for WMs that don't tell us about active windows.estade@chromium.org2011-04-082-14/+24
| | | | | | | | | | | also fix some style problems with ActiveWindowWatcherX BUG=78634 TEST=manual Review URL: http://codereview.chromium.org/6814006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80949 0039d316-1c4b-4281-b951-d872f2087c98
* Use EXPECT_DOUBLE_EQ for floating point tests.mmoss@chromium.org2011-04-081-4/+4
| | | | | | | | | | | | | | | | | | This fixes multiple test failures on the new Lucid bots, like: MultiAnimationTest.Basic: ui/base/animation/multi_animation_unittest.cc:32: Failure Value of: animation.GetCurrentValue() Actual: 0.36 Expected: Tween::CalculateValue(Tween::EASE_OUT, .2) Which is: 0.36 BUG= TEST=Fix printing_unittests, app_unittests, and gfx_unittests on new Lucid official builder. Review URL: http://codereview.chromium.org/6811036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80940 0039d316-1c4b-4281-b951-d872f2087c98
* Fade tab titlessail@chromium.org2011-04-082-4/+299
| | | | | | | | | | | | | | | | | | | | This change fades tab titles instead of truncating them with a "...". I tried to copy the Mac implemenation from here: http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m but my version is not as good since I couldn't figure out how to draw text on a transparent background. BUG=69301 TEST=Ran Chromium and verified that things looked ok. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80870 Review URL: http://codereview.chromium.org/6695043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80891 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80870 - Fade tab titlesThis change fades tab titles instead of ↵sail@chromium.org2011-04-082-299/+4
| | | | | | | | | truncating them with a "...".I tried to copy the Mac implemenation from here:http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.mbut my version is not as good since I couldn't figure out how to draw text on a transparent background.BUG=69301TEST=Ran Chromium and verified that things looked ok.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748Review URL: http://codereview.chromium.org/6695043 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6815022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80871 0039d316-1c4b-4281-b951-d872f2087c98
* Fade tab titlessail@chromium.org2011-04-072-4/+299
| | | | | | | | | | | | | | | | | | | This change fades tab titles instead of truncating them with a "...". I tried to copy the Mac implemenation from here: http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m but my version is not as good since I couldn't figure out how to draw text on a transparent background. BUG=69301 TEST=Ran Chromium and verified that things looked ok. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748 Review URL: http://codereview.chromium.org/6695043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80870 0039d316-1c4b-4281-b951-d872f2087c98
* Step 2 in refactoring NativeThemeWinrogerta@chromium.org2011-04-075-175/+86
| | | | | | | | | | | | | | Making the linux and chromeos native theme classes derive from the new base class added earlier. BUG=None TEST=None R=xiyuan@chromium.org Review URL: http://codereview.chromium.org/6803022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80850 0039d316-1c4b-4281-b951-d872f2087c98
* Removing uneeded test. Because of the native theme cleanup, the methodrogerta@chromium.org2011-04-071-18/+0
| | | | | | | | | | | | being called here is going away anyway. TEST=None BUG=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6801025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80783 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80748 - Fade tab titlesThis change fades tab titles instead of ↵sail@chromium.org2011-04-072-299/+4
| | | | | | | | | truncating them with a "...".I tried to copy the Mac implemenation from here:http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.mbut my version is not as good since I couldn't figure out how to draw text on a transparent background.BUG=69301TEST=Ran Chromium and verified that things looked ok.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416Review URL: http://codereview.chromium.org/6695043 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6815004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80749 0039d316-1c4b-4281-b951-d872f2087c98
* Fade tab titlessail@chromium.org2011-04-072-4/+299
| | | | | | | | | | | | | | | | | | This change fades tab titles instead of truncating them with a "...". I tried to copy the Mac implemenation from here: http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m but my version is not as good since I couldn't figure out how to draw text on a transparent background. BUG=69301 TEST=Ran Chromium and verified that things looked ok. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416 Review URL: http://codereview.chromium.org/6695043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80748 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 12:22:48 +0000