summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* General Focus/Activation/Keyboard input fixes for Aura Desktop. ananta@chromium.org2012-10-254-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Saw these issues while running Chrome Aura in desktop mode. 1. Focus issues:- A. When desktop chrome is launched we set focus to the content window. This ensures that keystrokes like backspace, etc make it through to the omnibox if it has focus. B. When we click on the WebView focus should transition away reliably from the omnibox to the WebView. This was not happening because the DesktopActivationClient class which implements the ActivationClient interface returns false in its DesktopActivationClient::CanActivateWindow implementation where it only allows activation if the window is a child of the root window which is not the case for the HTML page WebView window. C. Clicking back on the omnibox when the page has focus caused a bug whereby both views ended up showing the blinking cursor. Keyboard focus was with the omnibox though. This was because we save away the last focused view in the aura::client::ActivationDelegate::OnLostActive notification which is too late in the process. The new view which is already focused by that point. Fix is to save away the focused view in the OnBlur notification which happens before the new window is activated. 2. Text field selection:- When we lose focus in a text field we should clear the selection. 3. Infinite loop while processing keyboard input:- The DesktopNativeWidgetAura::OnKeyEvent calls the GetWidget()->GetInputMethod()->DispatchKeyEvent function which causes the keyboard input to be sent back to the DesktopNativeWidgetAura::OnKeyEvent class which causes an infinite loop. We should pass the keyboard event to the underlying native widget delegate. BUG=none R=beng Review URL: https://codereview.chromium.org/11234015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163974 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using "FE" (Unspecified Text) for extracting display names.mukai@chromium.org2012-10-251-14/+0
| | | | | | | | | | | I thought it seems useful, but it is not so good actually with some devices. See the bug for the details. BUG=157672 Review URL: https://chromiumcodereview.appspot.com/11275016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163964 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of bugs related to window sizing:sky@chromium.org2012-10-241-1/+2
| | | | | | | | | | | | | | | | . Make RenderWidgetHostViewAura pass down the work area. . Makes ash force the window to no bigger than the work area. The last one is a bit dubious and may bite us at some point, but it seems we should enforce some constraint. BUG=155629 TEST=covered by tests R=ben@chromium.org,oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/11253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163940 0039d316-1c4b-4281-b951-d872f2087c98
* gesture recognizer: Improve multi-finger scrolling.sadrul@chromium.org2012-10-243-33/+49
| | | | | | | | | | | | | | | | The patch includes several changes: * Make sure scroll-update events are generated properly during pinch. * Do not include radius in the bounding box for multi-finger gestures, because change in radius can be too large and overshadow the actual location change of the finger. * Reduce the amount a finger needs to scroll before pinch/scroll-update events are generated during a multi-finger gesture. BUG=151230,151153 Review URL: https://codereview.chromium.org/11274015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163925 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GestureRecognizerTest.GestureEventLongPress on Windowsszym@chromium.org2012-10-241-1/+8
| | | | | | | | BUG=157596 Review URL: https://codereview.chromium.org/11260020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove implicit conversion from SkBitmap to ImageSkiapkotwicz@chromium.org2012-10-242-4/+2
| | | | | | | | | | | BUG=154727 Test=None R=rsesek TBR=sky,jam Review URL: https://chromiumcodereview.appspot.com/11099010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163848 0039d316-1c4b-4281-b951-d872f2087c98
* desktop linux aura: Fix event/capture focus after dragging a window.erg@chromium.org2012-10-247-8/+24
| | | | | | | | | | | | | | Both linux_aura versions have had a persistent problem where if you drag a tab out of a window, you have to click on either window to get mouse input working in the web content area. This is because the RootWindow still thinks a mouse drag is in progress. BUG=146077 Review URL: https://chromiumcodereview.appspot.com/11189148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163742 0039d316-1c4b-4281-b951-d872f2087c98
* Sets the proper device scale factor on iOS.rohitrao@chromium.org2012-10-235-15/+53
| | | | | | | | | | | | | | iOS sets a single supported scale factor at runtime, either 100P or 200P depending on whether the device is hidpi. This CL also corrects some conversion methods that did not properly support 200P scale factors. BUG=None TEST=Image unittests all pass on hidpi devices. Review URL: https://chromiumcodereview.appspot.com/11233040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163725 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BubbleDelegateView and HWNDMessageHandler focus issue.msw@chromium.org2012-10-233-9/+40
| | | | | | | | | | | | | | | | | | | | Remove BubbleDelegateView's explicit SetFocusedView() call. ( workaround for old focus problems from http://crrev.com/108167 ) Have HWNDMessageHandler::Show() call ShowWindowWithState(). ( calls needed HWNDMessageHandlerDelegate::HandleInitialFocus() ) Add a BubbleDelegateViewTest.InitiallyFocusedView unit test with TODO. ( demonstrates a bug with the workaround for http://crbug.com/125976 ) This fixes BookmarkBubbleView's title textfield focus for native textfields. ( but does not fix the issue for the experimental NativeTextfieldViews ) ( nixing the NativeWidgetWin::RestoreFocusOnActivate() workaround does ) BUG=145732,125976 TEST=Bookmark bubble initially focuses the title textfield. Review URL: https://chromiumcodereview.appspot.com/10908233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163721 0039d316-1c4b-4281-b951-d872f2087c98
* Add message center close button to ui/resourcesstevenjb@chromium.org2012-10-232-0/+0
| | | | | | | | | | | Assets for http://codereview.chromium.org/11229022/ BUG=150872 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11233066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163714 0039d316-1c4b-4281-b951-d872f2087c98
* Add a mechanism to provide non-linear scaling of fling acceleration.rjkroege@chromium.org2012-10-231-3/+55
| | | | | | | | | | | | | | touchscreen fling is too slow at high velocities. This patch addes a facility to permit adjusting the fling acceleration multiplier differently across a uniform range of fling velocities so that fast flings can go extra fast and slow flings will be gentle. BUG=141653 Review URL: https://chromiumcodereview.appspot.com/11231018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163693 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Starts touch drag via long press.xiyuan@chromium.org2012-10-233-35/+24
| | | | | | | | | | | | | | | Touch drag starts on long press event and context menu shows up if no drag actually happens. BUG=117090 TEST=Manual per description above. R=sadrul@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11232052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163685 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of "work on separate browser contexts"scottmg@chromium.org2012-10-238-40/+15
| | | | | | | | | | | | | | | | A couple tests fixed up from http://codereview.chromium.org/11146023 Always start up in --desktop-aura mode now, and open ash from tools menu. - Implement host_desktop.cc and plumb a few places that need context to determine which style of desktop it belongs to. - Remove --desktop-aura, --open-ash, --enable-ash TBR=ben@chromium.org, jam@chromium.org BUG=133312 Review URL: https://chromiumcodereview.appspot.com/11227057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163664 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ChromeOS touch layout code.flackr@chromium.org2012-10-233-38/+12
| | | | | | | | | | | We have been using a single unified layout for a while and don't seem to have any issues. The ChromeOS layout touch code has been unused for a while. BUG=142661 Review URL: https://chromiumcodereview.appspot.com/11229058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163657 0039d316-1c4b-4281-b951-d872f2087c98
* linux desktop aura: Write a minimal, fake implementation of SetCapture.erg@chromium.org2012-10-234-33/+68
| | | | | | | | | | | | | | | | | | | | | This makes menu close when you click on another chrome window. (It already worked when you clicked on a non-chrome window since the activation chagnge closed the menu.) Along the way: - DesktopRootWindowHostLinux now does some minimal event redirection. - Fix aura::Event so converting the event |location| also converts the |root_location|. - Use ScreenPositionClient as the implementation of Window::ConvertPointToTarget; it's wrong outside of a specific case in chromeos. BUG=146077 Review URL: https://chromiumcodereview.appspot.com/11184047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163649 0039d316-1c4b-4281-b951-d872f2087c98
* Adding command line flags for calibrationskuhne@chromium.org2012-10-233-41/+78
| | | | | | | | | BUG=144639 Review URL: https://chromiumcodereview.appspot.com/11190056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163639 0039d316-1c4b-4281-b951-d872f2087c98
* Make gfx::Rect class operations consistently mutate the class they are ↵danakj@chromium.org2012-10-2327-130/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | called on. Currently some methods mutate the class, and some return a new value, requiring API users to know what kind of method they are calling each time, and making inconsistent code. For example: gfx::Rect rect; rect.Inset(1, 1, 1, 1); rect = rect.Intersect(other_rect); rect.Offset(1, 1); Instead of: gfx::Rect rect; rect.Inset(1, 1, 1, 1); rect.Intersect(other_rect); rect.Offset(1, 1); We could go either way - making the class immutable or all methods return a new instance - but I believe it is better to instead make all methods mutate the class. This allows for shorter lines of code by avoiding having to repeat the object's name twice in order to change it. This patch changes gfx::Rect classes and all the callsites that uses these methods. It should make no change in behaviour, so no new tests added. R=sky BUG=147395 Review URL: https://codereview.chromium.org/11110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163579 0039d316-1c4b-4281-b951-d872f2087c98
* Store the dimensions of the first finger's enclosing rectangle when creating ↵tdanderson@chromium.org2012-10-233-1/+25
| | | | | | | | | | | | | | | | | | | | | | an ET_GESTURE_TWO_FINGER_TAP event We would like to be able to perform touch target fuzzing on the first finger of a two-finger tap gesture in the same way as a long press gesture. This CL stores the dimensions of the first finger's enclosing rectangle when creating a two-finger tap gesture so that this information can be available to WebKit. The previously-unused |delta_x| and |delta_y| values in GestureEventDetails are now used in plumbing the enclosing rectangle's width and height values. This depends on https://bugs.webkit.org/show_bug.cgi?id=99763 landing and being gardened in first. BUG=140024 Review URL: https://chromiumcodereview.appspot.com/11232033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 163414 - Always start up in --desktop-aura mode now, and open ash ↵szym@chromium.org2012-10-238-16/+40
| | | | | | | | | | | | | | | | | | | | from tools menu. (This broke win_aura on main waterfall.) - Implement host_desktop.cc and plumb a few places that need context to determine which style of desktop it belongs to. - Remove --desktop-aura, --open-ash, --enable-ash TBR=jam@chromium.org BUG=133312 Review URL: https://chromiumcodereview.appspot.com/11146023 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/11230058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163563 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Row move animation polishments.xiyuan@chromium.org2012-10-232-17/+36
| | | | | | | | | | | | | | | - Run animation for partially visible slots. - Skip animation to/from invisible slots; BUG=117090 TEST=Verify no ghost animation for prev/next page item when dragging over page switcher buttons. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11236045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163508 0039d316-1c4b-4281-b951-d872f2087c98
* Add methods to base::Thread to allow Windows consumers to ask for COM to be ↵pkasting@chromium.org2012-10-231-33/+2
| | | | | | | | | | | | intialized on the Thread. This makes one functional change: when COM is initialized in STA mode, the Thread is forced to use a TYPE_UI message loop. Most of the modified consumers here didn't previously do that, but after discussion with cpu and siggi, it seems safest, even though it's more heavyweight. BUG=none TEST=none Review URL: https://codereview.chromium.org/11048029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163503 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unintended debug trace.kochi@chromium.org2012-10-231-4/+0
| | | | | | | | | | | https://chromiumcodereview.appspot.com/11198078 BUG=157298 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/11175051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163490 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate duplicate COM and OLE initializations.pkasting@chromium.org2012-10-231-8/+0
| | | | | | | | | | This is take 2; the original patch ( http://crrev.com/159815 ), which only dealt with OLE, broke a few tests. The OneClickSignIn tests were skipping the RenderViewHostTestHarness SetUp() method, while the Accessibility tests directly muck with Widgets and thus have to manually init OLE. BUG=none TEST=Fewer "Multiple OleInitialize..." messages in tests Review URL: https://codereview.chromium.org/11031059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163470 0039d316-1c4b-4281-b951-d872f2087c98
* Changed action box menu background and border to match the rest of the menusyefim@chromium.org2012-10-233-32/+7
| | | | | | | | BUG=125307 Review URL: https://chromiumcodereview.appspot.com/11227028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163469 0039d316-1c4b-4281-b951-d872f2087c98
* Context menu for multiple launchersoshima@chromium.org2012-10-231-0/+4
| | | | | | | | | | | | | - move the code to create/open context menu from launcher to root window controller. - updated methods that access shelf/launcher state to take root window so that menu can specify on which display it is working on. BUG=145978, 155776 TEST=none Review URL: https://chromiumcodereview.appspot.com/11198078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163459 0039d316-1c4b-4281-b951-d872f2087c98
* Get text input to be plumbed through to the RenderWidgetHostViewAura ↵ananta@chromium.org2012-10-224-5/+41
| | | | | | | | | | | | | | instance on Windows in desktop mode. This is achieved by passing the InputMethod instance to the InputMethodWin class which handles text input. In the OnChar handling we look for the TextInputClient implementation on the focused view and on failing to find that we retrieve that from the InputMethod instance. BUG=157172 R=ben Review URL: https://codereview.chromium.org/11228032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163446 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly empty the pipes on teardown to prevent cross process races.backer@chromium.org2012-10-221-0/+2
| | | | | | | | | | When running with --use-gl=osmesa on desktop linux builds, it's important to XSync in GPU process before firing an IPC to the browser in ~GpuCommandBufferStub. Otherwise, there may be X commands for the window pending when the browser destroys the associated X window. BUG=155834 Review URL: https://chromiumcodereview.appspot.com/11230036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163431 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed menu icon position to be centered between a gutter and left menu border.yefim@chromium.org2012-10-221-4/+7
| | | | | | | | | BUG=156883 Review URL: https://chromiumcodereview.appspot.com/11230032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163426 0039d316-1c4b-4281-b951-d872f2087c98
* Always start up in --desktop-aura mode now, and open ash from tools menu.scottmg@chromium.org2012-10-228-40/+16
| | | | | | | | | | | | | - Implement host_desktop.cc and plumb a few places that need context to determine which style of desktop it belongs to. - Remove --desktop-aura, --open-ash, --enable-ash TBR=jam@chromium.org BUG=133312 Review URL: https://chromiumcodereview.appspot.com/11146023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163414 0039d316-1c4b-4281-b951-d872f2087c98
* Support Help and Fn keys on Stout.yusukes@chromium.org2012-10-221-0/+18
| | | | | | | | | | | The scancodes for these keys are <FK14> and <FK15> respectively, that are translated to XF86XK_Launch5 and XF86XK_Launch6 XKeySyms. We have to convert the XKeySyms to valid VKEYs so that they are not filtered out as invalid keys. BUG=chrome-os-partner:14339 TEST=manually with an old Apple keyboard which has F13-19 keys Review URL: https://codereview.chromium.org/11238039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163397 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Make sure the timestamp is set correctly on the touchevents.sadrul@chromium.org2012-10-222-17/+27
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11229021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163391 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 162636 - Use LANCZOS3 resize algorithm to generate missing image reps ↵tbarzic@chromium.org2012-10-222-27/+5
| | | | | | | | | | | | | | | | | | for extension action icons. per ui-leads, we don't want to do this (extension developers should make the icon look good themselves) BUG=155329 TEST=manual ( install gmail notification extension, verifiy that extension icon does not look too pixelated) Review URL: https://chromiumcodereview.appspot.com/11017046 TBR=tbarzic@chromium.org Review URL: https://codereview.chromium.org/11232049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix LabelButton::GetThemeAnimation() logic.msw@chromium.org2012-10-222-2/+2
| | | | | | | | | | | | | | My http://crrev.com/162245 missed the animation difference between: TextButtonBorder::Paint() and TextButtonNativeThemeBorder::Paint(). Also update a low priority TODO. BUG=155363 TEST=Test [long kHoverAnimationDurationMs] animations in views examples. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11225024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163331 0039d316-1c4b-4281-b951-d872f2087c98
* Make opaques opaquer.avi@chromium.org2012-10-221-1/+1
| | | | | | | | | | BUG=156954 TEST=bug reporter will reply Review URL: https://chromiumcodereview.appspot.com/11226030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163311 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing crash with Chrome upon cursor accessskuhne@chromium.org2012-10-221-0/+1
| | | | | | | | BUG=157148 Review URL: https://chromiumcodereview.appspot.com/11232041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163309 0039d316-1c4b-4281-b951-d872f2087c98
* Add a minimum implementation of TsfTextStore::GetScreenExt.Yukawa@chromium.org2012-10-221-1/+24
| | | | | | | | | | | | TsfTextStore::GetScreenExt (ITextStoreACP::GetScreenExt) has not been implemented. This change set provides a minimum functionality of this method. Ideally the document rect should be retrieved from the renderer but it is currently expected to be a future work due to the missing functionality. BUG=141611 TEST=Manually done on Windows 8/Metro. Review URL: https://chromiumcodereview.appspot.com/11233029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163254 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashes in ProcessKeyEventDone.nona@chromium.org2012-10-221-1/+3
| | | | | | | | | | | This crash was introduced by crrev.com/162941. BUG=None TEST=Manually done on lumpy. Review URL: https://chromiumcodereview.appspot.com/11227019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163239 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable CJK omnibox suggest on Metro UInona@chromium.org2012-10-222-45/+32
| | | | | | | | | | | | | | On Metro UI, we can't get IMM32 message like WM_IME_COMPOSITION or IMN_OPENCANDIDATE/IMN_CLOSECANDIDATE. Instead of message handling, registering callback function to TsfEventRouter which monitors TSF related event and callbacks on specific event. To enable omnibox suggestion again for IME on Metro environment, I introduced two event callback, OnTextUpdatedByTsf which is called when the text contents are updated by TSF, and OnCandidateWindowCountChangedByTsf which is called when the number of currently opened candidate window is changed. These callbacks are never called without Metro environment, so this CL does not affects non Metro environment including previous version of Windows. BUG=141820, 151901 TEST=Manually done on Win8 for both Metro and classic UI. Review URL: https://chromiumcodereview.appspot.com/11141019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163233 0039d316-1c4b-4281-b951-d872f2087c98
* Make ui::Texture function prototypes consistent across all subclasses.reveman@chromium.org2012-10-211-1/+1
| | | | | | | | | | | BUG= TEST=manual TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11226012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163200 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Improve animation between rows.xiyuan@chromium.org2012-10-202-4/+110
| | | | | | | | | | | | | | Instead of moving diagonally, fade in the item to its new location and fade out at its old location. BUG=117090 TEST=Verify icons are not moving diagonally during drag. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11228011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163145 0039d316-1c4b-4281-b951-d872f2087c98
* Add Textfield::EnableViewsTextfield convenience function.msw@chromium.org2012-10-203-23/+19
| | | | | | | | | | | | | Update NativeWidgetWin::CreateInputMethod(). Update uses in omnibox_views.cc. BUG=131660 TEST=No behavioral changes. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11225012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163139 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Commit the suggested text in omnibox correctly for RTL languages.shishir@chromium.org2012-10-207-0/+23
| | | | | | | | | | | | Note that the ChromeOS omnibox currently does not handle RTL suggested text display correctly. This change will also work when that is fixed. BUG=155356 Review URL: https://chromiumcodereview.appspot.com/11239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ClipboardGtk::WriteBitmap not unpremultiplying images.dcheng@chromium.org2012-10-202-49/+14
| | | | | | | | | | | We share code with GdkPixbufFromSkBitmap now, which has also been updated to remove the need to pass in our own function to free memory. BUG=154573 Review URL: https://chromiumcodereview.appspot.com/11187047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163125 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android tweaks in chrome_browser_main.cc.newt@chromium.org2012-10-202-14/+15
| | | | | | | | | BUG=155686 Review URL: https://chromiumcodereview.appspot.com/11186062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163124 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop aura: Fix cursor displayerg@chromium.org2012-10-201-1/+1
| | | | | | | | | | | | | In r11033038, the cursorclient wasn't sent SetDeviceScaleFactor() messages. Those were needed to set the scale factor in the first place. Since we aren't receiving those calls anymore, set the default scale factor in CursorLoader to 1.0f. BUG=154183 Review URL: https://chromiumcodereview.appspot.com/11233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163108 0039d316-1c4b-4281-b951-d872f2087c98
* Fix win_aura build, use explicit gfx::Rect conversion.danakj@chromium.org2012-10-191-2/+2
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/11233013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163088 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the "set noparent" directivesdpranke@chromium.org2012-10-195-5/+0
| | | | | | | | | | | | | Now that OWNERS supports per-file owners, we can limit the scope of the top-level wildcard to just DEPS, and make darin and ben owners for everything else and remove the broad use of "set noparent". R=ben@chromium.org, darin@chromium.org BUG=88315 Review URL: https://codereview.chromium.org/11191038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make it possible to build without third_party/launchpad_translationsphajdan.jr@chromium.org2012-10-191-13/+35
| | | | | | | | | | | | | | | directory contents. This is helpful for Linux distributions that remove contents of many third_party directories to ensure no unwanted bundled copies of libraries are used. BUG=none TEST=none Review URL: https://codereview.chromium.org/11231010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163066 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Remove platform-specific operator=()s from gfx::Rect.danakj@chromium.org2012-10-194-35/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These operators are making it super difficult to gradually port cc/ over to use gfx types. We are currently using IntRects in cc/ which have platform-specific cast operators. We subclass IntRect to make a cast operator to gfx::Rect, so that we can transition everything from IntRect to gfx::Rect in pieces instead of the entire codebase in one go. But then, when you write IntRect i; gfx::Rect r = i; the compiler is not sure if it should cast IntRect=>Rect and assign, or cast IntRect=>CGRect and assign. Since there are explicit constructor for these types anyhow, you can change CGRect cg; gfx::Rect r = cg; to be CGRect cg; gfx::Rect r(cg); or gfx::Rect r = gfx::Rect(cg); and retain the same functionality. But by being explicit we don't confuse the compiler. BUG=152473 R=sky Review URL: https://chromiumcodereview.appspot.com/11195056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163032 0039d316-1c4b-4281-b951-d872f2087c98
* Changes on the Input method for metro ashcpu@chromium.org2012-10-198-6/+28
| | | | | | | | | | | | With this change and http://codereview.chromium.org/11194044/ you get some keyboard love in metro ash, like delete and tab work but no regular text input. BUG=151718 TEST=see bug Review URL: https://codereview.chromium.org/11183049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163030 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 23:29:28 +0000