| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=109665
TEST=none
Review URL: http://codereview.chromium.org/9176001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
First Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116956
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9127016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, the following changes were made:
Added functions GetStyle() and DeriveFontList(style) to FontList. Changed font list to use strings "Bold" and "Italic" instead of PANGO_STYLE_ITALIC and PANGO_WEIGHT_BOLD - where were actually compile constants for setting attributes and weren't recognized by Pango in a font string. (Whereas "Bold" and "Italic" are recognized).
Add RenderText test that checks that the width of a bold string > the width of a non-bold string.
Add FontList tests for the new functions.
BUG=107893
TEST=Run views_examples_exe "Text Styles" examples and try bold and italic styles (this depends on an unreleased CL). Also, new tests in FontListTest and RenderTextTest.
Review URL: http://codereview.chromium.org/8963027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
padding).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9151023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=109666
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9114029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/9167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9146018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=109638
TEST=none
TBR=ben@chromium.org
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9152016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
selected (matches TreeViewWin).
BUG=109141
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9148008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deletion, unless this behaviour is explicitly enabled by the user.
This behaviour can be enabled with the kern.ipc.shm_allow_removed
sysctl variable which is set to 0 by default.
In case it's not enabled we disable shm support.
This is not an issue on OpenBSD because we are allowing this by default
to follow what Linux does because most people will expect that.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8910016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used by the comboxbox.
BUG=100663
TEST=none
Review URL: http://codereview.chromium.org/9110048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, the following changes were made:
Added functions GetStyle() and DeriveFontList(style) to FontList. Changed font list to use strings "Bold" and "Italic" instead of PANGO_STYLE_ITALIC and PANGO_WEIGHT_BOLD - where were actually compile constants for setting attributes and weren't recognized by Pango in a font string. (Whereas "Bold" and "Italic" are recognized).
Add RenderText test that checks that the width of a bold string > the width of a non-bold string.
Add FontList tests for the new functions.
BUG=107893
TEST=Run views_examples_exe "Text Styles" examples and try bold and italic styles (this depends on an unreleased CL). Also, new tests in FontListTest and RenderTextTest.
Review URL: http://codereview.chromium.org/8963027
TBR=asvitkine@chromium.org
Review URL: http://codereview.chromium.org/9147016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, the following changes were made:
Added functions GetStyle() and DeriveFontList(style) to FontList. Changed font list to use strings "Bold" and "Italic" instead of PANGO_STYLE_ITALIC and PANGO_WEIGHT_BOLD - where were actually compile constants for setting attributes and weren't recognized by Pango in a font string. (Whereas "Bold" and "Italic" are recognized).
Add RenderText test that checks that the width of a bold string > the width of a non-bold string.
Add FontList tests for the new functions.
BUG=107893
TEST=Run views_examples_exe "Text Styles" examples and try bold and italic styles (this depends on an unreleased CL). Also, new tests in FontListTest and RenderTextTest.
Review URL: http://codereview.chromium.org/8963027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
aura (not in compact mode) and behind a flag on windows.
BUG=98345
TEST=make sure tab dragging still works on aura and windows both with
and without the flag 'Enable Tab Browser Dragging' enabled.
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9109018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of Chrome OS, locale resources can be reloaded.
We've seen crashes in testing code that suggest that this is
happening while the resources are being accessed from
another thread.
BUG=chromium-os:11102,chromium-os:19204
TEST=none
TBR=glotov,arv
Review URL: http://codereview.chromium.org/9124031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109141
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9152005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
versioning.
BUG=97845
TEST=clipboard unittests pass.
Review URL: http://codereview.chromium.org/9120009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9101004
TBR=saintlou@chromium.org
Review URL: http://codereview.chromium.org/9151011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9101004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerated content. This will be fully fixed once the browser compositor does not use the in_process_impl anymore.
WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=75491
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9014030
TBR=pkotwicz@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116786
Review URL: http://codereview.chromium.org/9124026
TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/9147007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This will be fully fixed once the browser compositor does not use the in_process_impl anymore.
WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=75491
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9014030
TBR=pkotwicz@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116786
Review URL: http://codereview.chromium.org/9124026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
left to resolve: editing, context menus and auto_expand_children.
BUG=109141
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9120014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This will be fully fixed once the browser compositor does not use the in_process_impl anymore.
WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=75491
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9014030
TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/9124026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be fully fixed once the browser compositor does not use the in_process_impl anymore.
WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=75491
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9014030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindowLinux previously synthesized CHAR events for the
Tab, Escape, and Backspace keys in an attempt to match
Windows, but it sounds like these events are discarded on
Windows. This change also removes a workaround in the Aura
implementation of UnhandledKeyboardEventHandler.
BUG=108480
TEST=none
Review URL: http://codereview.chromium.org/9108031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
no message loop.
There might not be a message loop if the X11 error happens early in initialization. This is the case for GLX initialization in the GPU process.
If there is no message loop, a simple error is logged containing the serial, error code, request code and minor code.
The purpose of posting a task to the message loop is to output a more descriptive error, involving calling various X11 functions such as XGetErrorText, which cannot be called in the error handler itself becasue of reentrancy issues.
BUG=109180
Review URL: http://codereview.chromium.org/9114014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107203
TEST=manually
Review URL: http://codereview.chromium.org/8923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS bot.
Disconnect signal connectors before destroying gtk widget.
Disconnect signal connectors before deleting NativeWidgetGtk whose ownership is WIDGET_OWNS_NATIVE_WIDGET.
This is hypothetical fix for 24352
BUG=chromium-os:24352
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116518
Review URL: http://codereview.chromium.org/9109004
TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/9138001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9108033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the IME binding will be used in production soon, I'd like to add unit tests for the class to prevent future regressions.
ibus_client.h
- Define ui::IBusClient interface which abstracts ibus IPC and makes it possible to remove ibus function calls from ui::InputMethodIBus.
ibus_client_impl.cc
ibus_client_impl.h
- A very thin wrapper around ibus which implements ui::IBusClient. libibus-dependent parts in ui::InputMethodIBus are moved to this class.
input_method_ibus.cc
- Removed all ibus related code. It uses ui::IBusClient interface instead to communicate with ibus-daemon.
- Now the class is testable since it does not communicate with ibus-daemon directly, and can compile on build bots where HAVE_IBUS is not #defined.
input_method_ibus_unittest.cc
- The test.
mock_ibus_client.cc
mock_ibus_client.h
- A dummy IBusClient implementation for the test. The dummy implementation requires neither ibus-daemon nor ibus header files.
composition_text.h
composition_underline.h
- Add operator== and operator!=.
ui.gyp
- Compile mock_ibus_client, character_composer and input_method_ibus when use_aura==1 and use_x11==1. Note that these files do not depend on ibus.
- Compile ibus_client_impl when use_aura==1 and use_ibus==1.
ui_unittests.gypi
- Compile character_composer_unittest and input_method_ibus_unittest when use_aura==1 and use_x11==1. The test does not depend on ibus.
BUG=108172
TEST=ran linux_chromeos_aura bot
Review URL: http://codereview.chromium.org/9005006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are actually two types of modality that the WM might care about - window modality and system modality. See the definitions of these in ui/base/ui_base_types.h.
This is a precursor to adding support for window modality to Ash. Right now we only do system modality which is undesirable for almost all cases of window modality.
http://crbug.com/109290
TEST=none
Review URL: http://codereview.chromium.org/9109035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
advertised by EGL.
At the moment we only bind to them if KHR_image (a superset) is advertised.
Because we determine to which extension each entry point belongs by parsing the header files and those entry points are not listed for KHR_image_base, I had to add some code to the autogenerator script to to add extra extensions for each entry point.
Review URL: http://codereview.chromium.org/9111039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
formulas.
(note that the asset was checked in earlier today to allow for successful trybots run with this CL).
This is getting us one step closer to the polished look, but is not finished. I still need to rework the menu positioning which I will do as a separate CL.
BUG=100663
TEST=none
Review URL: http://codereview.chromium.org/9110021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disconnect signal connectors before deleting NativeWidgetGtk whose ownership is WIDGET_OWNS_NATIVE_WIDGET.
This is hypothetical fix for 24352
BUG=chromium-os:24352
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116518
Review URL: http://codereview.chromium.org/9109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This effectively reverts r83921. We have a fair amount of rate limiting
logic based around GLContext::SetSwapInterval(1) in the RenderWidget
display path. This brings the behavior of GLContextGLX back in line with
other platforms.
BUG=109312
TEST=on linux, do the following:
1.) Enable compiz (on ubuntu, System->Preferences->Appearance->Visual
Effects->any option other than 'None')
2.) Open a new instance of chromium to
http://webstuff.nfshost.com/anim-timing/raftime.html
3.) Change the 'Compositing' select to 'on'
4.) The 'Avg delay between callbacks' should be approximately 16 and the
'Avg framerate' should be 59-60
Review URL: http://codereview.chromium.org/9116018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also improves the look of the dropdown box (which is far from
being polished).
BUG=105804,100663
TEST=none
Review URL: http://codereview.chromium.org/9114001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit API change: https://bugs.webkit.org/show_bug.cgi?id=75577.
BUG=none
Review URL: http://codereview.chromium.org/9008078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f109f51bb261a33db34d37c7dc9062f9aad2348d.
TBR=sky@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9116023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9111030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109222
TEST=Follow steps in bug report.
Review URL: http://codereview.chromium.org/9115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9111017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=109141
TEST=none
Review URL: http://codereview.chromium.org/9108013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Top' is checked.
The fix is to ensure the tooltip window is created with WS_EX_TOPMOST style.
BUG=62037
TEST=Manual test by launching task manager or panel and verifying tooltips appear in front.
Review URL: http://codereview.chromium.org/9030036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/109140
TEST=none
Review URL: http://codereview.chromium.org/9107001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Moved the code to handle vkey_menu to focus manager.
-Unify the code between win/aura/gtk to handle unhandled web keyevent. We were using different code path for unhandled web keyboard for regular page and login. This should fix this issue also.
-Improved focus test not to use fixed wait. This should also speedup the test a bit.
-Removed OmniboxViewViews tests that runs only on views/gtk. This is no longer supported and we can re-enable for win when ready.
BUG=99861,106998, 108480, 108459
TEST=manual: set focus to content area and hit alt key. the focus should be set to wrench menu on release.
Review URL: http://codereview.chromium.org/8907029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106689
TEST=Official builders go green.
TBR=erg,cmp
Review URL: http://codereview.chromium.org/9108017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sail@chromium.org
BUG=100663
TEST=none
Review URL: http://codereview.chromium.org/9116013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116526 0039d316-1c4b-4281-b951-d872f2087c98
|