| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=88017
TEST=Load a web page that should display a vertical slider and make sure it
appears vertical and correctly instead of horizonatally. Note that the
thumb part appears too far to the right; I have confirmed this on all platforms
(win,linux,mac). Since bug was was about a windows specific rendering issue,
I have opened another bug (89616) to keep track of the right offset.
Review URL: http://codereview.chromium.org/7400024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7401031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7396011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7328011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We use context sharing in CompositorGL to avoid compiling the same shaders for different compositors. Previously, we kept the shaders around until the program exited. With this change, we keep the shaders around until there are no more compositors.
BUG=89239
TEST=ui_tests on linux_views pass
Review URL: http://codereview.chromium.org/7367005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This CL was originally reviewed under
http://codereview.chromium.org/7331020/ . The only difference is the
removal of an #include from command_buffer.h that was accidentally
left in and which caused a significant increase in the number of files
containing static initializers, presumably because of the dependent
#include of <iostream>.)
This initial patch changes the Linux port to use
GLX_ARB_create_context_robustness when available, and tests
periodically whether the context has been lost after each draw call
and when making the context current. The detection of context loss
also works with EGL and ANGLE, although it always reports an unknown
reset status.
WebKit changes will follow which test the reset status and determine
what to do in response; for example, the policy might be to never
restore a WebGL context which was lost (due to a GPU reset) and which
was determined to be the guilty context.
Tested manually with WebGL stress tests and verified on Linux and
Windows that in at least some situations it is possible to detect
guilty contexts and shut down the associated WebGL application. Some
precision of this detection was recently lost and will need to be
fixed in following CLs. Also updated and ran GPU unit tests.
BUG=88106
TEST=none (tested manually; try servers)
R=gman,apatrick,piman
Review URL: http://codereview.chromium.org/7362005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7363005
Patch from Fady Samuel <fsamuel@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GL_ARB_robustness. (Regressed static initalizer size on Linux -- will need to reexamine code to understand why.)
This initial patch changes the Linux port to use
GLX_ARB_create_context_robustness when available, and tests
periodically whether the context has been lost after each draw call
and when making the context current. The detection of context loss
also works with EGL and ANGLE, although it always reports an unknown
reset status.
WebKit changes will follow which test the reset status and determine
what to do in response; for example, the policy might be to never
restore a WebGL context which was lost (due to a GPU reset) and which
was determined to be the guilty context.
Tested manually with WebGL stress tests and verified on Linux and
Windows that in at least some situations it is possible to detect
guilty contexts and shut down the associated WebGL application. Some
precision of this detection was recently lost and will need to be
fixed in following CLs. Also updated and ran GPU unit tests.
BUG=88106
TEST=none (tested manually; try servers)
Review URL: http://codereview.chromium.org/7331020
TBR=kbr@chromium.org
Review URL: http://codereview.chromium.org/7346032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initial patch changes the Linux port to use
GLX_ARB_create_context_robustness when available, and tests
periodically whether the context has been lost after each draw call
and when making the context current. The detection of context loss
also works with EGL and ANGLE, although it always reports an unknown
reset status.
WebKit changes will follow which test the reset status and determine
what to do in response; for example, the policy might be to never
restore a WebGL context which was lost (due to a GPU reset) and which
was determined to be the guilty context.
Tested manually with WebGL stress tests and verified on Linux and
Windows that in at least some situations it is possible to detect
guilty contexts and shut down the associated WebGL application. Some
precision of this detection was recently lost and will need to be
fixed in following CLs. Also updated and ran GPU unit tests.
BUG=88106
TEST=none (tested manually; try servers)
Review URL: http://codereview.chromium.org/7331020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library"). This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies. This makes the component build more consistent
with the static build.
An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.
A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.
R=rvargas,bradnelson,evan
Review URL: http://codereview.chromium.org/7344022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change broke compilation on Linux Builder (dbg)(shared):
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio
TBR=darin
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7352014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library"). This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies. This makes the component build more consistent
with the static build.
An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.
A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.
R=rvargas,bradnelson
Review URL: http://codereview.chromium.org/7344022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As we want to call GetClientRect, even in non-release builds.
BUG=Failing on release builder with:
375>d:\b\build\slave\chrome-official\build\src\third_party\leveldb\util\env_chromium.cc(239) : warning C4722: 'leveldb::`anonymous namespace'::ChromiumEnv::~ChromiumEnv' : destructor never returns, potential memory leak
365>d:\b\build\slave\chrome-official\build\src\ui\gfx\gl\gl_surface_wgl.cc(264) : error C2220: warning treated as error - no 'executable' file generated
365>d:\b\build\slave\chrome-official\build\src\ui\gfx\gl\gl_surface_wgl.cc(264) : warning C4700: uninitialized local variable 'rect' used
375>d:\b\build\slave\chrome-official\build\src\ui\gfx\gl\gl_surface_wgl.cc(264) : error C2220: warning treated as error - no 'executable' file generated
375>d:\b\build\slave\chrome-official\build\src\ui\gfx\gl\gl_surface_wgl.cc(264) : warning C4700: uninitialized local variable 'rect' used
365>d:\b\build\slave\chrome-official\build\src\third_party\leveldb\util\env_chromium.cc(239) : warning C4722: 'leveldb::`anonymous namespace'::ChromiumEnv::~ChromiumEnv' : destructor never returns, potential memory leak
375>LINK : fatal error LNK1257: code generation failed
TEST=Built locally.
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7349012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Rename xtb files following the app_strings.grd to ui_strings.grd rename.
Patch from Fabien Tassin <fta@sofaraway.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7258004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
few classes, and replaces an ugly view class name comparison with a clean
switch based on the view's role.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7328027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16019
TEST=Open http://www.google.com/search?sourceid=chrome&ie=UTF-8&q=arabic#sclient=psy&hl=en&source=hp&q=%D8%A8%D8%AC%D8%AF%D9%8A%D8%A9+%D8%B9%D8%B1%D8%A8%D9%8A%D8%A9%E2%80%8E+%CA%BE&pbx=1&oq=%D8%A8%D8%AC%D8%AF%D9%8A%D8%A9+%D8%B9%D8%B1%D8%A8%D9%8A%D8%A9%E2%80%8E+%CA%BE&aq=f&aqi=&aql=undefined&gs_sm=e&gs_upl=4559l4559l0l1l1l0l0l0l0l76l76l1l1&bav=on.2,or.r_gc.r_pw.&fp=7c469d2a1253a36a&biw=1832&bih=1022 and check if the tab has a "..." in the middle
Review URL: http://codereview.chromium.org/7324011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=ui_unittest
Review URL: http://codereview.chromium.org/7044062
Patch from Ian Vollick <vollick@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Each compositor has it's own context. We should share shaders between them because compiling shaders is expensive. To do this, I pin the very first context created with a ref count. Then I use context sharing to share the shaders.
BUG=none
TEST=by hand with intel, nv, nouveau, and tegra drivers on a TOUCH_UI build
Review URL: http://codereview.chromium.org/7327001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this was dropped accidentally in http://codereview.chromium.org/6718027 (surface.gyp) and http://codereview.chromium.org/6722026 (gl.gyp)
Remove now-redudant code that's implied by chromium_code: 1.
Fix the warnings that have crept in since chromium_code: 1 was removed.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91598
Review URL: http://codereview.chromium.org/7227009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
what windows does.
BUG=56650
TEST=press alt and release, focus should be on the wrench. press
space, make sure the window menu appears, not the wrench menu.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7237032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions.
This does not take care of everything! There are many deprecated macros that we
can't replace because their accessor replacements were in 2.20 or later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7227027
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/7329003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to the new easier to read variables.
BUG=none
TEST=Manual, everything still compiles.
Review URL: http://codereview.chromium.org/7313017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
skia-gpu GL interface with an uninitialized binding. Fixes a -Werror issue.
Review URL: http://codereview.chromium.org/7316023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does not take care of everything! There are many deprecated macros that we
can't replace because their accessor replacements were in 2.20 or later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7227027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org, tony@chromium.org
Review URL: http://codereview.chromium.org/7210060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7314013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved patch to new issue from my google account
BUG=79968
TEST=
Review URL: http://codereview.chromium.org/7253034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views_desktop.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7312010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gl.gyp to pick up -Werror.
It looks like this was dropped accidentally in http://codereview.chromium.org/6718027 (surface.gyp) and http://codereview.chromium.org/6722026 (gl.gyp)
Remove now-redudant code that's implied by chromium_code: 1.
Fix the warnings that have crept in since chromium_code: 1 was removed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7227009
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7227022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this was dropped accidentally in http://codereview.chromium.org/6718027 (surface.gyp) and http://codereview.chromium.org/6722026 (gl.gyp)
Remove now-redudant code that's implied by chromium_code: 1.
Fix the warnings that have crept in since chromium_code: 1 was removed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7227009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The previous implementation used to poll the environment for the window size every drawing cycle. On Linux this is an expensive operation because it requires a round trip to the X server. This CL pushes window size change to the compositor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7212028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7212023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extend favicon source to provide larger icons. For now, larger means at most 32x32. Also, the only icon we actually support at this resolution is the default (globe).
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7300017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For consistency, move the windows-specific code from range.cc into
range_win.cc.
Do the same for unit tests.
In addition to this being nicer in general, the make build also gets
confused if two files have the same path and basename, but different
extensions (range.cc, range.mm), which is fixed by this CL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7248068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These rules are in build/common.gypi already, which is included through
the chromium_code: 1 variable.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7309010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7232030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=app_unittests
R=cmp@chromium.org, tony@chromium.org
Review URL: http://codereview.chromium.org/7198030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7277072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7300012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7291011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7292005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should fix a compile error on Windows introduced at r91145.
TBR=sky@chromium.org,backer@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added interpolated transforms
BUG= none
TEST=ui_unittests
Review URL: http://codereview.chromium.org/7285003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7253057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so I can use the trybots in a follow up patch.
BUG=72317
TEST=None
R=maruel@chromium.org
Review URL: http://codereview.chromium.org/7248030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
replace existing data.
BUG=none
TEST=none
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7276044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90924 0039d316-1c4b-4281-b951-d872f2087c98
|