summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* linux_aura: Three fixes for switching themes.erg@chromium.org2013-06-222-0/+9
| | | | | | | | | | | | | | | | | | Native system theming was badly hacked into ThemeService with ifdefs. This correlates the code into its own file, which should be conditionally compiled out. When doing any switching of themes, we weren't notifying the non client view of the change. Make the options page in the linux_aura port behave the same way as in the GTK+ port. BUG=130810 Review URL: https://chromiumcodereview.appspot.com/17494005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208060 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the maximum number of list items in notifications.dewittj@chromium.org2013-06-221-1/+1
| | | | | | | | | | This changes the limit to 5 max instead of 8 max list items. BUG=251509 Review URL: https://chromiumcodereview.appspot.com/17198020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208052 0039d316-1c4b-4281-b951-d872f2087c98
* Support SetFocusedTextInputClient(NULL) in InputMethodTSF.Yukawa@chromium.org2013-06-221-0/+5
| | | | | | | | | | | | | It turned out that the previous implementation of InputMethodTSF did not support InputMethodTSF::SetFocusedTextInputClient(NULL). This CL fixes the issue. BUG=246534 Review URL: https://chromiumcodereview.appspot.com/17546002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208043 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a first-run balloon to the Windows notification center.dewittj@chromium.org2013-06-221-0/+4
| | | | | | | | | | | This is designed to attract attention to the system tray icon which can be hidden in the overflow area. BUG=246322 Review URL: https://chromiumcodereview.appspot.com/17286015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208031 0039d316-1c4b-4281-b951-d872f2087c98
* gpu: Add EGL fence support.epenner@chromium.org2013-06-223-5/+51
| | | | | | | | | | Adds fence support for EGL. BUG= Review URL: https://chromiumcodereview.appspot.com/14358014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208021 0039d316-1c4b-4281-b951-d872f2087c98
* Consider IME is associated with the top level widget rather than child widget.Yukawa@chromium.org2013-06-221-1/+12
| | | | | | | | | | | | | | | | | An important thing is that [NativeWidget A] owns Win32 input focus even when [View X] is logically focused by FocusManager. As a result, an Win32 IME may want to interact with the native view of [NativeWidget A] rather than that of [NativeWidget B]. This is why we need to call GetTopLevelWidget() here. Previous implementation treated [NativeWidget B] as associated with the IME but it was wrong. This CL fixes the this confusion. BUG=246534 Review URL: https://chromiumcodereview.appspot.com/17101019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208018 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac][MC] Initial accessibility pass.rsesek@chromium.org2013-06-224-2/+84
| | | | | | | | | | | | This gives all the buttons appropriate roles, AXTitles, and makes accessible more of the notification content. BUG=238248 R=dewittj@chromium.org, dmazzoni@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/17408004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207994 0039d316-1c4b-4281-b951-d872f2087c98
* ui/compositor: Remove unnecessary DEPS file.tfarina@chromium.org2013-06-221-3/+0
| | | | | | | | | | BUG=None TEST=tools/checkdeps/checkdeps.py succeeds R=piman@chromium.org Review URL: https://codereview.chromium.org/17183012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207991 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes two bugs:pkotwicz@chromium.org2013-06-223-4/+66
| | | | | | | | | | | | 1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006 2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage. BUG=242877 TEST=Manual, see bug Review URL: https://chromiumcodereview.appspot.com/16370006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the WebUI keyboard css and layout to work better in narrow spaces.stevet@chromium.org2013-06-224-44/+67
| | | | | | | | | | NOTE that this must be patched on top of https://codereview.chromium.org/15176004/ TODOs: Add a list of adjustments here before review. Review URL: https://chromiumcodereview.appspot.com/16336002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207982 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust do not disturb hovertext on Mac.dewittj@chromium.org2013-06-221-3/+10
| | | | | | | | | | From "Do not disturb" to "Do Not Disturb". BUG=252840 Review URL: https://chromiumcodereview.appspot.com/17068015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207981 0039d316-1c4b-4281-b951-d872f2087c98
* Make some additional adjustments to the v1 keyboard layout.stevet@chromium.org2013-06-212-20/+22
| | | | | | | | | | | | Move the mic key to the capslock location. Remove the '@' key in favour of a second symbol key. Adjust the sizing of the space key. BUG=248226 Review URL: https://chromiumcodereview.appspot.com/16943012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207958 0039d316-1c4b-4281-b951-d872f2087c98
* Convert asynchronous closure test in cr.ui framework to a browser test.kevers@chromium.org2013-06-212-134/+1
| | | | | | | | | BUG=249104 TEST=WebUIResourceBrowserTest Review URL: https://chromiumcodereview.appspot.com/16831021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207929 0039d316-1c4b-4281-b951-d872f2087c98
* Put back the code that I accidentally removed in crrev.com/17099003oshima@chromium.org2013-06-211-0/+3
| | | | | | | | | | TBR=sky@chromium.org BUG=252813 TEST=none Review URL: https://codereview.chromium.org/17068017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207927 0039d316-1c4b-4281-b951-d872f2087c98
* Adding self to OWNERS replacing gmanpiman@chromium.org2013-06-211-0/+1
| | | | | | | | | BUG=None R=apatrick@chromium.org Review URL: https://codereview.chromium.org/16867014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207926 0039d316-1c4b-4281-b951-d872f2087c98
* Define a LoggingSettings struct to use for InitLogging()akalin@chromium.org2013-06-211-5/+3
| | | | | | | | | | | | | | | | | | Update all callers of InitLogging() to use LoggingSettings, only setting fields that need a non-default value. Turn LoggingDestination enum into a bit field and define add LOG_DEFAULT and LOG_ALL constants. Fix erroneous comment saying that the default was to not lock the log file. BUG=247594 TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/16519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file permissions for https://chromiumcodereview.appspot.com/17112021rmsousa@chromium.org2013-06-217-0/+0
| | | | | | | | TBR=yukishiino@chromium.org Review URL: https://codereview.chromium.org/17155019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file permissions for https://chromiumcodereview.appspot.com/17112021rmsousa@chromium.org2013-06-2113-0/+0
| | | | | | | | | TBR=dmichael@chromium.org BUG= Review URL: https://codereview.chromium.org/16943013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207912 0039d316-1c4b-4281-b951-d872f2087c98
* Add base namespace to more values in sync and elsewhere.brettw@chromium.org2013-06-213-9/+10
| | | | | | | | | | This makes sync and net compile with no "using *Value". BUG= Review URL: https://codereview.chromium.org/17034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
* Test delegate_ in TrayBubbleView::GetAccessibleStatestevenjb@chromium.org2013-06-211-1/+1
| | | | | | | | | BUG=249846 R=msw@chromium.org Review URL: https://codereview.chromium.org/17045003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207890 0039d316-1c4b-4281-b951-d872f2087c98
* New method: InputMethod::IsCandidatePopupOpen()yukishiino@chromium.org2013-06-2121-1/+116
| | | | | | | | | | | | Supports a new method {ui,views}::InputMethod::IsCandidatePopupOpen(), which returns true if a candidate window is open. BUG=245578 TEST=Test manually. Review URL: https://chromiumcodereview.appspot.com/17112021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207858 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test failure in list_selection_model_test.html and port to automated ↵kevers@chromium.org2013-06-212-242/+0
| | | | | | | | | | | browser test. BUG=249104 TEST=WebUIResourceBrowserTest Review URL: https://chromiumcodereview.appspot.com/17450012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207855 0039d316-1c4b-4281-b951-d872f2087c98
* This patch brings the virtual keyboard up to the proposed v1 styling.stevet@chromium.org2013-06-216-96/+103
| | | | | | | | | | This also changes the layout of some keys to bring the keyboard closer to the v1 spec. BUG=248525,248226 Review URL: https://chromiumcodereview.appspot.com/16959020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207834 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205124 "Turn on touch drag and drop and touch editing by ..."varunjain@chromium.org2013-06-211-10/+0
| | | | | | | | | | | | | | > Turn on touch drag and drop and touch editing by default on chromeos. > > BUG=168162 > > Review URL: https://chromiumcodereview.appspot.com/16268020 TBR=varunjain@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/17068008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207820 0039d316-1c4b-4281-b951-d872f2087c98
* Match the NativeTextfieldViews cursor color to the text color.msw@chromium.org2013-06-211-4/+1
| | | | | | | | | | | | | | | | | The NativeTextfieldViews cursor color is hard-coded black. Instead, set the cursor color to Textfield::GetTextColor. This supports more Windows high-contrast black themes, etc. However, if Windows has red text, they'll get red cursors. (I think accessibility trumps that questionable coloring) (also, the native behavior is worse in my ugly test theme) BUG=252385,131660 TEST=Views Textfields cursors match their overall text color; meets accessibility requirements without other seriously negative effects. R=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/17517005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207795 0039d316-1c4b-4281-b951-d872f2087c98
* Change WGC3DInProcessCBImpl factories to return a base class pointer.sievers@chromium.org2013-06-213-24/+28
| | | | | | | | TBR=sky@chromium.org for ui/aura/bench/bench_main.cc Review URL: https://chromiumcodereview.appspot.com/17447007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207782 0039d316-1c4b-4281-b951-d872f2087c98
* Only slide-down animation in message center too.mukai@chromium.org2013-06-211-36/+38
| | | | | | | | | | BUG=247796 TEST=manually R=dewittj@chromium.org Review URL: https://chromiumcodereview.appspot.com/17382011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207776 0039d316-1c4b-4281-b951-d872f2087c98
* Port passing closure tests for cr.ui framework to browser tests. This CL ↵kevers@chromium.org2013-06-214-637/+0
| | | | | | | | | | | deals with porting closure tests that require minimal formatting changes to run as browser tests. BUG=249104 TEST=WebUIResourceBrowserTest Review URL: https://chromiumcodereview.appspot.com/17315020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207770 0039d316-1c4b-4281-b951-d872f2087c98
* Insert text directly from the virtual keyboard.bryeung@chromium.org2013-06-2116-660/+110
| | | | | | | | | | | | | | | | This allows the insertion of text that does not directly correspond to key codes. The new API introduced is a temporary solution to allow us to continue prototyping the virtual keyboard and understanding how the implementation will interact with IMEs until proper IME integration can be achieved. BUG=237533 Review URL: https://chromiumcodereview.appspot.com/16972006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207752 0039d316-1c4b-4281-b951-d872f2087c98
* HWNDMessageHandler::OnNCActivate should clear high word of wparam before ↵jianli@chromium.org2013-06-212-3/+17
| | | | | | | | | | | | | converting it to BOOL. It is found out that high word of wparam could be set when the window is minimized or restored. We should clear wparam's high word before converting it to BOOL. BUG=244986 TEST=Manual test by following repro steps as in the bug Review URL: https://chromiumcodereview.appspot.com/17283013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207714 0039d316-1c4b-4281-b951-d872f2087c98
* Moves querying of appbar autohide edges to a background thread. Itsky@chromium.org2013-06-219-388/+195
| | | | | | | | | | | | | | | turns out querying for the autohide edges spawns a nested message loop. Since we end up querying for autohide edges at window creation time (autohide edges are queried from WM_NCCALCSIZE which is invoked during window creation) we can end up attempting to use a window (if say a WM_COPYDATA is received) before we've really set things up. BUG=94752 162535 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/17239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207698 0039d316-1c4b-4281-b951-d872f2087c98
* Make webui menu use hard coded blackxiyuan@chromium.org2013-06-211-0/+1
| | | | | | | | | | As a short term work around for issue 252362. BUG=252362 Review URL: https://chromiumcodereview.appspot.com/17493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the aura unit tests for ozone=1rjkroege@chromium.org2013-06-212-0/+13
| | | | | | | | | | | | Implemented NativeEvent copying for ozone events to fix crash in unit tests and suppressed cursor tests that cannot yet function. BUG=252320 Review URL: https://chromiumcodereview.appspot.com/17274016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207646 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix the problem that a popup could be closed while it is still in ↵jianli@chromium.org2013-06-203-4/+13
| | | | | | | | | | | | | | | | | | animation. This occurs when the test code creates a popup and close the collection immediately. The fix is to close the popup without animation for this case. All the popup animations are coordinated by the popup collection. Added DCHECKs in the popup controller to guard the places that might trigger the 2nd animation while the previous animation has not ended. BUG=249131 TEST=reenable the disabled test R=dewittj@chromium.org, rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207470 Review URL: https://codereview.chromium.org/17468007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207644 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 207508 "Add a hide_layer_and_subtree() flag to cc::Layer"oshima@chromium.org2013-06-203-19/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Add a hide_layer_and_subtree() flag to cc::Layer > > This flag does what it says. We can use this flag to simplify ui::Layer > as it was recursively calling SetIsDrawable() instead, and now can just > SetHideLayerAndSubtree() on a single layer. > > This flag is needed to allow readbacks of layers that are have hidden > visibility (possibly due to an ancestor). > > Tests: > LayerTest.CheckPropertyChangeCausesCorrectBehavior > LayerImplTest.VerifyLayerChangesAreTrackedProperly > LayerTreeHostCommonTest.SubtreeHidden_SingleLayer > LayerTreeHostCommonTest.SubtreeHidden_SingleLayerImpl > LayerTreeHostCommonTest.SubtreeHidden_TwoLayers > LayerTreeHostCommonTest.SubtreeHidden_TwoLayersImpl > > R=enne, piman > BUG=242572 > > Review URL: https://chromiumcodereview.appspot.com/16896017 reveting this because this broke login screen on cros. (crbug.com/252494) TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/17279011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207627 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup android_webview scroll offset delegation to Java side.mkosiba@chromium.org2013-06-201-0/+4
| | | | | | | | | | | | This connects the scroll offset that is delegated from the CC all the way up to the Java android.view.View class. BUG=b/6029133 TEST=AndroidWebViewTest Review URL: https://chromiumcodereview.appspot.com/16255010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207614 0039d316-1c4b-4281-b951-d872f2087c98
* message_center only needs to depend on compositor on platforms using viewsthakis@chromium.org2013-06-202-3/+6
| | | | | | | | | | | | | Removes a few hundred compilation units when building 'message_center' on mac. No intended behavior change. BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/17390015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207610 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] App launcher drag/drop.koz@chromium.org2013-06-2011-28/+334
| | | | | | | | | | This allows icons to be dragged from the windows App Launcher to the taskbar. BUG=153335 Review URL: https://chromiumcodereview.appspot.com/17370003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207608 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Delete LayerTreeAsText / ShowPlatformLayerTreeenne@chromium.org2013-06-201-2/+0
| | | | | | | | | | | | | | | | | CC currently has three (3) ways to dump layers: LayerTreeAsText, LayerTreeAsJSON, and AsValue. LayerTreeAsText is the least useful due to the fact that if you have more than a few layers it falls off the bottom of the screen. Its layer printing abilities have been entirely replaced (in my opinion) with TraceViewer's ability to capture frames. R=nduca@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/17351009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207596 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: cros: Show notification when low-power charger connectedjamescook@chromium.org2013-06-201-4/+18
| | | | | | | | | | | | | | | | | First landed as https://codereview.chromium.org/17157007 and broke win_aura Encourage the user to plug in the official charger. Also extract FakeMessageCenter into a message_center_test_support target so I can use it for a unit test. BUG=249852 TEST=ash_unittests TrayPowerTest.* TBR=mukai@chromium.org - previously reviewed Review URL: https://codereview.chromium.org/17482007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207584 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that all DesktopCaptureClient instances return the same capture ↵ananta@chromium.org2013-06-202-13/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | window state. The capture window state in desktop chrome AURA is maintained in the DesktopCaptureClient instances which are created for every root window. Every top level window in desktop chrome AURA has an associated root window. When events like mouse/touch are dispatched in AURA, we dispatch these events to the capture window if one exists first and then proceed to find the appropriate target for the event. The capture window is retrieved via the capture client instance for the RootWindow which received the event. As all DesktopCaptureClient instances only return a valid capture window if their root window took capture, scenarios like the context menu popping up in response to an right mouse button down/touch down, etc don't dispatch the corresponding right mouse button release/touch release messages to the right window. (The context menu sets capture when it is displayed). Fix is to ensure that the DesktopCaptureClient::GetCaptureWindow function returns a valid capture window by also enumerating the global DesktopCaptureClient list. The other change is in the DesktopCaptureClient::SetCapture function where we also need to cancel existing touches/gestures on other RootWindows and transfer them over to the new capture window. We do the same in the ASH CaptureController::SetCapture class. This ensures that gesture state is reset correctly. Should fix the context menu flakiness observed with the long press gesture in desktop Chrome AURA. BUG=245503 R=sky@chromium.org TEST=Covered by modified views tests ResetMouseEventHandlerOnCapture, ResetOtherWindowCaptureOnCapture and newly added test CaptureWindowInputEventTest. Review URL: https://codereview.chromium.org/17106009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207539 0039d316-1c4b-4281-b951-d872f2087c98
* Animate clearing all notifications for Windows.jianli@chromium.org2013-06-202-24/+141
| | | | | | | | | | | | | | It starts by sliding out the topmost visible notification in the tray view. Then the notification below will start to slide out after a short delay. After the bottom-most visible notification has been slided out, the tray will be closed. When the clear-all animation is in progress, the buttons and scroll bars are disabled to prevent the user from clicking on them accidentally. BUG=244606 TEST=manual test by clearing all notifications in the tray R=dewittj@chromium.org, dimich@chromium.org Review URL: https://codereview.chromium.org/17114005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207512 0039d316-1c4b-4281-b951-d872f2087c98
* Add a hide_layer_and_subtree() flag to cc::Layerdanakj@chromium.org2013-06-203-36/+19
| | | | | | | | | | | | | | | | | | | | | | | | This flag does what it says. We can use this flag to simplify ui::Layer as it was recursively calling SetIsDrawable() instead, and now can just SetHideLayerAndSubtree() on a single layer. This flag is needed to allow readbacks of layers that are have hidden visibility (possibly due to an ancestor). Tests: LayerTest.CheckPropertyChangeCausesCorrectBehavior LayerImplTest.VerifyLayerChangesAreTrackedProperly LayerTreeHostCommonTest.SubtreeHidden_SingleLayer LayerTreeHostCommonTest.SubtreeHidden_SingleLayerImpl LayerTreeHostCommonTest.SubtreeHidden_TwoLayers LayerTreeHostCommonTest.SubtreeHidden_TwoLayersImpl R=enne, piman BUG=242572 Review URL: https://chromiumcodereview.appspot.com/16896017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207508 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers, delete some strings forwarding headers.avi@chromium.org2013-06-203-3/+3
| | | | | | | | | | BUG=247723 TEST=everything compiles OK TBR=ben@chromium.org Review URL: https://codereview.chromium.org/17390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207507 0039d316-1c4b-4281-b951-d872f2087c98
* This is causing TestCSP to fail on chromium.macrmsousa@chromium.org2013-06-203-12/+4
| | | | | | | | | | | | | | | | | | | | | | Revert 207470 "[Mac] Fix the problem that a popup could be close..." > [Mac] Fix the problem that a popup could be closed while it is still in animation. > > This occurs when the test code creates a popup and close the collection immediately. The fix is to close the popup without animation for this case. > > All the popup animations are coordinated by the popup collection. Added DCHECKs in the popup controller to guard the places that might trigger the 2nd animation while the previous animation has not ended. > > BUG=249131 > TEST=reenable the disabled test > R=dewittj@chromium.org, rsesek@chromium.org > > Review URL: https://codereview.chromium.org/17468007 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/17361005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207503 0039d316-1c4b-4281-b951-d872f2087c98
* move all textfield icon/custom border support to AutofillDialogViewsestade@chromium.org2013-06-208-121/+18
| | | | | | | | | BUG=248208 R=msw@chromium.org, sadrul@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/17132002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207495 0039d316-1c4b-4281-b951-d872f2087c98
* Update remaining Blink header includesabarth@chromium.org2013-06-201-1/+0
| | | | | | | | | | | | | This CL updates the remaining #includes from Source/WebKit/chromium/public to public/web. After this CL lands, I'll be able to remove the forwarding headers in Blink. TBR=darin@chromium.org BUG=239545 Review URL: https://codereview.chromium.org/17481004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207493 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Remove cc::Thread and cc::ThreadImpl.danakj@chromium.org2013-06-201-7/+3
| | | | | | | | | | | | | These classes are replaced by using base::SingleThreadTaskRunner directly. R=piman,jamesr BUG=251134 Depends on: https://codereview.chromium.org/17362002/ Review URL: https://chromiumcodereview.appspot.com/17114008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207491 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly set the text color used in the OSX App Launcher grid.tapted@chromium.org2013-06-207-18/+70
| | | | | | | | | | | | | | | | | | This updates the OSX app list to use the same text color as on CrOS and Windows (gray), as well as updating the text color to a darker gray when the grid item is highlighted. Currently the item title color used is the default control color (black). BUG=138633 TEST=Launch OSX App launcher and observe gray text on items in the grid, and a darker text when an item is highlighted. Also added app_list_unittests:AppsGridControllerTest.SelectionChangesTextColor Review URL: https://chromiumcodereview.appspot.com/17112018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207490 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary DCHECKmukai@chromium.org2013-06-201-4/+8
| | | | | | | | TBR=dmichael@chromium.org Review URL: https://codereview.chromium.org/17076014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207479 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-30 21:31:48 +0000