summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Adds ComboboxModelObserver to ComboboxModelsky@chromium.org2013-10-016-1/+47
| | | | | | | | | | | | | I'm going to need this so that I can make RecentlyUsedFoldersComboModel notify observers when it changes. BUG=294330 TEST=none R=msw@chromium.org Review URL: https://codereview.chromium.org/25146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the multiple shift-chording edge cases we were discussing offline.rsadam@chromium.org2013-10-012-7/+36
| | | | | | | | | | | | | Specifically: 1. Start chording with shift key, slide finger off shift key 2. While chording with one shift key, press another shift key 3. Place a finger on the screen before chording with shift key, remove finger and then end chording. BUG=297586 Review URL: https://codereview.chromium.org/25158002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226299 0039d316-1c4b-4281-b951-d872f2087c98
* Make notifications appear after the topmost one is closed.dewittj@chromium.org2013-10-012-7/+35
| | | | | | | | | | | Mouse tracking suffers when we close notifications due to a poor ordering in Views code. This reorders the events in such a way that we are properly tracking mouse exits. BUG=299183 Review URL: https://codereview.chromium.org/24903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226268 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issuesben@chromium.org2013-10-015-6/+16
| | | | | | | | | TBR=sky@chromium.org BUG=none Review URL: https://codereview.chromium.org/25352002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226256 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging to figure out if TabStrip is being passed invalid indexsky@chromium.org2013-10-011-2/+2
| | | | | | | | | | | | | Syzy says we're accessing beyond the size of TabStrip::tabs_. This adds some code in hopes of isolating that. BUG=294353 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/25021007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226247 0039d316-1c4b-4281-b951-d872f2087c98
* XChangeProperty() expects values of size 32 to be longs (see "man ↵alextaran@chromium.org2013-10-013-4/+12
| | | | | | | | | | | | | XChangeProperty"). Changed parameter types to long when calling XChangeProperty due to https://bugs.freedesktop.org/show_bug.cgi?id=16802 BUG=296940 R=tony@chromium.org,erg@chromium.org Review URL: https://codereview.chromium.org/24281007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226245 0039d316-1c4b-4281-b951-d872f2087c98
* Show menu after selection changearv@chromium.org2013-10-011-0/+14
| | | | | | | | | | | | | Delay showing the context menu shown from the context menu button. This is so that the selection changes before the menu is shown and the update of the menu items is done in the correct order. BUG=301584 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/25174005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226217 0039d316-1c4b-4281-b951-d872f2087c98
* Delete IBusInputContextClientkomatsu@chromium.org2013-10-011-2/+0
| | | | | | | | | | IBusInputContextClient is no longer used in the production at all. BUG=275262 Review URL: https://codereview.chromium.org/25081003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226216 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces the dialog UI to confirm HDCP verification.mukai@chromium.org2013-10-012-0/+8
| | | | | | | | | | BUG=294452 R=dkrahn@chromium.org, mnissler@chromium.org, msw@chromium.org TEST=manually Review URL: https://codereview.chromium.org/24252009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226212 0039d316-1c4b-4281-b951-d872f2087c98
* Supports cap height in gfx::Font and gfx::FontList.yukishiino@chromium.org2013-10-0114-29/+93
| | | | | | | | | | | | | | | | | | | This CL is a preparation of http://crrev.com/23601006 . Cap height will be used to determine the fixed baseline of text, especially for Omnibox but not limited to. Omnibox wants to show Latin characters vertically center, i.e. ABC look just center. Omnibox also wants to resize the font list so text is small enough to fit in Omnibox. The baseline is determined from these two restrictions. All the texts are rendered based on this baseline regardless its height. Any characters within the height of the font list must fit in Omnibox. For text controls other than Omnibox, the height of text box may be determined from the height of the font list and the cap height may not be used. If the height of text box is smaller than the height of the font list, then the text control determines the baseline based on cap height so it shows ABC vertically center. BUG=146236,264436 TEST=Ran ui_unittests. Review URL: https://codereview.chromium.org/24240013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226202 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if we get WM_ACTIVATE during Init().sky@chromium.org2013-10-011-0/+5
| | | | | | | | | | | | | If during HWNDMessageHandler::Init() we get an NC_ACTIVATE we're not really setup and can't handle processing it (else we crash). BUG=275954 TEST=none R=ananta@chromium.org Review URL: https://codereview.chromium.org/25197004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226200 0039d316-1c4b-4281-b951-d872f2087c98
* Originally MenuButton can show the empty menu but operating the empty menu ↵hirono@chromium.org2013-10-011-0/+3
| | | | | | | | | | | | | by keyboard caused to freeze. This CL adds a guard and prevents MenuButton from opening the empty menu. BUG=244300 TEST=manually Review URL: https://codereview.chromium.org/25211002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226175 0039d316-1c4b-4281-b951-d872f2087c98
* More debugging code for RootWindow holding onto deleted aura::Windowsky@chromium.org2013-10-012-27/+29
| | | | | | | | | | | | | | | | | | | | | | Real changes: . Streamline resetting of mouse_moved_handler_. Changes to *always* reset if mouse_moved_handler_ is not a child of this. This ensures we always clean up mouse_moved_handler_ if things shifted from when we set mouse_moved_handler_. . Moves clearing *before* invoking OnCaptureLost. This way if OnCaptureLost has side effects we aren't left in a bad state. And MouseMovedHandlerSetReason into debugging class. I'm getting crashes in OnWindowDestroyed but can't see the reason. This should fix that (assuming I still get crashes). BUG=275760 TEST=none R=sadrul@chromium.org Review URL: https://codereview.chromium.org/25302002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226164 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing crash Report - Magic Signature: views::View::ConvertPointToScreenskuhne@chromium.org2013-10-016-32/+117
| | | | | | | | | | | | | | | | | The problem: - The BubbleDelegateView tracks the destruction of the widget which owns the anchor view. - The anchor view gets queried dynamically for its location upon any position change of the anchor widget. - When a view gets deleted, the widget does not have to be deleted. Taking that all together and looking at the shelf it is possible to get to the following scenario: The user puts the shelf into auto hiding mode (so it changes its location). The bubble gets shown. The button - which was used for the anchor - gets deleted, which triggers the destruction of the bubble. The bubble however gets faded out slowly (while the shelf shifts out of view). In this case the location would get queried, but the view is already gone. BUG=297676 TEST=unittest, but none visually since there isn't a simple reproducible case known Review URL: https://codereview.chromium.org/24469006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226158 0039d316-1c4b-4281-b951-d872f2087c98
* Use DwmGetCompositionTimingInfo to get vsync info on Vista+jbauman@chromium.org2013-10-013-3/+43
| | | | | | | | | | DwmGetCompositionTimingInfo works to find out vsync info on Vista+. Luckily using a NULL HWND (required on Win 8.1+) avoids the issue where the window starts flickering. BUG=291390 Review URL: https://codereview.chromium.org/25102004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226152 0039d316-1c4b-4281-b951-d872f2087c98
* ui/native_theme: Get rid of unnecessary views include.tfarina@chromium.org2013-10-012-2/+0
| | | | | | | | | | | | | It seems menu_config.h is not actually used by common_theme.cc. Remove it. BUG=None TEST=checkdeps.py passes, native_theme links. R=ben@chromium.org TBR=ben Review URL: https://codereview.chromium.org/25021004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226149 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that FocusOutlineManager.visible doesn't return a value.tkent@chromium.org2013-10-011-1/+1
| | | | | | | | | | We should return a value. BUG=283692 Review URL: https://codereview.chromium.org/25014007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226122 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Flip the close button when it is the leftmost button.erg@chromium.org2013-10-015-27/+62
| | | | | | | | | | | The linux close button assets are designed to be flipped when they're on the left side of the screen. They were not being flipped properly. BUG=281788 Review URL: https://codereview.chromium.org/24855003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226121 0039d316-1c4b-4281-b951-d872f2087c98
* remove PNGCodec::CreateSkBitmapFromBGRAFormat -- not referencedreed@google.com2013-10-012-30/+0
| | | | | | | | | | | | optimizations I was attempting.. until I discovered it is never called. 1. need to set opaque to true when we can (it never does in the current code) 2. the scale by alpha is numerically off by 1 for opaque-alpha BUG=302003 Review URL: https://codereview.chromium.org/25251004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226117 0039d316-1c4b-4281-b951-d872f2087c98
* Protect reentrant animations when IMMEDIATELY_ANIMATE_TO_NEW_TARGET is used.varkha@chromium.org2013-10-015-4/+84
| | | | | | | | | BUG=297974 TEST=TBD Review URL: https://codereview.chromium.org/25107002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226111 0039d316-1c4b-4281-b951-d872f2087c98
* events: Create a separate events component out of ui.sadrul@chromium.org2013-10-0116-93/+152
| | | | | | | | | BUG=none R=ben@chromium.org Review URL: https://codereview.chromium.org/24788002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226105 0039d316-1c4b-4281-b951-d872f2087c98
* enhance MenuItemView, MenuModelAdapter and SimpleMenuModel for dynamic model ↵kuan@chromium.org2013-10-016-62/+97
| | | | | | | | | | | | | | | | and menu this is in preparation for dynamic model and menu for recent tabs submenu: - move model-specific method from MenuItemView to MenuModelAdapter - add method to MenuModelAdapter to add menu item at specific index from model - add RemoveItemAt to SimpleMenuModel BUG=256750 TEST=nothing yet. Review URL: https://codereview.chromium.org/25174004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226096 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the desktop content and the container window in AURA has correct ↵ananta@chromium.org2013-09-308-135/+67
| | | | | | | | | | | | | | | | | | | | | | | sizes on all platforms. The addition of the desktop container window broke linux aura because it uses the Desktop layout manager which resized the container window once it became the child of the root window. On Windows AURA we don't use the Desktop layout manager. Fix is to unify the size handling code in the DesktopNativeWidgetAura class in the OnRootWindowHostResized notification. We resize both the content and the container windows here. The logic from the DesktopNativeWidgetAura::OnBoundsChanged function has been moved OnRootWindowHostResized OnRootWindowHostMoved handlers. As per discussion with sky removed the Desktop Layout Manager. BUG=292530 R=erg@chromium.org, sky@chromium.org, sky TEST=Covered by views test DesktopAuraWindowSizeTest Review URL: https://codereview.chromium.org/24704002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226057 0039d316-1c4b-4281-b951-d872f2087c98
* Remove touch_140/touch_180 assets.oshima@chromium.org2013-09-3036-0/+0
| | | | | | | | | | | They're no longer in use. BUG=299852 R=girard@chromium.org Review URL: https://codereview.chromium.org/25103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226041 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve find bar selection across tab switches.pkasting@chromium.org2013-09-301-2/+0
| | | | | | | | | | | | | This also removes SearchTextfieldView from the Windows code, which did nothing the underlying Textfield wasn't already doing. BUG=297385 TEST=Open the find bar in two tabs, select different text in each find bar, and toggle between the two tabs. The selections should be preserved. R=finnur@chromium.org, sail@chromium.org Review URL: https://codereview.chromium.org/24449008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226039 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of device scale factorben@chromium.org2013-09-301-1/+5
| | | | | | | | | R=sky@chromium.org http://crbug.com/300831 Review URL: https://codereview.chromium.org/25096003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226029 0039d316-1c4b-4281-b951-d872f2087c98
* Removing my self from OWNERSsail@chromium.org2013-09-301-1/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/25313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226006 0039d316-1c4b-4281-b951-d872f2087c98
* New resources for menu checks and arrows for selected menu items.estade@chromium.org2013-09-304-0/+0
| | | | | | | | | BUG=298398 R=oshima@chromium.org Review URL: https://codereview.chromium.org/24998010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226005 0039d316-1c4b-4281-b951-d872f2087c98
* Fix font size for virtual keyboard.kevers@chromium.org2013-09-301-0/+1
| | | | | | | | | BUG=294192 R=bshe@chromium.org Review URL: https://codereview.chromium.org/25033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225993 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for longpress typing of alternate keys.kevers@chromium.org2013-09-301-5/+13
| | | | | | | | | BUG=295062 R=bshe@chromium.org Review URL: https://codereview.chromium.org/25065002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225991 0039d316-1c4b-4281-b951-d872f2087c98
* The original bug happens because when libGL.so.1 is loaded, it registerschihchung@chromium.org2013-09-301-4/+3
| | | | | | | | | | | | | | | | | some function pointers to the X library, but there is no way to unregister them when it is unloaded. So if we keep using X after libGL.so.1 is unloaded, the stale function pointers will be called and bad things happen. The unloading happens after the first test is finished, so the second test always crashes. The fix is just don't unload these libraries. BUG=chromium:250813 TEST=run video_decode_accelerator_unittest on parrot and spring Review URL: https://codereview.chromium.org/23456029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225931 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the DBus dependency on CommitText.komatsu@chromium.org2013-09-302-7/+5
| | | | | | | | BUG=288388 Review URL: https://codereview.chromium.org/23498022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225913 0039d316-1c4b-4281-b951-d872f2087c98
* gfx: Create a separate gfx component out of ui.sadrul@chromium.org2013-09-3024-311/+475
| | | | | | | | | | | Landed previously in r225857, which was reverted in r225859 because it broke android tests. BUG=103304 R=ben@chromium.org Review URL: https://codereview.chromium.org/25015003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225909 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly resets long press timer when entering chording mode.rsadam@chromium.org2013-09-301-1/+1
| | | | | | | | BUG=297586 Review URL: https://codereview.chromium.org/25023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225903 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 225857 "gfx: Create a separate gfx component out of ui."ckocagil@chromium.org2013-09-2823-473/+311
| | | | | | | | | | | | | | | > gfx: Create a separate gfx component out of ui. > > BUG=103304 > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/25015003 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/25161002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225859 0039d316-1c4b-4281-b951-d872f2087c98
* gfx: Create a separate gfx component out of ui.sadrul@chromium.org2013-09-2823-311/+473
| | | | | | | | | BUG=103304 R=ben@chromium.org Review URL: https://codereview.chromium.org/25015003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225857 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this as the previous attempt failed on linux auraananta@chromium.org2013-09-282-4/+75
| | | | | | | | | | | | | | | Perform the window activation code in WM_ACTIVATE instead of WM_NCACTIVATE. This ensures that we don't inadvarently mark a window as active when the code uses APIs like FlashWindow, which send periodic WM_NCACTIVATE messages to flash the caption. BUG=297813 TEST=Covered by ui test WidgetNotActivatedOnFakeActivationMessages TBR=sky@chromium.org Review URL: https://codereview.chromium.org/25131002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225851 0039d316-1c4b-4281-b951-d872f2087c98
* Makes destruction of DesktopNativeWidgetAura saner (2)sky@chromium.org2013-09-273-25/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt 2 at this. This is same as last patch but I'm disabling unit test on linux as ownership of X widget is different than HWND when destroying parent with transients. Will file bug to track it down. Prior to this patch DesktopNativeWidgetAura destruction keyed off destruction of the window_ (not the rootwindow). This meant that by the time we destroyed the Widget the RootWindow was still live. This meant any children of the rootwindow, such as child widgets, were alive as well. The general expectation is that by the time a Widget is destroyed and child Widgets have also been destroyed. This patch changes destruction so that we key off the AcceleratedWidget going away. When that happens we destroy the RootWindow. By doing this we ensure child Widgets have also been destroyed. BUG=288953 TEST=covered by test R=ben@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/24990003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225814 0039d316-1c4b-4281-b951-d872f2087c98
* [rAC] Ensure proper keyboard navigation.groby@chromium.org2013-09-272-7/+22
| | | | | | | | | | | | | | BaseView blocks all keyDown:/keyUp: messages, but keyboard navigation relies on those messages travelling along the responder chain. This change makes sure that the BaseView subclass simply forwards all key messages to its next responder. NOTRY=true BUG=286524 Review URL: https://codereview.chromium.org/24170004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225806 0039d316-1c4b-4281-b951-d872f2087c98
* Initial commit of v2, an experiment to divine a simpler API for a hardware ↵ben@chromium.org2013-09-2726-0/+1034
| | | | | | | | | | | accelerated UI framework that can be used to write both a window manager and UI controls. BUG=none TBR=sky@chromium.org Review URL: https://codereview.chromium.org/25079003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225795 0039d316-1c4b-4281-b951-d872f2087c98
* Update READMEsben@chromium.org2013-09-272-15/+18
| | | | | | | | | BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/25091003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225792 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 225776 "Perform the window activation code in WM_ACTIVATE..."petewil@chromium.org2013-09-272-72/+4
| | | | | | | | | | | | | | | | | | | > Perform the window activation code in WM_ACTIVATE instead of WM_NCACTIVATE. > > This ensures that we don't inadvarently mark a window as active when the code uses APIs like FlashWindow, > which send periodic WM_NCACTIVATE messages to flash the caption. > > BUG=297813 > TEST=Covered by ui test WidgetNotActivatedOnFakeActivationMessages > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/24856002 TBR=ananta@chromium.org Review URL: https://codereview.chromium.org/25014006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225785 0039d316-1c4b-4281-b951-d872f2087c98
* Don't set DesktopNativeWidgetAura's window transparent if not necessary.jbauman@chromium.org2013-09-272-1/+11
| | | | | | | | | | | If it's not using the native frame (e.g. on XP), the window doesn't need to be transparent, which saves a clear before painting its contents. BUG= R=ben@chromium.org Review URL: https://codereview.chromium.org/24941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225781 0039d316-1c4b-4281-b951-d872f2087c98
* Perform the window activation code in WM_ACTIVATE instead of WM_NCACTIVATE.ananta@chromium.org2013-09-272-4/+72
| | | | | | | | | | | | | This ensures that we don't inadvarently mark a window as active when the code uses APIs like FlashWindow, which send periodic WM_NCACTIVATE messages to flash the caption. BUG=297813 TEST=Covered by ui test WidgetNotActivatedOnFakeActivationMessages R=sky@chromium.org Review URL: https://codereview.chromium.org/24856002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225776 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 225755 "Makes destruction of DesktopNativeWidgetAura saner"sky@chromium.org2013-09-273-131/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > Makes destruction of DesktopNativeWidgetAura saner > > Prior to this patch DesktopNativeWidgetAura destruction keyed off > destruction of the window_ (not the rootwindow). This meant that by > the time we destroyed the Widget the RootWindow was still live. This > meant any children of the rootwindow, such as child widgets, were > alive as well. The general expectation is that by the time a Widget is > destroyed and child Widgets have also been destroyed. > > This patch changes destruction so that we key off the > AcceleratedWidget going away. When that happens we destroy the > RootWindow. By doing this we ensure child Widgets have also been > destroyed. > > BUG=288953 > TEST=covered by test > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/24515004 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/25045005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225767 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Implement the rest of DesktopScreenX11.erg@chromium.org2013-09-274-21/+96
| | | | | | | | | | | | | | | | When trying to call GetDisplayNearestWindow(), we should just query the bounds of the DRWHX11 instead of either going through the aura::Window::GetBoundsInScreen() machinery or going to the X server. Also fixes a small regression in tracking open_windows() caused by a bad merge. BUG=287972 R=sadrul@chromium.org Review URL: https://codereview.chromium.org/24513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225765 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsRunningOnChromeOS to SysInfostevenjb@chromium.org2013-09-274-12/+4
| | | | | | | | | | | | | | | | | Also, use lsb-release/CHROMEOS_RELEASE_NAME instead of the USER env variable. This CL depends on https://codereview.chromium.org/23588009/ BUG=270135 For trivial base/ changes: R=derat@chromium.org, satorux@chromium.org, sky@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/23904025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225761 0039d316-1c4b-4281-b951-d872f2087c98
* Makes destruction of DesktopNativeWidgetAura sanersky@chromium.org2013-09-273-25/+131
| | | | | | | | | | | | | | | | | | | | | | Prior to this patch DesktopNativeWidgetAura destruction keyed off destruction of the window_ (not the rootwindow). This meant that by the time we destroyed the Widget the RootWindow was still live. This meant any children of the rootwindow, such as child widgets, were alive as well. The general expectation is that by the time a Widget is destroyed and child Widgets have also been destroyed. This patch changes destruction so that we key off the AcceleratedWidget going away. When that happens we destroy the RootWindow. By doing this we ensure child Widgets have also been destroyed. BUG=288953 TEST=covered by test R=ben@chromium.org Review URL: https://codereview.chromium.org/24515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225755 0039d316-1c4b-4281-b951-d872f2087c98
* BitmapContentLayerUpdater shouldn't reallocate bitmap smaller.jbauman@chromium.org2013-09-271-2/+3
| | | | | | | | | | | BitmapContentLayerUpdater was always allocating a new bitmap if the size of the region to be drawn changed, even if the new region was smaller. These unnecessary reallocations can be very expensive because they require page faults and for the operating system to clear out the memory. BUG=296423 R=ben@chromium.org, enne@chromium.org, vangelis@chromium.org Review URL: https://codereview.chromium.org/24486002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225751 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last dependencies on ui/base from ui/gfxben@chromium.org2013-09-27104-383/+438
| | | | | | | | | BUG=103304 R=sky@chromium.org Review URL: https://codereview.chromium.org/23498059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225722 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-27 12:32:18 +0000