| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8742030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97248
TEST=none
Review URL: http://codereview.chromium.org/8754003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Views screen locker password errors and the 3G promo bubble looks good; except:
I filed crosbug.com/23324 for ScreenLockerViews MouseEventRelay.
BUG=98322
TEST=MessageBubbles work as before (screen locker password errors, 3G MobileDataPromo).
Review URL: http://codereview.chromium.org/8557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, when bubbles pop up, Chrome renders as inactive/'unfocused'.
Call DisableInactiveRendering on Widget::Show rather than Widget construction.
BUG=98312,98323
TEST=Showing bubbles doesn't make Chrome appear inactive/'unfocused'.
Review URL: http://codereview.chromium.org/8741011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements GetTopLevel(), IsWindowActive(), and
ActivateWindow().
BUG=99712
TEST=added
Review URL: http://codereview.chromium.org/8692016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes clang plugin complaint about missing override:
./ui/gfx/compositor/compositor_cc.h:35:11: error: [chromium-style] Overriding method must be marked with OVERRIDE.
virtual void* GetDisplay();
^
Also, adds |SetCurrent| call to properly track context in |GLContextNSView::MakeCurrent|.
BUG=104390
TEST=Compiles on Mac/clang. compositor_unittests pass.
R=piman@chromium.org, kbr@chromium.org
Review URL: http://codereview.chromium.org/8748018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added desaturated gray IDR_FRAME, IDR_FRAME_INACTIVE, and IDR_FRAME_APP_PANEL for Aura.
BUG=105883
TEST=visual
Review URL: http://codereview.chromium.org/8748014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8741024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang bot (too much inlined). TBR since this just moves some code to
the .cc file.
Makes TestWebGraphicsContext3D::initialize create a stub context and
surface. This is needed otherwise we crash when code tries to access
the current context. Also makes GLContextStub::MakeCurrent set itself
as the current context.
BUG=104360
TEST=none
R=kbr@chromium.org,piman@chromium.org
TBR=kbr@chromium.org,piman@chromium.org
Review URL: http://codereview.chromium.org/8742022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API replaces gdk_window_lookup and gdk_xid_table_lookup which are
deprecated in 2.24. gdk_x11_window_lookup_for_display was added in 2.24.
As well porting the users to use this new API a compatability version was
added to the ui/base/gtk/gtk_compat.h file.
BUG=79722
TEST=Compiles and ui_unittests run. Chrome also runs.
Review URL: http://codereview.chromium.org/8632021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to use the preemption strategy in starting the new animation.
scheduleAnimation will queue up animations. Holding down
Ctrl-Home will after a while keep on rotating well after the accelerator key has been released
Review URL: http://codereview.chromium.org/8741016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit.
You are asked to review this as you have OWNERS for these files.
BUG=None
TEST=Compiles
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8699008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97845
TEST=none
Review URL: http://codereview.chromium.org/8682029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105443
TEST=None
Review URL: http://codereview.chromium.org/8700013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Alt-L (print layer tree)
Added name in RenderWidgetHostViewAura
Made Window::SetName update the layer name.
Review URL: http://codereview.chromium.org/8585007
TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/8741018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Alt-L (print layer tree)
Added name in RenderWidgetHostViewAura
Made Window::SetName update the layer name.
Review URL: http://codereview.chromium.org/8585007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is follow-up from review http://codereview.chromium.org/8486020.
This eliminates down-cast of GLSurface in CLContextNSView::Initialize in favor of
GLSurfaceNSView::OnMakeCurrent implementation. Also, allows offscreen path in USE_AURA
due to its usage in SharedResourcesCC.
BUG=104390
TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.*
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/8687016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8735009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cache substring bounds to avoid unnecessary g_free. Consolidate drawing functions with RenderTextWin. Remove UpdateLayout() from RenderText::SetSelectionModel().
BUG=103647
TEST=TextfieldViewModelTest; Manual test selection highlight on bidi text.
(Do not really know how to test "fi" ligature part. But since the selection
highlight is not done by using pango attribute, I would assume that solves the problem).
Review URL: http://codereview.chromium.org/8536047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context and
Clang errors on cros build bots:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20Clang%20%28ChromeOS%20dbg%29/builds/3620/steps/compile/logs/stdio
surface. This is needed otherwise we crash when code tries to access
the current context. Also makes GLContextStub::MakeCurrent set itself
as the current context.
BUG=104360
TEST=none
R=piman@chromium.org,kbr@chromium.org
Review URL: http://codereview.chromium.org/8733010
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8742006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
surface. This is needed otherwise we crash when code tries to access
the current context. Also makes GLContextStub::MakeCurrent set itself
as the current context.
BUG=104360
TEST=none
R=piman@chromium.org,kbr@chromium.org
Review URL: http://codereview.chromium.org/8733010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I couldn't reproduce locally and not 100% sure if this fixes the leak.
I'll remove suppression after I confirm it on the bot.
BUG=104760
TEST=none
Review URL: http://codereview.chromium.org/8662046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directly to the screen in the browser process.
The new composited code path is now the default, though the old code path
has been left in place under a command line flag while we gain confidence.
Issue 105344 has been filed about removing the old code path.
The new code path does not currently support 10.5. The consequence is that
plugins using the InvalidatingCoreAnimation rendering model will not work
on this version of Mac OS. Pepper 3D is not affected; it now uses a
different rendering path.
Changed the type of IOSurfaces' IDs from uint64 to uint32 in a few places
throughout the code to match the IOSurfaceID typedef in the system header.
This was necessary in order to simplify integration with Chrome's OpenGL
code.
There is a known problem in the new code path with garbage occasionally
being drawn to the plugin's area during live resizing of Core Animation
plugins. Issue 105346 has been filed to track this. It is unclear whether
the additional complexity of the fix that is likely needed is worth it.
Tested manually with the following content, with and without the
--disable-composited-core-animation-plugins flag:
- YouTube (does not trigger this code path)
- Google+ Hangouts
- http://unity3d.com/gallery/demos/live-demos (Unity 3D)
- http://www.erain.com/labs/molehill/ (Stage 3D in Flash 11)
- http://www.nissan-stagejuk3d.com/
(Stage 3D in Flash 11, live resizing; web site is flaky, sometimes
fails to start)
BUG=38967
TEST=manual testing with above test cases
Review URL: http://codereview.chromium.org/8678037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112006
Review URL: http://codereview.chromium.org/8587024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104396
TEST=none
Review URL: http://codereview.chromium.org/8659045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The desktop host window's bounds are set to cover the entire
display at startup on Chrome OS. This change makes us watch
for resolution changes and update the bounds accordingly.
BUG=105562
TEST=manual: ran it on a chrome os device, switched between 1024x768 and 1280x800, and checked that the host window was resized accordingly
Review URL: http://codereview.chromium.org/8727013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New API used:
gtk_widget_{set,get}_has_window - added 2.18 - replaces !GTK_WIDGET_NO_WINDOW
gtk_widget_{set,get}_allocation - added 2.18 - replaces direct access
gtk_bin_get_child - replaces direct access
gtk_widget_get_window - added 2.14 - replaces direct access
g_cclosure_marshal_VOID__BOXED - replaces gtk_marshal_VOID__BOXED
With these changes this directory can compile with GSEAL enabled and
deprecated functions disabled.
BUG=79722
TEST=Compiles and also the ui_unittests pass
Review URL: http://codereview.chromium.org/8646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8587024
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8662039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104133,104135
TEST=ShellTest.CreateLockScreenModalWindow, ShellTest.CreateModalWindow.
Review URL: http://codereview.chromium.org/8638013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8687031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8587024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all.
Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches what is done in render_text_linux.cc
and avoids doing unnecessary work unless needed.
BUG=none
TEST=Run chrome.exe with command-line --use-pure-views. Edit text in the omnibox. It should work as before.
Review URL: http://codereview.chromium.org/8633019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testing and what not.
I'll wire this up separately.
BUG=104360
TEST=none
R=piman@chromium.org
Review URL: http://codereview.chromium.org/8729016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Reorganizes views_examples target into two: views_examples_lib (a component) and views_examples_exe (a runner in views, which builds in Aura but does not run without crashing due to lack of desktop environment).
. Refactors ExamplesMain into ExamplesWindowContents, a contents view that hosts the examples UI. Makes a publicly exported function from views examples to show a window containing this view.
. Moves the examples into the views namespace.
. Adds a button to launch the ExamplesWindow inside aura_shell.
. Adds a NativeTabbedPaneViews to host the examples content. This is not a production class and is mostly just intended to get something onto the screen. The code is copy-pasta from NativeTabbedPaneWin. I imagine we can get rid of all of this once we stop using TabbedPanes in Chrome.
http://crbug.com/105622
TEST=none
Review URL: http://codereview.chromium.org/8687013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes:
- Don't try to replace small resources with large ones based on a compile flag. We'll need a more dynamic mechanism.
- No need to disable the Getting Started Guide
- Anything with TOOLKIT_USES_GTK won't support touch.
- Don't need the screen locker logout hack. WebUI screen locker now works, and is also about to work on Aura builds.
- Re-enable a bunch of tests which were disabled/flaky in TOUCH_UI builds.
- No need to disable SSL Client certificate selector, we have a WebUI version now.
- TOUCH-specific max tab count is gone, remove hack from test.
- Remove exclusions from chrome_tests.gypi for touch tests that are no longer included in the build.
BUG=105046
TEST=
Review URL: http://codereview.chromium.org/8691005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some checks for TOUCH_UI goes away, and some gets replaced with USE_AURA.
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8662011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code in SubmenuView expects the delta scroll to be in multiples of
MouseWheelEvent::kWheelDelta which is defined as 120 for all platforms.
However, MouseWheelEvent has an offset which is created using
kWheelScrollAmount, defined in ui/base/x/events_x.cc, which is set
to 53(this is a value used in GTK).
BUG=none
TEST=Open google.com in AURA build, go to Wrench Menu->Tools->Encoding where it shows a big list of menu items. Use mouse wheel to scroll through the list. Observe that the sub menu scrolls.
Patch by ckqr36@motorola.com
Review URL: http://codereview.chromium.org/8538003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is relying on the fact that the WebGraphicsContext3DInProcessImpl has a gfx::GLContext under the hood. The alternative is to push SetSwapInterval into the initialization of WebGraphicsContext3DInProcessImpl. I've preferred to do it here, because I think that they other clients of WebGraphicsContext3DInProcessImpl don't need vsync enabled.
BUG=none
TEST=Build chrome using GYP_DEFINES="use_aura=1 use_webkit_compositor=1". Run chrome with proprietary Nvidia driver (supports vsync). See no tearing when dragging the window around.
Review URL: http://codereview.chromium.org/8700007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8729013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These handlers were just calling DefWindowProc in a redraw lock.
Windows will handle these messages without our redraw lock.
Speculative fix for windows still rendering through Chrome.
www.google.com/support/forum/p/Chrome/thread?hl=en&tid=7c59b88a16fb3043&start=40
BUG=97808
TEST=Lower reports of similar rendering issues...
Review URL: http://codereview.chromium.org/8664013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105518
TEST=Build with -Duse_xi2_mt=1
Review URL: http://codereview.chromium.org/8717002
Patch from Ningxin Hu <ningxin.hu@intel.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue 23461.
BUG=105609
TEST=dialog colors should be correct again
Review URL: http://codereview.chromium.org/8725010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103886
TEST=see bug
Review URL: http://codereview.chromium.org/8675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inspired by r111713.
BUG=none
TEST=none
R=gbillock@chromium.org
Review URL: http://codereview.chromium.org/8687002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moved some static constants and functions into the anonymous namespaces, and marked a couple of static locals as const (because they are, and non-const static locals make me nervous).
NativeThemeWin is kind of a mess. I kept the public overload of PaintTextField next to the private overload because I think it probably should be private. The file length decreased by one line because I removed a blank line.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8679010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=94640
TEST=Verify thumbnails are still added to NTP page.
Review URL: http://codereview.chromium.org/8631002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8690004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8718004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8716001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111669 0039d316-1c4b-4281-b951-d872f2087c98
|