| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This time, we allow the StackingClient to be optional. If not specified, unparented windows will just be added to the RootWindow.
BUG=none
TEST=existing automation
Review URL: http://codereview.chromium.org/8916020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus is owned by child window.
This was causing a focus to be stolen when non active window calls ClearNativeFocus.
BUG=114477
TEST=OmniboxViewTest.PopupAccelerators passes with this change
Review URL: http://codereview.chromium.org/8931022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is advertised.
This will fix vista boxes with legacy XP drivers and make ANGLE work if D3D9Ex is disabled.
Review URL: http://codereview.chromium.org/8913015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid creating a temporary |gfx::Font| just to get its
name and size to pass it to Skia.
Note: There's room for further optimizations here, such
as caching, which I plan to look at in a future CL.
BUG=107394
TEST=Run aura and check that omnibox still looks fine. Run about:tracing and check that time used by this code is significantly decreased.
Review URL: http://codereview.chromium.org/8910004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Showing the avatar menu crashes after crrev.com/114330.
SizeToContents was called before BubbleFrameView init.
This workaround checks GetBubbleFrameView before calling SizeToContents.
Also, run OnAvatarMenuModelChanged on Init, not ctor.
BUG=106989,107574
TEST=No crash and doesn't regress crbug.com/106989.
Review URL: http://codereview.chromium.org/8909013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first of several CLs to add a "laptop mode" to Aura that works like the traditional ChromeOS browser view. In particular:
* Keep the browser maximized.
* Hide window caption buttons.
* Suppress the launcher and related shelf items.
* Suppress background image.
* Add the switch to about:flags.
These things don't work yet:
* Status area is wedged in upper-left corner.
* Popup browser windows are maximized and they shouldn't be.
BUG=106898
TEST=manual, run ChromeOS Aura build and turn the flag on and off
Review URL: http://codereview.chromium.org/8895003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8909007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/8936011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105879
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8915007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
together, so I'm relanding together. Here's the original descriptions:
Fixes layout bugs in ShelfLayoutManager. The problem with invoking
SetBounds on the widget during the animation is we end up back in the
layoutmanager and cancel the change. Also adds some tests for
ShelfLayoutManager.
and
Create a visible shelf and constrain window movement
This also includes the fix, which you reviewed @
http://codereview.chromium.org/8914012 .
BUG=106432 107287 107401
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8914023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=God
NOTRY=true
BUG=chromium:107599
TEST=None
Review URL: http://codereview.chromium.org/8818013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We appear to need to mark classes AURA_SHELL_EXPORT in order to use them in unit tests.
TBR=sky@chromium.org
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8911010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8933010/ caused a regression in interactive_ui_tests on Linux+Aura+ChromeOS
http://codereview.chromium.org/8873036/
was rebased on the above and had to be reverted
TBR=sky@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8916010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106432
TEST=None
Review URL: http://codereview.chromium.org/8873036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetBounds on the widget during the animation is we end up back in the
layoutmanager and cancel the change. Also adds some tests for
ShelfLayoutManager.
BUG=107287 107401
TEST=see bug, but now covered by unit tests.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8929023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24183
TEST=Manual. Focus is seen on login screen, input works.
TBR=ben
Review URL: http://codereview.chromium.org/8890096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit da56a47ab4279016cd690e576bee1d81d414aac5.
TBR=ben@chromium.org
BUG=none
TEST=browser_tests should pass without crash
Review URL: http://codereview.chromium.org/8938015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accelerator, so VKEY_MENU must be handled when released.
BUG=106998,104359
TEST=OmniboxViewTest.AltEnter pases on x11/aura
Review URL: http://codereview.chromium.org/8883041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher I routed obtaining the id through the shell delegate (since
it lives in chrome).
BUG=105900
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8933010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unit tests.
Review URL: http://codereview.chromium.org/8926008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=about:tracing
Review URL: http://codereview.chromium.org/8895020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105879
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8917018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetImageNamed().
BUG=106060
TEST=none
Review URL: http://codereview.chromium.org/8937012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
styles (foreground, underline, strike) are applied through Skia (not Pango) during drawing the text.
BUG=106120
TEST=build aura, start chromium, type in bank of america in omnibox (https://.... while https is drawn as green). ctrl-l, the whole URL should be drawn in the same white foreground.
Review URL: http://codereview.chromium.org/8920008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8938005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105900
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8934007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105204
TEST=Manual
Review URL: http://codereview.chromium.org/8817018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=none
Review URL: http://codereview.chromium.org/8921022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceBundle().
BUG=106060
TEST=none
Review URL: http://codereview.chromium.org/8917026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL (http://codereview.chromium.org/8821004/) was causing crash on some of browser_tests due to this.
BUG=104361
TEST=manual, and browser_tests now pass without crash
Review URL: http://codereview.chromium.org/8892025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114095
Review URL: http://codereview.chromium.org/8894018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8926004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new truncate mode is needed by my upcoming changes to
rewrite CanvasSkia::DrawText().
Part of the change is changing the binary search code to a
more traditional form that also makes the truncate mode
work correctly. This is covered by the new unit tests.
BUG=105550
TEST=New and existing tests in text_elider_unittest.cc.
Review URL: http://codereview.chromium.org/8917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
character keys.
I also added an unittest entry that checks the accelerator is processed only once. This test has failed before.
This CL depends on
http://codereview.chromium.org/8834014/
BUG=106702
TEST=Ran aura_shell_unittest
Review URL: http://codereview.chromium.org/8833012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105879
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8909002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeComboboxViews was not passing itself as a (transient) parent to
MenuRunner::RunMenuAt. All mouse events were sent to the open menu (since it
is set as the capture window), and ModalityEventFilter::PreHandleMouseEvent
dropped them all since they were not directed to a child of the active modal
dialog.
BUG=105155
TEST=none
Review URL: http://codereview.chromium.org/8893019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui::KeyboardCodeFromXKeysym.
Add some X keysym names that are handled by the former function to the latter.
BUG=103511
TEST=ran try
Review URL: http://codereview.chromium.org/8803004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug 107104)
- Improve RenderTextWin font fallback.
Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.
This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.
The CL includes some modifications to address this.
Some tests are disabled under XP, see:
http://crbug.com/106450
Also, fixes some lint warnings.
BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020
TBR=asvitkine@chromium.org
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Improve RenderTextWin font fallback.
Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.
This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.
The CL includes some modifications to address this.
Some tests are disabled under XP, see:
http://crbug.com/106450
Also, fixes some lint warnings.
BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020
TBR=asvitkine@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes crash on JS dialog popups from the extension bubbles.
Check for child HWND in WidgetFocusChangeListener::OnNativeFocusChange.
Code from BubbleWidget in browser_bubble_win.cc (crrev.com/112278)
See Issue 106958 for Aura, the dialog&bubble close early without crashing.
BUG=106723,106958
TEST=The js alert extension attached to the issue doesn't crash, popup works on non-aura.
Review URL: http://codereview.chromium.org/8879045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split --aura-windows into --aura-workspace-manager and --aura-translucent-frames.
Also fixed a bug where the window frame was still opaque despite the latter flag.
BUG=106890
TEST=manual, run with all combinations of above flags
Review URL: http://codereview.chromium.org/8890036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=98345
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8892013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have several copies of the code that draws the non-client frame area of windows, including OpaqueBrowserFrameView, ConstrainedWindowFrameViews, CustomFrameView, and others. We need yet another version for Aura. Rather than make another copy I'm trying to refactor out the common drawing code. This is step 1, creating a views::FrameBackground class and using it in two cases.
BUG=102797
TEST=visual, try normal frame, install a theme, open a constrained window like cookie > Show cookies and other site data, open a popup from popuptest.com
Review URL: http://codereview.chromium.org/8772060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=none
Review URL: http://codereview.chromium.org/8897006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104248
TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests
Review URL: http://codereview.chromium.org/8890042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/8873038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8888037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When defined USE_XI2_MT, slot id of TouchEvent is maintained
by a map of tracking id to slot id. Because tracking id will
always keep increasing. The item should be released by TouchRelease
to free the slot id for future use.
BUG=106673
TEST=Manually Tested
Review URL: http://codereview.chromium.org/8839004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes tests either use mock compositor or mock
WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.
Attempt 2 failed because of last minute changes to chrome_tests.gypi
that I didn't merge properly with. TBRing again.
BUG=104360
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8890050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113809 0039d316-1c4b-4281-b951-d872f2087c98
|