summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
...
* Ignore attempts by the window manager to put chrome in fullscreen or out of ↵pkotwicz@chromium.org2014-06-173-43/+124
| | | | | | | | | | | | | | | | | | fullscreen. Chrome currently does not propagate the fullscreen state from views::Widget to the other places which need it (Browser, BrowserView, FullscreenController). Previously, when the window manager would attempt to put the window into fullscreen we would update layout, but the bookmark bar would not hide because it is toggled by Browser::WindowFullscreenStateChanged(). The exit bubble would not show either. BUG=362998 TEST=DesktopWindowTreeHostX11Test.WindowManagerTogglesFullscreen Review URL: https://codereview.chromium.org/332743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277609 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Remove deprecated color_picker_simple_border which is not used.shouqun@chromium.org2014-06-171-1/+0
| | | | | | | | | | | According to http://crrev.com/23026006, color_picker_simple_border is deprecated. BUG= TEST= Review URL: https://codereview.chromium.org/334183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277595 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid spinning the UI loop in WidgetTest.ExitFullscreenRestoreStatetapted@chromium.org2014-06-161-10/+5
| | | | | | | | | | | | | | | | | | Otherwise a failure can result in an infinite loop and stdio spew that clogs the test runner. This also helps ensure maximize and fullscreen states read back via the widget are updated synchronously. This behaviour is assumed for the correct operation, e.g., of NativeAppWindowViews and packaged app APIs. Bot runs and local tests with --gtest_repeat suggest that this does not inadvertently introduce flakiness. BUG=378134 Review URL: https://codereview.chromium.org/321353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277578 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a spelling mistake in a comment.rjkroege@chromium.org2014-06-161-2/+2
| | | | | | | | | BUG=none TBR=spang@chromium.org. Review URL: https://codereview.chromium.org/338223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 276827 "readability review for luken"cpu@chromium.org2014-06-168-1767/+1525
| | | | | | | | | | | | | | | | | | | This is crashing for our canary users on Windows BUG=384736 > readability review for luken > > original code review at: > https://codereview.chromium.org/245763002/ > > Review URL: https://codereview.chromium.org/269513002 TBR=luken@chromium.org Review URL: https://codereview.chromium.org/338833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277532 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Skeleton implementation of OSExchangeDataProviderMac.andresantoso@chromium.org2014-06-164-5/+154
| | | | | | | | | This gets ui_unittests to compile and not crash when TOOLKIT_VIEWS=1 on Mac (but there are still 7 failures). Review URL: https://codereview.chromium.org/337833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277529 0039d316-1c4b-4281-b951-d872f2087c98
* [Ozone-DRI] Fix VLOG message when mode is NULLdnicoara@chromium.org2014-06-161-1/+1
| | | | | | | | | | | | | A NULL mode signifies a disable operation. In this case print an empty size. This fixes the case where printing the mode size causes a segfault since the mode is NULL. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/334363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277527 0039d316-1c4b-4281-b951-d872f2087c98
* Notifies capslock state changed in fake ime keyboard.shuchen@chromium.org2014-06-161-0/+20
| | | | | | | | | BUG=375586 TEST=Verified on Pixel device and linux_chromeos. Review URL: https://codereview.chromium.org/334863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277524 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Fill in InputMethod access in NativeWidgetMac.andresantoso@chromium.org2014-06-164-8/+66
| | | | | | | | | | | | Add NativeWidgetMac implementation of CreateInputMethod() and GetHostInputMethod(). We can now pass more unit tests including TextfieldTest and ComboboxTest. BUG=374077 Review URL: https://codereview.chromium.org/332893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277521 0039d316-1c4b-4281-b951-d872f2087c98
* Removes X11 dependency in ui/base/ime/... and InputMethodEngine.shuchen@chromium.org2014-06-1613-153/+248
| | | | | | | | | BUG=380349, 355261, 369891 TEST=Verified in Pixel device, and made sure existing browser_tests are not broken. Review URL: https://codereview.chromium.org/324903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277512 0039d316-1c4b-4281-b951-d872f2087c98
* Added VLOGs to touch_exploration_controller.cc for better debugging messages.lisayin@chromium.org2014-06-162-6/+97
| | | | | | | | BUG=377040 Review URL: https://codereview.chromium.org/319023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277496 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #includes in tooltip_aura.cc.sungmann.cho@navercorp.com2014-06-161-1/+0
| | | | | | | | | | | | After the landing https://codereview.chromium.org/191663002, tooltip_aura.cc doesn't need the command line switch related headers anymore. So we can remove these. BUG=350569 Review URL: https://codereview.chromium.org/333213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277488 0039d316-1c4b-4281-b951-d872f2087c98
* Start removing USE_ASH.erg@chromium.org2014-06-162-4/+3
| | | | | | | | BUG=375466 Review URL: https://codereview.chromium.org/294053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277485 0039d316-1c4b-4281-b951-d872f2087c98
* Fix accessibility in Windows x64 build.dmazzoni@chromium.org2014-06-162-4/+10
| | | | | | | | | | | | | | The only fix needed was to cast the LPARAM to a DWORD when handling WM_GETOBJECT in two places. Also fixes and re-enables a bunch of Windows accessibility tests, and deletes a couple of old disabled tests that aren't worth fixing. BUG=179717,383240 Review URL: https://codereview.chromium.org/329863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277457 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes unittests with --enable-text-input-focus-manager flag enabled.yukishiino@chromium.org2014-06-167-30/+117
| | | | | | | | | | | Some unittests get broken when --enable-text-input-focus-manager is enabled. Fixes those tests. BUG=290701 TEST=Run unittests. Review URL: https://codereview.chromium.org/334573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277444 0039d316-1c4b-4281-b951-d872f2087c98
* CHR-1796: Implement UIATextProvider::get_Value method.mpichlinski@opera.com2014-06-163-6/+19
| | | | | | | | | | | | | On Windows 8 LDTP gettextvalue function uses IRawElementProviderSimple::GetPatternProvider for UIA_ValuePatternId and method IValueProvider::get_Value which is not implemented instead of IAccessible::get_accValue. BUG=384224 Review URL: https://codereview.chromium.org/337453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277416 0039d316-1c4b-4281-b951-d872f2087c98
* App list: TileItemView::SetAppListItem exits early if item already set.mgiuca@chromium.org2014-06-161-0/+10
| | | | | | | | | | | | This effectively caches the result of CalculateKMeanColorOfBitmap so it does not have to be recomputed every time the start page view is reset. Noticeable improvement in the time it takes to switch to the start page. BUG=382795 Review URL: https://codereview.chromium.org/326023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277407 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Add browser tests to test the default action dialog.hirono@chromium.org2014-06-161-4/+21
| | | | | | | | | BUG=383738 TEST=run the test Review URL: https://codereview.chromium.org/330003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277392 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Stop video support in the gallery.hirono@chromium.org2014-06-162-41/+2
| | | | | | | | | | | | We have the separated video player, and we don't need to play videos in the gallery. BUG=251702 TEST=None Review URL: https://codereview.chromium.org/337893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277388 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Refocus to the list after renaming a file/folderyoshiki@chromium.org2014-06-161-0/+2
| | | | | | | | | BUG=383234 TEST=manually tested Review URL: https://codereview.chromium.org/333203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277384 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Add new owners to the ui/file_manager directory and its tests.hirono@chromium.org2014-06-161-0/+1
| | | | | | | | | | BUG=None TEST=None R=kinaba@chromium.org Review URL: https://codereview.chromium.org/338733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277365 0039d316-1c4b-4281-b951-d872f2087c98
* Removed un-used commandline switches.zmo@chromium.org2014-06-142-14/+0
| | | | | | | | | | | | | | | | | --disable-gl-multisampling (replaced by gpu_driver_bug_workaround switch --disable_multisampling) --enable-chromium-branding (no longer used) --force_discrete (no longer used, use gpu_driver_bug_workaround instead) --force_integrated (no longer used, use gpu_driver_bug_workaround instead) --gpu-switching (no longer used, use gpu_driver_bug_workaround instead) BUG=351312 TEST=bots R=kbr@chromium.org,piman@chromium.org,sky@chromium.org,nfullagar@chromium.org Review URL: https://codereview.chromium.org/321913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277256 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces network error state to the app_list voice search.mukai@chromium.org2014-06-144-18/+28
| | | | | | | | | | BUG=383015 R=xiyuan@chromium.org TEST=manually Review URL: https://codereview.chromium.org/331543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277245 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed overview mode crashing when being cancelled during selection movementnsatragno@chromium.org2014-06-142-9/+31
| | | | | | | | | | | | | | The reason this was happening is that the selection widget being animated after having been destroyed. This patch fixes the problem by making sure there is actually a root window when invoking widget movement/resize events. BUG=382982 TEST=WidgetTest.CloseWidgetWhileAnimating Review URL: https://codereview.chromium.org/328723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277214 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 277111 "Roll ICU to icu52"sorin@chromium.org2014-06-132-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It breaks a bunch of bots with a compile time error ../out/Release/gen/tc_pnacl_newlib/lib/libicuuc_nacl.a: error: undefined reference to 'icudt52_dat' For example: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/7531 > Roll ICU to icu52 > > The ICU update does the following among other things: > - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG > encoding spec. > - Add CP866 > - Add far better/more extensive support for plural, format, etc > - Numerous locale data update > - Khmer/Lao line/word-breaking support > - More compact Chinese/Japanese dictionary (now a part of the upstream > instead of our local patch) > - Better plural support that we plan to use right away. > > - Update icu/BUILD.gn : file list update, new defines, etc. > - Update tests > a. icu_string_conversions_unittests : drop iscii (nobody uses it) and > remove JIS X 212 code points from the round-trip test > b. l10n_util_unittests: Display names for zh-*. > c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change). > d. Update Expected results in file_manager_browsertest/test_util.js > (see http://crbug.com/383930) > - Update SpellcheckerWordIterator > a. Add U+0027 back to MidNumLet > b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based > word-breaking. > - l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino) > - Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full > has 'at' before time, which is not handled by Date.parse() > - update license.py because we don't have a separate Chinese/Japanese > dictionary any more. It's now a part of ICU > > BUG=132145,277023,136148,360433,364072 > TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*, > browser_tests (encoding related, Iden*verifyGet*), > unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*, > layout tests (encoding, date/calendar, line breaking, and others), > build 'base_i18n_nacl', GN build bots. > > Review URL: https://codereview.chromium.org/265613002 TBR=jshin@chromium.org Review URL: https://codereview.chromium.org/336793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277117 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittests for X11TopmostWindowFinderpkotwicz@chromium.org2014-06-1310-192/+590
| | | | | | | | | | | | | | | | A couple of additional changes: - Moves X11PropertyChangeWaiter to its own class so that it can be shared among several tests - Moves the dependency on Xlib.h out of path_x11.h and uses forward declaration instead. This is necessary because the definitions of "None" and "Bool" in Xlib.h conflict with those in gtest. - Moves X11WindowEventFilter::SetUseHostWindowBorders() into x11_util.cc so that it can be used in tests on X windows which are not associated with a views::Widget BUG=None TEST=X11TopmostWindowFinderTest.* R=sadrul TBR=sky (For trivial change to the includes in ui/gfx/path_x11.*) Review URL: https://codereview.chromium.org/264713007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277116 0039d316-1c4b-4281-b951-d872f2087c98
* Roll ICU to icu52jshin@chromium.org2014-06-132-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ICU update does the following among other things: - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG encoding spec. - Add CP866 - Add far better/more extensive support for plural, format, etc - Numerous locale data update - Khmer/Lao line/word-breaking support - More compact Chinese/Japanese dictionary (now a part of the upstream instead of our local patch) - Better plural support that we plan to use right away. - Update icu/BUILD.gn : file list update, new defines, etc. - Update tests a. icu_string_conversions_unittests : drop iscii (nobody uses it) and remove JIS X 212 code points from the round-trip test b. l10n_util_unittests: Display names for zh-*. c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change). d. Update Expected results in file_manager_browsertest/test_util.js (see http://crbug.com/383930) - Update SpellcheckerWordIterator a. Add U+0027 back to MidNumLet b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based word-breaking. - l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino) - Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full has 'at' before time, which is not handled by Date.parse() - update license.py because we don't have a separate Chinese/Japanese dictionary any more. It's now a part of ICU BUG=132145,277023,136148,360433,364072 TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*, browser_tests (encoding related, Iden*verifyGet*), unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*, layout tests (encoding, date/calendar, line breaking, and others), build 'base_i18n_nacl', GN build bots. Review URL: https://codereview.chromium.org/265613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277111 0039d316-1c4b-4281-b951-d872f2087c98
* Export SearchProvider interface to ui/app_list and use it in athena.mukai@chromium.org2014-06-135-1/+122
| | | | | | | | | | BUG=380444, 380875 R=oshima@chromium.org, xiyuan@chromium.org TEST=compile succeeds, manually check behavior Review URL: https://codereview.chromium.org/331523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277094 0039d316-1c4b-4281-b951-d872f2087c98
* Updated Slider to raise drag started and ended events for touch gestures.bruthig@chromium.org2014-06-136-52/+461
| | | | | | | | | BUG=370181 Test=SliderTest.GesturesWithNoListener, SliderTest.TapGesture, SliderTest.ScrollGestureWithoutUpdate, SliderTest.ScrollGestureWithUpdate, SliderTest.ScrollGestureTransitionsToFling Review URL: https://codereview.chromium.org/308003008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277093 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Route raw screen coordinates to touch eventsjdduke@chromium.org2014-06-136-16/+76
| | | | | | | | | | | Use the |MotionEvent.getRaw{X,Y}| properties to properly populate the touch event's screen coordinates via |WebTouchPoint.screenPosition|. BUG=382488 Review URL: https://codereview.chromium.org/336513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and simplify RTHB GetGlyphXBoundary logicckocagil@chromium.org2014-06-133-10/+42
| | | | | | | | | | BUG=382692 R=msw NOTRY=true Review URL: https://codereview.chromium.org/328683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277069 0039d316-1c4b-4281-b951-d872f2087c98
* Aura tooltips do not move on mouse move in case of many neighboringmboc@opera.com2014-06-136-3/+202
| | | | | | | | | | | | | | | views with the same tooltip label BUG=Aura tooltips do not move on mouse move in case of many neighboring views with the same tooltip label. This can be really uncomfortable when working with lots of tabs with the same address on the tab strip. Try creating ~30 startpage tabs and hover over one of them, then move the cursor to others. The tooltip will just sit in the place where it was first shown. Review URL: https://codereview.chromium.org/213833018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277010 0039d316-1c4b-4281-b951-d872f2087c98
* Gallery.app: Add new gallery icons.hirono@chromium.org2014-06-1311-4/+14
| | | | | | | | | | | | | Previously we uses the image file type icon as the application icons. This CL replaces them with real ones. BUG=371284 TEST=manually R=yoshiki@chromium.org Review URL: https://codereview.chromium.org/331783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277006 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Supports text input on non UTF-8 environments.yukishiino@chromium.org2014-06-131-3/+6
| | | | | | | | | | | | | | | | We have assumed that XLookupString always returns a UTF-8 string, but it's not true. It could be any other encoding depending on the system locale and we have to support it. The root cause of the Issue 376893 is 1. XLookupString returns a ISO-8859-1 string (for example) 2. We converts it by UTF8ToUTF16. 3. The resulting character code is zero. 4. Cannot input a (non-ASCII) character. BUG=376893 Review URL: https://codereview.chromium.org/323023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277003 0039d316-1c4b-4281-b951-d872f2087c98
* Show copy progress based on processed bytes of all contained files.fukino@chromium.org2014-06-131-18/+55
| | | | | | | | | | | | When we receive 'end_copy_entry', we can add (entry.size - entry.processedBytes) as a processed bytes of the operation. Too many calls to progressCenter can use too much memory and can prevent progressPanel to be updated, so we throttle calling progressCallback() in updateProgress(). BUG=373627 Review URL: https://codereview.chromium.org/325693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276993 0039d316-1c4b-4281-b951-d872f2087c98
* Show scrollbar while the area is scrolling.fukino@chromium.org2014-06-132-1/+14
| | | | | | | | | | | | | Scrollbar should keep visible while a user is scrolling the view. To achieve this, the view listen to 'scroll' event and make the scrollbar visible. After some time have passed (currently 1 second), the scrollbar will get invisible. BUG=373632 TEST=manually tested Review URL: https://codereview.chromium.org/326333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276989 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Address spurious scale detection issuesjdduke@chromium.org2014-06-137-30/+164
| | | | | | | | | | | | | | | | | Certain device constants for scale detection interact poorly with large or variable touch sizes. Fix this by explicitly suppressing pinch detection if there is but one active touch point. Also address an issue where the first touch sequence seen after ScaleGestureDetector creation would trigger a scale event because of improper NaN initialization. Finally, port the latest update from the Android platform GestureDetector for suppressing double-taps (including double-tap drag zooms) if the time delay between the first pointer up and the second pointer down is sufficiently short. BUG=376618,382209,340263 Review URL: https://codereview.chromium.org/330723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276965 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Initial skeleton for implementing NativeWidgetMactapted@chromium.org2014-06-138-13/+305
| | | | | | | | | | | | | | | | | | | | | | | | | This adds two classes under ui/views/cocoa: BridgedNativeWidget (a C++ class which bridges an NSWindow) and BridgedContentView (an Objective-C "root" NSView which bridges a views::View). With respect to NativeWidgetMac, BridgedNativeWidget performs a role similar to aura::Window on Aura platforms. Among other things, it will (soon) be a ui::LayerOwner. It serves for implementation-hiding: it owns Objective-C objects for NativeWidgetMac so that native_widget_mac.h does not force .cc files to become .mm. It also allows implementation-sharing between NativeWidgetMac and, later, DesktopNativeWidgetMac. BridgedContentView allows messages to feed through from Cocoa into toolkit-views, by implementing the required Objective-C interfaces and bridging to C++ code. Adds 3 tests, and gets 17 others passing. Total 202/468 passing. BUG=378134 Review URL: https://codereview.chromium.org/329743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276957 0039d316-1c4b-4281-b951-d872f2087c98
* RenderTextHarfBuzz: Replace bare static pointer with base::LazyInstance<>::Leakyckocagil@chromium.org2014-06-131-21/+26
| | | | | | | | | | BUG=383956 R=msw NOTRY=true Review URL: https://codereview.chromium.org/334743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276956 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where NVDA wouldn't enter browse mode on page load.dmazzoni@chromium.org2014-06-131-2/+3
| | | | | | | | | | | | This started happening when we started sending events on web pages before they fully load. BUG=368549 NOTRY=true Review URL: https://codereview.chromium.org/332893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276944 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BaseBubbleController close issue.xrenishere@gmail.com2014-06-132-0/+10
| | | | | | | | | | | | | | | | A bubble should disappear when we right mouse click on a blank space. Add event monitor for NSRightMouseDownMask, and change not to use performSelector, for sometimes when rightmouse down happens, a menu comes out. This menu might be a Modal Dialogue Box. So we can't perform the windowDidResignKey until the menu is closed. BUG=378186 TEST="--gtest_filter=BaseBubbleControllerTest.*" R=rsesek@chromium.org Review URL: https://codereview.chromium.org/300113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276875 0039d316-1c4b-4281-b951-d872f2087c98
* Views which cannot process events cannot be tooltip targetstdanderson@chromium.org2014-06-132-4/+11
| | | | | | | | | | | | | | | | The check for CanProcessEventsWithinSubtree() needs to be made on |this| before the loop (along with HitTestRect()) instead of inside the loop on the children. Otherwise it would be possible to return a view for which CanProcessEventsWithinSubtree() returns false. BUG=382873, 378530 TEST=Added coverage in ViewTest.CanProcessEventsWithinSubtree Review URL: https://codereview.chromium.org/327843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276873 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Fix slop region boundary handling.tdresser@chromium.org2014-06-126-23/+64
| | | | | | | | | | | | | | | | | | | | Committed https://src.chromium.org/viewvc/chrome?view=rev&revision=276728. Broke gn build. Reverted: https://codereview.chromium.org/330613003 Ensure the screenPosition of touches is never truncated to an integer. Check if the unified gesture detector is enabled before disabling the inclusive slop region. BUG=381174 TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/334753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276852 0039d316-1c4b-4281-b951-d872f2087c98
* Do not mirror views bubbles anchored to minimized widgets.msw@chromium.org2014-06-121-1/+2
| | | | | | | | | | | | Bubbles should not use the anchor rect of minimized windows. BUG=372713 TEST=Minimizing and restoring Chrome with a session restore bubble should leave the bubble anchored as it was. R=sky@chromium.org Review URL: https://codereview.chromium.org/332593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276845 0039d316-1c4b-4281-b951-d872f2087c98
* readability review for lukenluken@chromium.org2014-06-128-1525/+1767
| | | | | | | | | original code review at: https://codereview.chromium.org/245763002/ Review URL: https://codereview.chromium.org/269513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276827 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Allow held touch-events to contribute to gesture events.sadrul@chromium.org2014-06-122-14/+58
| | | | | | | | | | | | | | | When a touch-move event is 'held', i.e. it is not dispatched, the event does produce any gesture events. However, once this 'held' event is dispatched (either because a touch-release event was encountered, or because ReleasePointerMoves() was called on the dispatcher), it should be used to generate the appropriate gesture events. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/332703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276781 0039d316-1c4b-4281-b951-d872f2087c98
* Move unusual character block logic to a helper functionckocagil@chromium.org2014-06-124-32/+64
| | | | | | | | | | BUG= NOTRY=true R=msw Review URL: https://codereview.chromium.org/324983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276776 0039d316-1c4b-4281-b951-d872f2087c98
* The 1st patch to disambiguate message center notificationsjuyik@chromium.org2014-06-1211-55/+80
| | | | | | | | | | | | | | | | | | | | | | | | | This is the first half of the work to disambiguate the message center notifications originated from different profiles. It clarifies the semantics of message center as the backend of notification by: 1) Adding comments on the usage of id in the MessageCenter interface. 2) Adding a FindVisibleNotificationById(id) method to message center interface so users can directly find backend notifications without going to the notification ui manager interface. 3) Removing the redundant HasNotification() method since the FindVisibleNotificationById() can server the same purpose. Reviewers: * davemoore: please review chrome/browser/chromeos/* * jamescook: please review ash/* TBR=davemoore@chromium.org BUG=297867 Review URL: https://codereview.chromium.org/324583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276756 0039d316-1c4b-4281-b951-d872f2087c98
* [Ozone] Fix component builddnicoara@chromium.org2014-06-121-0/+2
| | | | | | | | | | | | | Missing header include would result in symbols being defined locally only. TBR=spang@chromium.org NOTRY=true BUG=none Review URL: https://codereview.chromium.org/335663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276744 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable unified gesture detector.tdresser@chromium.org2014-06-121-2/+2
| | | | | | | | | | | | Enabled here: https://codereview.chromium.org/315713002/ Disable here: https://codereview.chromium.org/312303003/ BUG=332418 TEST=GestureRecognizerTest.* Review URL: https://codereview.chromium.org/318853005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276742 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-27 18:24:46 +0000