summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Fixs bug where keyevents weren't created correctly on Xsky@chromium.org2014-06-191-1/+1
| | | | | | | | | | | | | This resulted in incorrect processing and things like entering not working. BUG=386256 TEST=none R=ben@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/344763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278369 0039d316-1c4b-4281-b951-d872f2087c98
* App list uses PaginationModel to transition between pages.mgiuca@chromium.org2014-06-195-63/+198
| | | | | | | | | | | | Should not affect behaviour of the normal app list. The experimental app list now transitions pages in from the correct side of the screen, instead of simply sliding pages out to the left. BUG=377381 Review URL: https://codereview.chromium.org/316393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278361 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix: Translate: leak of a ComboboxModelhajimehoshi@chromium.org2014-06-193-0/+70
| | | | | | | | | | | | | | | A ui::Combobox (|denial_combobox_|) doesn't take an owner of a ui::ComboboxModel, so we should have clarify who is the owner of the combobox model. This CL fixed the leak to make TranslateBubbleView owner of the ui::ComboboxModel (|denial_combobox_model_|). BUG=309468 R=sky@chromium.org Review URL: https://codereview.chromium.org/330443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278347 0039d316-1c4b-4281-b951-d872f2087c98
* Fix first time switching from classic to GTK theme.estade@chromium.org2014-06-191-1/+3
| | | | | | | | | | Make sure Widget observes the correct NativeTheme. Wait until everything else is done initializing so GetNativeTheme() returns the right thing. BUG=384492 Review URL: https://codereview.chromium.org/330873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278334 0039d316-1c4b-4281-b951-d872f2087c98
* Add device policy: Kiosk Virtual Keyboard Layout.rsadam@chromium.org2014-06-192-5/+29
| | | | | | | | BUG=376900 Review URL: https://codereview.chromium.org/320223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278317 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multi-finger click no entry bug in TouchExplorationControllerevy@chromium.org2014-06-192-5/+64
| | | | | | | | | | | | | Fixes a bug where user starts a right click through double tap long press or split tap long press, and places down more fingers, resulting in a no-entry sign over a grey box appearing on the screen that the user cannot leave by clicking. This was fixed by making sure the release of the long press has the same touch id as the press, where before it was the id final finger to be released. BUG=385302 TEST=TouchExplorationTest.* Review URL: https://codereview.chromium.org/334223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278310 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the colour and layout logic of the App Info dialog headingsashab@chromium.org2014-06-192-0/+3
| | | | | | | | | | | | | | | Added a colour to the version number and updated the font size to better match the mocks. Also fixed a small bug in the logic that lays out the name and version to place the version number on the next line if there are no links (no webstore or license links) for the app. Based off CL 335523002. BUG=385423, 383720 Review URL: https://codereview.chromium.org/336333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278290 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Drive app integration.xiyuan@chromium.org2014-06-192-0/+10
| | | | | | | | | | | | | | | - DriveAppProvider to map Drive apps to chrome apps or local url apps; - DriveAppMapping to track the mapped chrome apps; - DriveServiceBridge to wrap DriveAPIService and DriveAppRegistry to provide the user Drive apps info; - Put feature behind "--enable-drive-apps-in-app-list"; BUG=358791,345066 TEST=DriveAppProviderTest.*:DriveAppMappingTest.* Review URL: https://codereview.chromium.org/308003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278265 0039d316-1c4b-4281-b951-d872f2087c98
* Repairs crash in RTreeBase::Node::LeastAreaEnlargementluken@chromium.org2014-06-198-1525/+1780
| | | | | | | | | | | | | | | | | | | | This CL was originally uploaded at https://codereview.chromium.org/269513002 but was reverted due to a high number of crash reports on Windows. The issue was that RTree::Insert() would remove duplicate nodes before re-inserting them, but didn't handle the corner case where the root node would end up as a non-leaf node with only one child. RTree::Remove() did the right thing in this case, which is to remove the root and replace it with its solitary child, but RTree::Insert() did not. This lead to a situation with invalid trees being created that would ultimately lead to a crash on a subsequent call to RTree::Insert(). A short unit test that reproduced the crash is included. BUG=384736 Review URL: https://codereview.chromium.org/342723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278227 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes TooltipControllerTest to create a toplevel tooltip window on Linux.pkotwicz@chromium.org2014-06-193-123/+17
| | | | | | | | | | | Also removes obsolete test cases which tested the behavior before tooltips were toplevel windows on Linux BUG=None TEST=None Review URL: https://codereview.chromium.org/333333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278221 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Label::PaintText overrides.msw@chromium.org2014-06-194-12/+21
| | | | | | | | | | | | | | | | | This is simple cleanup in preparation for a Label rewrite. These overrides were supplying an extra gfx::Canvas flag. Instead, add an explicit label flag for NO_SUBPIXEL_RENDERING. Update some callers and the unit test. TODO(followup): Update more Label::SetBackgroundColor callers. BUG=240037 TEST=No exit warning or sticky keys label rendering changes. R=sky@chromium.org Review URL: https://codereview.chromium.org/341713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278213 0039d316-1c4b-4281-b951-d872f2087c98
* Create scanout buffer in GbmSurfaceFactory.alexst@chromium.org2014-06-192-0/+37
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/341603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278209 0039d316-1c4b-4281-b951-d872f2087c98
* Change to CustomFrameView Caption Button Inset.jonross@chromium.org2014-06-181-1/+5
| | | | | | | | | | Restrict increase of button inset to linux only. This will allow the Windows Classic theme to maintain its look, while the updated linux look is still available. This returns the inset size on non-linux platforms to their state pre r272576 BUG=381821 Review URL: https://codereview.chromium.org/336553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278173 0039d316-1c4b-4281-b951-d872f2087c98
* [reland] views: Move MenuButton from TextButton to LabelButton.erg@chromium.org2014-06-1811-30/+87
| | | | | | | | | | | | | | | | | | | | | | | [This reland also fixes an issue with the label drawn on top of the old profile switching menu. It also expands ExtensionApiTest.Bookmarks disabling from just Windows to Windows and Linux.] This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases. This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux. BUG=155363,331924,385934,383452 R=msw@chromium.org, noms@chromium.org TBR=msw@chromium.org, sky@chromium.org First Review URL: https://codereview.chromium.org/298813002 Review URL: https://codereview.chromium.org/344643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278156 0039d316-1c4b-4281-b951-d872f2087c98
* Add dmazzoni to owners of ui/chromeos for accessibility featuresjamescook@chromium.org2014-06-181-0/+3
| | | | | | | | | BUG=none R=dmazzoni@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/343713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278122 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor views::Label and gfx::RenderText shadow functions.msw@chromium.org2014-06-188-69/+19
| | | | | | | | | | | | | | This is mechanical cleanup in preparation for a Label rewrite. Use simple gfx::ShadowValues setter functions everywhere. Remove a forbidden static FontList instance. BUG=240037 TEST=No appearance changes for views text shadows. R=sky@chromium.org Review URL: https://codereview.chromium.org/343513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278101 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the controllers when ScreenManager is deleteddnicoara@chromium.org2014-06-181-0/+2
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/344443009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278100 0039d316-1c4b-4281-b951-d872f2087c98
* Added split tap to TouchExplorationController.evy@chromium.org2014-06-183-42/+314
| | | | | | | | | | | | | | Split tap allows a user to click while in touch exploration mode by tapping a second finger anywhere on the screen. *Added TOUCH_EXPL_SECOND_PRESS state and a InTouchExplSecondPress function in the controller *Added tests for tap and tap hold events, and also tested the case where the user lifts the touch exploration finger first. BUG= 385151 TEST = TouchExplorationTest.* Review URL: https://codereview.chromium.org/333623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278093 0039d316-1c4b-4281-b951-d872f2087c98
* Re-styled App Info Dialog according to UI feedback 2sashab@chromium.org2014-06-182-0/+4
| | | | | | | | | | | | | | | Re-styled the App Info Dialog again according to new UI feedback. This involves moving the 'Remove' and 'Create Shortcuts' buttons into a new AppInfoFooterPanel, which is displayed at the bottom of the app info dialog. Depends on review https://codereview.chromium.org/327743002/. BUG=266739 Review URL: https://codereview.chromium.org/335523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278072 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use-after-free when switching profiles in the experimental app list.calamity@chromium.org2014-06-184-9/+31
| | | | | | | | | | | This CL fixes an issue where the ContentsSwitcherView would dereference a pointer to a freed ContentsView. BUG=384957 Review URL: https://codereview.chromium.org/334293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky AppsGridViewTest on valgrind bot.xiyuan@chromium.org2014-06-183-35/+29
| | | | | | | | | | | | | - Remove local test timeouts; - Add page flip history to PageFlipWaiter and use that for test expectations to solve the problem that a single Wait returns with multiple page flipping happened on valgrind; BUG=385167 Review URL: https://codereview.chromium.org/339933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278049 0039d316-1c4b-4281-b951-d872f2087c98
* [Views] Add a capability to the bubble delegate to be able to set the font ↵gbillock@chromium.org2014-06-184-0/+27
| | | | | | | | | | of the title. BUG=383947 Review URL: https://codereview.chromium.org/326963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278045 0039d316-1c4b-4281-b951-d872f2087c98
* Slight refactor of search result handling in ContentsView.calamity@chromium.org2014-06-182-15/+20
| | | | | | | | | | | | This CL is a small refactor of ContentsView::ShowSearchResults() which avoids resetting the start page before showing the search results in the experimental app list. BUG=349727 Review URL: https://codereview.chromium.org/331413003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278024 0039d316-1c4b-4281-b951-d872f2087c98
* Finalize documentation for the automation extension API.dtseng@chromium.org2014-06-181-0/+3
| | | | | | | | | | | | | | | | | | This duplicates the accessibility enums between accessibility and automation converting to camel casing. It also cleans up some of the idl For the sake of record, attempts to share the same enum ran into the following issues: - the docs generator assumes a one-to-one (save camel/snake/unix casing) correspondance between filenames and idl namespaces. - the handlebar templating language does not allow for logical string comparisons/equality checks or passing in-line string literals, so attempting to in-line names was unsuccessful. - references to the enums (which were cased for the sake of cpp enums), were incorrect for the docs (which want camel casing). A local cl with the change is still available but suffers from odd filename, casing conflicts, and AX* naming issues. BUG=309681 Review URL: https://codereview.chromium.org/335923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278011 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the position of drag thumbnail when the scale settings is not 100%.hirono@chromium.org2014-06-182-41/+72
| | | | | | | | | | | | | | | | | | | | | | The thumbnail of an image file is a squared image. This is implemented as an image in a square container. The non square image is cropped by the square container, but the hidden part of the image causes unwated position gap of the dragging thumbnail. Previously we handle the gap by adding 1000px padding for the thumbnail. But the padding causes another bug when the browser is shown in non 100% scale. This CL stops to add 1000px padding. Instead, to handle the unwanted gap, the CL let Files.app copy the image to a square canvas. For the solution, we don't need to crop an image by a square canvas because the canvas itself is square, and thus we are free from position gap problem. BUG=339179 TEST=manually R=mtomasz@chromium.org Review URL: https://codereview.chromium.org/338253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277993 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move canvas tests into gfx_unittests target.tfarina@chromium.org2014-06-182-2/+2
| | | | | | | | | | | | | Pretty straightforward, nothing really blocks it, so we can move it easily from ui_unittests target to gfx_unittests now. BUG=331829 TEST=ui_unittests, gfx_unittests with/out --test-launcher-bot-mode TBR=danakj@chromium.org,ben@chromium.org Review URL: https://codereview.chromium.org/332353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277978 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of views: Move MenuButton from TextButton to LabelButton. ↵jackhou@chromium.org2014-06-1811-87/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/298813002/) Reason for revert: This is causes ExtensionApiTest.Bookmarks to fail on Linux: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5412 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32272 TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org NOTRY=true NOTREECHECKS=true Original issue's description: > views: Move MenuButton from TextButton to LabelButton. > > This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases. > > This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux. > > BUG=155363 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277878 Review URL: https://codereview.chromium.org/340003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277974 0039d316-1c4b-4281-b951-d872f2087c98
* Update OWNERS of ui/app_list and chrome/browser/ui/app_list.mgiuca@chromium.org2014-06-181-1/+2
| | | | | | | | | | | | Added calamity and mgiuca (working heavily in these folders). Removed koz (no longer works on app list). BUG=None NOTRY=true Review URL: https://codereview.chromium.org/339983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277971 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up GLSurfaceCGLccameron@chromium.org2014-06-186-170/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is in preparation for support for using remote CALayers. The big change is to separate out ImageTransportSurfaceIOSurface into ImageTransportSurfaceFBO and its StorageProvider. The IOSurface- specific bits of ImageTransportSurfaceIOSurface are moved into the StorageProvider. A separate CALayer-specific version will be added later. While in the neighborhood, don't make everything inherit from GLSurfaceCGL (that class doesn't actually do anything). Move the helper functions and classes from its file to more appropriate locations. Make image_transport_surface_mac.cc a .mm file, because it will need to include Objective C code in the near future. Move the ImageTransportSurfaceFBO into its own file. Also make the IOSurface handles in renderer_host use the 32-bit IOSurfaceID handle type instead of uint64, since that is the type actually used by the interface, and those other bits may find use in disambiguating handle types. BUG=312462 Review URL: https://codereview.chromium.org/334173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277970 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist (0,0) sized offscreen surfaces on Windowsdnicoara@chromium.org2014-06-181-0/+4
| | | | | | | | BUG=381041 Review URL: https://codereview.chromium.org/341673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277969 0039d316-1c4b-4281-b951-d872f2087c98
* Force resetting the VK insets when overscroll mode is disabled.kevers@chromium.org2014-06-181-0/+2
| | | | | | | | | | The login and lock screens can toggle overscroll mode for the virtual keyboard without triggering a rebuild of the VK. Thus, it is possible to be in an inconsistent state between keyboard bounds change notifications. This patch forces any insets to be reset if overscroll mode is not enabled. BUG=384981 Review URL: https://codereview.chromium.org/341623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277961 0039d316-1c4b-4281-b951-d872f2087c98
* GN: Fix up various gpu targetsjamesr@chromium.org2014-06-181-1/+1
| | | | | | | | | | | | | | | This makes the gl_tests and gpu_unittests targets link and run and fixes up a few other misc issues: *) outdated nss filelists and defines *) outdated cc file lists R=brettw@chromium.org, piman@chromium.org TBR=ben@chromium.org for ui/events/ change Review URL: https://codereview.chromium.org/338633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277958 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off accessibility access to notification images.petewil@chromium.org2014-06-181-5/+34
| | | | | | | | | | | | | | | | | Since we don't have alt text yet, accessibility screen readers have nothing useful to say in screen readers. Until alt text is available, disable the images from appearing in the screen reader. This is done by removing the accessibility child object from a parent. In this case, we introduce a new fake parent object for the small icon, and make the existing parent ignore the image for the large icon and the large image of an image notification. BUG=381363 Review URL: https://codereview.chromium.org/325203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277957 0039d316-1c4b-4281-b951-d872f2087c98
* Fix progress bar indicator for accessibility.petewil@chromium.org2014-06-171-0/+15
| | | | | | | | | | | | The progress bar was not being read properly by screen readers for the Mac (VoiceOver). This gives the screen reader enough information to do its job. BUG=370512 Review URL: https://codereview.chromium.org/333643007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277880 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move MenuButton from TextButton to LabelButton.erg@chromium.org2014-06-1711-30/+87
| | | | | | | | | | | | This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases. This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux. BUG=155363 Review URL: https://codereview.chromium.org/298813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277878 0039d316-1c4b-4281-b951-d872f2087c98
* Add notification title back to ChromeOS.dewittj@chromium.org2014-06-171-1/+4
| | | | | | | | | | | Fixes regression introduced by r276036 that removed the title from the notification center on ChromeOS. BUG=350449 Review URL: https://codereview.chromium.org/335413005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277870 0039d316-1c4b-4281-b951-d872f2087c98
* keyboard: Fix hit-testing code to not create the keyboard window.sadrul@chromium.org2014-06-172-9/+51
| | | | | | | | | | | | | KeyboardControllerProxy::GetKeyboardWindow() can create the keyboard window if it's not already created. So during hit-testing, use HasKeyboardWindow() to first determine if the window exists, before using GetKeyboardWindow(). BUG=380215 R=kevers@chromium.org Review URL: https://codereview.chromium.org/341573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277854 0039d316-1c4b-4281-b951-d872f2087c98
* Use shorter timeouts in GestureRecognizerTest suite.tdresser@chromium.org2014-06-171-2/+9
| | | | | | | | | | Locally, this reduces the time the suite takes from ~15 seconds to ~5 seconds. BUG=384314 Review URL: https://codereview.chromium.org/333893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277844 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the BubbleFrameView close button insets.msw@chromium.org2014-06-171-16/+17
| | | | | | | | | | | | | | | | | | Set the button size after setting the border. (this takes the updated insets into account) Refine BubbleFrameView's title bar layout calculations. Return the close button's right inset in GetTitleInsets. See before/after pics on the bug (expected is with this CL). BUG=385422 TEST=Views dialogs place the (x) close button correctly. R=sky@chromium.org Review URL: https://codereview.chromium.org/339063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277822 0039d316-1c4b-4281-b951-d872f2087c98
* Add dnicoara to ui/ozone/platform/{caca,dri} OWNERSspang@chromium.org2014-06-172-0/+2
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/323343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277770 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Add a test to open a file dialog box.hirono@chromium.org2014-06-174-24/+70
| | | | | | | | | BUG=345059 TEST=run the test Review URL: https://codereview.chromium.org/331583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277727 0039d316-1c4b-4281-b951-d872f2087c98
* aura-linux: Supports deadkey + shift + alphabet for XIM.yukishiino@chromium.org2014-06-172-3/+37
| | | | | | | | | | | https://codereview.chromium.org/243143002/ was incomplete and it does not take care of deadkey + shift + alphabet combinations. This CL complements it and takes care of key sequences including shift key. BUG=367103 TEST=Done manually. Review URL: https://codereview.chromium.org/321963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277714 0039d316-1c4b-4281-b951-d872f2087c98
* Make BoundsAnimator always own its animation delegate.pkasting@chromium.org2014-06-175-49/+35
| | | | | | | | | | | All non-unittest code wanted this behavior. BUG=none TEST=none Review URL: https://codereview.chromium.org/331323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277707 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the GetUndocumentedDPIScale and GetUndocumentedDPITouchScale ↵ananta@chromium.org2014-06-174-49/+4
| | | | | | | | | | | | | methods from ui/gfx/win/dpi.cc/.h as these are no longer needed given that Chrome is now HiDPI aware. On the same lines removed some code from the GetMinimizeButtonOffsetForWindow function for window which attempts to workaround some issues with Surface Pro. This is also not needed given that we are HiDPI aware. BUG=338172 Review URL: https://codereview.chromium.org/336873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277696 0039d316-1c4b-4281-b951-d872f2087c98
* Improve list CSS in optionsestade@chromium.org2014-06-171-3/+3
| | | | | | | | | | | | - less jiggle in autofill edit address lists (e.g. name list) when you select the item - fix some broken css (hasElementFocus should be has-element-focus). - Don't apply "new" list css to autofill edit address lists because it looks terrible (change list rules to .settings-list) BUG= Review URL: https://codereview.chromium.org/335113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277692 0039d316-1c4b-4281-b951-d872f2087c98
* Add new DialogDelegate type for dialogs in the App Listsashab@chromium.org2014-06-172-65/+0
| | | | | | | | | | | | | | | | | | | | Add a simpler WidgetDelegate for dialogs in the app list. The current app list dialogs extend DialogDelegate, which can't be customised enough to achieve the required look for dialogs that open inside the app list. Also, a lot of functions that WidgetDelegate provides are not useful for app list dialogs (e.g. OK/cancel buttons, a titlebar, etc). For now, only the App Info Dialog will use this dialog type. In a later commit, all dialogs that can be launched from the app launcher (including the Uninstall and Create Shortcuts dialogs) will be modified to use this same dialog style. BUG=369888 Review URL: https://codereview.chromium.org/306023011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277691 0039d316-1c4b-4281-b951-d872f2087c98
* android: Fix set_area size for snapshot_androidpowei@chromium.org2014-06-171-1/+11
| | | | | | | | | | | | | | | | | | For Chrome for Android, the size of the layers correspond to their physical pixel size. We should scale the copy request subrect by the device scale factor. The reason why content/test/gpu/page_sets/pixel_tests.py never failed is because the test only takes a 300x300 sub-region of the output bitmap; so as long as the request subrect is greater than that region, the test will pass through. After this change, ui::GrabViewSnapshot will return a bitmap of the content in phyiscal pixel size. Should not affect pixel_tests.py. BUG=384551 Review URL: https://codereview.chromium.org/333413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277690 0039d316-1c4b-4281-b951-d872f2087c98
* GN: libjpeg_turbo and various mac fixesjamesr@chromium.org2014-06-171-1/+4
| | | | | | | | | | | | This adds yasm rules for the assembly in libjpeg_turbo and fixes various issues that show up on the Mac GN build. With this blink_heap_unittests builds and runs. R=brettw@chromium.org, kbr@chromium.org Review URL: https://codereview.chromium.org/334013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277689 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spacing of bubble buttons in RTL.michaelpg@chromium.org2014-06-171-1/+1
| | | | | | | | | | | Tiny change replaces margin-left with webkit-margin-start to properly space controlled setting indicators in RTL. R=dbeam@chromium.org Review URL: https://codereview.chromium.org/338903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277676 0039d316-1c4b-4281-b951-d872f2087c98
* Combobox arrow theming for aura linuxestade@chromium.org2014-06-179-30/+81
| | | | | | | | | | See bug for before and after screenshots. BUG=384164 Review URL: https://codereview.chromium.org/337613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277612 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-27 16:16:26 +0000