summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
...
* Use a direct include of the message_loop header in ui/, part 2.avi@chromium.org2013-07-1844-45/+45
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19631002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212291 0039d316-1c4b-4281-b951-d872f2087c98
* Fix logic for accent key and long press on key without any accentbshe@chromium.org2013-07-182-4/+10
| | | | | | | | | | | | | | This CL fixes two things: 1. Should set back to lower case after select any accent key at upper case mode 2. Should not remove the active class from a key without any accent keys after a long press BUG=254408 Review URL: https://chromiumcodereview.appspot.com/19277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212286 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in ui/, part 1.avi@chromium.org2013-07-1843-48/+44
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19629002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212243 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 212230 "Create top-level separate targets for browser and..."scottmg@chromium.org2013-07-182-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caused Linux x64 sizes to fail for reasons unclear. > Create top-level separate targets for browser and child dlls > > The general idea is that there's top level targets chrome and chrome_child, > and corresponding content_app and content_app_child that depend on only > the subtargets that should be included in the appropriate dll. > > Pull bluetooth_utils from bluetooth_device into separate common target > as it's referenced from chrome/common/extensions. > > Currently (probably) Windows-only and requires setting chrome_multiple_dll=1 > for gyp. > > Links, but Blink is still included in browser. > > Single-process mode is currently disabled when chrome_multiple_dll is set. > > Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html > generated by "python tools\win\split_link\graph_dependencies.py deps.html" > > Remove the previous hacky-er attempt at this that was named "split dll". > > TBR=jam@chromium.org > > BUG=237249,256965 > > Review URL: https://codereview.chromium.org/17619005 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/19572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212239 0039d316-1c4b-4281-b951-d872f2087c98
* Create top-level separate targets for browser and child dllsscottmg@chromium.org2013-07-182-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The general idea is that there's top level targets chrome and chrome_child, and corresponding content_app and content_app_child that depend on only the subtargets that should be included in the appropriate dll. Pull bluetooth_utils from bluetooth_device into separate common target as it's referenced from chrome/common/extensions. Currently (probably) Windows-only and requires setting chrome_multiple_dll=1 for gyp. Links, but Blink is still included in browser. Single-process mode is currently disabled when chrome_multiple_dll is set. Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html generated by "python tools\win\split_link\graph_dependencies.py deps.html" Remove the previous hacky-er attempt at this that was named "split dll". TBR=jam@chromium.org BUG=237249,256965 Review URL: https://codereview.chromium.org/17619005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212230 0039d316-1c4b-4281-b951-d872f2087c98
* Settings: Can't delete a long URL item in start-up overlay.tkent@chromium.org2013-07-181-1/+1
| | | | | | | | | | | | r211560 was not a right fix. Dispatching 'blur' events during capturing phase can disturb user's mouse click. In this CL, we cancel button focus in button's mousedown handler, and don't remove focus from the URL field. BUG=260553 Review URL: https://chromiumcodereview.appspot.com/19463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix squished webui overlay issue.dbeam@chromium.org2013-07-181-24/+26
| | | | | | | | | | | Overlays have a max-height: 0; until some initialization code is called to set their height via JavaScript. This was being registered to be done on DOMContentLoaded and this was before other files' DOMContentLoaded handlers initialized contents (which affects the JS logic to set the dialog sizes). R=estade@chromium.org BUG=258752 Review URL: https://chromiumcodereview.appspot.com/19235009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212222 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring. Move ui/base/win/ime_input.* to ui/base/ime/win/yoichio@chromium.org2013-07-189-110/+114
| | | | | | | | | | renaming ImeInput to IMM32Manager. That is IMM32 API wrapper. BUG=246534 Review URL: https://chromiumcodereview.appspot.com/19504004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212199 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing doubleclick issue in aura/ash metro mode.shrikant@chromium.org2013-07-182-4/+21
| | | | | | | | | | | | Added tracking for double clicks when mouse events are generated synthetically. BUG=235630 R=ananta,cpu,sky TEST=Please follow steps as outlined in the bug description. Review URL: https://chromiumcodereview.appspot.com/19027004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 212022 "The previous implementation is not correct, it de..."gavinp@chromium.org2013-07-171-10/+0
| | | | | | | | | | | | | | | | > The previous implementation is not correct, it depended on the Fullscreen video class, but the PowerSaveBlocker could be used for embedding video or the use case which isn't related to the video at all. > > This patch adds new API to PowerSaveBlocker. > > BUG=247892 > > Review URL: https://chromiumcodereview.appspot.com/17175009 TBR=michaelbai@chromium.org Review URL: https://codereview.chromium.org/19659002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212092 0039d316-1c4b-4281-b951-d872f2087c98
* Uprev polymer librarybshe@chromium.org2013-07-1710-36/+36
| | | | | | | | | BUG=None R=kevers@chromium.org Review URL: https://codereview.chromium.org/19257004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212066 0039d316-1c4b-4281-b951-d872f2087c98
* The previous implementation is not correct, it depended on the Fullscreen ↵michaelbai@chromium.org2013-07-171-0/+10
| | | | | | | | | | | | video class, but the PowerSaveBlocker could be used for embedding video or the use case which isn't related to the video at all. This patch adds new API to PowerSaveBlocker. BUG=247892 Review URL: https://chromiumcodereview.appspot.com/17175009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212022 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexturepiman@chromium.org2013-07-171-1/+1
| | | | | | | | | | | These are not used anymore except for clearing the client-provided texture, so this removes 1 of 4 TextureLayer paths, and implifies externally-exposed state. BUG=None Review URL: https://chromiumcodereview.appspot.com/19303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212008 0039d316-1c4b-4281-b951-d872f2087c98
* Message center re-organizedsidharthms@chromium.org2013-07-1713-50/+171
| | | | | | | | | | | | The message center has been re-organized to get rid of unused classes since we don't need the rounded corners and the arrow. This redesign affects Linux (Aura) and Windows builds BUG=249482, 259577 Review URL: https://chromiumcodereview.appspot.com/18003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212007 0039d316-1c4b-4281-b951-d872f2087c98
* Sets notifier's image at construction.mukai@chromium.org2013-07-171-0/+2
| | | | | | | | | | | | Sometimes a notifier may not call UpdateIconImage() later but in notifier from beginning. Synced notifications would be an example. BUG=None R=rsesek@chromium.org Review URL: https://chromiumcodereview.appspot.com/19238008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition which could allow an accelerated surface to be read ↵zturner@chromium.org2013-07-172-0/+19
| | | | | | | | | | | | | | | | from before it had been presented to. The issue is caused by an insufficient check to determine when the surface is ready to be copied to. It is possible for the surface object to be created but not the swap chain. This CL requires that both the surface and the swap chain be created before the test can run. BUG=260438 @sky: content/browser/* @apatrick: ui/surface/* Review URL: https://chromiumcodereview.appspot.com/19286007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211961 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Change the mouse cursor during drag operations.erg@chromium.org2013-07-178-34/+93
| | | | | | | | BUG=130806 Review URL: https://chromiumcodereview.appspot.com/19280005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211959 0039d316-1c4b-4281-b951-d872f2087c98
* Settings: Do not focus on buttons by right-press.tkent@chromium.org2013-07-171-2/+0
| | | | | | | | | | | | | Blink changes focus by mouse right-press too. We should ignore it in Settings UI if FocusManager.disableMouseFocusOnButtons is called. Note that this change won't affect right-click context menu. BUG=259653 Review URL: https://chromiumcodereview.appspot.com/19275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211949 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA/Telemetry stats for end-to-end scroll latencymiletus@chromium.org2013-07-171-8/+9
| | | | | | | | | | | | | | | | This CL adds the UMA/Telemetry metric for measuring the end-to-end scroll latency from when the original touch events are created to when the final frame is swapped. BUG=246034 TEST=1. Run telemetry smoothness test and make sure average_scroll_update_latency is in the result. 2. Check that chrome://histograms/Event.Latency.TouchToScrollUpdateSwap exist after scrolling some webpages. Review URL: https://chromiumcodereview.appspot.com/18937002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211948 0039d316-1c4b-4281-b951-d872f2087c98
* Progress bars for app install in the OSX App Launcher grid.tapted@chromium.org2013-07-176-55/+235
| | | | | | | | | | | | | | | | | | | | | | | Observe ItemHighlightedChanged, ItemIsInstallingChanged and ItemPercentDownloadedChanged in the app list grid to show install progress. Install progress uses an NSProgressIndicator in the grid cell that temporarily replaces the button title. When the item is fully downloaded, the progress bar briefly turns into an indeterminate bar whilst unpacking the bundle and finishing the install. Screenshots at http://crbug.com/138633#c75 BUG=138633 TEST=Show the OSX app launcher while installing a big item from the webstore. A follow-up will enable the webstore to show the launcher on mac automatically. Also added app_list_unittests AppsGridControllerTest.ItemInstallProgress Review URL: https://chromiumcodereview.appspot.com/18703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211944 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove an API that's never called.groby@chromium.org2013-07-173-12/+0
| | | | | | | | | | TBR=sky@chromium.org R=ben@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/18462003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211942 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 211928 "Ignore reordered notifications in the NTP for ins..."tapted@chromium.org2013-07-177-217/+59
| | | | | | | | | | | | | | | | | | | | | | This had a wonky rebase :( > Ignore reordered notifications in the NTP for installing apps. > > Changes to the app sort order via ExtensionSorting does not rely on the > extension corresponding to the reordered ID to be installed. This > changes a DCHECK to instead ignore such changes for the NTP webui. > > BUG=257960 > TEST=Enable App Launcher, install a big app, and move it in the app > launcher while it is downloading. Chrome should not crash. > > Review URL: https://chromiumcodereview.appspot.com/18807003 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/19517002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211941 0039d316-1c4b-4281-b951-d872f2087c98
* Crash fix (divide by zero) for ComputeLetterboxRegion() and extra sanity checks.miu@chromium.org2013-07-171-0/+2
| | | | | | | | | BUG=259599 TEST=Added expectation to ComputeLetterboxRegion unit test. Manually confirmed the crash mentioned in the bug went away with this fix. Review URL: https://chromiumcodereview.appspot.com/19092003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211939 0039d316-1c4b-4281-b951-d872f2087c98
* Use the wider Bold/Normal font in LabelButton::GetPreferredSize.msw@chromium.org2013-07-171-4/+11
| | | | | | | | | | | | | | Some text appears wider when rendered normally than when bold. Accommodate the widest, as buttons may show bold and shouldn't resize. See ui_strings_ja.xtb's "キャンセル" (Cancel) cut off at http://crbug.com/259156 BUG=259156 TEST=CrOS --lang=ja doesn't elide Cancel dialog button text, see the bug. R=mukai@chromium.org,kochi@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/18513007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211935 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore reordered notifications in the NTP for installing apps.tapted@chromium.org2013-07-177-59/+217
| | | | | | | | | | | | | | Changes to the app sort order via ExtensionSorting does not rely on the extension corresponding to the reordered ID to be installed. This changes a DCHECK to instead ignore such changes for the NTP webui. BUG=257960 TEST=Enable App Launcher, install a big app, and move it in the app launcher while it is downloading. Chrome should not crash. Review URL: https://chromiumcodereview.appspot.com/18807003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211928 0039d316-1c4b-4281-b951-d872f2087c98
* Add reset button for each preference in gesture config UImohsen@chromium.org2013-07-171-0/+2
| | | | | | | | | | | | | A reset button is added for each preference in the gestue config UI (chrome://gesture). When no value is set for a preference (i.e. it is set to default), the button is disabled. When a value is set, the button is enabled and can be used to reset the preference to the default value. BUG=251858 Review URL: https://chromiumcodereview.appspot.com/18023026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211927 0039d316-1c4b-4281-b951-d872f2087c98
* Enable pop-up menus in OSX App Launcher for search results.tapted@chromium.org2013-07-174-9/+96
| | | | | | | | | | | | | | | | | | | | | | | | | Adds a lazily created MenuController for search result items in the AppsSearchResultsModelBridge. This is populated from the model when a menu is requested for a context-menu event on the results NSTableView. The menu is the same as the context menu shown on the items in the grid. Also fixes a bug where the lightweight ItemObservers were not created when setting the initial model. Only really a problem in tests, since the search results model is otherwise empty when first populating the view. However, the observers should be updated at the same time to be consistent. Screenshot at http://crbug.com/138633#c78 BUG=138633 TEST=Search for an installed app in the OSX App Launcher. Right-click the result. A (functional) context menu should be shown matching the menu shown in the grid. Also covered by added app_list_unittests:AppsSearchResultsControllerTest.ContextMenus Review URL: https://chromiumcodereview.appspot.com/18071011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211914 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent popup windows from showing in the taskbar in Linuxsidharthms@chromium.org2013-07-171-0/+18
| | | | | | | | | | | | Since we don't use any special window type for popup windows which tells the window manager to hide them from the taskbar, we need to specifically ask it to do so. This change only affects top-level popup windows. BUG=259581 Review URL: https://chromiumcodereview.appspot.com/18238015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211909 0039d316-1c4b-4281-b951-d872f2087c98
* Reverse the direction of the slash on notifications DnD mode.dewittj@chromium.org2013-07-166-0/+0
| | | | | | | | | TBR=oshima@chromium.org BUG=260864 Review URL: https://codereview.chromium.org/19417004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211862 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webui keyboard regressionbshe@chromium.org2013-07-165-87/+127
| | | | | | | | | | | | | | | | | | We are iterating on layout of extension keyboard fast. To avoid maintain layouts for extension keyboard and webui keyboard, and avoid unintentionally break webui keyboard during experiment on extension keyboard, this CL creates webui_index.html to completely seperate them. Note: this is temporary, once we have dynamical layout loading mechanism implemented, we should remove webui_index.html file and only use index.html for both webui and extension keyboard. BUG=260283 R=bryeung@chromium.org, kevers@chromium.org Review URL: https://codereview.chromium.org/19157007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211850 0039d316-1c4b-4281-b951-d872f2087c98
* Make views::MenuItemView respect menu sublabels.estade@chromium.org2013-07-167-57/+80
| | | | | | | | | | | Add sublabels for wallet manage link items. BUG=258198 R=sky@chromium.org Review URL: https://codereview.chromium.org/18862005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211816 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fixed a leak in a test introduced in r211693.sadrul@chromium.org2013-07-161-2/+4
| | | | | | | | | BUG=235574, 260582 R=sky@chromium.org Review URL: https://codereview.chromium.org/19267009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211777 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Fix linker warnings.thakis@chromium.org2013-07-152-6/+4
| | | | | | | | | | | | | | | | | | | | | | | https://chromiumcodereview.appspot.com/16140023 added a findBarView to the class itself, having this in the test too causes: ld: warning: instance method 'findBarView' in category from obj/chrome/browser/ui/cocoa/find_bar/unit_tests.find_bar_cocoa_controller_unittest.o overrides method from class in libbrowser_ui.a(browser_ui.find_bar_cocoa_controller.o) Remove the method in the test. https://chromiumcodereview.appspot.com/14598015 added -iconView to MCNotificationController (TestingInterface) to a second file (it's already in notification_controller_unittest.mm, now it's in popup_collection_unittest.mm too), causing: ld: warning: instance method 'iconView' in category from obj/ui/message_center/cocoa/message_center_unittests.notification_controller_unittest.o conflicts with same method from another category Remove second copy. No intended behavior change. BUG=none R=rsesek@chromium.org Review URL: https://codereview.chromium.org/19274002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211713 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Keep track of restored bounds to fix tab dragging.erg@chromium.org2013-07-152-7/+40
| | | | | | | | | | | | | Starting in r210142, dragging tabs started relying on the restored bounds being accurate. Afterwards, tab dragging would crash because the linux_aura code would be passing back an empty rect. Keep track of the restored bounds as best as we can. BUG=175448 Review URL: https://chromiumcodereview.appspot.com/18733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211697 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make sure the mouse-button is still down before setting the capture.sadrul@chromium.org2013-07-152-1/+99
| | | | | | | | | | | | | | | | | | | | | | | It is possible for a View to show a context menu on mouse-press. Since the menu does a capture and starts a nested message-loop, the release goes to the menu. The next click (i.e. both mouse-press and release events) also go to the menu. The menu (and the nested message-loop) gets closed after this second release event. The code then resumes from the code in Widget::OnMouseEvent() for the first mouse-press, and it sets a capture on the view (and native-widget) that the first press event was on. Consequently, all the subsequent mouse-events continue to go to this target, unless the next mouse-release event resets the capture. To fix this, before setting a capture on the view in response to a mouse-press event, make sure that after dispatching the event down the view hierarchy, the mouse-button is still down. BUG=235574 R=sky@chromium.org Review URL: https://codereview.chromium.org/19137002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211693 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual ↵brettw@chromium.org2013-07-153-3/+3
| | | | | | | | | | to the base namespace. TBR=sky Review URL: https://codereview.chromium.org/19052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211675 0039d316-1c4b-4281-b951-d872f2087c98
* This caused failures in ui_unittests FontListTest.Fonts_GetHeight_GetBaselinemark@chromium.org2013-07-155-85/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=30356 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=13543 Revert 211664 "Shows Japanese and English mixed queries correctly." > Shows Japanese and English mixed queries correctly. > > This CL respects the common height and baseline of the fonts in the given font list, and draw text according to the baseline. > > The cause of vertically-misaligned queries was that > 1. ASCII characters have 23 pixels in height > 2. Japanese characters have 17 pixels in height > > pango_layout_get_pixel_size(), which is called in RenderTextLinux::GetStringSize(), returns the above size. > > Also see: > https://docs.google.com/a/chromium.org/document/d/1e2n9lEM_usn37Pld8tMeo_qpfLRQQjkx-O1hTHi3sPo/edit?usp=sharing > > BUG=244323 > TEST=Test manually. > > Review URL: https://chromiumcodereview.appspot.com/18848002 TBR=yukishiino@chromium.org Review URL: https://codereview.chromium.org/19270002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211669 0039d316-1c4b-4281-b951-d872f2087c98
* Shows Japanese and English mixed queries correctly.yukishiino@chromium.org2013-07-155-11/+85
| | | | | | | | | | | | | | | | | | | | This CL respects the common height and baseline of the fonts in the given font list, and draw text according to the baseline. The cause of vertically-misaligned queries was that 1. ASCII characters have 23 pixels in height 2. Japanese characters have 17 pixels in height pango_layout_get_pixel_size(), which is called in RenderTextLinux::GetStringSize(), returns the above size. Also see: https://docs.google.com/a/chromium.org/document/d/1e2n9lEM_usn37Pld8tMeo_qpfLRQQjkx-O1hTHi3sPo/edit?usp=sharing BUG=244323 TEST=Test manually. Review URL: https://chromiumcodereview.appspot.com/18848002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211664 0039d316-1c4b-4281-b951-d872f2087c98
* Dismiss context menus in app list on scroll.koz@chromium.org2013-07-1511-0/+44
| | | | | | | | | BUG=257000 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/18668002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211626 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate from googleurl/ includes to url/ ones in the remaining top-level ↵tfarina@chromium.org2013-07-131-1/+1
| | | | | | | | | | | directories. BUG=229660 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/18919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
* Settings: Deletable list item should not get focus on "X" button click.tkent@chromium.org2013-07-131-1/+1
| | | | | | | | | | | | | The "X" button has its own mousedown handler, which calls stopPropagation. So FocusManager.disableMouseFocusOnButtons() didn't work. This CL fixes the bug by canceling button focus in capturing phase. BUG=258382,259203 Review URL: https://chromiumcodereview.appspot.com/18434007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211560 0039d316-1c4b-4281-b951-d872f2087c98
* Create some platform independent code for the Autofill dialog post-submit ↵dbeam@chromium.org2013-07-134-2/+11
| | | | | | | | | | | | | | bubble. Also, implement the views version. BUG=243574 R=estade@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16467005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211551 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Convert more test targets to use isolate.frankf@chromium.org2013-07-132-0/+19
| | | | | | | | | BUG=249870 TBR=ben@chromium.org, acolwell@chromium.org, joi@chromium.org, enne@chromium.org, mark@chromium.org, jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/19040002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211547 0039d316-1c4b-4281-b951-d872f2087c98
* Use Windows native textfields and old dialogs on Win8 Metro.msw@chromium.org2013-07-132-1/+11
| | | | | | | | | | | | | | | | | | | | | This fixes TSF IME integration for non-Aura Win8 Metro browser UI textfields. This should be merged to M-29, and reverted with the real fix for Issue 239690. See screenshots and initial testing details at http://crbug.com/259125 Revert Views Textfields on Win8 Metro Chrome to Windows native controls. (impacts Omnibox, and Find-Bar/Bubble/Dialog (non-web-content) textfields) Use the old dialog style when using Windows textfields (just Metro by default). Necessary because transparent dialogs can't host native control child HWNDs. BUG=239690,259125 TEST=Windows IME works everywhere, Win8 Metro dialogs use the old style. R=kochi@chromium.org,yukawa@chromium.org,nona@chromium.org,sadrul@chromium.org TBR=sky@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/18948006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211544 0039d316-1c4b-4281-b951-d872f2087c98
* [OSX] Cleanup - Use NSZeroPoint if possible.groby@chromium.org2013-07-132-2/+2
| | | | | | | | | | | | | | | By convention, we prefer NSZeroPoint over an explicit invocation of NSMakePoint(0, 0). Minor cleanup, using a script: find . -name '*.mm' -exec sed -i'' -e 's/NSMakePoint(0,[[:space:]]*0)/NSZeroPoint/g' {} \; TBR=darin@chromium.org R=shess@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/18856016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211541 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix to logic that selects whether two selection handles or one is shown.varunjain@chromium.org2013-07-132-53/+101
| | | | | | | | BUG=256761,259453 Review URL: https://chromiumcodereview.appspot.com/19054010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211536 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebGraphicsContext::readBackFramebuffer implementation.jbauman@chromium.org2013-07-132-14/+0
| | | | | | | | | | This isn't used anymore. BUG= Review URL: https://chromiumcodereview.appspot.com/18464007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211528 0039d316-1c4b-4281-b951-d872f2087c98
* This CL did the following two things:bshe@chromium.org2013-07-128-78/+207
| | | | | | | | | | | | | | | | | | | | 1. It extends the old toKeyset attribute of kb-key-base. The new syntax should look like this: <kb-key toKeyset="up:upper:lower; long:upper;"></kb-key> And it means on key up, keyboard should transit to upper case, and when any key pressed, then transit back to lower case. On long press, keyboard should transit to upper case and stays to upper case(caps lock). toKeyset := (up|down|long):id:[id] id := one of the keyset ids defined in keyboard layout Note: double click on key is not yet supported. It will be in a follow up CL. 2. replace the toKeyset attribute with nextKeyset attribute. If nextKeyset is not null, the current keyset should transit to nextKeyset after pressed any key (unless the key specified a different keyset). BUG=252751 Review URL: https://chromiumcodereview.appspot.com/18942003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ui compositor context calls on multiple threadsboliu@chromium.org2013-07-121-17/+5
| | | | | | | | | | | | | | | | Threaded compositing is enabled, but DefaultContextFactory::CreateContextCommon calls makeContextCurrent which is not on the compositor thread where the context is normally used and destroyed. Remove the code to disable vsync that requires calling makeContextCurrent since it is probably broken already. BUG=259957 Review URL: https://chromiumcodereview.appspot.com/18258009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211475 0039d316-1c4b-4281-b951-d872f2087c98
* Colors in views::StyledLabel.fdoray@chromium.org2013-07-125-34/+117
| | | | | | | | | | | | | Add the possibility to specify a custom foreground color when defining the style of a text range in a views::StyledLabel. Also support auto color readability in views::StyledLabel, to automatically adjust the foreground colors when they are not readable over the background color. Necessary to comply with the mock of the bookmark sync promo (crbug.com/244279). TEST=No user visible change introduced by this CL. Custom colors will be used in the bookmark sync promo (crbug.com/244279). BUG=244630 Review URL: https://chromiumcodereview.appspot.com/17756003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211471 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-17 00:58:22 +0000