| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7277015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure the touch_pressed_handler_ is the view being removed before resetting it to NULL.
BUG=none
TEST=things compile and existing tests continue to pass
Review URL: http://codereview.chromium.org/7276002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the layer we force the complete bounds to be painted. This way the
Compositors don't have to worry about partial update of a size they've
never seen. This matches old logic I removed thinking it was no longer
needed.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7272013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This includes a new lang: bs (Bosnian).
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7278001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
data on the clipboard.
BUG=73478
Review URL: http://codereview.chromium.org/7222016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84791
TEST=Test the checkbox in the uninstaller as mentioned in the bug, but also
all checkboxes in chrome too.
Review URL: http://codereview.chromium.org/7196002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TEST() macro is used to define and name a test function, the first argument
is the test case name and thus doesn't need to be a typedef of testing::Test.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7262022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The issue with r90511 was that we need EGL header files for touchui=1 builds. The solution was to pull them in from third_party/angle for touchui=1 only.
BUG=none
TEST=by hand on Linux (w/ and w/o TOUCH_UI), Windows, and Mac
TBR=sky@chromium.org,apatrick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process and browser. Behind a compile TOUCH_UI flag.
It uses the MAC OSX AcceleratedSurface IPCs to communicate between the GPU process and browser. The major difference between the OSX display path is that I send an ACK back after AcceleratedSurfaceSetIOSurface because the process of binding a texture to the pixmap may destroy the contents of the pixmap.
BUG=none
TEST=by hand on Linux (w/ and w/o TOUCH_UI), Windows, and Mac
Review URL: http://codereview.chromium.org/6987014
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7261016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser. Behind a compile TOUCH_UI flag.
It uses the MAC OSX AcceleratedSurface IPCs to communicate between the GPU process and browser. The major difference between the OSX display path is that I send an ACK back after AcceleratedSurfaceSetIOSurface because the process of binding a texture to the pixmap may destroy the contents of the pixmap.
BUG=none
TEST=by hand on Linux (w/ and w/o TOUCH_UI), Windows, and Mac
Review URL: http://codereview.chromium.org/6987014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since removing the X11 background thread, this class is now only
used from the UI thread.
Review URL: http://codereview.chromium.org/7187026
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7235020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RWHVV_touch will soon use CompositorGL and TextureGL. It will subclass TextureGL to wrap image data coming from the GPU process. It will need to access CompositorGL in order to make the GL context associated with the compositor current when making instances of the subclass of TextureGL.
In addition, the subclass of TextureGL will use a slightly different fragment shader. This CL also includes a refactor of how shaders are produced to share commonality.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7235003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories."
The issue with the r90464 was that in the win shared build we build dlls and we
need BASE_API to export functions and symbols.
BUG=72317
TEST=None
TBR=rsesek@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/7263009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/common/ directories.
BUG=72317
TEST=None
R=rsesek@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/7231016
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/7265009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/7231016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pump and an X message pump.
The changes:
* Rename MessagePumpGlibX to MessagePumpX.
* Rename MessagePumpForUI to MessagePumpGlib.
* Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX.
* Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher.
MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work.
BUG=none
TEST=existing message-pump tests.
Review URL: http://codereview.chromium.org/7250001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Since removing the X11 background thread, this class is now only
used from the UI thread.
Review URL: http://codereview.chromium.org/7187026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to display texture produced by the GPU process for the RWHVV via the browser compositor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7231012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org
Review URL: http://codereview.chromium.org/7242005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that we generally should use EXPECT, and only switch to ASSERT when
the test would otherwise crash.
An example when to use ASSERT is:
- When going to manipulate a returned pointer value, we should ASSERT at some
point that the pointer is non-NULL.
Another example is:
- If you are going to check the values in an array, you ASSERT on the size of
the array. I.e, the array should contain 3 elements, because you are going to
access the third element at index 2, if the array doesn't contain 3
elements, the test will crash, so you should ASSERT before trying to
access the element instead of EXPECT because you want to abort the test
instead of crashing the entire binary.
And in the cases here, we don't have these situations and the individual test
expectations are not linked, so we are better using EXPECT than ASSERT
everywhere.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=phajdan.jr@chromium.org,sky@chromium.org
Review URL: http://codereview.chromium.org/7243005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation of having the browser compositor display textures generated by the GPU process.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7232016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86527
TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.)
Review URL: http://codereview.chromium.org/7189076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=16416
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7228002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do a local copy of the bitmap pixels to a temporary bitmap whose pixels are created with |allocPixels()| and hence refcounted.
This is necessary because SkPicture defers drawing until some time after the |drawBitmap()| call and expects the ref-counting mechanism to hold on to the pixels for it.
BUG=none
TEST=manual using --enable-accelerated-drawing and --force-compositing-mode flags
Review URL: http://codereview.chromium.org/7189064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=9269,13399,14520
BUG=none
TEST=none
R=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7216031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=8976,8977,8978,8979,8980,8981,8982,17240
BUG=none
TEST=none
R=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7227002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7200045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
CID=8818
Review URL: http://codereview.chromium.org/7217016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=wjmaclean@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/7219010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org
Review URL: http://codereview.chromium.org/7189067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of allocating it on the heap, just allocate it on the stack.
Thus we don't have to delete it manually.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.BasicOperations
R=phajdan.jr@chromium.org,sky@chromium.org
Review URL: http://codereview.chromium.org/7205022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7205044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On linux, CanvasSkia::DrawStringInt() was removing ampersands (when
HIDE_PREFIX flag was set) with gfx::RemoveWindowsStyleAccelerators(),
which has the side effect of doubling underscores. This CL replaces the call
with code that only strips ampersands (turning doubled ampersands into
a single ampersand).
BUG=chromium-os:15823
TEST=observe network menu with SSIDs containing underscores and ampersands
Review URL: http://codereview.chromium.org/7170025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and strong refs.
This deprecates the operator-based conversion methods in favor of To/CopyType().
New callsites should use these methods. Other uses will be converted in a later
CL.
BUG=58030
TEST=ui_unittests
Review URL: http://codereview.chromium.org/7205031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7202014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
predictions.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89716
Review URL: http://codereview.chromium.org/7187029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Autofill field type predictions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7187029
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/7204037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
predictions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7187029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86600
TEST=see bug description for repro step
Review URL: http://codereview.chromium.org/7201017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was the last remaining test to move.
BUG=72317
TEST=ui_unittests
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7201011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7111060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7202003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=TemplateURLParserTest.TestDictionary, TestMSDN, TestWikipedia (as per sadrul)
Note: testing with mobile user-agent will also yield better results: --user-agent=iPhone or similar mobile
Review URL: http://codereview.chromium.org/7065052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views.
BUG=none
TEST=the close button of the rotated window highlights on hover.
Review URL: http://codereview.chromium.org/7193025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=GtkDndUtilTest.*
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7200004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=DataPackTest.*
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7189034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove a few unnecessary includes.
- Add missing OVERRIDE to overridden methods.
- Add missing base:: prefix.
- Include the right mac file.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7185016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7193012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7172028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CrOS network menu shows the associated network in bold face and non-associated networks in regular face. The size of these fonts matches for non-touch builds but are different for touch builds.
BUG=none
TEST=on touch build, open network menu and check if all items are the same size
Review URL: http://codereview.chromium.org/7044121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89427 0039d316-1c4b-4281-b951-d872f2087c98
|