summaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Revert 232439 "Add a way for notifications to be linked from set..."csharp@chromium.org2013-11-0125-1110/+289
| | | | | | | | | | | | | | | | | > Add a way for notifications to be linked from settings dialog. > > Adds an event, onShowSettings, that is fired when the link is clicked. > The link is only shown when the event is subscribed to. > > BUG=304208,286608 > > Review URL: https://codereview.chromium.org/26876006 TBR=dewittj@chromium.org Review URL: https://codereview.chromium.org/56353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232444 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way for notifications to be linked from settings dialog.dewittj@chromium.org2013-11-0125-289/+1110
| | | | | | | | | | | Adds an event, onShowSettings, that is fired when the link is clicked. The link is only shown when the event is subscribed to. BUG=304208,286608 Review URL: https://codereview.chromium.org/26876006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232439 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the non browser/no app widget is fully visible when created on ashoshima@chromium.org2013-11-016-3/+8
| | | | | | | | | | added minimum_visibility flag to WindowState to guarantee that the part of widget is always visible. TEST=open TaskManager on 2nd display, close it, disconnect display, then open task manager again. minimum visibility is covered by test. Review URL: https://codereview.chromium.org/55303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232400 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary dependencies on "ui" target from some other targets.tfarina@chromium.org2013-11-012-2/+15
| | | | | | | | | | BUG=302505 TEST=None, targets built. R=dalecurtis@chromium.org,thestig@chromium.org,ben@chromium.org Review URL: https://codereview.chromium.org/48213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232399 0039d316-1c4b-4281-b951-d872f2087c98
* Creates functions to make it easier to determine why we're crashingsky@chromium.org2013-11-011-1/+31
| | | | | | | | | | | | | | | Currently if creating an HWND fails we crash (similar to out of memory). There may be a number of reasons why creation fails. This adds a couple of functions that are called into with common error codes we see to easily identify the reason. BUG=82193 TEST=none R=eroman@chromium.org Review URL: https://codereview.chromium.org/54913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232384 0039d316-1c4b-4281-b951-d872f2087c98
* ui/web_dialogs: Remove webkit/glue entry from DEPS.tfarina@chromium.org2013-11-011-1/+0
| | | | | | | | | | | | | webkit/ directory is dying and nobody at web_dialogs uses anything from webkit/glue, so we don't need this entry at the DEPS file. BUG=None TEST=None TBR=ben@chromium.org Review URL: https://codereview.chromium.org/54373010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232382 0039d316-1c4b-4281-b951-d872f2087c98
* Always aligns text at vertically center (Textfield, Label).yukishiino@chromium.org2013-11-0121-128/+124
| | | | | | | | | | | | | Re-applies http://crrev.com/25039002 with only the change s/numeric_limits<int>::max()/INT_MAX/ This CL makes Textfield and Label put the content text at vertically center respecting the cap height. Also removes vertical alignment support (ALIGN_{TOP,BOTTOM,VCENTER}). BUG=146236, 264436 TEST=Test manually + ui_unittests Review URL: https://codereview.chromium.org/54353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232374 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Apply focus hack only if a list item gets selected.tkent@chromium.org2013-11-011-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | This fixes two regressions by r227470 [1]. crbug.com/312611: We didn't remove focus from inner elements by mousedown because the list item contained the focused element. We don't need such behavior if the list item is already selected. crbug.com/313125: MenuButton::hideMenu() sets focus on the menu button element. So List::handleMouseDown thought a list item had a special focus handling, and canceled the default behavior. This issue is also resolved by not applying the hack for already-selected list item. crbug.com/313611: The focus hack should work only for left button. [1] http://src.chromium.org/viewvc/chrome?view=rev&revision=227470 BUG=312611,313125,313611 Review URL: https://codereview.chromium.org/54053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232368 0039d316-1c4b-4281-b951-d872f2087c98
* Trim small shadow bubble image assets.msw@chromium.org2013-11-0125-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Trim the assets to more tightly fit their visual contents. (they had excessively large transparent internal padding) Trim 8px/16px off of 100%/200% bubble border images. Trim 2px/4px off of 100%/200% bubble arrow images. (the bottom 1px of the 200% border had 1/255 alpha...) Keeps dimension consistency needed by Views::BubbleBorder. (more code flexibility would allow non-uniform trimming) Edit Bookmark dialog pics: http://crbug.com/313400 (note the area trimmed from the edges of the window) Update the bookmark bubble anchor insets to match. (needed for anchoring with PAINT_NONE arrow and insets) (no other bubbles should need this type of update, afaict) Simplify BubbleDelegateTest.NonClientHitTest test cases. (was too fragile, broken by minor image size changes) BUG=313400 TEST=Non-Ash bubble-bordered windows have reduced bounds. No visual regressions in bubbles, new style dialogs, menus, etc. R=sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/53943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232367 0039d316-1c4b-4281-b951-d872f2087c98
* Embeds offline voice recognizer plugin and its manager to app-list start page.mukai@chromium.org2013-11-011-0/+7
| | | | | | | | | | BUG=312365 R=xiyuan@chromium.org TEST=manually Review URL: https://codereview.chromium.org/29763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232311 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fallback behavior of EventFactoryOzone::GetInstancespang@chromium.org2013-11-013-43/+0
| | | | | | | | This is not needed anymore with OzonePlatform. Review URL: https://codereview.chromium.org/47643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232305 0039d316-1c4b-4281-b951-d872f2087c98
* Implement --ozone-platform flag to select OzonePlatform implementation at ↵spang@chromium.org2013-11-0111-8/+212
| | | | | | | | | | | | | | | | | | | | runtime This provides a way to select an ozone implementation to use at runtime. Each ozone implementation adds its name to the ozone_platforms GYP variable, and we take care of parsing the flag value and configuring chromium to use that implementation during initialization. To support external ports, we generate the list of enabled platforms at build time. The list is a static array that maps values of the --ozone_platform flag to a constructor function for an OzonePlatform subclass. At runtime, we call the constructor for platform specified on the command-line and use it to provide implementations of the various ozone interfaces (SurfaceFactoryOzone, EventFactoryOzone). Review URL: https://codereview.chromium.org/44053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232301 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix linux aura without USE_XI2_MT.dongseong.hwang@intel.com2013-11-011-7/+5
| | | | | | | | | touch_factory_x11.cc:96 must not use XScopedString because it is defined ui/base. ui/base depends on ui/events. Review URL: https://codereview.chromium.org/49383011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232256 0039d316-1c4b-4281-b951-d872f2087c98
* Activate a window when dropping something on it.pkasting@chromium.org2013-10-311-0/+1
| | | | | | | | | | | | This allows BrowserView::OnActiveTabChanged() to set focus correctly for tabs added in drops. BUG=310321 TEST=Open two Chrome windows, one navigated to yahoo.com and the other to crbug.com/310321. Highlight "yahoo.com" in the omnibox in window A, click in window B, then drag the "Issue 299186" link in comment 3 from window B to the tabstrip of window A. Drop. Focus should be in the web content area (i.e. pressing down arrow will scroll that content), not in the omnibox. R=ben@chromium.org Review URL: https://codereview.chromium.org/51103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232215 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build of TestCompositorHostOzonespang@chromium.org2013-10-311-1/+1
| | | | | | Review URL: https://codereview.chromium.org/47733004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232205 0039d316-1c4b-4281-b951-d872f2087c98
* Rename desktop_cursor_loader_updater_aurax11.kalyan.kondapally@intel.com2013-10-313-16/+16
| | | | | | | | | | | | This CL renames DesktopCursorLoaderUpdaterAuraX11 as DesktopCursorLoaderUpdaterAuraLinux. This would make it possible for using it on Linux platform with Ozone besides X11. BUG= Review URL: https://codereview.chromium.org/47073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232200 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure on Windows AURA that the cursor stays within the bounds of the window ↵ananta@chromium.org2013-10-313-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during a LockMouse operation and is unclipped during the UnlockMouse operation. On Windows we can ensure that the cursor stays within the bounds of a window via the ClipCursor API. Changes in this CL are as below:- 1. The cursor is clipped in the RootWindowHost::ConfineCursorToRootWindow abstraction and is unclipped in the RootWindowHost::UnConfineCursor abstraction. Currently these functions are only implemented on Windows in the DesktopRootWindowHostWin class. 2. Added an accessor method UnConfineCursor to the RootWindow class which forwards this call to the RootWindowHost. This is on the same lines as the ConfineCursorToWindow method in the RootWindow class. 3. We need to explicitly hide the cursor on Windows via the ShowCursor API. This is done in the DesktopRootWindowHostWin::OnCursorVisibilityChanged function. 4. If we receive non client messages in the RenderWidgetHostViewAura class in the locked mouse state, we should move the cursor to the center and return. If we don't do this then it causes DCHECKs to fire in the webkit mouse event conversion code. In any case non client messages should not be sent to webkit. Fixes bug https://code.google.com/p/chromium/issues/detail?id=305563 BUG=305563 R=scheib@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/49383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232176 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OzonePlatformspang@chromium.org2013-10-3119-18/+350
| | | | | | | | | | | | | | | | | | | | | | | | | This provides a way to select an ozone implementation to use at build time. It replaces the previous ad-hoc requirement to inject implementations of ozone interfaces somewhere during initialization, such as by overriding ContentMainDelegate::PreSandboxStartup(). That requirement made it difficult for external ozone implementations to build internal targets such as content_shell because those targets do not initialize the external ozone implementation without additional patching. Enabling external ports of chromium is one of the main goals of ozone. The OzonePlatform code is located at ui/ozone and depends on code in ui/gfx and ui/events because it must inject implementations into those components. The ozone platform is initialized from ui/aura or ui/gl, as those components need the interfaces provided by ozone in order to function. There are two in-tree platforms currently: test (image dump) and dri (libdrm-based direct rendering). The platform is selected by the setting ozone_platform gyp variable and defaults to "test". Review URL: https://codereview.chromium.org/44933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232170 0039d316-1c4b-4281-b951-d872f2087c98
* Adding relaunch menu to Windows 8 Aura code. We expect following transitions ↵shrikant@chromium.org2013-10-313-0/+49
| | | | | | | | | | | | | | | | with new menu: 1. When in desktop mode, you should see "Relaunch Chrome in Windows 8 mode", if clicked it will kill current browser process and relaunches all open tabs in Windows 8 mode. 2. When in Windows 8 mode, menu is "Relaunch Chrome in desktop mode", if clicked it will kill current browser process (gets user out of Ash shell) and relaunches all tabs in desktop mode. Once we select to launch in different mode through these menu items we store new mode in registry and use this mode as default mode for next time launch. This means even if you click on desktop icon and last mode stored is metro, user will be switched to metro mode. BUG=280823 R=cpu@chromium.org, jschuh@chromium.org, sky@chromium.org, ananta, cpu Review URL: https://codereview.chromium.org/32843009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232120 0039d316-1c4b-4281-b951-d872f2087c98
* Enable profile pinning by setting browser window relaunch detailscalamity@chromium.org2013-10-312-36/+43
| | | | | | | | | | | | | | | Make it possible to pin shortcuts by setting the relaunch data for each browser window. BUG=177490,107080,146647 TEST=Create separate profiles and pin the taskbar icons. Clicking the pinned icons should relaunch chrome with the appropriate profile. TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231295 Review URL: https://codereview.chromium.org/14122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232109 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG.msw@chromium.org2013-10-3113-31/+2
| | | | | | | | | | | | | | | | Remove the IDRs, asset files, and example usage. These assets were only used for the fullscreen bubble. Use some highly similar and more common assets instead. Tweak its padding to accommodate slightly larger assets. See before/after at: http://crbug.com/181257#c14 BUG=181257,313400 TEST=Fullscreen bubble looks slightly different, no other change. R=sky@chromium.org,yzshen@chromium.org,oshima@chromium.org,scheib@chromium.org Review URL: https://codereview.chromium.org/53703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232085 0039d316-1c4b-4281-b951-d872f2087c98
* RenderTextWin: Break runs at UBLOCK_GEOMETRIC_SHAPES.msw@chromium.org2013-10-313-7/+57
| | | | | | | | | | | | | | | | | Based on Cem's original CL: http://crrev.com/23522018 His r221850 was reverted in r228312 for Issue 287816. That perf regression is due to unnecessary run breaking. This version of the CL performs more limited run breaking. (just the ('▶') play character's UBLOCK_GEOMETRIC_SHAPES) BUG=278913,287816 TEST=YouTube/SoundCloud tab titles don't use weird fonts when they contain '▶'; no perf regression. R=asvitkine@chromium.org,ckocagil@chromium.org, Review URL: https://codereview.chromium.org/53033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232076 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing #includes of <algorithm> for std::min/std::maxyukawa@chromium.org2013-10-311-0/+2
| | | | | | | | | | Required when building on VS2013. BUG=288948 Review URL: https://codereview.chromium.org/52823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232070 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible use after free in RootWindow::DispatchHeldEventssky@chromium.org2013-10-313-16/+72
| | | | | | | | | | | | | Code needs to handle the case of RootWindow being deleted during DispatchHeldEvents. BUG=309768 TEST=covered by test now R=ben@chromium.org Review URL: https://codereview.chromium.org/52543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232062 0039d316-1c4b-4281-b951-d872f2087c98
* GetDisplayForScreen cleanupdominik.rottsches@intel.com2013-10-311-6/+7
| | | | | | | | | | | | | Doing the primary display check inside the GetDisplayForScreen function so that the other utility functions can stop guessing about whether the display they return is primary or not. BUG= R=Nico Review URL: https://codereview.chromium.org/47073006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232054 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move android C++ source files into base/android directory.tfarina@chromium.org2013-10-3113-43/+43
| | | | | | | | | | BUG=299841 TEST=None, no functional changes. R=ben@chromium.org,bulach@chromium.org Review URL: https://codereview.chromium.org/51663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232036 0039d316-1c4b-4281-b951-d872f2087c98
* pango_util: DrawPangoLayout no longer fades out the text.mgiuca@chromium.org2013-10-311-29/+4
| | | | | | | | | | | | | | | As of r231992, this code is no longer used, so this CL is just for the purpose of merging back into M31. This affects tab rendering on Linux GTK. In certain Linux environments, the text fade is causing the title to be missing entirely. Therefore, the fade effect is temporarily disabled. BUG=123104 Review URL: https://codereview.chromium.org/50533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232034 0039d316-1c4b-4281-b951-d872f2087c98
* Move test-only stuff from cc/debug/ to cc/testjamesr@chromium.org2013-10-312-2/+3
| | | | | | | | | | | | This moves the test/fake context implementations from cc/debug/ to cc/test and stops linking them into production targets. Test targets elsewhere in the tree can link against cc_test_support to use these. R=danakj,piman Review URL: https://codereview.chromium.org/50303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232025 0039d316-1c4b-4281-b951-d872f2087c98
* Update documentation of GetNativeDisplay.kalyan.kondapally@intel.com2013-10-311-2/+2
| | | | | | | | | | | GetNativeDisplay return's native display handle and is used to obtain the egl display connection. Updated documentation to reflect the same. BUG= Review URL: https://codereview.chromium.org/50303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232007 0039d316-1c4b-4281-b951-d872f2087c98
* Work around issue seen in Linux GTK where some tabs have no text.mgiuca@chromium.org2013-10-314-3/+97
| | | | | | | | | | | | | | This issue is not always present; it seems to only manifest itself on Ubuntu 13.10 with certain video card drivers. To work around this, use the Skia Canvas text rendering for tabs, instead of the Pango one. BUG=123104 Review URL: https://codereview.chromium.org/47543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231992 0039d316-1c4b-4281-b951-d872f2087c98
* ozone: Rename CreateStartupEventConverters() to StartProcessingEvents()spang@chromium.org2013-10-315-7/+11
| | | | | | | | | | | | | | | | This function has a broader role than its name and comment suggest. No events should be processed without a call to this function. All chrome processes have an EventFactoryOzone; this provides the platform-specific code to ui/events. The code should only actually dispatch events in processes that call StartProcessingEvents(). BUG=none TEST=ui_unittests Review URL: https://codereview.chromium.org/50123007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 231472 "Remove views::InputMethod::On[Focus|Blur] calling..."yoichio@chromium.org2013-10-3110-7/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > Remove views::InputMethod::On[Focus|Blur] calling from not top level widgets. > > This patch is a step of refactoring for the IME related focus handling. > > Background issue: > No top level widget can call views::InputMethod::On[Focus|Blur] as documented. > That hack was needed because to create a new widget with a new window handle by a mouse leaving event invoked Aura focus to the widget first and win32 focus next. > InputMethodTSF focusing works on widgets with win32 focus so the first focusing missed TSF focusing. > 2nd focusing by win32 also didn't work because InputMethodBridge > permitted the TextInputClient setting only once. > > Solution: > This patch changes to call OnWillChangeFocusedClientand OnDidChangeFocusedClient whenever a TextInputClinet is set or not. > Then secondary win32 focusing sets InputMethodTSF focus. > > BUG=302229, 306368 > TEST=manually done in Windows 8 Aura with or without --enable-text-services-framework flag. > > Review URL: https://codereview.chromium.org/34573003 TBR=yoichio@chromium.org Review URL: https://codereview.chromium.org/53913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231973 0039d316-1c4b-4281-b951-d872f2087c98
* Enables chording with the control and alt keys.rsadam@chromium.org2013-10-313-11/+55
| | | | | | | | | | Note that there is an edge case where we start chording with control (or alt) before continuing chording with shift. This will not work. Added a TODO to fix that; but it isn't an immediate priority. BUG=312336 Review URL: https://codereview.chromium.org/49243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231967 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ozone build with clangrjkroege@chromium.org2013-10-301-1/+1
| | | | | | | | | BUG=none TBR=spang@chromium.org Review URL: https://codereview.chromium.org/48623007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231944 0039d316-1c4b-4281-b951-d872f2087c98
* Build "shell" target with chromium_code set.tfarina@chromium.org2013-10-301-1/+4
| | | | | | | | | | | | This should enable all warnings that comes with chromium_code for this target. BUG=None TEST=ninja -C out/Debug shell R=ben@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/50043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231934 0039d316-1c4b-4281-b951-d872f2087c98
* Add |position| to AppListItemModel and add AppListItemList (Take 2)stevenjb@chromium.org2013-10-3025-255/+634
| | | | | | | | | | | | | | | | | | | | | | This adds a |position_| member to AppListItemModel in preparation for syncing the app list independent of extensions. It also moves some common code in AppListModel and AppListFolderItem into AppListItemList, which ensures that |position_| is keept up to date. This implementation keeps all position maintenance in AppListItemList and uses AppListItemListObserver to allow ExtensonAppItem to (temporarily) override the positioning logic. BUG=305024 For as/shell OWNER: R=jennyz@chromium.org, xiyuan@chromium.org TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/50003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231923 0039d316-1c4b-4281-b951-d872f2087c98
* Add callbacks to register EGL bindings from Ozonednicoara@chromium.org2013-10-307-8/+33
| | | | | | | | | | | | | | | | Ozone needs to provide a custom way to load EGL and GLES2 bindings. Since Ozone lives in ui/gfx/ozone it cannot have dependencies to ui/gl to register the libraries. This patch adds to callbacks to Ozone's LoadEGLGLES2Bindings function such that when performing GL bindings initialization ui/gl will provide the callbacks to register the bindings. BUG= Review URL: https://codereview.chromium.org/47213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231893 0039d316-1c4b-4281-b951-d872f2087c98
* Disables GetTextfieldBaseline_FontFallbackTest on Windows.yukishiino@chromium.org2013-10-301-6/+8
| | | | | | | | | | | | | Regardless of Windows version, disables the test on Windows because the test is unstable on Windows and it fails depending on minor changes of test environments. This test will be rewritten in http://crrev.com/25039002 soon. BUG=311267 TEST=Run views_unittests. Review URL: https://codereview.chromium.org/43363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231892 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderTextMac more efficient by caching fonts and taking advantage of ↵avi@chromium.org2013-10-303-57/+92
| | | | | | | | | | | | | | | | toll-free bridging of CT/NSFont. BUG=312436 TEST=no console spew as in bug R=asvitkine@chromium.org, mark@chromium.org, shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231670 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=231685 Review URL: https://codereview.chromium.org/49503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231879 0039d316-1c4b-4281-b951-d872f2087c98
* Move test-only ContextFactory implementations out of production targetsjamesr@chromium.org2013-10-3015-274/+362
| | | | | | | | | | | | | | | | | | This moves (Test|Default)ContextFactory and associated setup out of the production compositor target into the test-only compositor_test_support library. This removes the need for us to link in fake/mock classes into the prod build and cleans up several pieces of confusing static state. Code that wants to use one of the test ContextFactory implementations now has to call either ui::InitializeContextFactoryForTests() or, if it's depending on content and using aura, content::ImageTransportFactory::InitializeForUnitTests() and pass in a ContextFactory implementation. Content-based tests get the latter for free through content::BrowserTestBase. R=piman,sky Review URL: https://codereview.chromium.org/45963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231867 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in RepostEvent() incorrectly resetting held_move_event_ twicesky@chromium.org2013-10-302-5/+62
| | | | | | | | | | | | | | Problem with current code is if RepostEvent() is invoked during dispatch of a reposted event, we incorrectly clear held_move_event_, resulting in dropping the second reposted event. BUG=306935 TEST=covered by test now R=sadrul@chromium.org Review URL: https://codereview.chromium.org/51663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231846 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tableview change selection on tap downsky@chromium.org2013-10-305-31/+139
| | | | | | | | | | | | Additionally makes the header resize by way of gestures too. BUG=312718 TEST=make sure touching a row in task manager changes selection R=sadrul@chromium.org Review URL: https://codereview.chromium.org/51263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a SEGV error on copying of a fabricated KeyEvent.komatsu@chromium.org2013-10-302-1/+10
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/49223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231791 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Don't implement InputStateLookup.erg@chromium.org2013-10-302-4/+8
| | | | | | | | | | | | | | | | | In X11, we only receive events of mouse events; we cannot query the state ourselves. The best we can do here is use the built in event tracking to emulate it. This is not perfect. This enhances the tab dragging code (which runs mostly outside of aura's event handling stuff) so that it sets the global Env mouse button data when it starts and stops, so this should fix the case of tab dragging. BUG=306048 Review URL: https://codereview.chromium.org/50713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231765 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tooltips not show if it consists entirely of whitespacesky@chromium.org2013-10-302-4/+21
| | | | | | | | | | | | Showing an empty tooltip is not useful. BUG=312265 TEST=covered by test now R=varunjain@chromium.org Review URL: https://codereview.chromium.org/50603008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231762 0039d316-1c4b-4281-b951-d872f2087c98
* Set focused TextInputType to InputMethodEndingeIBus.yoichio@chromium.org2013-10-302-6/+86
| | | | | | | | | | This doesn't change actual behavior. BUG=311514 Review URL: https://codereview.chromium.org/43433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231751 0039d316-1c4b-4281-b951-d872f2087c98
* Use string directionality for CanvasSkia fade truncation; cleanup.msw@chromium.org2013-10-303-84/+17
| | | | | | | | | | | | | | | Fix Canvas::DrawFadeTruncatingStringRect LTR/RTL handling. Use GetFirstStrongCharacterDirection for string direction. Remove DrawFadeTruncatingString; use FontList version. Remove unused TruncateFadeHeadAndTail enum and code. Update TextExample for FontList and lift OS_WIN checks. BUG=145418 R=asvitkine@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/49903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231734 0039d316-1c4b-4281-b951-d872f2087c98
* Partial revert of r223054: Abandon sticky focus mechanismyukawa@chromium.org2013-10-3010-146/+2
| | | | | | | | | | | | | | | | r223054 introduced sticky focus mechanism as a tentative workaround so that TSF backend can work well under Aura event model until IME focus handling is completely fixed. However, TSF backend has been disabled even in immersive (metro) mode since r223589. This CL abandons sticky focus mechanism to simplify the code. BUG=290701 Review URL: https://codereview.chromium.org/48163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231732 0039d316-1c4b-4281-b951-d872f2087c98
* Add layout switcher for virtual keyboard.kevers@chromium.org2013-10-308-43/+224
| | | | | | | | BUG=311565 Review URL: https://codereview.chromium.org/43593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231710 0039d316-1c4b-4281-b951-d872f2087c98
* Not moving a docked window when restoring a previously maximized window. ↵varkha@chromium.org2013-10-301-0/+1
| | | | | | | | | | | | | | | When a maximized window gets docked (possible with a secondary monitor - see bug steps to repro) it now gets restored first. This prevents weird animated behavior or hiding it when it gets undocked or restored. Additionally a tab dragged out of a maximized browser and docked is not maximized anymore at the end of the drag (this used to be causing it to get undocked immediately). BUG=309954 BUG=305276 TEST=interactive_ui_tests --gtest_filter=*TabDragControllerTest*DetachToDockedWindowFromMaximizedWindow* Review URL: https://codereview.chromium.org/38073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231698 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-17 13:31:12 +0000