| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=274679
TEST=N/A
TBR=cbentzel, jamesr, simonjam, tzik, stevet, mpcomplete
Review URL: https://chromiumcodereview.appspot.com/23064011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file is not necessary as we use base/base.gyp:run_all_unittests to actually
run the unittests for url_lib.
BUG=None
TEST=url_unittests still runs
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/23251005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two more test cases to the TestResolveRelativeWithNonStandardBase
unittest.
BUG=None
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/22857002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds some missing OVERRIDE to virtual functions.
BUG=229660
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22927003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the final patch in this series of merging the external googleurl repo
into Chromium source code base.
BUG=229660
R=brettw@chromium.org,joth@chromium.org,blundell@chromium.org,thakis@chromium.org,thestig@chromium.org
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/20349002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Brett is overloaded with code reviews, which means having him as the only owner
of this directory is problematic. I understand this code fairly well and should
be able to review easy changes. I'll still ask Brett to review the hard
changes, however.
R=brettw@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/20373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a constructor to GURL that takes a std::string instead of a char*
and a length. This constructor allows Blink to produce a temporary std::string
containing the URL's spec that we can move directly into the GURL, avoiding a
copy.
Once I update Blink, this constructor will help us avoid spending 5% of our
total time rendering http://sina.com.cn on KURL -> GURL conversions.
R=brettw
BUG=261412
Review URL: https://chromiumcodereview.appspot.com/20127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"foo"PRIuS is a user-defined literal in C++11. Add spaces around these macros.
Likewise, L"\xab"L"c" is a user-defined literal, so insert a space in the
middle.
No functionality change.
BUG=chromium:263960
TBR=alokp@chromium.org, dmichael@chromium.org, enne@chromium.org, isherman@chromium.org, rsleevi@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/20182002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need to copy url_unittests to googleurl_unittests anymore, because
the bots were already updated to run url_unittests instead of googleurl_unittests
This hack is not necessary and can be removed now.
BUG=229660
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/19467002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directives.
This is to move back icu headers in
third_party/icu/public/{i18n,common}/unicode back to their upstream
locations in third_party/icu/source/{i18n,common}/unicode.
http://codereview.chromium.org/18836004 has is a CL to move
ICU header files.
Roll ICU to the version with the above ICU CL (http://crrev.com/211851 ).
In addition to the global replacement of third_party/icu/public with third_party/icu/source, the top-level DEPS, DEPS in printing and chrome/ are tightened up. (the latter two were too permissive (it used to allow any header from third_party/icu).
Besides, sync '-foo' list in ios/public/DEPS with '+foo' in the top-level DEPS and build/linux/unbundled/icu.gyp is updated.
BUG=251433
TEST=Compile succeeds on all bots. checkdeps.py does not find any error.
TBR=brettw,sky,wtc
Review URL: https://chromiumcodereview.appspot.com/18252003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15709011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no change
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/16413006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 203025 "Make the copy of GURL in src/url buildable as a c..."
>
> > Make the copy of GURL in src/url buildable as a component build. (try 2)
> >
> > BUG=229660
> > TBR=brettw
> >
> > Review URL: https://chromiumcodereview.appspot.com/15805003
>
> TBR=thestig@chromium.org
>
> Review URL: https://codereview.chromium.org/15848009
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/15799007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make the copy of GURL in src/url buildable as a component build. (try 2)
>
> BUG=229660
> TBR=brettw
>
> Review URL: https://chromiumcodereview.appspot.com/15805003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/15848009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=229660
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/15805003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative revert:
url_unittests url_unittests crashed or hung
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/36158
> Make the copy of GURL in src/url buildable as a component build.
>
> BUG=229660
>
> Review URL: https://chromiumcodereview.appspot.com/15255009
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/15859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=229660
Review URL: https://chromiumcodereview.appspot.com/15255009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For this to work on iOS, the entire .app bundle needs to be dulpicated.
Further, the executable name can't be changed because the build process puts the
name of the executable in the Info.plist.
BUG=229660
TBR=brettw
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14921002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.
BUG=229660
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/13825012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uses it.
BUG=229660
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14222028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=229660
TEST=url_unittests
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.
>
> To not break the buildbot, this creates a fake target that copies url_unittests
> to googleurl_unittests as temporary scaffolding.
>
> BUG=229660
> R=brettw@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14199009
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14028022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.
BUG=229660
R=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14199009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is temporary just to avoid weird link issues in Windows XP.
- Update the gyp file.
- Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory
name.
- Update the header include paths.
- Update the header include guards.
- Rename the target name from googleurl to url and googleurl_unittests to
url_unittests.
- Remove GURL_API (this will be replaced by URL_EXPORT when we componentize it again).
- Remove url_common.h (will be replaced by url_export.h when we componentize it again).
BUG=229660
TEST=url_unittests
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/13998025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
url/url_canon_stdstring.h:65: error: undefined reference to 'vtable for url_canon::StdStringCanonOutput'
> url: Changes to make it build standalone.
>
> - Update the gyp file.
> - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory
> name.
> - Update the header include paths.
> - Update the header include guards.
> - Rename the target name from googleurl to url and googleurl_unittests to
> url_unittests.
> - Add missing OVERRIDEs where clang complains.
>
> BUG=229660
> TEST=url_unittests
> R=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/14016005
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14264002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XP bots are still red, and it's still whining about URL.DLL
> Lets try this again.
>
> Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
>
> > Revert 193968 "Roll the DEPS for google-url."
> >
> > > Roll the DEPS for google-url.
> > >
> > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> > >
> > > This also changes googleurl.gyp to reference the files under url/, so that we
> > > don't break the Blink tree.
> > >
> > > BUG=229660
> > > R=brettw@chromium.org
> > > TBR=brettw@chromium.org
> > >
> > > Review URL: https://chromiumcodereview.appspot.com/14089011
> >
> > TBR=tfarina@chromium.org
> > Review URL: https://codereview.chromium.org/14028012
>
> TBR=michaeln@google.com
> Review URL: https://codereview.chromium.org/14109014
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we wrap the entire file under namespace url_parse and the unnamed
namespace, to be compliant with the ODR.
BUG=82078
TEST=googleurl_unittests
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's failing consistedly Win Builder (dbg) like this...
42>CustomBuild:
42> TEMPORARY: Copying url_unittests to googleurl_unittests
42> 'stat.S_IWUSR' is not recognized as an internal or external command,
42> operable program or batch file.
42>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error MSB6006: "cmd.exe" exited with code 255.
42>
42>Build FAILED.
... and i want to go home now.
> url: Copy 'googleurl_unittests' target from 'url_unittests'.
>
> To not break the buildbot, this creates a fake target that copies url_unittests
> to googleurl_unittests as temporary scaffolding.
>
> BUG=229660
> R=brettw@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14013003
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14239004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.
BUG=229660
R=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
> Revert 193968 "Roll the DEPS for google-url."
>
> > Roll the DEPS for google-url.
> >
> > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> >
> > This also changes googleurl.gyp to reference the files under url/, so that we
> > don't break the Blink tree.
> >
> > BUG=229660
> > R=brettw@chromium.org
> > TBR=brettw@chromium.org
> >
> > Review URL: https://chromiumcodereview.appspot.com/14089011
>
> TBR=tfarina@chromium.org
> Review URL: https://codereview.chromium.org/14028012
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14109014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll the DEPS for google-url.
>
> And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
>
> This also changes googleurl.gyp to reference the files under url/, so that we
> don't break the Blink tree.
>
> BUG=229660
> R=brettw@chromium.org
> TBR=brettw@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14089011
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14028012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
This also changes googleurl.gyp to reference the files under url/, so that we
don't break the Blink tree.
BUG=229660
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14089011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update the gyp file.
- Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory
name.
- Update the header include paths.
- Update the header include guards.
- Rename the target name from googleurl to url and googleurl_unittests to
url_unittests.
- Add missing OVERRIDEs where clang complains.
BUG=229660
TEST=url_unittests
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14016005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This was marked as Copyright Google, not an open-source license.
Review URL: https://codereview.chromium.org/13955007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/14101003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Original location:
https://code.google.com/p/google-url/
This includes changes up to r184.
These files are unchanged from the Google Code repo and do not yet build.
Updating includes, etc. will be done in a separate pass.
Review URL: https://codereview.chromium.org/13821004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193439 0039d316-1c4b-4281-b951-d872f2087c98
|