summaryrefslogtreecommitdiffstats
path: root/url
Commit message (Collapse)AuthorAgeFilesLines
* Move the logic for getting icu data out of icu_utiljshin@chromium.org2013-12-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently, how to build/link the icu data is split between common.gypi and icu_util.cc Move it out of icu_util.cc and put it in common.gypi Also, remove icudata from the dependency list in url.gyp. icuuc depends on icudata and specifying icuuc alone is sufficient. Otherwise, ninja complains about multiple rules specified for icudata and a circular dependency when icu_use_data_file_flag is set to 1 on Linux. A similar change has to be made in third_party/WebKit/Source/web/web.gyp. (see https://codereview.chromium.org/93053003/ ) This CL does not change the actual build process, yet. It's just to prepare to switch to "icu*.dat" on Mac and Linux. BUG=72633 TEST=All the configuration/builds go fine on all platforms. Review URL: https://codereview.chromium.org/89863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238567 0039d316-1c4b-4281-b951-d872f2087c98
* Deinline the implementation of StdStringCanonOutput.tfarina@chromium.org2013-12-033-21/+39
| | | | | | | | | | | | | | | This should move the implementation of StdStringCanonOutput from the header to the source file, that should please the chromium-style clang plugin. BUG=287029 TEST=url_unittests R=thakis@chromium.org,abarth@chromium.org TBR=abarth Review URL: https://codereview.chromium.org/84673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238392 0039d316-1c4b-4281-b951-d872f2087c98
* Support URL fragment resolution against non-hierarchical schemesjoth@chromium.org2013-11-2313-113/+209
| | | | | | | | | | | | | | | | | | | | | | Support URL fragment resolution against non-hierarchical schemes As a result, data: about: etc now have 'query' and 'ref' components parsed; as a result a new GURL::GetContent() convenience is added to retrieve the spec with the scheme stripped off. A complication in supporting this is that we now need to allow whitespace to trailing whitespace to be preserved when transferring url_parse::Parsed structs between KURL and GURL. Without this, the URL prior to the #fragment can change (i.e. whitespace stripped) when following an anchor link which breaks the page (causes reload from source). See http://crbug.com/291747 for more details on this. R=brettw@chromium.org TBR=cbentzel@chromium.org BUG=291747 Review URL: https://codereview.chromium.org/23835019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236917 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some debugging checks that expect HTTP protocol schemes to alsoricea@chromium.org2013-11-223-0/+19
| | | | | | | | | | | | | | accept WebSocket protocol schemes. No functional change to release builds. Debug builds will stop crashing when the new WebSocket implementation is used. BUG= TEST=net_unittests Review URL: https://codereview.chromium.org/68213017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236713 0039d316-1c4b-4281-b951-d872f2087c98
* Make our codebase less entertaining.thakis@chromium.org2013-11-032-2/+2
| | | | | | | | | | | | No intended behavior change. BUG=none TBR=owners NOTRY=true Review URL: https://codereview.chromium.org/56043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232663 0039d316-1c4b-4281-b951-d872f2087c98
* Use copy-swap idiom for GURL::operator=cjhopman@chromium.org2013-10-243-20/+45
| | | | | | | | | | | | | All the work to correctly handle ownership and internal state of GURL is already done by the copy-constructor, destructor, and GURL::Swap. Repeating that work for GURL::operator= is just another place where we might get it wrong. BUG=309975 Review URL: https://codereview.chromium.org/30693010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230829 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing to support fragment resolution against non-hierarchical schemeskristianm@chromium.org2013-10-244-4/+29
| | | | | | | | | | | | | Adds a new GURL::GetContent() to retrieve the text after scheme: specifically intended for use in non-hierarchical schemes (data: etc). Doing the first part of https://codereview.chromium.org/23835019/ in a preparation CL. BUG=291747 Review URL: https://codereview.chromium.org/23549039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230781 0039d316-1c4b-4281-b951-d872f2087c98
* Make GURL use scoped_ptr for inner_url_akalin@chromium.org2013-10-222-31/+32
| | | | | | | | | BUG=309975 R=brettw@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/34843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230211 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in GURL with self-assignment and non-NULL inner_url_akalin@chromium.org2013-10-222-0/+10
| | | | | | | | | BUG=309975 R=darin@chromium.org Review URL: https://codereview.chromium.org/32583006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230079 0039d316-1c4b-4281-b951-d872f2087c98
* Support IDNA 2008 with UTS46.jshin@chromium.org2013-09-293-23/+195
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UTS 46 provides a migration path from IDNA 2003 to IDNA 2008. 1. Use the up-to-date Unicode data; new characters were added and some case-folding/mapping have changed since Unicode 3.2 on which IDNA 2003 is based. 2. Define a case folding/mapping as is the case with IDNA 2003. 3. Use transitional mechanism for 4 deviant characters : German sharp-S, Greek final-sigma, ZWJ and ZWNJ. That is, the former two are mapped to 'ss' and regular sigma and the latter two are dropped. All the major browsers do this at the moment so allowing them does not do any good. We'll review this later as the consensus builds among browser vendors and registrars. We can also consider handling them separately. For instance, ZWJ/ZWNJ can be allowed with ContextJ rules, which requires a minor change in ICU's UTS 46 implementation. 4. Symbol and punctuations continue to be allowed. We also do the following: 1. Continue to "violate" STD3 rules about non-LDH (Letter, digits and hyphens) by allowing non-LDH's. That is no change from the current implementation. 2. Do not allow unassigned code points any more. With an up-to-date Unicode data, this does not make much difference. And the chance of new characters not yet reflected in our Unicode data popping up in a domain name is extremely low. 3. Continue to use CHECK_BIDI. The Bidi rule in IDNA 2008 is more permissive than in IDNA 2003. References: 1. http://unicode.org/reports/tr46/ and references therein to IDNA 2003 and 2008 RFCs. 2. What IE 10 does : http://goo.gl/3XBhqw 3. Mozilla bug : https://bugzilla.mozilla.org/show_bug.cgi?id=479520 BUG=61328 TEST=url_unittests (URLCanonTest.Host), net_unittests (NetUtilTest.IDNToU*), unittests (X509CertificateModelTest.*) R=brettw@chromium.org, pkasting@chromium.org, rsleevi@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/23642003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225878 0039d316-1c4b-4281-b951-d872f2087c98
* [CleanUp] Use base::STLSetDifference() in place of std::set_difference()limasdf@gmail.com2013-09-241-0/+3
| | | | | | | | | BUG=254066 TEST=compile Review URL: https://chromiumcodereview.appspot.com/23904026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224914 0039d316-1c4b-4281-b951-d872f2087c98
* Escape single-quote in query strings to avoid certain types of xss.tsepez@chromium.org2013-09-242-2/+2
| | | | | | | | | | About 46 LayoutTests will need rebaselining after this lands. BUG=292740 R=abarth@chromium.org Review URL: https://chromiumcodereview.appspot.com/23754022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224874 0039d316-1c4b-4281-b951-d872f2087c98
* Make relative file url parsing fail where there is a host:port in the ↵tsepez@chromium.org2013-09-184-27/+103
| | | | | | | | | | | | | relative URL. BUG=285720 R=brettw@chromium.org, jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223928 Review URL: https://codereview.chromium.org/23464046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223969 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 223928 "Make relative file url parsing fail where there i..."tsepez@chromium.org2013-09-184-97/+24
| | | | | | | | | | | | | | | > Make relative file url parsing fail where there is a host:port in the relative URL. > > BUG=285720 > R=brettw@chromium.org, jar@chromium.org > > Review URL: https://codereview.chromium.org/23464046 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/23702051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223940 0039d316-1c4b-4281-b951-d872f2087c98
* Make relative file url parsing fail where there is a host:port in the ↵tsepez@chromium.org2013-09-184-24/+97
| | | | | | | | | | | relative URL. BUG=285720 R=brettw@chromium.org, jar@chromium.org Review URL: https://codereview.chromium.org/23464046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix OOB read when parsing protocol-relative URLsaedla@chromium.org2013-09-171-3/+2
| | | | | | | | BUG=285742 Review URL: https://chromiumcodereview.appspot.com/23902014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223735 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce GURL::SchemeIsHttpFamily(), which returns true for http and https.cdn@chromium.org2013-08-222-0/+7
| | | | | | | | | | BUG=274679 TEST=N/A TBR=cbentzel, jamesr, simonjam, tzik, stevet, mpcomplete Review URL: https://chromiumcodereview.appspot.com/23064011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218893 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused gurl_test_main.cctfarina@chromium.org2013-08-201-77/+0
| | | | | | | | | | | | | This file is not necessary as we use base/base.gyp:run_all_unittests to actually run the unittests for url_lib. BUG=None TEST=url_unittests still runs R=abarth@chromium.org Review URL: https://codereview.chromium.org/23251005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218478 0039d316-1c4b-4281-b951-d872f2087c98
* Add fragment URL test cases to non-standard base unittest.mkosiba@chromium.org2013-08-161-6/+16
| | | | | | | | | | | | This adds two more test cases to the TestResolveRelativeWithNonStandardBase unittest. BUG=None R=brettw@chromium.org Review URL: https://codereview.chromium.org/22857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218002 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some clang warnings found by chromium-style plugin.tfarina@chromium.org2013-08-132-2/+4
| | | | | | | | | | | This adds some missing OVERRIDE to virtual functions. BUG=229660 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/22927003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217211 0039d316-1c4b-4281-b951-d872f2087c98
* Stop pulling googleurl through DEPS.tfarina@chromium.org2013-08-126-355/+439
| | | | | | | | | | | | | This is the final patch in this series of merging the external googleurl repo into Chromium source code base. BUG=229660 R=brettw@chromium.org,joth@chromium.org,blundell@chromium.org,thakis@chromium.org,thestig@chromium.org TBR=brettw Review URL: https://chromiumcodereview.appspot.com/20349002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216922 0039d316-1c4b-4281-b951-d872f2087c98
* Add abarth as an OWNER of src/urlabarth@chromium.org2013-07-261-0/+1
| | | | | | | | | | | | | | Brett is overloaded with code reviews, which means having him as the only owner of this directory is problematic. I understand this code fairly well and should be able to review easy changes. I'll still ask Brett to review the hard changes, however. R=brettw@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/20373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213939 0039d316-1c4b-4281-b951-d872f2087c98
* Allow efficient WebURL -> GURL conversionsabarth@chromium.org2013-07-262-2/+25
| | | | | | | | | | | | | | | | | This CL adds a constructor to GURL that takes a std::string instead of a char* and a length. This constructor allows Blink to produce a temporary std::string containing the URL's spec that we can move directly into the GURL, avoiding a copy. Once I update Blink, this constructor will help us avoid spending 5% of our total time rendering http://sina.com.cn on KURL -> GURL conversions. R=brettw BUG=261412 Review URL: https://chromiumcodereview.appspot.com/20127002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213885 0039d316-1c4b-4281-b951-d872f2087c98
* Make inttypes.h and similar macro usage C++11-friendly.thakis@chromium.org2013-07-251-1/+1
| | | | | | | | | | | | | | | | "foo"PRIuS is a user-defined literal in C++11. Add spaces around these macros. Likewise, L"\xab"L"c" is a user-defined literal, so insert a space in the middle. No functionality change. BUG=chromium:263960 TBR=alokp@chromium.org, dmichael@chromium.org, enne@chromium.org, isherman@chromium.org, rsleevi@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/20182002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove googleurl_unittests hack.tfarina@chromium.org2013-07-191-59/+0
| | | | | | | | | | | | | We don't need to copy url_unittests to googleurl_unittests anymore, because the bots were already updated to run url_unittests instead of googleurl_unittests This hack is not necessary and can be removed now. BUG=229660 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/19467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212683 0039d316-1c4b-4281-b951-d872f2087c98
* Replace third_party/icu/public with third_party/icu/source in the include ↵jshin@chromium.org2013-07-183-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | directives. This is to move back icu headers in third_party/icu/public/{i18n,common}/unicode back to their upstream locations in third_party/icu/source/{i18n,common}/unicode. http://codereview.chromium.org/18836004 has is a CL to move ICU header files. Roll ICU to the version with the above ICU CL (http://crrev.com/211851 ). In addition to the global replacement of third_party/icu/public with third_party/icu/source, the top-level DEPS, DEPS in printing and chrome/ are tightened up. (the latter two were too permissive (it used to allow any header from third_party/icu). Besides, sync '-foo' list in ios/public/DEPS with '+foo' in the top-level DEPS and build/linux/unbundled/icu.gyp is updated. BUG=251433 TEST=Compile succeeds on all bots. checkdeps.py does not find any error. TBR=brettw,sky,wtc Review URL: https://chromiumcodereview.appspot.com/18252003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212324 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in url/, win8/.avi@chromium.org2013-06-117-7/+7
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15709011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205663 0039d316-1c4b-4281-b951-d872f2087c98
* Use base:: on string16 and char16 in net/ and url/avi@chromium.org2013-06-1130-249/+265
| | | | | | | | | | BUG=none TEST=no change TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/16413006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205636 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 203027 "Revert 203025 "Make the copy of GURL in src/url b..."thestig@chromium.org2013-05-319-391/+440
| | | | | | | | | | | | | | | | | | | | | > Revert 203025 "Make the copy of GURL in src/url buildable as a c..." > > > Make the copy of GURL in src/url buildable as a component build. (try 2) > > > > BUG=229660 > > TBR=brettw > > > > Review URL: https://chromiumcodereview.appspot.com/15805003 > > TBR=thestig@chromium.org > > Review URL: https://codereview.chromium.org/15848009 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/15799007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 203025 "Make the copy of GURL in src/url buildable as a c..."thestig@chromium.org2013-05-309-440/+391
| | | | | | | | | | | | | | | > Make the copy of GURL in src/url buildable as a component build. (try 2) > > BUG=229660 > TBR=brettw > > Review URL: https://chromiumcodereview.appspot.com/15805003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/15848009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203027 0039d316-1c4b-4281-b951-d872f2087c98
* Make the copy of GURL in src/url buildable as a component build. (try 2)thestig@chromium.org2013-05-309-391/+440
| | | | | | | | | BUG=229660 TBR=brettw Review URL: https://chromiumcodereview.appspot.com/15805003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203025 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 201723 "Make the copy of GURL in src/url buildable as a c..."nkostylev@chromium.org2013-05-239-463/+414
| | | | | | | | | | | | | | | | | | Speculative revert: url_unittests url_unittests crashed or hung http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/36158 > Make the copy of GURL in src/url buildable as a component build. > > BUG=229660 > > Review URL: https://chromiumcodereview.appspot.com/15255009 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/15859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201755 0039d316-1c4b-4281-b951-d872f2087c98
* Make the copy of GURL in src/url buildable as a component build.thestig@chromium.org2013-05-239-414/+463
| | | | | | | | BUG=229660 Review URL: https://chromiumcodereview.appspot.com/15255009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the googleurl_unittests hack so iOS builds work again.lliabraa@chromium.org2013-05-031-7/+4
| | | | | | | | | | | | | | | For this to work on iOS, the entire .app bundle needs to be dulpicated. Further, the executable name can't be changed because the build process puts the name of the executable in the Info.plist. BUG=229660 TBR=brettw NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14921002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198149 0039d316-1c4b-4281-b951-d872f2087c98
* url: Copy 'googleurl_unittests' target from 'url_unittests'. Third attempt.tfarina@chromium.org2013-04-251-0/+62
| | | | | | | | | | | | To not break the buildbot, this creates a fake target that copies url_unittests to googleurl_unittests as temporary scaffolding. BUG=229660 R=brettw@chromium.org Review URL: https://codereview.chromium.org/13825012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196507 0039d316-1c4b-4281-b951-d872f2087c98
* url: Replace Google copyright with the Chromium licence in all files that ↵tfarina@chromium.org2013-04-2434-926/+100
| | | | | | | | | | | uses it. BUG=229660 R=brettw@chromium.org Review URL: https://codereview.chromium.org/14222028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195974 0039d316-1c4b-4281-b951-d872f2087c98
* url: Fix the include paths to icu unicode APIs.tfarina@chromium.org2013-04-204-10/+6
| | | | | | | | | | | BUG=229660 TEST=url_unittests R=brettw@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14371002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195396 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195389 "url: Copy 'googleurl_unittests' target from 'url_..."gavinp@chromium.org2013-04-201-62/+0
| | | | | | | | | | | | | | | | | | > url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2. > > To not break the buildbot, this creates a fake target that copies url_unittests > to googleurl_unittests as temporary scaffolding. > > BUG=229660 > R=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14199009 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14028022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195392 0039d316-1c4b-4281-b951-d872f2087c98
* url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.tfarina@chromium.org2013-04-201-0/+62
| | | | | | | | | | | | To not break the buildbot, this creates a fake target that copies url_unittests to googleurl_unittests as temporary scaffolding. BUG=229660 R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/14199009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195389 0039d316-1c4b-4281-b951-d872f2087c98
* url: Build it as a static library.tfarina@chromium.org2013-04-1837-716/+648
| | | | | | | | | | | | | | | | | | | | | | This is temporary just to avoid weird link issues in Windows XP. - Update the gyp file. - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory name. - Update the header include paths. - Update the header include guards. - Rename the target name from googleurl to url and googleurl_unittests to url_unittests. - Remove GURL_API (this will be replaced by URL_EXPORT when we componentize it again). - Remove url_common.h (will be replaced by url_export.h when we componentize it again). BUG=229660 TEST=url_unittests R=brettw@chromium.org Review URL: https://codereview.chromium.org/13998025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193777 "url: Changes to make it build standalone."jochen@chromium.org2013-04-1538-268/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | url/url_canon_stdstring.h:65: error: undefined reference to 'vtable for url_canon::StdStringCanonOutput' > url: Changes to make it build standalone. > > - Update the gyp file. > - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory > name. > - Update the header include paths. > - Update the header include guards. > - Rename the target name from googleurl to url and googleurl_unittests to > url_unittests. > - Add missing OVERRIDEs where clang complains. > > BUG=229660 > TEST=url_unittests > R=brettw@chromium.org > > Review URL: https://codereview.chromium.org/14016005 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14264002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193992 "Lets try this again."jochen@chromium.org2013-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The XP bots are still red, and it's still whining about URL.DLL > Lets try this again. > > Revert 193983 "Revert 193968 "Roll the DEPS for google-url."" > > > Revert 193968 "Roll the DEPS for google-url." > > > > > Roll the DEPS for google-url. > > > > > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > > > > > This also changes googleurl.gyp to reference the files under url/, so that we > > > don't break the Blink tree. > > > > > > BUG=229660 > > > R=brettw@chromium.org > > > TBR=brettw@chromium.org > > > > > > Review URL: https://chromiumcodereview.appspot.com/14089011 > > > > TBR=tfarina@chromium.org > > Review URL: https://codereview.chromium.org/14028012 > > TBR=michaeln@google.com > Review URL: https://codereview.chromium.org/14109014 TBR=michaeln@google.com Review URL: https://codereview.chromium.org/14263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194151 0039d316-1c4b-4281-b951-d872f2087c98
* url: Remove using namespace declaration from url_parse_unittests.cctfarina@chromium.org2013-04-151-7/+8
| | | | | | | | | | | | | Instead we wrap the entire file under namespace url_parse and the unnamed namespace, to be compliant with the ODR. BUG=82078 TEST=googleurl_unittests TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194130 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194082 "url: Copy 'googleurl_unittests' target from 'url_..."michaeln@google.com2013-04-131-78/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's failing consistedly Win Builder (dbg) like this... 42>CustomBuild: 42> TEMPORARY: Copying url_unittests to googleurl_unittests 42> 'stat.S_IWUSR' is not recognized as an internal or external command, 42> operable program or batch file. 42>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error MSB6006: "cmd.exe" exited with code 255. 42> 42>Build FAILED. ... and i want to go home now. > url: Copy 'googleurl_unittests' target from 'url_unittests'. > > To not break the buildbot, this creates a fake target that copies url_unittests > to googleurl_unittests as temporary scaffolding. > > BUG=229660 > R=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14013003 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14239004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194086 0039d316-1c4b-4281-b951-d872f2087c98
* url: Copy 'googleurl_unittests' target from 'url_unittests'.tfarina@chromium.org2013-04-131-17/+78
| | | | | | | | | | | | To not break the buildbot, this creates a fake target that copies url_unittests to googleurl_unittests as temporary scaffolding. BUG=229660 R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/14013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194082 0039d316-1c4b-4281-b951-d872f2087c98
* Lets try this again.michaeln@google.com2013-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 193983 "Revert 193968 "Roll the DEPS for google-url."" > Revert 193968 "Roll the DEPS for google-url." > > > Roll the DEPS for google-url. > > > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > > > This also changes googleurl.gyp to reference the files under url/, so that we > > don't break the Blink tree. > > > > BUG=229660 > > R=brettw@chromium.org > > TBR=brettw@chromium.org > > > > Review URL: https://chromiumcodereview.appspot.com/14089011 > > TBR=tfarina@chromium.org > Review URL: https://codereview.chromium.org/14028012 TBR=michaeln@google.com Review URL: https://codereview.chromium.org/14109014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193992 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193968 "Roll the DEPS for google-url."michaeln@google.com2013-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | > Roll the DEPS for google-url. > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > This also changes googleurl.gyp to reference the files under url/, so that we > don't break the Blink tree. > > BUG=229660 > R=brettw@chromium.org > TBR=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14089011 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14028012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193983 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the DEPS for google-url.tfarina@chromium.org2013-04-121-1/+1
| | | | | | | | | | | | | | | And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. This also changes googleurl.gyp to reference the files under url/, so that we don't break the Blink tree. BUG=229660 R=brettw@chromium.org TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/14089011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193968 0039d316-1c4b-4281-b951-d872f2087c98
* url: Changes to make it build standalone.tfarina@chromium.org2013-04-1138-254/+269
| | | | | | | | | | | | | | | | | | | - Update the gyp file. - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory name. - Update the header include paths. - Update the header include guards. - Rename the target name from googleurl to url and googleurl_unittests to url_unittests. - Add missing OVERRIDEs where clang complains. BUG=229660 TEST=url_unittests R=brettw@chromium.org Review URL: https://codereview.chromium.org/14016005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193777 0039d316-1c4b-4281-b951-d872f2087c98
* Fix license on gurl unittest.brettw@chromium.org2013-04-101-2/+3
| | | | | | | This was marked as Copyright Google, not an open-source license. Review URL: https://codereview.chromium.org/13955007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193463 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:21:42 +0000