summaryrefslogtreecommitdiffstats
path: root/views/accessibility/view_accessibility.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-201-3/+3
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Support accDoDefaultAction for NativeButton in ViewAccessibility.ctguil@chromium.org2011-01-141-4/+17
| | | | | | | | | BUG=none TEST=Manual Review URL: http://codereview.chromium.org/6310002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71512 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from views. Part 3: Switch accessibility strings to string16.avi@chromium.org2011-01-141-4/+4
| | | | | | | | | BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6192007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71461 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-11-211-5/+6
| | | | | | | | | | | | | | | Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 TEST=none TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/5144005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ↵sky@chromium.org2010-11-191-6/+5
| | | | | | | | | | | | | | | | | sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/5184009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66786 0039d316-1c4b-4281-b951-d872f2087c98
* Converts usage of SetProp/GetProp to a map. Even after making sure wesky@chromium.org2010-11-191-5/+6
| | | | | | | | | | | | clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66784 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of view accessibility and view accessibility wrapper.ctguil@chromium.org2010-10-221-154/+91
| | | | | | | | | | | | | | | 1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility. 2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects. 3. Update get_accFocus to use FocusManager. 4. Move oleacc guid definitions to view_win.cc. BUG=none TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe. Review URL: http://codereview.chromium.org/4047001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Windows location bar send accessibility events to thedmazzoni@chromium.org2010-10-211-1/+7
| | | | | | | | | | | | accessibility extension API on Windows. This adds a few more accessibility events to views accessibility while we're at it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63394 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Downloads Shelf keyboard-accessible (via F6) and accessible todmazzoni@chromium.org2010-10-211-0/+2
| | | | | | | | | | | | | screenreaders. Rename AccessibleToolbarView to AccessiblePaneView to reflect that it covers more than just toolbars. Also add infobars to the F6 pane traversal. BUG=372 TEST=none Review URL: http://codereview.chromium.org/3722004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63358 0039d316-1c4b-4281-b951-d872f2087c98
* Return the IAccessible interface of the deepest descent that contains the ↵ctguil@chromium.org2010-10-201-39/+16
| | | | | | | | | | | | | | | | speficied point in view accessibility's accHitTest. Previously accHitTest would 1. Only return a direct child that contained the specified point (accHitTest was called repeatedly until it returned CHILDID_SELF). 2. Always return a VT_I4 variant for a view that has no children instead of returing an IAccessible interface (which didn't work with the AT programs for some reason). BUG=none TEST=Manual: NVDA reads views on mouse overwith no children on mouse over like toolbar buttons. TEST=Manual: AccExplorer32 and Inspect32 can select views with no children. Review URL: http://codereview.chromium.org/3890003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63273 0039d316-1c4b-4281-b951-d872f2087c98
* Make accessible getters return values instead of accepting an output ↵ctguil@chromium.org2010-09-281-17/+6
| | | | | | | | | | | parameter. GetAccessibleName still needs to be converted. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/3416033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60828 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r60342.dtseng@chromium.org2010-09-241-0/+4
| | | | | | | TBR=dmazzoni. Review URL: http://codereview.chromium.org/3444021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60474 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Set focus to a ConfirmInfoBar. This serves to alerts screen reader ↵maruel@chromium.org2010-09-231-4/+0
| | | | | | | | | | | | | | users ..." This reverts commit 60342. TBR=dtseng BUG=none TEST=none Review URL: http://codereview.chromium.org/3472008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60348 0039d316-1c4b-4281-b951-d872f2087c98
* Set focus to a ConfirmInfoBar. This serves to alerts screen reader users ↵dtseng@chromium.org2010-09-231-0/+4
| | | | | | | | | | that the confirmation has appeared and alleviates the need to hunt for these controls. BUG=37360 TEST=Confirm that focus lands correctly on the "save" button when logging into a site and offer to save passwords is enabled. Review URL: http://codereview.chromium.org/3405026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60342 0039d316-1c4b-4281-b951-d872f2087c98
* Alway return interface from ViewAccessibility::get_accChild.ctguil@chromium.org2010-09-031-164/+68
| | | | | | | | | BUG=none TEST=Verify screen reader accessibility during events like nagivating toolbar or menus. Review URL: http://codereview.chromium.org/3292007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58547 0039d316-1c4b-4281-b951-d872f2087c98
* Connect native view accessibles back to the accessibility tree.ctguil@chromium.org2010-09-021-5/+4
| | | | | | | | | BUG=none TEST=interactive_ui_tests:AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree Review URL: http://codereview.chromium.org/3244011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58314 0039d316-1c4b-4281-b951-d872f2087c98
* Another take on menu's. This uses the hosting menu scroll view container as ↵dtseng@chromium.org2010-08-191-0/+2
| | | | | | | | | | | | | | | | | a menubar on which we can fire MENUSTART and MENUEND events. The end result is that we now have the following scenario when a user opens a menu. 1. focus lands on the menu button. 2. down arrow. 3. A "chromium" menu item appears. 4. down arrow (or enter). 5. The first menu item gets focused. The only differences from what we currently have is Jaws/NVDA no longer say "context menu opened" or "applications". The first real menuitem also doesn't get focused when the menu shows. BUG=none. TEST=use NVDA and Jaws to navigate the menu's (opening, closing, submenus, accelerators). Review URL: http://codereview.chromium.org/3155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56715 0039d316-1c4b-4281-b951-d872f2087c98
* Enable better NVDA support for custom menus.ctguil@chromium.org2010-08-061-0/+2
| | | | | | | | | | | | - Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role. - Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus. TEST=The wrench menu and it's menu items are read aloud when using NVDA. BUG=49360 Review URL: http://codereview.chromium.org/3015055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55163 0039d316-1c4b-4281-b951-d872f2087c98
* Fire focus events when CustomButtons are hottracked.dtseng@chromium.org2010-07-071-0/+18
| | | | | | | | BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2867040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51753 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radiobuttons and connect up child widgets again.dtseng@chromium.org2010-06-241-1/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2806030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50778 0039d316-1c4b-4281-b951-d872f2087c98
* Small tweaks to improve toolbar keyboard accessibility: Put focus rectsdmazzoni@chromium.org2010-06-221-3/+1
| | | | | | | | | | | | | around more controls (including location bar, only when in full keyboard access mode). Fix accessible names. Fix spacebar to activate menu buttons. Remove methods for child focus, they're not needed anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/2817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98
* Keep a cache of all views that have sent notifications. This ensures that ↵dtseng@chromium.org2010-06-181-2/+36
| | | | | | | | | | AccessibleObjectFromEvent works properly. BUG=9601 TEST=none Review URL: http://codereview.chromium.org/2823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50302 0039d316-1c4b-4281-b951-d872f2087c98
* Initial work to fix the IAccessible tree in circumstances where there is a ↵ctguil@chromium.org2010-05-271-25/+34
| | | | | | | | | | widget not at the root of the UI heirarchy. Also contains misc fixes for setting correct name/role for controls found in the Options dialog. BUG=9621 TEST=none Review URL: http://codereview.chromium.org/2174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48444 0039d316-1c4b-4281-b951-d872f2087c98
* Provide accessibility support for Window_win.ctguil@chromium.org2010-05-171-50/+52
| | | | | | | | TEST=Ensure that the About Chrome dialog has proper accessibility role. BUG=none Review URL: http://codereview.chromium.org/1838002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for dtseng. Ensure that the variant out param gets properlydmazzoni@chromium.org2010-04-231-0/+3
| | | | | | | | | | | | initialized as the variant isn't guaranteed to have been zeroed. Original issue: 1689011 BUG=36086 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45460 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Allow views to have multiple accessibility states and add ↵mhm@chromium.org2010-04-091-9/+26
| | | | | | | | | | | | | correct roles. Allow views to contain multiple accessibility states since states are not mutually exclusive, we treat them as an uint32. Add missing roles to couple of views. BUG=None TEST=Run unit tests, and check accessibility tree. Review URL: http://codereview.chromium.org/1527019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44054 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Extension toolbar and infobar container views should not ↵ctguil@chromium.org2010-03-301-3/+5
| | | | | | | | | | | | | | | | | | | have state visible if they are not rendered on screen. Add the ROLE_PANE role to viewsaccessibility types. Provide accessible role and name for BrowserActionsContainer, InfoBarContainer, and InfoBar. Set BrowserActionsContainer view visibility to true only when it contains browser actions. Set ExtensionShelf vew visibility to true only when it has non-zero height. BUG=36224 TEST=Verify extension toolbar and infobar container accessibility info within AccExplore32.exe Review URL: http://codereview.chromium.org/669275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43044 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add support for Accessibility Value.ctguil@chromium.org2010-03-261-7/+34
| | | | | | | | | | BUG=9604 TEST=point AccExplorer to Edit Bookmark dialog, see if everything has a MSAA information, like: Name, Role, State, Value. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42831 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r41640.ajwong@chromium.org2010-03-161-0/+4
| | | | | | | | | | Original patch by thiago.farina@gmail.com Revision r41640 was reverted in r41676 because it looked like it might have been responsible for Interactive UI test failures in linux and windows. However, reverting didn't fix, so I'm reapplying it. Review URL: http://codereview.chromium.org/982004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41683 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Landing tfarina CL. " because it broke Interactive UI tests on Linux ↵ajwong@chromium.org2010-03-161-4/+0
| | | | | | | | | | and Windows. This reverts r41640. Review URL: http://codereview.chromium.org/1037001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41676 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina CL. ctguil@chromium.org2010-03-151-0/+4
| | | | | | | | | | | | | Original patch by thiago.farina@gmail.com See original review at: http://codereview.chromium.org/820001/show BUG=9616, 36281 TEST=point AccExplorer to the clear browsing data dialog, every control should be identified and should have the correct values. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41640 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina CL. ctguil@chromium.org2010-03-101-0/+2
| | | | | | | | | | | | | | Original patch by thiago.farina@gmail.com See original review at: http://codereview.chromium.org/668225/show BUG=9616 TEST=opens AccExplorer2, opens clear browsing data, select the a checkbox+label with the AccExplorer2 tool, see if the role for this control is checkbox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41178 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-081-3/+4
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that accessibility information from native views like the ↵ananta@chromium.org2009-10-161-3/+6
| | | | | | | | | | | | | | | | | autocomplete edit are returned correctly to accessibility clients like screen readers. We achieve this by sending off the WM_GETOBJECT message to the underlying native view HWND if the current view cannot return accessibility information for its children. Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291 Bug=13291 Review URL: http://codereview.chromium.org/287007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29338 0039d316-1c4b-4281-b951-d872f2087c98
* Accessibility information from the renderer was not being returned to tools ↵ananta@chromium.org2009-10-101-1/+80
| | | | | | | | | | | | | | | | | | | | | | | | like screen readers, etc. This was because the object implementing the root IAccessible interface did not know how to navigate a native render view. To work around this, we now check if the underlying view is a native view in our root IAccessible::get_accChild function and if yes we send the WM_GETOBJECT message to the corresponding RenderWidgetHostViewWin class, which returns an IAccessible interface which then can expose information from the renderer. The other changes in the accessibility code are for some crashes I observed while testing the screen readers like nvda, the Windows screen reader which send a flurry of WM_GETOBJECT messages leading to some race conditions. We also ensure that the accessibility information for a view is torn down when the view is destroyed. Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291 Bug=13291 Review URL: http://codereview.chromium.org/261044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28655 0039d316-1c4b-4281-b951-d872f2087c98
* Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce ↵jhawkins@chromium.org2009-09-101-4/+4
| | | | | | | | | | dependencies on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support and exposure of additional accessibility roles. Includes naming ↵klink@chromium.org2009-08-221-0/+2
| | | | | | | | | | of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars. BUG=13291,19982 TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document. Review URL: http://codereview.chromium.org/174252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
* Adds additional MSAA information to fill in a few gaps in the hierarchy.klink@chromium.org2009-07-281-0/+2
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/160239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MSAA information to various (previously uncovered) bits of the UI, ↵klink@chromium.org2009-07-231-8/+16
| | | | | | | | | | | including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support. BUG=None. Test=None. Review URL: http://codereview.chromium.org/155446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21476 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-0/+698
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 11:13:45 +0000