summaryrefslogtreecommitdiffstats
path: root/views/controls/menu
Commit message (Collapse)AuthorAgeFilesLines
* Changes mnemonics for bookmark menus to show the mnemonics if eithersky@chromium.org2010-06-253-14/+58
| | | | | | | | | | | | | the os says we should, or focus was on the button that triggered showing the menu. Also changes mnemonic processing to not guess at mnemonic if menu has mnemonics. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2831031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50852 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-245-28/+24
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-245-24/+28
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 2.ben@chromium.org2010-06-233-4/+5
| | | | | | | | | | | | - Rename Canvas to CanvasSkia. - Create a subclass Canvas that inherits from CanvasSkia for compatibility. BUG=none TEST=none Review URL: http://codereview.chromium.org/2862025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus and makes widgetgtk not send outsky@chromium.org2010-06-222-5/+11
| | | | | | | | | | | mousemove if the event is the result of a grab. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50529 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for radio menu items to bookmark menus.sky@chromium.org2010-06-186-26/+141
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2846014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50246 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for click-drag-release on views embedded in a menu tosky@chromium.org2010-06-182-5/+124
| | | | | | | | | | | behave as if the user initially clicked on the view. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50244 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the merged menu:sky@chromium.org2010-06-175-9/+12
| | | | | | | | | | | | | | | | | | | | | . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for showing accelerators in bookmark menus.sky@chromium.org2010-06-098-24/+110
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49335 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so child views of menuitemview can be traversed with thesky@chromium.org2010-06-0912-53/+234
| | | | | | | | | | | | | keyboard. Because I don't want the menu to actually get focus I'm using SetHotTracked when traversing and AcceleratorPressed from enter/return. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49270 0039d316-1c4b-4281-b951-d872f2087c98
* Views menu gradient change for ChromeOS to sync with gtk theme change.xiyuan@chromium.org2010-05-201-5/+3
| | | | | | | | | BUG=chromium-os:2691 TEST=Verify views menu on bookmark bar etc also use the subtle gradient. Review URL: http://codereview.chromium.org/2117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47803 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate View::UILayoutIsRightToLeft() to standardize on ↵pkasting@chromium.org2010-05-103-4/+4
| | | | | | | | | | base::i18n::IsRTL(). Was only needed for EnableUIMirroringForRTLLanguages(), which was only used by Views::Label, which already had this capability via set_rtl_alignment_mode(). BUG=none TEST=none Review URL: http://codereview.chromium.org/1991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46869 0039d316-1c4b-4281-b951-d872f2087c98
* Close menu on grab broke event.oshima@chromium.org2010-05-053-2/+17
| | | | | | | | | | | This is necessary for screen locker to grab the input event. Technically, this can happen when another part of chrome tries to grab the input, so this is safer to handle this. BUG=none TEST=none Review URL: http://codereview.chromium.org/1900002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46441 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from the last few files that don't need it.thestig@chromium.org2010-04-271-0/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45665 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-1611-199/+323
| | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=25563 TEST=see bug Review URL: http://codereview.chromium.org/1664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44807 0039d316-1c4b-4281-b951-d872f2087c98
* Make views menu have a similar look and feel of native menu on ChromeOS:xiyuan@chromium.org2010-04-133-0/+42
| | | | | | | | | | | | | | - Mark menu host popup with GDK_WINDOW_TYPE_HINT_MENU so that window manager would add drop shadow and border to it; - Use the same gradient fill as menu's background; - Use the same selection color and text color; BUG=<http://crosbug.com/1885> TEST=Verify bookmark menu have a similar look and feel as other menus (e.g. wrench menu). Review URL: http://codereview.chromium.org/1547030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44370 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Allow views to have multiple accessibility states and add ↵mhm@chromium.org2010-04-094-1/+16
| | | | | | | | | | | | | correct roles. Allow views to contain multiple accessibility states since states are not mutually exclusive, we treat them as an uint32. Add missing roles to couple of views. BUG=None TEST=Run unit tests, and check accessibility tree. Review URL: http://codereview.chromium.org/1527019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44054 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:oshima@chromium.org2010-04-061-1/+6
| | | | | | | | | | | | | | | | | BookmarkBarView tests fixes * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BookmarkBarView tests fixes"oshima@chromium.org2010-04-051-7/+1
| | | | | | | | | | I don't understand why this is still causing the problem, but reverting this for now. This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d. Review URL: http://codereview.chromium.org/1612005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43674 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkBarView tests fixesoshima@chromium.org2010-04-051-1/+7
| | | | | | | | | | | | | | * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43628 0039d316-1c4b-4281-b951-d872f2087c98
* Fix number of arguments to gtk callback macro.dmazzoni@chromium.org2010-04-012-7/+5
| | | | | | | | | BUG=none TEST=navigating menus using the keyboard no longer crashes. Review URL: http://codereview.chromium.org/1549011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43379 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-317-14/+251
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply r42703 which was reverted because of a conflict with another patch ↵estade@chromium.org2010-03-262-9/+9
| | | | | | | | | | | | | | | | | that was being reverted: TBR=ananta Views: fix a crash where in the browser actions container. This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. original review: http://codereview.chromium.org/1237004/show Review URL: http://codereview.chromium.org/1449001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42813 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-267-255/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* estade:- This revert is to fix interactive ui test failures which have been ↵ananta@chromium.org2010-03-262-16/+19
| | | | | | | | | | | | | | | | | | | | | broken since Wednesday. Your CL is not at fault though. 42498 seems to be the culprit. I had to revert your CL as it leads to conflicts while reverting 42498 Revert 42703 - Views: fix a crash where in the browser actions container. This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/1423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42778 0039d316-1c4b-4281-b951-d872f2087c98
* Views: fix a crash where in the browser actions container.estade@chromium.org2010-03-262-19/+16
| | | | | | | | | | | This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42703 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-247-17/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-247-255/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-247-17/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-2312-14/+14
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix some GdkPixbuf leaks.mattm@chromium.org2010-03-231-0/+1
| | | | | | | | | | | | Also expand some documentation for functions that returned a GdkPixbuf about who owns the reference BUG=38895 TEST=manual test that nothing is broken, will watch bot for leak results Review URL: http://codereview.chromium.org/1075014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42302 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-227-164/+17
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-227-17/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-227-164/+17
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-227-17/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-203-6/+7
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-195-7/+7
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-174-4/+4
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-141-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-141-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-089-100/+66
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Don't mirror menu position for RTL because on Windows we set RLT window ↵dpolukhin@google.com2010-03-063-23/+22
| | | | | | | | | | | | | flags and Window does it for us. Place mirroring changes from http://codereview.chromium.org/601032 to GTK specific part. TEST=In TRL layout check drop down menus on Windows, Linux and Chrome OS - on all platforms menu should be inside Chrome window. BUG=36627 Review URL: http://codereview.chromium.org/660376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40838 0039d316-1c4b-4281-b951-d872f2087c98
* New network menu button UI for ChromeOS.chocobo@chromium.org2010-02-191-0/+11
| | | | | | | | | Added ability to change label font in gtk menu item. TEST=none BUG=none Review URL: http://codereview.chromium.org/650074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39516 0039d316-1c4b-4281-b951-d872f2087c98
* implement previous TODO to show associated shortcut keys for page and wrench ↵kuan@chromium.org2010-02-192-7/+35
| | | | | | | | | | menu options BUG=33593 TEST=verify per bug report. Review URL: http://codereview.chromium.org/646058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39442 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where deleting bookmarks in bookmarks menu wouldn't alwayssky@chromium.org2010-02-182-1/+17
| | | | | | | | | | | trigger a redraw of the menu. BUG=35570 TEST=see bug Review URL: http://codereview.chromium.org/626012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39363 0039d316-1c4b-4281-b951-d872f2087c98
* Support tooltips in MenuItemView. Use that tooltip support in the finnur@chromium.org2010-02-172-2/+22
| | | | | | | | | | | Browser Action Container overflow menu. BUG=35345 TEST=None Review URL: http://codereview.chromium.org/611009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39174 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed alignment of button dropdowns for RTL languages.avayvod@chromium.org2010-02-112-6/+25
| | | | | | | | | | | BUG=none TEST=Run chrome with LANGUAGE=ar or with --lang=ar. Verify that all status area menus as well as main menu are aligned properly (go to the right, not to the left). Review URL: http://codereview.chromium.org/601032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38807 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-061-3/+5
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in disabling browser action from context menu onsky@chromium.org2010-02-023-5/+33
| | | | | | | | | | | | | | | | views/gtk. The crash occurred because on views we dispatch the menu action immediately (well, after the nested message loop exits), but on windows the action is posted after a delay. The code wasn't written to deal with immediate dispatch, so I changed the gtk code to post a task to dispatch activation. I've also added a warning that menu2 won't work on the stack, which has always been the case, just not stated. BUG=33619 TEST=see bug report. Review URL: http://codereview.chromium.org/557065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37835 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 15:39:12 +0000