summaryrefslogtreecommitdiffstats
path: root/views/controls/menu
Commit message (Collapse)AuthorAgeFilesLines
* Fix context menus for touchui=1sadrul@chromium.org2010-11-181-1/+1
| | | | | | | | | | | | | Nested tasks are generally allowed for context menus (e.g. in MenuController::Run, NativeMenuDOMUI::RunMenuAt). Do the same here. This fixes a X-freeze caused by context menus when touchui=1 with the X message-pump. BUG=none TEST=manual, context menus in web-pages should work and not freeze X. Review URL: http://codereview.chromium.org/5206002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66621 0039d316-1c4b-4281-b951-d872f2087c98
* views: Override gtk-menu-images=0 for menu items with icons.derat@chromium.org2010-11-111-0/+6
| | | | | | | | | | | | | | This lets us disable icons by default, which gets rid of the ugly GTK+ copy/cut/paste icons in stock menus while still showing icons for Views menu items that have explicitly asked for them, like the ones in the Chrome OS network menu. BUG=chromium-os:4345 TEST=built and ran it Review URL: http://codereview.chromium.org/4708008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix menu click bug.oshima@chromium.org2010-11-101-1/+1
| | | | | | | | | | TBR=chocobo@chromium.org BUG=chromium-os:8718 TEST=open context/status menu and test if mouse click selects the menu item. Review URL: http://codereview.chromium.org/4692002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65600 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send many requests to flimflam when network chagned.oshima@chromium.org2010-11-092-2/+25
| | | | | | | | | | | | | | | Send sync request to flimflam only if new request didn't come in 50ms. Network menu was updating menu twice when opening. BUG=chromium-os:8435 TEST=manual: enable vlog (--vlog=1) and observe that chrome log reports one "UpdateNetworkStatus" when network changes (disable, enable ethernet etc) There may be two when wifi is enabled as different wifi source may be recognized at different timing. Review URL: http://codereview.chromium.org/4229005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65478 0039d316-1c4b-4281-b951-d872f2087c98
* Re-insert IP address in Network Menu.stevenjb@chromium.org2010-11-082-5/+7
| | | | | | | | | BUG=chromium-os:8476 TEST=Open the network menu on ChromeOS; the IP address should be at the bottom of the menu. Review URL: http://codereview.chromium.org/4544001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65398 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing leaks from SetProp. Apparently there is a finitesky@chromium.org2010-11-011-8/+4
| | | | | | | | | | | | | | | | | | amount of memory reserved for properties and Windows doesn't always automatically free up the memory if the window is deleted without an explicit remove. For the time being I've made it easier to track SetProp leaks, but we may want to move to using something other than SetProp in the future that isn't as fragile. I didn't fix a couple of places that were trickier. I'm going to file separate bugs on them. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/4195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64619 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-2/+1
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Grab keyboard input when showing domui/views menu.oshima@chromium.org2010-10-272-16/+21
| | | | | | | | | | BUG=chromium-os:8118 TEST=manual: open more than 2 windows, then open wrench menu and hit alt-tab. It will not switch to other window. Review URL: http://codereview.chromium.org/4189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64103 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-266-2/+53
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* Update gtk/menu2 without closing menuoshima@chromium.org2010-10-261-8/+15
| | | | | | | | | | | | | | | * ResetMenu now simply remove all menu items. * This will closes all submenus opened. It require a lot more work to update submenus correctly. Since there is no scenario that requires this so this is good enough for our use case. BUG=chromium-os:8106 TEST=manual: on chromeos device, open network menu and change network settings. (plug-unplug ethernet) Review URL: http://codereview.chromium.org/4120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63899 0039d316-1c4b-4281-b951-d872f2087c98
* Menu crash fix for domui/gtk menu that is caused by multiple context menu ↵oshima@chromium.org2010-10-224-2/+112
| | | | | | | | | | | | | | | | | | | requests. Renderer may issue multiple ContextMenu request even if the menu is open.(this happenes when renderer receives mouse events before context menu is actually opened by previous request.) This is causing a crash in menu2 (both domiu/gtk impl) because menu2 has nested message loop, and the menu object gets deleted by 2nd request while it's handling message loop. This CL addresses this issue by creating separate object to handle the nested loop. Use only variables on stack and do not touch instance variable if the menu is already deleted. BUG=chromium-os:7929, chromium-os:7228 TEST=manual. on a page, continously click mouse to open/close context menu. It used to crash at some point, but shouldn't crash with this patch. Review URL: http://codereview.chromium.org/4046004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63576 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - views/.pkasting@chromium.org2010-10-203-51/+0
| | | | | | | | | | This also removes DEBUG_MENU. I don't think the extra ints are a big deal. They should be optimized away in release mode. Also fixes a spelling error and converts some silly code to using early returns. BUG=none TEST=none Review URL: http://codereview.chromium.org/3908004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63150 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-3/+3
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in wrench menu where closing with menu open could triggersky@chromium.org2010-10-051-0/+1
| | | | | | | | | | | crash. BUG=56842 TEST=see bug Review URL: http://codereview.chromium.org/3552008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61474 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI implementation of Menu2.oshima@chromium.org2010-10-041-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | A few key design points. * Uses DOMView to render menu content. * MenuUI (subclass of DOMUI) uses GtkWiget tree to access WidgetGtk and MenuModel. Alternative way was to change TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine. * Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add. * Menu gets shown after the renderer rendered the content (thus has some size) to avoid showing small/empty menu. Mouse processing is blocked until the menu is shown (see Dispatcher). A few issues that will be addressed in separate CL * RTL (will be after beta) * menu scroll. working on it now. * menu sometimes show scroll bar. (I just need to disable it) * unit test for native_menu_domui BUG=chromiun-os:6497 TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two: * mnemonic should work now on context menus. * menu larger than screen does not scroll. I'll implement this in separate CL Review URL: http://codereview.chromium.org/3442018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mnemonic and add keyboard shortcut text to the accessible name of ↵ctguil@chromium.org2010-10-012-21/+35
| | | | | | | | | | | | | text buttons in the wrench menu. Add breaks to GetAccessibleState switch statements. BUG=51738 TEST=Verify in NVDA and JAWS that text buttons are read without mnemonic and with keyboard shortcut. Review URL: http://codereview.chromium.org/3612001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61201 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor RadioButton Image code for linux/gtkoshima@chromium.org2010-09-293-76/+122
| | | | | | | | | | | so that DOMUI menu can use the same image. BUG=none TEST=none Review URL: http://codereview.chromium.org/3435033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
* Add SetMinimumWidth to Menu2 for chromeos.oshima@chromium.org2010-09-297-0/+20
| | | | | | | | | | | | | This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497) Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone. BUG=none TEST=none Review URL: http://codereview.chromium.org/3533001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
* Make accessible getters return values instead of accepting an output ↵ctguil@chromium.org2010-09-286-28/+18
| | | | | | | | | | | parameter. GetAccessibleName still needs to be converted. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/3416033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60828 0039d316-1c4b-4281-b951-d872f2087c98
* Make windows menu accelerators work in owner-draw mode.asargent@chromium.org2010-09-151-9/+5
| | | | | | | | | | | | | | | | | For items added to context menus by extensions, we display the extension's icon next to the top-level item. To display this icon, we use owner-draw mode, and it turns out that our code was assuming that we didn't need to tell windows about the labels of items in owner-draw mode. BUG=54497 TEST=Steps are outlined in the bug. Also all things menu related should be tested on windows.(wrench menu, context menus in web content, bookmark bar items, browser actions, etc.) Review URL: http://codereview.chromium.org/3402005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59560 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in bookmark menus where using arrow keys would selectsky@chromium.org2010-09-132-3/+29
| | | | | | | | | | | invisible menu items. BUG=54800 TEST=see bug Review URL: http://codereview.chromium.org/3315021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59226 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the max width for bookmark menus back to 400 and leaves themsky@chromium.org2010-09-072-9/+10
| | | | | | | | | | | | at 800 for the wrench menu. Apparently folks don't like wide bookmark menus. BUG=50653 TEST=see bug Review URL: http://codereview.chromium.org/3317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58771 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bookmark menus to deal with multiple menus sharing the samesky@chromium.org2010-09-072-48/+123
| | | | | | | | | | | mnemonic. BUG=49728 TEST=see bug Review URL: http://codereview.chromium.org/3325015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58745 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-034-20/+20
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-024-20/+20
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-024-20/+20
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for invisible menu items to bookmark menus and wires itsky@chromium.org2010-09-011-4/+7
| | | | | | | | | | | up for the wrench menu. BUG=46221, 54017 TEST=see bug Review URL: http://codereview.chromium.org/3289001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58218 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-014-20/+20
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-014-20/+20
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-271-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Another take on menu's. This uses the hosting menu scroll view container as ↵dtseng@chromium.org2010-08-193-4/+19
| | | | | | | | | | | | | | | | | a menubar on which we can fire MENUSTART and MENUEND events. The end result is that we now have the following scenario when a user opens a menu. 1. focus lands on the menu button. 2. down arrow. 3. A "chromium" menu item appears. 4. down arrow (or enter). 5. The first menu item gets focused. The only differences from what we currently have is Jaws/NVDA no longer say "context menu opened" or "applications". The first real menuitem also doesn't get focused when the menu shows. BUG=none. TEST=use NVDA and Jaws to navigate the menu's (opening, closing, submenus, accelerators). Review URL: http://codereview.chromium.org/3155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56715 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FillRect(... SkPaint) to DrawRect() since it doesn't necessarily ↵pkasting@chromium.org2010-08-181-1/+1
| | | | | | | | | | fill, it just draws with the provided paint. BUG=none TEST=none Review URL: http://codereview.chromium.org/3165032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56589 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-136-14/+17
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize most_recent_profile_ in constructor.ctguil@chromium.org2010-08-101-1/+1
| | | | | | | | | BUG=51631 TEST=Ensure chrome --first-run don't crash when opening the wrench menu. Review URL: http://codereview.chromium.org/3139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55606 0039d316-1c4b-4281-b951-d872f2087c98
* Enable better NVDA support for custom menus.ctguil@chromium.org2010-08-064-10/+25
| | | | | | | | | | | | - Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role. - Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus. TEST=The wrench menu and it's menu items are read aloud when using NVDA. BUG=49360 Review URL: http://codereview.chromium.org/3015055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55163 0039d316-1c4b-4281-b951-d872f2087c98
* Add view class names to some classes used in the Wrench menu.dmazzoni@chromium.org2010-08-044-0/+29
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2832106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-042-3/+6
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Makes cut/copy/paste buttons centered with respect to thesky@chromium.org2010-08-032-7/+11
| | | | | | | | | | | | | separator. This proves a bit tricky as normally separators are closer to the bottom of the space provided. I've centered them now so that the buttons look centered too. BUG=50099 TEST=see bug Review URL: http://codereview.chromium.org/3072015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54772 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-312-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-271-0/+3
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2620-0/+20
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in links ending up too small. The problem is that wesky@chromium.org2010-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | changed IsFocusable to check IsVisibleInRootView. This meant that any views (like label) whose preferred size takes into account focusable and cached the preferred size before they were visible in the root view would end up with the wrong size because they didn't recalculate when IsVisibleInRootView changed. I've separated out the two states so that IsFocusable no longer checks IsVisibleInRootView and is protected. All consumers now call IsFocusableInRootView which checks IsFocusable and IsVisibleInRootView. BUG=49635 TEST=see bug. Review URL: http://codereview.chromium.org/3046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53187 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views]Handle focus traversing correctly.suzhe@chromium.org2010-07-201-2/+10
| | | | | | | | | | | | This CL adds a wrapper window class on top of GtkWindow to intercept its move_focus method, so that we can handle focus traversing by ourselves. BUG=49204: Chrome/views toolbar "tab" accessibility broken. TEST=See bug report. Review URL: http://codereview.chromium.org/3013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53123 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in views/gtk when pressing space bar on a menu button.sky@chromium.org2010-07-181-0/+6
| | | | | | | | | BUG=49366 TEST=see bug Review URL: http://codereview.chromium.org/3046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52874 0039d316-1c4b-4281-b951-d872f2087c98
* Ups the max size of bookmark menus to accommodate the wrench menu.sky@chromium.org2010-07-081-1/+3
| | | | | | | | | BUG=48309 TEST=see bug Review URL: http://codereview.chromium.org/2880019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo that caused wrong menu highlight color being used for ChromeOS.xiyuan@chromium.org2010-07-071-1/+1
| | | | | | | | | BUG=chromium-os:4580 TEST=Verify correct color 0xDCE4FA is used for menu highlight per chromium-os:4580. Review URL: http://codereview.chromium.org/2861049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51780 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing states for menu items. This allows AT's to know when a ↵dtseng@chromium.org2010-07-071-0/+13
| | | | | | | | | | menu item has a submenu (HASPOPUP) and is checked (either a radio or checkbox). BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2858051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51751 0039d316-1c4b-4281-b951-d872f2087c98
* Makes menu draw disabled arrow the correct color for classic windows.sky@chromium.org2010-07-072-6/+19
| | | | | | | | | BUG=48099 TEST=see bug Review URL: http://codereview.chromium.org/2835033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes menus when shown by way of pressing alt-f. I need to turn onsky@chromium.org2010-07-073-15/+8
| | | | | | | | | | | | | | | | nested tasks as in some situations the menu may be shown when the message loop is processing a task. If the message loop is processing a taskand we don't set nested tasks allowed to true then none of the tasks scheduled by the menu (paints, delays...) are processed and the menu appears totally broken. BUG=48102 TEST=give focus to the page, press alt-f, press arrow keys and make sure the menu updates appropriately. Review URL: http://codereview.chromium.org/2836044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r51526mnissler@chromium.org2010-07-051-0/+1
| | | | | | | | | | | | | | | | | | Auto-size the views version of the options dialog. This adds support for auto-sizing tab controls, adjusts the options dialog to use it and takes care of any fallout due to the new layout handling. Also fixes a couple of small bugs in the views Layout() machinery and sanitizes layouting of options pages. BUG=36497 TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language. original issuse: http://codereview.chromium.org/2812026/show Review URL: http://codereview.chromium.org/2883022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 23:22:11 +0000