summaryrefslogtreecommitdiffstats
path: root/views/controls/menu
Commit message (Collapse)AuthorAgeFilesLines
* Revert 74693. Changing approach.ben@chromium.org2011-02-142-7/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74849 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Widgetwin->NativeWidgetWinben@chromium.org2011-02-112-7/+7
| | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6510001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74693 0039d316-1c4b-4281-b951-d872f2087c98
* Fix MenuClosed on views+gtkpiman@google.com2011-02-111-0/+2
| | | | | | | | | | | | This is necessary to get context menus working in Pepper. MenuClosed is called on views+win and native gtk, so this seems like the right thing to do. BUG=none TEST=Ran Pepper Flash on a Chrome OS build, made sure context menus work Review URL: http://codereview.chromium.org/6250098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74666 0039d316-1c4b-4281-b951-d872f2087c98
* Use DispatchX for dispatching X events.sadrul@chromium.org2011-02-114-8/+8
| | | | | | | | | | This fixes an error clang shows with -Woverloaded-virtual. BUG=72575 TEST=none Review URL: http://codereview.chromium.org/6487004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74595 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-102-14/+14
| | | | | | | | | | | | | | Re-landing, moving the bits Mac uses to ui/base/events.h BUG=72040 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74377 - Migrate Event API methods to Google Style.ben@chromium.org2011-02-092-8/+8
| | | | | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6480001 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6469014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74379 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-092-8/+8
| | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6480001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu arrow position for RTLoshima@google.com2011-02-093-15/+42
| | | | | | | | | | | | | Flip the direction of submenu arrow for RTL BUG=chromium-os:5593 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74171 Review URL: http://codereview.chromium.org/6428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74324 0039d316-1c4b-4281-b951-d872f2087c98
* Move Event files into views/eventsben@chromium.org2011-02-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/6459024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74305 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile after views API changes, and remove some dead code.sadrul@chromium.org2011-02-092-13/+0
| | | | | | | | BUG=none TEST=none TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74255 0039d316-1c4b-4281-b951-d872f2087c98
* Rework tree APIs to reflect Google style and more const-correctness.Also, ↵ben@chromium.org2011-02-095-33/+30
| | | | | | | | | | | move PrintViewHierarchy/PrintFocusHierarchy out into a separate header. BUG=72040 TEST=None Review URL: http://codereview.chromium.org/6452011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74244 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux MouseWheelEvent consistent with win.xiyuan@chromium.org2011-02-081-1/+1
| | | | | | | | | | | Also reverted SubmenuView scroll direction change in r73996. BUG=chromium:72320 TEST=Views scroll should be consistent on all platforms per chromium:72320 Review URL: http://codereview.chromium.org/6453008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74195 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix submenu arrow position for RTL"oshima@google.com2011-02-083-41/+14
| | | | | | | | | | | | | This reverts commit 37d4bc610b675ab94dd1d696fbdd474cbfc46208. TBR=dmazzoni@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6462006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu arrow position for RTLoshima@google.com2011-02-083-14/+41
| | | | | | | | | | | Flip the direction of submenu arrow for RTL BUG=chromium-os:5593 TEST=none Review URL: http://codereview.chromium.org/6428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74171 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up RTL methods.ben@chromium.org2011-02-083-6/+6
| | | | | | | | | | | | | | No one used the non-RTL version of GetBounds(), so I renamed it GetMirroredBounds() and got rid of the enum. Same for GetX(), consolidated with MirroredX() into GetMirroredX(). GetPosition() already took into account mirroring, so renamed GetMirroredPosition() for symmetry. Renamed the other functions to be getters. De-inlined a few that were doing complex looking stuff. http://crbug.com/72040 TEST=none Review URL: http://codereview.chromium.org/6334152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74087 0039d316-1c4b-4281-b951-d872f2087c98
* Rework basic bounds methods on View to match new V2 API: ben@chromium.org2011-02-085-10/+6
| | | | | | | | | | | | | | | | SetBounds(const gfx::Rect& rect) -> SetBoundsRect(); DidChangeBounds()->OnBoundsChanged() GetLocalBounds(false)->GetLocalBounds() GetLocalBounds(true)->GetContentsBounds() Moved GetBounds(), GetX(), and GetPosition into RTL section. http://crbug.com/72040 TEST=none Review URL: http://codereview.chromium.org/6410109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74052 0039d316-1c4b-4281-b951-d872f2087c98
* Make mouse wheel scrolling in views menu smoother.xiyuan@chromium.org2011-02-075-3/+17
| | | | | | | | | | | | | | | Mouse wheel scrolling eventually calls each MenuItemView's GetPreferredSize for every row moved. This change added a preferred size cache to make it more efficient. Also flipped scroll direction to be consistent with the scrolling direction in other places. BUG=chromium-os:11057 TEST=Verify mouse wheel scrolling is smooth per chromium-os:11057. Review URL: http://codereview.chromium.org/6368105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73996 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-0520-31/+31
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Added battery status update in drop-down when power is changed.oshima@google.com2011-02-031-0/+2
| | | | | | | | | BUG=10972 TEST=Click on battery icon to open power status drop-down, trigger power status change by plugging/unplugging power, make sure drop-down is updated. Review URL: http://codereview.chromium.org/6312092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73676 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in BookmarkMenuController::GetTooltipText that occurredsky@chromium.org2011-02-011-0/+5
| | | | | | | | | | | | because we were passing in an id that it wasn't prepared for. This happened if a menu had no children. BUG=71555 TEST=see bug Review URL: http://codereview.chromium.org/6368024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73315 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/6305001/ for Simon:sky@chromium.org2011-01-282-1/+16
| | | | | | | | | | | | | | Add tooltips to bookmark buttons in drop-down menus (views only). Contributed by simonmorris@chromium.org BUG=5246 TEST=Hover over a bookmark button in a drop-down menu. TEST=Give a bookmark button a very long title, and hover over it. Review URL: http://codereview.chromium.org/6339011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73017 0039d316-1c4b-4281-b951-d872f2087c98
* Fix printing PDFs through right click on Mac and Linux. Looks like they ↵jam@chromium.org2011-01-271-16/+2
| | | | | | | | | both give the menu closed notification before the notification about which item was clicked. BUG=70987 Review URL: http://codereview.chromium.org/6336014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72840 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code as cause of crash was found. I'm TBRing as thissky@chromium.org2011-01-241-2/+2
| | | | | | | | | | | | just converts some CHECKs to DCHECKs. BUG=62872 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6360015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72367 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-215-7/+7
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus. The crash would happen because we weresky@chromium.org2011-01-211-0/+1
| | | | | | | | | | | incorrectly clearing the selection. BUG=62872 TEST=none Review URL: http://codereview.chromium.org/6275009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72048 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-202-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression in submenus not working.jam@chromium.org2011-01-201-2/+15
| | | | | | | BUG=69797 Review URL: http://codereview.chromium.org/6304013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72005 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Allow grabbing/ungrabbing touch devices for XInput2.sadrul@chromium.org2011-01-201-0/+21
| | | | | | | | | | | | | | | This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71879 Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72002 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-201-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71879 due to compile failure - touch: Allow grabbing/ungrabbing touch ↵sadrul@chromium.org2011-01-201-21/+0
| | | | | | | | | | | | | | | | | | devices for XInput2. This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6300007 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/6349008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71885 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Allow grabbing/ungrabbing touch devices for XInput2.sadrul@chromium.org2011-01-201-0/+21
| | | | | | | | | | | | | This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71879 0039d316-1c4b-4281-b951-d872f2087c98
* Move UI-relevant Windows files to ui/base.ben@chromium.org2011-01-192-5/+5
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6254011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98
* Move more dnd related files to ui/baseben@chromium.org2011-01-193-9/+9
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98
* Allow printing/saving a plugin through right click menu, even if it's in a ↵jam@chromium.org2011-01-151-17/+22
| | | | | | | | | frame or an embed element. BUG=50285 Review URL: http://codereview.chromium.org/6142013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71519 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing context menu for the new views textfield.varunjain@chromium.org2011-01-142-6/+0
| | | | | | | | | BUG=none TEST=right click on the new textfield should show the context menu and all commands on the menu should work. Review URL: http://codereview.chromium.org/6155011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71467 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from views. Part 3: Switch accessibility strings to string16.avi@chromium.org2011-01-142-3/+2
| | | | | | | | | BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6192007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71461 0039d316-1c4b-4281-b951-d872f2087c98
* Move models from app to ui/base/modelsben@chromium.org2011-01-1411-63/+63
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging in code in hopes of figuring out a crash in thesky@chromium.org2011-01-132-90/+121
| | | | | | | | | | | | | | menu code. It seems like we end up getting mouse events from a widget that is no longer visible. Additionally it seems possible that the selection is cleared before we expect it. Hopefully both of these CHECKs will help figure out what is going on. BUG=62872 TEST=none Review URL: http://codereview.chromium.org/6288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71371 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-134-20/+20
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* Move OSExchangeData from src/app to src/ui/base/dragdropben@chromium.org2011-01-123-2/+8
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71205 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71169 - Revert 71167 - Remove wstring from gfx.avi@chromium.org2011-01-122-2/+2
| | | | | | | | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6130008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71167 - Remove wstring from gfx.joi@chromium.org2011-01-122-2/+2
| | | | | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71169 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from gfx.avi@chromium.org2011-01-122-2/+2
| | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71167 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from views. Part 2: Switch accelerator strings to string16.avi@chromium.org2011-01-102-17/+18
| | | | | | | | | BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6199005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70936 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from views. Part 1: Switch member variables to string16.avi@chromium.org2011-01-103-7/+10
| | | | | | | | | BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70899 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 8, the last part.avi@chromium.org2011-01-071-1/+1
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70769 0039d316-1c4b-4281-b951-d872f2087c98
* Change Font.GetStringWidth() to take string16 instead of wstring.estade@chromium.org2011-01-042-3/+4
| | | | | | | | | | | do a bunch of string fixes along the way. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/5985007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70440 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 4.avi@chromium.org2011-01-041-1/+2
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/5958017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70423 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/win_util to the base/win directory and use the base::win namespace.brettw@google.com2010-12-312-4/+4
| | | | | | | | | Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98
* Remove win_util::FormatMessage and FormatLastWin32Error. These were only ↵brettw@google.com2010-12-302-5/+5
| | | | | | | | | | | | | | used in a couple of diagnostic places and one can always use the "Error Lookup" utility. Move window HWND-specific functions from base/win_util.h to a new file app/win/hwnd_util.h. I plan to put some more stuff from app/win_util into this file as well. Move gfx/window_impl.h into app/win TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70312 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 22:49:44 +0000