summaryrefslogtreecommitdiffstats
path: root/views/controls/native
Commit message (Collapse)AuthorAgeFilesLines
* A NativeHostViewViews class for embedding views inside NativeHostView instances.anicolao@google.com2010-12-174-3/+156
| | | | | | | | | BUG=none TEST=manually on touchui build Review URL: http://codereview.chromium.org/5785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69551 0039d316-1c4b-4281-b951-d872f2087c98
* gtk views: NULL-check fixed_ before hidingevan@chromium.org2010-11-121-1/+2
| | | | | | | | | | | | Due to a bug in the test setup, these critical errors were not causing DCHECKs. Fixing that bug caused this bug to become more visible. BUG=62868 TEST=no more critical errors in ExtensionApiTest.GetViews and others Review URL: http://codereview.chromium.org/4856001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65891 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes another gray rect. This problem occurred because NativeViewHostsky@chromium.org2010-10-061-0/+2
| | | | | | | | | | | | | | was not correctly resetting state when the child was switched. In particular it wouldn't remove the clip when switching, which meant that if we switched back to an hwnd we had installed a clip we wouldn't reset the clip when we should have. BUG=57573 TEST=see bug Review URL: http://codereview.chromium.org/3605010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61688 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-272-9/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Add in a browser test for dialog resizing, which was catching an issue with ↵scottbyer@chromium.org2010-08-201-5/+9
| | | | | | | | | | | | | the way we were using GTK in toolkit views. Possibly related to 27365 or 38785. http://code.google.com/p/chromium-os/issues/detail?id=4126 BUG=chromium-os:4126 TEST=HtmlDialogBrowserTest.SizeWindow Review URL: http://codereview.chromium.org/2768006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56919 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix bad license headers found in some filestfarina@chromium.org2010-07-281-3/+3
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3017036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53974 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-264-0/+4
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 47902 and 47900.dpolukhin@chromium.org2010-05-211-10/+5
| | | | | | | | | | | | Chrome UI blinks after replacement of gtk_widget_set_size_request with gtk_widget_size_allocate on resizing or infobar appearing animation. It happens because gtk_widget_size_allocate results in background resizing on message loop idle. It looks like we can't use gtk_widget_size_allocate at this place at all. Review URL: http://codereview.chromium.org/2131021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47913 0039d316-1c4b-4281-b951-d872f2087c98
* NativeViewHostGtk should use gtk_views_fixed instead of gtk_fixeddpolukhin@chromium.org2010-05-211-5/+10
| | | | | | | | | | | | and avoid calling gtk_widget_set_size_request to don't spoil preferred size for native controls. BUG=crosbug.com/2876 TEST=See bug description. Review URL: http://codereview.chromium.org/2068006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47900 0039d316-1c4b-4281-b951-d872f2087c98
* Gets rid of the annoying white dot in the upper left corner of allsky@chromium.org2010-04-231-0/+1
| | | | | | | | | | | | | | | | chromeos windows. This white dot was a gtkfixed that should not have been visible. It was being made visible by the show_all in WindowGtk. There may be some regressions from this change, but we should individually be doing show/show_all for hierarchies rather than in window. BUG=none TEST=none Review URL: http://codereview.chromium.org/1730008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45442 0039d316-1c4b-4281-b951-d872f2087c98
* Add EnableDoubleBuffer to WidgetGtkoshima@chromium.org2010-04-211-7/+9
| | | | | | | | | | | | | This will be used to eliminate flicker issue in notification panel (and probably in settings when settings is moved to views). NativeViewHostGtk was creating Fixed with gdk window everytime it is repositioned with clipping. This was causing a lot of creation/deletion of fixed when moving a native control in scroll bar. BUG=23445 TEST=none Review URL: http://codereview.chromium.org/1725005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45252 0039d316-1c4b-4281-b951-d872f2087c98
* Polish ChromeOS options dialog:xiyuan@chromium.org2010-04-211-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow so that it has a frame; This piece of code is based on Chrome's OptionsWindowView. Ideally, we should use Chrome's options view but we still missing underlying controls such as Tree and Table. - Use last active browser window as options dialog's parent; This makes optiosn dialog transient for the browser window and window manager will no longer treat it as top-level window and will not move and resize it; - If user switches to a new browser window and invokes options dialog again, close the existing one and re-opens it for the current browser window. This is currently supported by window manager; - Update CustomerFrameView and WindowDelegate to make client edge optionaly; Options dialog has no client area padding and does not have a client edge per UI mock; - Make NativeViewHost respects its background. This solves the problem that tab pane background is not properly cleared when hosting a native GtkVBox pane in TabbedPane; BUG=<http://crosbug.com/1885> TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings Review URL: http://codereview.chromium.org/1672003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views] Handle focus in event of native views and controls correctly.suzhe@chromium.org2010-04-122-9/+10
| | | | | | | | | BUG=http://crosbug.com/1800 TEST=Build chromium with toolkit_views=1, and run it with ibus input method, then try if the input method can be enabled inside find bar. Review URL: http://codereview.chromium.org/1547027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44260 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-232-2/+2
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-141-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* Unblock focus signal handlers only when they're blocked.oshima@chromium.org2010-03-111-11/+18
| | | | | | | | | | | | Unblocking fails when handlers are not blocked. Minor fix. use correct data type for signal handler id. BUG=none TEST=none Review URL: http://codereview.chromium.org/844003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41318 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 577015.twiz@chromium.org2010-02-121-3/+8
| | | | | | | | | | | See http://codereview.chromium.org/577015 for the review status of this CL. BUG=None TEST=ExtensionApiTest.Popup Review URL: http://codereview.chromium.org/600101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-102-0/+16
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Don't emit focus event when moving focus around when re-creating fixed widget.oshima@chromium.org2010-01-271-5/+75
| | | | | | | | | | | | - This fixes the crash in compact navigation bar without a adjustment. - I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView. BUG=chromium-os:1010 TEST=manual: compact nav bar does not crash. Review URL: http://codereview.chromium.org/548151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts change to native_view_host_gtk. This fixes the bug, but isn'tsky@chromium.org2010-01-071-2/+0
| | | | | | | | | | | | the right fix. Current code is correct. BUG=31132 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/523141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that resulted in background tabs not getting sizedsky@chromium.org2010-01-071-1/+3
| | | | | | | | | | | | | correctly. When using fixed like we are we need to explicitly call allocate, otherwise the child won't get a size allocate and correctly update itself. BUG=31132 TEST=see bug Review URL: http://codereview.chromium.org/525093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35719 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-071-1/+19
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-062-0/+39
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-237-12/+34
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views not draw focus for native controls on Gtk. As Gtk renderssky@chromium.org2009-12-032-3/+15
| | | | | | | | | | | the focus for us, this resulted in double the focus indicators. BUG=none TEST=none Review URL: http://codereview.chromium.org/468004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33739 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-2/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* When a GtkWidget was destroyed the NVH would not be detached.jcampan@chromium.org2009-10-091-3/+3
| | | | | | | | | | | There was a hack in location_bar_view to prevent an assert, but it would cause an other assert. Also fixed a double delete with the find_bar_host. BUG=None TEST=Start Chrome Linux toolkit view. Close it. It should not assert. Review URL: http://codereview.chromium.org/266034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28556 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-057-128/+49
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* When installing/uninstalling the clip on native buttons they would not be ↵jcampan@chromium.org2009-10-021-2/+2
| | | | | | | | | | | | | | painted properly. This is the case for animations, such as the dangerous download item animation. (For some unclear reasons this would happen only in aero and only in a popup browser frames.) Explicitly asking for a repaint when setting the clip fixes it. BUG=23087 TEST=Start a dangerous download from a popup (sorry, I don't have any public URL to repro). The dangerous download should display properly in the download shelf. Review URL: http://codereview.chromium.org/259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27858 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-297-49/+128
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few bugs in view/gtk frameworkoshima@chromium.org2009-09-251-2/+3
| | | | | | | | | | | | | | | | | NativeControlGtk * Layout if the visibility is changed after the native view is created. (I also added DCHECK(GetWidget()) to make sure Wiget is available at this point) NativeViewHostGtk * decrement the native_view's ref count only if it still has a parent. * create fixed in AddedToWidget if fixed_ does not exist. This can happen when a view is removed, then added. BUG=none TEST=unit test for last 2 bugs is added to view_unittest.cc (ChangeVisibility). Review URL: http://codereview.chromium.org/219035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27282 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27113, it breaks the ChomeOS build.jcampan@chromium.org2009-09-247-128/+49
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/231022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-247-49/+128
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/206025 for Charlie:sky@chromium.org2009-09-161-4/+8
| | | | | | | | | | | | Fix settings page transparent background issue Also comment out focus manager check due to bug: http://crbug.com/21378 TEST=none BUG=none Review URL: http://codereview.chromium.org/194128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26370 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the focus remembered across tab switches for Chrome Linux with ↵jcampan@chromium.org2009-09-144-5/+41
| | | | | | | | | | | | | | | toolkit views. It also contains clean-ups and implementation of different minor focus related things. BUG=None TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab. Also test that deactivating/reactivating the browser window still restores focus properly. Review URL: http://codereview.chromium.org/194041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on ↵ben@chromium.org2009-08-012-19/+18
| | | | | | | | | | | | | shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt. The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler. BUG=none TEST=none Review URL: http://codereview.chromium.org/159751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug introduced by my clipping changes - when you switched tabs the tab ↵ben@chromium.org2009-07-231-0/+1
| | | | | | | | | | | area would blank out - we weren't showing the NativeView in calls to ShowWidget, only the fixed. BUG=none TEST=none Review URL: http://codereview.chromium.org/160049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NativeViewHostGtk clipping.ben@chromium.org2009-07-233-65/+129
| | | | | | | | | | | | | Basically, I introduce an additional GtkFixed into the GtkWidget hierarchy. When clipping is required, this is re-created with a X Window and clipping is performed. For some reason, Gtk+Cairo won't clip rendering to the parent GtkWidget if there isn't an associated X Window. This also fixes the GetPreferredSize implementation for NativeButtonGtk which would return ever increasing values of size each time it was called. BUG=none TEST=none Review URL: http://codereview.chromium.org/159153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two crashers with TOOLKIT_VIEWS build:ben@chromium.org2009-07-211-2/+7
| | | | | | | | | | | - NativeViewHostGtk::RemovedFromWidget crashes due to WidgetGtk::window_contents_ being NULL... basically when RemovedFromWidget is called from the RootView's dtor, the window_contents_ and widget_ properties of the containing WidgetGtk are NULL. It seems acceptable to not clean up in this case. - TabContentsViewGtk dtor needs to call CloseNow(). This is similar to ~TabContents() calling DestroyWindow on the view's HWND. Without this, the TabContentsViewGtk object was destroyed but the corresponding GtkWidget wasn't, and so subsequent signal handlers would crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/159130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage by removing another dependency on browser/gtk by creating ↵ben@chromium.org2009-06-172-54/+26
| | | | | | | | | | | a new TabContentsViewGtk specifically for views. This subclasses WidgetGtk similar to how TabContentsViewWin subclasses WidgetWin. There was a bug in NativeViewHostGtk - reparenting needs to be done atomically using gtk_widget_reparent since GtkWidgets are refcounted and when removed from a container are released, causing a crash when a TabContents is reparented. The code now compiles thanks to a stubbed BlockedPopupContainer, however there is one remaining issue - the browser window no longer paints and the app instantly hangs. However this is better than the current state so I figured I'd send the code review. Review URL: http://codereview.chromium.org/126107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18588 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-122-9/+0
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Make Combobox portableben@chromium.org2009-06-021-0/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17382 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of related bugs:sky@chromium.org2009-06-011-10/+27
| | | | | | | | | | | | | | | | . gdk_display_get_pointer requires a display. . Don't do anything in NativeViewHostGtk if asked to remove and there is no native view. . Make NativeViewHostGtk deal with the native view already having the same parent. . Implement a couple of methods in NativeTabContentsContainerGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/115989 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17349 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get gtk/views to bring up browser window w/out crashingdavemoore@chromium.org2009-05-301-1/+3
| | | | | | | TBR: beng Review URL: http://codereview.chromium.org/118051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17292 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk work: NativeViewPhotoboothGtk, adds a missing methodsky@chromium.org2009-05-291-0/+4
| | | | | | | | | | | to NativeViewHostGtk and location bar view colors. BUG=none TEST=none Review URL: http://codereview.chromium.org/115958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-291-1/+1
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak... the wrapped platform helper isn't a view, so it's not ↵ben@chromium.org2009-05-293-6/+7
| | | | | | | | | | auto-deleted... use a scoped_ptr instead! BUG=none TEST=none Review URL: http://codereview.chromium.org/118025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17220 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match ↵ben@chromium.org2009-05-297-0/+717
the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView). BUG=none TEST=none Review URL: http://codereview.chromium.org/114059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 17:00:37 +0000