summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-0127-111/+109
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0127-109/+111
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in r56766oshima@chromium.org2010-09-011-0/+2
| | | | | | | | | | | CustomButton::OnKeyEvent should return false when the event is not handled BUG=chromium-os:6290 TEST=none Review URL: http://codereview.chromium.org/3276007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58111 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-279-27/+32
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 12.viettrungluu@chromium.org2010-08-223-3/+5
| | | | | | | | | | | | | | - This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16 instead of a wstring. - This entailed changing the base class, ComboboxModel, and shaving a herd of yaks. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3159031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the stop button when the user is hovering it and the page finishes ↵pkasting@chromium.org2010-08-202-2/+24
| | | | | | | | | | | | | | loading, so we don't look like we stay loading forever. This change only does this for Mac and Windows, as GTK is going to be trickier. This also fixes a pair of other bugs on Windows and Linux: * Because we were setting the timer after telling the browser to reload, and the browser was calling us back synchronously, the timer had no effect. * Because the timer firing changed modes with |force| set to true, if the page finished loading before the timer fired, the timer would flip the button back to reload. BUG=46981 TEST=Hover the reload button and hit F5. When the page finishes loading, the stop button should become disabled. Mousing away should change it to an enabled reload button. Review URL: http://codereview.chromium.org/3198005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56925 0039d316-1c4b-4281-b951-d872f2087c98
* Add in a browser test for dialog resizing, which was catching an issue with ↵scottbyer@chromium.org2010-08-202-5/+14
| | | | | | | | | | | | | the way we were using GTK in toolkit views. Possibly related to 27365 or 38785. http://code.google.com/p/chromium-os/issues/detail?id=4126 BUG=chromium-os:4126 TEST=HtmlDialogBrowserTest.SizeWindow Review URL: http://codereview.chromium.org/2768006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56919 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove dead code, use early returns to reduce indenting, shorten.pkasting@chromium.org2010-08-192-112/+70
| | | | | | | | | | This makes one behavioral change: a mouse release with a successful HitTest and |canceled| true will set the state to HOT instead of NORMAL. This seemed more correct to me. BUG=none TEST=none Review URL: http://codereview.chromium.org/3175027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56766 0039d316-1c4b-4281-b951-d872f2087c98
* Another take on menu's. This uses the hosting menu scroll view container as ↵dtseng@chromium.org2010-08-193-4/+19
| | | | | | | | | | | | | | | | | a menubar on which we can fire MENUSTART and MENUEND events. The end result is that we now have the following scenario when a user opens a menu. 1. focus lands on the menu button. 2. down arrow. 3. A "chromium" menu item appears. 4. down arrow (or enter). 5. The first menu item gets focused. The only differences from what we currently have is Jaws/NVDA no longer say "context menu opened" or "applications". The first real menuitem also doesn't get focused when the menu shows. BUG=none. TEST=use NVDA and Jaws to navigate the menu's (opening, closing, submenus, accelerators). Review URL: http://codereview.chromium.org/3155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56715 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FillRect(... SkPaint) to DrawRect() since it doesn't necessarily ↵pkasting@chromium.org2010-08-181-1/+1
| | | | | | | | | | fill, it just draws with the provided paint. BUG=none TEST=none Review URL: http://codereview.chromium.org/3165032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56589 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetDisplayStringInLTRDirectionality from wstring to string16.tony@chromium.org2010-08-181-1/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3108027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56535 0039d316-1c4b-4281-b951-d872f2087c98
* Status menu change per chromium-os:5517xiyuan@chromium.org2010-08-172-2/+19
| | | | | | | | | | | | | | | | | | | | - Apply 10% white to selected menu button; - Remove the menu offset so that the menu is top aligned with toolbar; - Make all status area buttons derive from StatusAreaButton; - Move ClockMenuButton's text size logic into StatusAreaButton to share the logic with LanguageMenuButton; - Strip unused space from LanguageMenuButton so that it looks good with 10% white highlight; - Make LanguageMenuButton and ClockMenuButton center aligned; - Add 1-pixel padding at top when the vertical space is odd number so that text looks properly aligned with the icons; BUG=chromium-os:5517 TEST=Verify fix for chromium-os:5517. Review URL: http://codereview.chromium.org/3141019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-1323-51/+60
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Get rid of TreeNodeChildrenReordered.tfarina@chromium.org2010-08-112-41/+3
| | | | | | | | | | | | Reason: This function was never implemented by TreeNodeModel and is unlike it will be. Also it proved to not be necessary at all. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3091016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55657 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize most_recent_profile_ in constructor.ctguil@chromium.org2010-08-101-1/+1
| | | | | | | | | BUG=51631 TEST=Ensure chrome --first-run don't crash when opening the wrench menu. Review URL: http://codereview.chromium.org/3139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55606 0039d316-1c4b-4281-b951-d872f2087c98
* Improvements to accessibility extension api support for "views":dmazzoni@chromium.org2010-08-062-5/+11
| | | | | | | | | | | | | 1. Handles the new wrench menu. 2. Uses NotifyAccessibilityEvent to find out when focus changes, rather than installing focus change listeners that need to be cleaned up. BUG=none TEST=Updated AccessibilityEventRouterViewsTest.TestFocusNotification Review URL: http://codereview.chromium.org/3056045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55196 0039d316-1c4b-4281-b951-d872f2087c98
* Enable better NVDA support for custom menus.ctguil@chromium.org2010-08-064-10/+25
| | | | | | | | | | | | - Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role. - Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus. TEST=The wrench menu and it's menu items are read aloud when using NVDA. BUG=49360 Review URL: http://codereview.chromium.org/3015055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55163 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Add view class names to some classes used in the Wrench menu.dmazzoni@chromium.org2010-08-046-0/+45
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2832106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-042-3/+6
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from l10n_util/ResourceBundle locale functions.evan@chromium.org2010-08-041-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3069026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54917 0039d316-1c4b-4281-b951-d872f2087c98
* Makes cut/copy/paste buttons centered with respect to thesky@chromium.org2010-08-032-7/+11
| | | | | | | | | | | | | separator. This proves a bit tricky as normally separators are closer to the bottom of the space provided. I've centered them now so that the buttons look centered too. BUG=50099 TEST=see bug Review URL: http://codereview.chromium.org/3072015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54772 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 5ziadh@chromium.org2010-08-021-0/+3
| | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3080013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-2/+2
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-3111-15/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54074.dtseng@chromium.org2010-07-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3010040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland code reverted in r52599, to take another look at the page ↵pkasting@chromium.org2010-07-301-2/+4
| | | | | | | | | | | cycler data. There was a lot of noise in the previous data, and since the current page cycler t and t_ref times are close, I'm hoping to see something more conclusive. TBR=jar BUG=47227 TEST=none Review URL: http://codereview.chromium.org/3026032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54236 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).rohitrao@chromium.org2010-07-291-1/+1
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial tests for keyboard access (tabbing in some dialogs).dtseng@chromium.org2010-07-281-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix bad license headers found in some filestfarina@chromium.org2010-07-2812-49/+42
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3017036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53974 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial focus when the task manager first activates and shows. ↵dtseng@chromium.org2010-07-281-0/+1
| | | | | | | | | | Also, send our custom accessibility events in NativeControl's Focus() method. BUG=50401 TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager Review URL: http://codereview.chromium.org/3038031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53959 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").pkasting@chromium.org2010-07-272-22/+34
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3058011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-277-0/+21
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code path in TabbedPane::RemoveTabAtIndex()mnissler@chromium.org2010-07-271-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3044022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53781 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-273-143/+98
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2683-0/+83
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in links ending up too small. The problem is that wesky@chromium.org2010-07-213-8/+3
| | | | | | | | | | | | | | | | | | | | changed IsFocusable to check IsVisibleInRootView. This meant that any views (like label) whose preferred size takes into account focusable and cached the preferred size before they were visible in the root view would end up with the wrong size because they didn't recalculate when IsVisibleInRootView changed. I've separated out the two states so that IsFocusable no longer checks IsVisibleInRootView and is protected. All consumers now call IsFocusableInRootView which checks IsFocusable and IsVisibleInRootView. BUG=49635 TEST=see bug. Review URL: http://codereview.chromium.org/3046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53187 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views]Handle focus traversing correctly.suzhe@chromium.org2010-07-201-2/+10
| | | | | | | | | | | | This CL adds a wrapper window class on top of GtkWindow to intercept its move_focus method, so that we can handle focus traversing by ourselves. BUG=49204: Chrome/views toolbar "tab" accessibility broken. TEST=See bug report. Review URL: http://codereview.chromium.org/3013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53123 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in views/gtk when pressing space bar on a menu button.sky@chromium.org2010-07-181-0/+6
| | | | | | | | | BUG=49366 TEST=see bug Review URL: http://codereview.chromium.org/3046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52874 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to only handle real visiblity changes in NativeViewHost.mnissler@chromium.org2010-07-161-3/+7
| | | | | | | | | BUG=49100 TEST=Open options dialog -> Personal Stuff. Turn on sync, turn off sync, switch to advanced page. Browser shouldn't crash. Review URL: http://codereview.chromium.org/2868048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52629 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46492 to repair perf regression in XP single-core Moz Page Cyclerjar@chromium.org2010-07-161-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Actually, this only reverts the windows specific portion of 46492. Initial revert and restore (see revisions 52456 and 52441) seemed to show that this was indeed the cause of the regression. There was some problem with the perf bot, so I'm landing again to confirm that this removes the regression. As pointed out by pkasting, this is all browser side computation, but on a single core (as noted by Darin), browser processing becomes critical path (and can impact perf). My suspicioun is that the original code did some caching of its font metrics, and this was not (to the same extent??) being done in the replacement (centralized) code. If this does not provide the perf fix I'm expecting, I'll revert it. BUG=47227 TBR=pkasting Review URL: http://codereview.chromium.org/3023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52599 0039d316-1c4b-4281-b951-d872f2087c98
* Relayout content pref page properly upon sync status changes.mnissler@chromium.org2010-07-1510-1/+27
| | | | | | | | | | | | This fixes a layouting problem that resulted in the "Stop syncing this account" button not being sized properly after setting up sync. BUG=48807 TEST=Open options dialog in non-synced state, configure sync, check "Stop syncing this account" button after setup. Review URL: http://codereview.chromium.org/2980005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52463 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus placement after using ctrl+tab in dialogs.dtseng@chromium.org2010-07-141-7/+7
| | | | | | | | BUG=48986 TEST=none Review URL: http://codereview.chromium.org/2948010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52375 0039d316-1c4b-4281-b951-d872f2087c98
* This ensures ATs read the correct selected tab when the containing tabbed ↵dtseng@chromium.org2010-07-141-1/+6
| | | | | | | | | | pane gets focus. BUG=48885 TEST=none Review URL: http://codereview.chromium.org/2974006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52321 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the announcement of combo boxes by excluding them from firing events on ↵dtseng@chromium.org2010-07-122-2/+8
| | | | | | | | | | our combobox IAccessible. Since we already call SetFocus on the native combo box, this event will go to the AT correctly, but this IAccessible won't be hooked up to the rest of the IAccessible tree. Also, any changes made in combobox.cc/h concerning accessibility won't show up when the combobox receives focus. BUG=48703 TEST=none Review URL: http://codereview.chromium.org/2937004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52132 0039d316-1c4b-4281-b951-d872f2087c98
* Ups the max size of bookmark menus to accommodate the wrench menu.sky@chromium.org2010-07-081-1/+3
| | | | | | | | | BUG=48309 TEST=see bug Review URL: http://codereview.chromium.org/2880019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo that caused wrong menu highlight color being used for ChromeOS.xiyuan@chromium.org2010-07-071-1/+1
| | | | | | | | | BUG=chromium-os:4580 TEST=Verify correct color 0xDCE4FA is used for menu highlight per chromium-os:4580. Review URL: http://codereview.chromium.org/2861049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51780 0039d316-1c4b-4281-b951-d872f2087c98
* Fire focus events when CustomButtons are hottracked.dtseng@chromium.org2010-07-072-0/+23
| | | | | | | | BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2867040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51753 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing states for menu items. This allows AT's to know when a ↵dtseng@chromium.org2010-07-071-0/+13
| | | | | | | | | | menu item has a submenu (HASPOPUP) and is checked (either a radio or checkbox). BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2858051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix column sizing in views::TableView.mnissler@chromium.org2010-07-072-2/+8
| | | | | | | | | | | | r51628 accidentally broke the sizing logic to only work if autosize_columns_ is set. Use a flag to track whether an initial sizing operation is required. BUG=48373 TEST=Open Content Settings Exceptions dialog, close, reopen. Columns in the table should be sized reasonably instead of being all clumped up at the left edge. Review URL: http://codereview.chromium.org/2888001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51749 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 13:37:35 +0000