| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8687031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8729013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8718004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8716001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8658010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8658009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104599
R=mazda@chromium.org
Review URL: http://codereview.chromium.org/8695005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8682011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8655001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8669002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8651006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed most obvious TOUCH_UI tests. Either obvious because we have USE_AURA | TOUCH_UI or because it is in a GTK module.
This CL focuses mainly on Views cleanup.
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8632016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105046
Review URL: http://codereview.chromium.org/8635010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110949
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8598031
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8547015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views.
Specifically:
- views-desktop (classes and NativeWidgetView[s])
- NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al).
- RWHVV, NWKEV
- NativeViewHostViews
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
nested loop can exit.
BUG=104684
TEST=BrowserTest.CloseWithAppMenuOpen passes on aura build
Review URL: http://codereview.chromium.org/8597010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original change (http://codereview.chromium.org/8565011/) was
reverted due to failing NativeTextfieldViewsTest.HitInsideTextAreaTest.
The test was too strict when comparing cursor bounds and failed due
to font fallback causing height differences in cursor bounds. This
updated CL makes the test only check the x value of cursor bounds.
Original CL description:
This is done by using a metafile to capture the font
that Uniscribe would use to render the text (since
there is no API to get this from Uniscribe itself).
Makes SCRIPT_CACHE be per-run, since different runs
may have different fonts and the SCRIPT_CACHE cannot
be re-used between these.
This is similar to what is done in WebKit in FontCacheWin.cpp
BUG=90426,104234
TEST=Run chrome.exe --use-pure-views and paste some Hebrew
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8570003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the clipboard text initially rather than using
whatever happened to be in the clipboard at the time
of the test.
BUG=none
TEST=Copy some non-ASCII text before running TextfieldViewsModelTest.Clipboard.
Then, run the test. It should not fail.
Review URL: http://codereview.chromium.org/8486024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wouldn't do a final layout resulting in the content not laying out
correctly.
BUG=104082
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8573029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8568022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101774
TEST=NONE
Review URL: http://codereview.chromium.org/8527015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The window gets removed in RemovedFromWidget, so it is not necessary to do
this again in NativeViewDetaching. This fixes a couple of failing DOMViewTest
tests.
BUG=103487
TEST=DOMViewTest.TestRemoveAndDelete, TestReparent (browser_tests)
Review URL: http://codereview.chromium.org/8574016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101774
TEST=NONE
Review URL: http://codereview.chromium.org/8564015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the test set the clipboard first before testing
that CUT doesn't set the clipboard. Without this, the
test would fail when run a second time due to existing
clipboard contents.
Also, refactor the code to add test helper methods for
getting and setting clipboard text.
BUG=none
TEST=Run NativeTextfieldViewsTest.ReadOnlyTest twice. The second time should not fail.
Review URL: http://codereview.chromium.org/8570002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the use_wayland build which was broken by this commit:
http://codereview.chromium.org/8113028
Similar to win, we create a wayland namespace inside base
and define WaylandEvent there.
Historical note:
Wayland does not have a "native" event structure. Instead, the client
is made aware of events via a callback executed in the context
of display_run():
http://git.chromium.org/gitweb/?p=chromiumos/third_party/wayland-demos.git;a=blob;f=clients/window.c
So we create WaylandEvent structure which takes the parameters from
the callback and wraps them into a structure. For details, see:
src/ui/wayland/events/wayland_event.h
BUG=chromium:102903
TEST=Compiles but doesn't yet link with this change plus a series of
others I'm working on.
R=msw@chromium.org,oshima@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/8378005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the test didn't derive from ViewsTestBase, resulting in OLE not getting initialized, which would lead to failure registering drop targets.
BUG=chromium:104067
TEST=TabbedPaneTest.* doesn't crash.
Review URL: http://codereview.chromium.org/8567002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8497067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first preliminary change for the support of global keyboard shortcut.
BUG=97255
TEST=None
Review URL: http://codereview.chromium.org/8508055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'm also disabling it.
BUG:104067
TBR:mnissler
Review URL: http://codereview.chromium.org/8560003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:104067
TBR:mnissler
Review URL: http://codereview.chromium.org/8560002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
child and title is empty
BUG=chromium-os:22051
TEST=None
Review URL: http://codereview.chromium.org/8511003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove Views dependencies from text_input_client.h.
- Change namespace from views:: to ui::.
This change is necessary for RenderWidgetHostViewAura to support IME since RWHVA is Views agnostic and cannot directly use classes under views/ime/.
BUG=chromium:97261
TEST=try
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109583
Review URL: http://codereview.chromium.org/8509034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove Views dependencies from text_input_client.h.
- Change namespace from views:: to ui::.
This change is necessary for RenderWidgetHostViewAura to support IME since RWHVA is Views agnostic and cannot directly use classes under views/ime/.
BUG=chromium:97261
TEST=try
Review URL: http://codereview.chromium.org/8509034
TBR=yusukes@google.com
Review URL: http://codereview.chromium.org/8491035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove Views dependencies from text_input_client.h.
- Change namespace from views:: to ui::.
This change is necessary for RenderWidgetHostViewAura to support IME since RWHVA is Views agnostic and cannot directly use classes under views/ime/.
BUG=chromium:97261
TEST=try
Review URL: http://codereview.chromium.org/8509034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add "native_view()" check in NativeTabContentsContainerAura
This is necessary as native_view gets destroyed when parent window gets destroyed before tab_contents detatches the native view.
type child should be added to parent.
BUG=99937
TEST=manual: open http auth dialog and close.
Review URL: http://codereview.chromium.org/8462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix invalid transition in custom_button.cc When the mouse is released on a custom button, the state is set to BS_NORMAL if the hit test fails.
The following two transitions should have the same final effect.
BS_PRESSED -> BS_HOT -> BS_NORMAL
BS_PRESSED -> BS_NORMAL
Review URL: http://codereview.chromium.org/8437003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nested menu brought up a dialog.
BUG=101881
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8447019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.
TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.
Review URL: http://codereview.chromium.org/8439015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8429014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45605
TEST=Tested it with Google Japanese Input method on Win7
Review URL: http://codereview.chromium.org/8294026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8405002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107907 0039d316-1c4b-4281-b951-d872f2087c98
|