summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Fixes possible crash in menus and makes widgetgtk not send outsky@chromium.org2010-06-222-5/+11
| | | | | | | | | | | mousemove if the event is the result of a grab. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50529 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the extension resize gripper only visible when the mouse is oversky@chromium.org2010-06-223-5/+45
| | | | | | | | | | | it. BUG=45750 TEST=see bug Review URL: http://codereview.chromium.org/2800022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50515 0039d316-1c4b-4281-b951-d872f2087c98
* Small tweaks to improve toolbar keyboard accessibility: Put focus rectsdmazzoni@chromium.org2010-06-222-0/+8
| | | | | | | | | | | | | around more controls (including location bar, only when in full keyboard access mode). Fix accessible names. Fix spacebar to activate menu buttons. Remove methods for child focus, they're not needed anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/2817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TableViewTest.PersistSelectionOnSort and PersistMultiSelectionOnSort as ↵mattm@chromium.org2010-06-181-2/+2
| | | | | | | | | | | | | fails. (They were re-enabled in 50245) BUG=45015 TBR=nkostylev Review URL: http://codereview.chromium.org/2807008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50282 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for radio menu items to bookmark menus.sky@chromium.org2010-06-186-26/+141
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2846014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50246 0039d316-1c4b-4281-b951-d872f2087c98
* TableViewTests.Sort* started crashing. Marking as DISABLED_.nkostylev@google.com2010-06-181-10/+10
| | | | | | | | | | | | | | Revert 48168 - Mark TreeViewTests as FAILS_ rather than DISABLED_ TBR=jcivelli BUG=45015 Review URL: http://codereview.chromium.org/2171006 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/2824016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50245 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for click-drag-release on views embedded in a menu tosky@chromium.org2010-06-182-5/+124
| | | | | | | | | | | behave as if the user initially clicked on the view. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50244 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests.Sort as DISABLED_.nkostylev@google.com2010-06-181-1/+1
| | | | | | | | | | | Test crashes on Vista bot. BUG=45015 TBR=rafaelw Review URL: http://codereview.chromium.org/2870013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50241 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-183-11/+12
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the merged menu:sky@chromium.org2010-06-177-26/+71
| | | | | | | | | | | | | | | | | | | | | . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for UI issues on AutoFill dialog on Windows.georgey@chromium.org2010-06-162-2/+10
| | | | | | | | BUG=46525 TEST=In the bug. Review URL: http://codereview.chromium.org/2802005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50040 0039d316-1c4b-4281-b951-d872f2087c98
* Add accessibility support for Textfields in Windows.dtseng@chromium.org2010-06-162-0/+84
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49955 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-06-151-7/+12
| | | | | | | | | | | | | | | | Changes the tab close button to a dot, unless you're near the button or the tab is selected. The only difference between this and the first is that I missed a remove from the set if the view was deleted, which resulted in a crash. I've added an interactive test case that covers this. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49828 0039d316-1c4b-4281-b951-d872f2087c98
* Unicode bidi mirroring characters are not correctly mirrored in textfield ↵xji@chromium.org2010-06-152-12/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | and omnibox (which use CRichEditCtrl) while *inputting*. Since bidi mirroring characters are correctly mirrored when rendering the whole text, fix it by re-rendering the whole text every time the text changes. NOTE: this change will mess up the undo queue. The continuous keystroke wont be treated as one undo event. Every single keystroke is treated as a undo state. Using the following as example: 1. paste string "abcd " into find-in-page; 2. type in 'e', 'f', and ' '. 3. paste string "xyz". When undo, the string sequence will be: "abcd ef xyz" => "abcd ef " ==> "abcd ef" ==> "abcd e" ==> "abcd " =>"". Without the change, the string sequence is: "abcd ef xyz" => "abcd ef " => "abcd " =>"". BUG=46298 TEST=follow the steps described in the bug. Review URL: http://codereview.chromium.org/2741007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49795 - Changes the tab close button to a dot, unless you're near the ↵sky@chromium.org2010-06-151-12/+7
| | | | | | | | | | | | | | | | | | | button or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49801 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab close button to a dot, unless you're near the buttonsky@chromium.org2010-06-151-7/+12
| | | | | | | | | | | | | | or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49795 0039d316-1c4b-4281-b951-d872f2087c98
* Same issue as in omnibox, keyboard layout change inside DefWindowProc() inxji@chromium.org2010-06-101-2/+23
| | | | | | | | | | | | NativeTextfieldWin::HandleKeystroke(). Restore keyboard layout after DefWindowProc(). BUG=14049 TEST=open find-in-page, type in pure Hebrew, press HOME/END/shift-HOME/shift-END, keyboard layout should not be changed. Review URL: http://codereview.chromium.org/2738008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49455 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for showing accelerators in bookmark menus.sky@chromium.org2010-06-098-24/+110
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49335 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of about boxseanparent@google.com2010-06-091-1/+6
| | | | | | | | | | | | | | | | | Removed redundent version from update string. Added a line break to the ChromeOS version on test builds to improve appearence (select and drag to see complete version). Added margins to multiline edit fields without borders to make them match single line edit fields in positioning. Fixed an issue with setting the initial focus for GTK based windows. This fixes the problem of the cursor showing up in the version field. BUG=chromium-os:3571 1589 2967 TEST=none Review URL: http://codereview.chromium.org/2620003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49322 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so child views of menuitemview can be traversed with thesky@chromium.org2010-06-0915-56/+250
| | | | | | | | | | | | | keyboard. Because I don't want the menu to actually get focus I'm using SetHotTracked when traversing and AcceleratorPressed from enter/return. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49270 0039d316-1c4b-4281-b951-d872f2087c98
* views: Use FRIEND_TEST_ALL_PREFIXES.tfarina@chromium.org2010-06-051-5/+5
| | | | | | | | | BUG=44549 TEST=trybots Review URL: http://codereview.chromium.org/2699003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49011 0039d316-1c4b-4281-b951-d872f2087c98
* Added const to image parameters for ImageButton class.avayvod@google.com2010-06-022-10/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2418003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48748 0039d316-1c4b-4281-b951-d872f2087c98
* Initial work to fix the IAccessible tree in circumstances where there is a ↵ctguil@chromium.org2010-05-272-1/+6
| | | | | | | | | | widget not at the root of the UI heirarchy. Also contains misc fixes for setting correct name/role for controls found in the Options dialog. BUG=9621 TEST=none Review URL: http://codereview.chromium.org/2174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48444 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-1/+1
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-1/+1
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Add bug number in comments for each TreeViewTest marked as FAILSrafaelw@chromium.org2010-05-251-1/+11
| | | | | | | | | TBR=phajdan.jr TEST=NONE Review URL: http://codereview.chromium.org/2223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48214 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-251-1/+1
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Bound checkingon TableViewjcivelli@chromium.org2010-05-253-29/+43
| | | | | | | | | | Adding bound checking to View <-> Model methods to investigate unit-tests failures. BUG=None TEST=unit-tests should still pass Review URL: http://codereview.chromium.org/2069019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48185 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests as FAILS_ rather than DISABLED_rafaelw@chromium.org2010-05-251-11/+12
| | | | | | | | | TBR=jcivelli BUG=45015 Review URL: http://codereview.chromium.org/2171006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48168 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling TableViewTests (failing on vista)rafaelw@chromium.org2010-05-251-9/+9
| | | | | | | | TBR=jcivelli Review URL: http://codereview.chromium.org/2112017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48164 0039d316-1c4b-4281-b951-d872f2087c98
* Add multiline support to views::TextField.xiyuan@chromium.org2010-05-224-41/+307
| | | | | | | | | | | | | | - Add a GtkViewsTextView derived from GtkTextView and supports border and info text when empty; - Update NativeTextfieldGtk to use GtkViewsTextView for multiline text; - Remove the multiline suppression in BugReportView; BUG=chromium-os:3426 TEST=Verify feedback dialog on ChromeOS uses multiline text edit for description field. Review URL: http://codereview.chromium.org/2138003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47986 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 47902 and 47900.dpolukhin@chromium.org2010-05-211-10/+5
| | | | | | | | | | | | Chrome UI blinks after replacement of gtk_widget_set_size_request with gtk_widget_size_allocate on resizing or infobar appearing animation. It happens because gtk_widget_size_allocate results in background resizing on message loop idle. It looks like we can't use gtk_widget_size_allocate at this place at all. Review URL: http://codereview.chromium.org/2131021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47913 0039d316-1c4b-4281-b951-d872f2087c98
* NativeViewHostGtk should use gtk_views_fixed instead of gtk_fixeddpolukhin@chromium.org2010-05-211-5/+10
| | | | | | | | | | | | and avoid calling gtk_widget_set_size_request to don't spoil preferred size for native controls. BUG=crosbug.com/2876 TEST=See bug description. Review URL: http://codereview.chromium.org/2068006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47900 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-202-14/+33
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* Views menu gradient change for ChromeOS to sync with gtk theme change.xiyuan@chromium.org2010-05-201-5/+3
| | | | | | | | | BUG=chromium-os:2691 TEST=Verify views menu on bookmark bar etc also use the subtle gradient. Review URL: http://codereview.chromium.org/2117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47803 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash when menus were destroyed. I wasn't resetting asky@chromium.org2010-05-111-0/+2
| | | | | | | | | | | pointer, leading to bad data write on destruction. BUG=42513 TEST=see bug Review URL: http://codereview.chromium.org/2013016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46974 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate View::UILayoutIsRightToLeft() to standardize on ↵pkasting@chromium.org2010-05-1016-29/+27
| | | | | | | | | | base::i18n::IsRTL(). Was only needed for EnableUIMirroringForRTLLanguages(), which was only used by Views::Label, which already had this capability via set_rtl_alignment_mode(). BUG=none TEST=none Review URL: http://codereview.chromium.org/1991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46869 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build failure due to bad merge resolvepkasting@chromium.org2010-05-101-1/+1
| | | | | | | | BUG=43259 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46834 0039d316-1c4b-4281-b951-d872f2087c98
* Add tooltip support to Windows tables.pkasting@chromium.org2010-05-102-9/+89
| | | | | | | | | | This doesn't actually make use of the functionality yet, but we get a nice benefit for free: by turning this on, we automatically get "labeltips" (see comments in the code) for all elided items in tables. BUG=43259 TEST=Hover any elided item in a table and it should display a tooltip with the full item text atop it. Review URL: http://codereview.chromium.org/2012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46832 0039d316-1c4b-4281-b951-d872f2087c98
* Remove checkbox table support, as it is unused.pkasting@chromium.org2010-05-105-163/+39
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2009007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46829 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a few stray bits of win2k support.pkasting@chromium.org2010-05-072-13/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1998012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46753 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 42867 - "OK" button disabled on "Edit Exception" dialog boxxji@chromium.org2010-05-071-1/+8
| | | | | | | | | | | | | | | | | | | | when URL is modified in non-empty input field - RTL In RTL chrome in windows, the text get from "Pattern" text field is wrapped with LRE/POP, which makes the pattern invalid. Trim explicit bidi control characters off in NativeTextfieldWin::GetText(). BUG=http://crbug.com/42867 TEST= 1. Launch Chrome with RTL language UI 2. click Wrench => Options => Under the Hood => Content settings => Exceptions => Edit... 3. modify an existing url on the Pattern field. The "OK" button should not be grayed out. Review URL: http://codereview.chromium.org/1703026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46751 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly call gtk_widget_show_all() to show the treeview in the language ↵yusukes@google.com2010-05-071-0/+2
| | | | | | | | | | | config dialog. BUG=chromium-os:2877 TEST=manual. verified that the tree view widget is shown as expected. Review URL: http://codereview.chromium.org/2038001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46656 0039d316-1c4b-4281-b951-d872f2087c98
* Make Font::GetStringWidth() a shortcut for gfx::Canvas::SizeStringInt() on ↵pkasting@chromium.org2010-05-051-2/+4
| | | | | | | | | | | | Windows. These two functions already did the same thing on Mac and Linux. If they ever returned different results on Windows, it would lead to subtle bugs, since measurement and drawing would slightly disagree. Clean up a few other things so that all three implementations of GetStringWidth() are identical. BUG=38717 TEST=none Review URL: http://codereview.chromium.org/1928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46492 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 41985 - The focus frames are out of range on the Options ↵xji@chromium.org2010-05-053-14/+329
| | | | | | | | | | | | | | | | | | | | : RTL. Previously, Label::CalculateDrawStringParams() computes the text boundary for signle-line and multi-line texts differently, so the boundary of focus rectangle is computed differently too inside Label::Paint(). Now, Label::CalculateDrawStringParams() computes text boundary without differentiate single-line and multi-line text, the boundary itself always takes mirror into consideration. So, the boundary of focus rectangle no longer need mirroring for both cases. BUG=http://crbug.com/41985 TEST= 1. Launch Chrome with RTL languages UI (ex: chrome.exe --lang=he) 2. click Wrench => Options Under the Hood 3. click or press tab to focus any string there. 4. the focus should be around the text, not out of the text range. Review URL: http://codereview.chromium.org/1694012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46484 0039d316-1c4b-4281-b951-d872f2087c98
* Close menu on grab broke event.oshima@chromium.org2010-05-053-2/+17
| | | | | | | | | | | This is necessary for screen locker to grab the input event. Technically, this can happen when another part of chrome tries to grab the input, so this is safer to handle this. BUG=none TEST=none Review URL: http://codereview.chromium.org/1900002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46441 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors animation to allow for cleaner subclassing. I'm doing thissky@chromium.org2010-05-053-4/+4
| | | | | | | | | | | | for creating a different animation subclass (which you'll see shortly). BUG=none TEST=none Review URL: http://codereview.chromium.org/1961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46433 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetDisplayStringInLTRDirectionality() in more places to simplify code.pkasting@chromium.org2010-05-051-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1928004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46427 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show Vista elevation shield if UAC is disabled.mirandac@google.com2010-04-301-1/+2
| | | | | | | | | BUG=42571 TEST=disable UAC and run Chrome as first run, with import. check "make chrome your default browser" box. see no shield. Review URL: http://codereview.chromium.org/1732013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46142 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make use of gtk_signal macros in more places.erg@chromium.org2010-04-294-15/+14
| | | | | | | | | | | BUG=None TEST=compiles, and manually. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1648016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45942 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:45:34 +0000