summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* wstring: remove wstring functions from base/i18n/rtl.hevan@chromium.org2011-04-251-1/+2
| | | | | | | | | | And update callers. BUG=23581 Review URL: http://codereview.chromium.org/6883140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Change status button menu"saintlou@chromium.org2011-04-256-37/+7
| | | | | | | | | | | This reverts commit d73c5c63912ce402c82777bee1ec8f1a31544d9f. BUG=none TEST=none Review URL: http://codereview.chromium.org/6904003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82906 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move LinkController into its own header file.tfarina@chromium.org2011-04-253-32/+37
| | | | | | | | | | | | | | | | | | | While I'm here, did some changes: - Rename the LinkController interface to LinkListener. - Move the interface to link_listener.h - Rename the event from LinkActivated to LinkClicked. - Changed the get/set accessors to listener()/set_listener(). - Add OVERRIDE to LinkClicked methods. BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6881099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
* Change status button menu (ClockMenu, NetworkMenu, PowerMenu) implementation ↵rhashimoto@chromium.org2011-04-226-7/+37
| | | | | | | | | | | | | | | | from Menu2 to MenuItemView. This required modifying MenuItemView to support per-item fonts, which are needed to display the currently associated network in boldface. This CL depends on http://codereview.chromium.org/6870016/ to work properly on the ChromeOS login screen. BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/6811025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82676 0039d316-1c4b-4281-b951-d872f2087c98
* Add SubmenuView::magic_token_ and checks.msw@chromium.org2011-04-224-26/+53
| | | | | | | | | | | | | | | Add MenuHostRootView::destroyed_flag_ and check. May help identify the cause of crbug.com/78792. Minor refactoring / code consolidation. BUG=78792 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82385 Review URL: http://codereview.chromium.org/6879059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82596 0039d316-1c4b-4281-b951-d872f2087c98
* remove unused classsaintlou@chromium.org2011-04-215-454/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6880081 Patch from Emmanuel Saint-Loubert <saintlou@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82488 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82385 - this might be breaking the interactive_ui_tests on windows ↵nsylvain@chromium.org2011-04-214-51/+25
| | | | | | | | | | | and browser_tests on windows. The blamelist is big, so this is a guess. Original description: Add SubmenuView::magic_token_ and checks.Add MenuHostRootView::destroyed_flag_ and check.May help identify the cause of crbug.com/78792.Minor refactoring / code consolidation.BUG=78792TEST=noneReview URL: http://codereview.chromium.org/6879059 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6882117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82466 0039d316-1c4b-4281-b951-d872f2087c98
* Add SubmenuView::magic_token_ and checks.msw@chromium.org2011-04-204-25/+51
| | | | | | | | | | | | | Add MenuHostRootView::destroyed_flag_ and check. May help identify the cause of crbug.com/78792. Minor refactoring / code consolidation. BUG=78792 TEST=none Review URL: http://codereview.chromium.org/6879059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82385 0039d316-1c4b-4281-b951-d872f2087c98
* Revert workaround. This was problematic because it is relyingsaintlou@chromium.org2011-04-201-5/+1
| | | | | | | | | | | | on an unrelated constant (kFavicon) which now has a different value for the touch case. BUG=none TEST=none Review URL: http://codereview.chromium.org/6879053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82294 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused class. Deprecated when we moved to web ui prefssaintlou@chromium.org2011-04-205-363/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6877065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82293 0039d316-1c4b-4281-b951-d872f2087c98
* Centralizes checking for non-null return from CreateWindow.sky@chromium.org2011-04-1910-8/+27
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6880034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82137 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing menu crashes. I'm trying to fix three things:sky@chromium.org2011-04-192-8/+44
| | | | | | | | | | | | | | | | . Its possible the hook function may end up getting invoked when open_native_menu_win_ is NULL. . If ~NativeMenuWin runs before the menu has closed, we crash. . Delays notifying model until using a task after the nested message loop returns. This better matches what WM_MENUCOMMAND does. BUG=79810 TEST=none, make sure menus on windows haven't regressed. R=ben@chromium.org Review URL: http://codereview.chromium.org/6879020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82107 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing bug where occassionally clicks on context menus aresky@chromium.org2011-04-152-36/+97
| | | | | | | | | | | | | | | | dropped. I believe this is a bug in windows, and I'm just working around it. The work around is to extend the hook function we have to watch for LBUTTONUP events over menu items, exit the menu and notify the model, in effect doing our own mouse processing. BUG=5212 TEST=thoroughly test context menus to make sure you don't get any weird behavior. R=ben@chromium.org Review URL: http://codereview.chromium.org/6861003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81696 0039d316-1c4b-4281-b951-d872f2087c98
* Make the usage stats checkbox on EULA screen speak and focus.chaitanyag@chromium.org2011-04-141-0/+1
| | | | | | | | BUG=chromium-os:14128 TEST=Test manually, see issue 14128 Review URL: http://codereview.chromium.org/6852008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81636 0039d316-1c4b-4281-b951-d872f2087c98
* step 3 of native theme refactoringrogerta@chromium.org2011-04-124-89/+81
| | | | | | | | | | | | | | Moved all calls to old menu drawing api to new NativeTheme::Paint(). Moved all calls to old push/radio/check button api to new NativePaint::Paint(). BUG=None TEST=Affects windows platform only. All menus in chrome, such as wrench menu, should look and behave as before, with no change. All pushbuttons, radiobuttons, and checkbox in web page forms should look and behave as before. Review URL: http://codereview.chromium.org/6825007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81257 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable FREEZE_UPDATE propertyoshima@google.com2011-04-111-1/+4
| | | | | | | | | | | | | | | This is a real fix for 13750. When the entire area of a WidgetGtk is covered by another GdkWindow, the WidgetGtk doesn't get expose event, which was causnig 13750. This fixes this issue by listening child widget's expose event and remove the FREEZE_UPDATE property. BUG=chromium-os:11514, chromium-os:13750 TEST=see bug for repro steps R=sky@chromium.org Review URL: http://codereview.chromium.org/6823017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81123 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in menu that would clip to menu height instead of work area.sky@chromium.org2011-04-051-1/+1
| | | | | | | | | | BUG=78111 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6792036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80463 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for regressions caused by FREEZE_UPDATE propertyoshima@google.com2011-04-041-1/+8
| | | | | | | | | | | | * menu can be closed before being shown. (native_menu_gtk.cc) * virtual keyboard doesn't get expose event on window_contents_ due to renderer covering the entire area. BUG=chromium-os:13760, chromium-os:11514 TEST=refer to bugs. Review URL: http://codereview.chromium.org/6794026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80366 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate cross platform logic into MenuHost.ben@chromium.org2011-04-0111-289/+198
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6690054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80232 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the new input method API for Views into Chromium.suzhe@google.com2011-04-0114-255/+1169
| | | | | | | | | | | | | | | | | | This CL contains following changes: 1. Improve TextfieldViewsModel to support composition text. 2. Implement TextInputClient interface in NativeTextfieldViews. 3. Fix Textfield and native implementations to avoid calling TextfieldController::ContentsChanged() when the text is changed by calling Textfield::SetText() or AppendText(). 4. Fix a bug in FocusManager that causes NativeTextfieldViewsTest.FocusTraversalTest to fail. 5. Fix accelerator_handler_touch.cc to send key events to the top-level widget's input method instance instead of the root view. 6. Do the same fix in extension_input_api.cc. 7. Hook InputMethod into WidgetGtk and WidgetWin. BUG=75003 TEST=views_unittests --gtest_filter=NativeTextfieldViews* Review URL: http://codereview.chromium.org/6675005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80226 0039d316-1c4b-4281-b951-d872f2087c98
* Notify child widgets before and after a reparenting.asanka@chromium.org2011-03-311-21/+3
| | | | | | | | | | | | | | | | Attaching a native view to a NativeViewHostWin may cause that view to be disassociated from a view hierarchy with a different FocusManager. Notifying the widgets that they are about to be removed from their current parent gives them the opportunity to disassociate themselves from their current FocusManager. BUG=77447 TEST=none Review URL: http://codereview.chromium.org/6776025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80096 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline to end of file.ben@chromium.org2011-03-311-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80087 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Widget Event code, other cleanup.msw@chromium.org2011-03-314-12/+11
| | | | | | | | | | | | | Rename *NativeCapture to *MouseCapture. Rename and move ShouldReleaseCaptureOnMouseReleased. Move static flag function to Event. BUG=72040 TEST=Mouse interaction on win & linux_views. Review URL: http://codereview.chromium.org/6756043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80065 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for paint issue on initial screen.oshima@google.com2011-03-312-0/+26
| | | | | | | | | | | | | It turns out that the sync counter that we used to rely on to synchronize window painting doesn't work for the initial screen as gtk may ignore and simply update the count without painting if the configure notify doesn't change the window size. This change uses FREEZE_UPDATES to notify WM to guarantee that WM will show only after the window is painted. I also removed gdk_window_process_updates from login code because this fixes crosbug.com/12566. I confirmed that gdk_widnow_process_update in map handler is necessary for touch. This is due to a bug in touch code but since this path will be removed in near future, i'll keep this workaround as is for touch. BUG=chromium-os:11514 TEST=see bug description. Review URL: http://codereview.chromium.org/6698063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80056 0039d316-1c4b-4281-b951-d872f2087c98
* TextButton inside NativeButton for the touch casesaintlou@chromium.org2011-03-319-47/+130
| | | | | | | | | | | | | | | | | | This CL wraps TextButton inside NativeButton for the touch case. The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. BUG=none TEST=none Review URL: http://codereview.chromium.org/6756017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80024 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2011-03-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80021 0039d316-1c4b-4281-b951-d872f2087c98
* Make MenuHost concrete, hide platform specific implementation behind ↵ben@chromium.org2011-03-319-70/+221
| | | | | | | | | | | | NativeMenuHost. This is the first step, creating this structure. Will consolidate common functionality and state next. BUG=72040 TEST=all menu tests for bookmark bar, wrench menu Review URL: http://codereview.chromium.org/6740022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80015 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a comment to explain a non-obvious fallthrough to another case statement.finnur@chromium.org2011-03-311-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6675046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79983 0039d316-1c4b-4281-b951-d872f2087c98
* In preparation for NativeTheme refactoring, renaming the class NativeThemerogerta@chromium.org2011-03-309-52/+51
| | | | | | | | | | | | to NativeThemeWin, since it is windows specific anyway. BUG=None TEST=None R=xiyuan@chromium.org Review URL: http://codereview.chromium.org/6778009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79874 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79762 - This CL wraps TextButton inside NativeButton for the touch case. dhollowa@chromium.org2011-03-309-133/+47
| | | | | | | | | | | | | | | | | | | | | The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is just transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. Note: the Windows trybot seems to fail on flaky test BUG=none TEST=none Review URL: http://codereview.chromium.org/6770014 TBR=saintlou@chromium.org Review URL: http://codereview.chromium.org/6731075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79768 - Fixed Clang error to http://codereview.chromium.org/6770014/dhollowa@chromium.org2011-03-301-2/+5
| | | | | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6749046 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6749047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79769 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed Clang error to http://codereview.chromium.org/6770014/dhollowa@chromium.org2011-03-301-5/+2
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6749046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79768 0039d316-1c4b-4281-b951-d872f2087c98
* This CL wraps TextButton inside NativeButton for the touch case. saintlou@chromium.org2011-03-299-47/+133
| | | | | | | | | | | | | | | | | | The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is just transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. Note: the Windows trybot seems to fail on flaky test BUG=none TEST=none Review URL: http://codereview.chromium.org/6770014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79762 0039d316-1c4b-4281-b951-d872f2087c98
* Disambiguate OnMouseCaptureLost from OnMouseReleased.msw@chromium.org2011-03-2926-169/+155
| | | | | | | | | | | | | Nix RenderWidgetHostViewViews' OnMouseCaptureLost forwarding. Consolidate code, remove unnecessary overrides, etc. Fix up test, |event| args, OVERRIDEs, and (c) dates. BUG=72040 TEST=Views mouse button release, cancelling mouse down/drag. Review URL: http://codereview.chromium.org/6685069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79640 0039d316-1c4b-4281-b951-d872f2087c98
* Changes windows menu to strip out tabs in the string. Windowssky@chromium.org2011-03-281-0/+4
| | | | | | | | | | | | | | interprets tabs as an accelerator. This means if the menu text has tabs in it we get weird behavior, and possibly trigger bugs in windows. BUG=77151 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6745002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79614 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more WidgetWin/WidgetGtk creations to use a new cross-platform ↵ben@chromium.org2011-03-284-13/+12
| | | | | | | | | | static ctor on Widget: CreateWidget(). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6732028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79586 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-287-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix caret bounds to use min of available height and font height.oshima@google.com2011-03-251-1/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6733058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79469 0039d316-1c4b-4281-b951-d872f2087c98
* Modify #include order slightly to clearly put ATL headers first.pkasting@chromium.org2011-03-251-4/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6676120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79353 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Textfield and AutocompleteEditViewViews.suzhe@google.com2011-03-235-125/+67
| | | | | | | | | | | | | | | Changes made by this CL: 1. Adds OnBeforeUserAction() and OnAfterUserAction() in TextfieldController. 2. Adds Textfield::HasSelection(). 3. Changes NativeTextfieldViews to use KeyEvent::GetCharacter(). 3. Refactors AutocompleteEditViewViews to use new TextfieldController methods. BUG=75003 TEST=views_unittests --gtest_filter=*Textfield* and interactive_ui_tests --gtest_filter=AutocompleteEditViewViews* Review URL: http://codereview.chromium.org/6685082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79201 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move MessageBoxView into the namespace views.tfarina@chromium.org2011-03-222-40/+45
| | | | | | | | | | | BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6715020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78994 0039d316-1c4b-4281-b951-d872f2087c98
* WinDDK ATL and MSVC express 2008/2005 compatability mark@chromium.org2011-03-211-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
* Add CreateParams to Widget, and replace CreatePopupWidget with CreateParams.ben@chromium.org2011-03-213-17/+11
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6712008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78893 0039d316-1c4b-4281-b951-d872f2087c98
* Forward mouse wheel events to submenusoshima@google.com2011-03-193-1/+23
| | | | | | | | | | | | Mouse wheel wasn't working for submenus on chromeos. This CL fixes this issue by forwarding events to submenu, like other mouse events. BUG=chromium-os:11834 TEST=see bug for repro step. Review URL: http://codereview.chromium.org/6673105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78802 0039d316-1c4b-4281-b951-d872f2087c98
* views: Cleanup TabbedPane class.tfarina@chromium.org2011-03-186-98/+119
| | | | | | | | | | | BUG=None TEST=views_examples, and existing views_unittests R=sky@chromium.org Review URL: http://codereview.chromium.org/6685039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78775 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where if you click on the bookmark bubble, then change thesky@chromium.org2011-03-172-0/+10
| | | | | | | | | | | | | | | | folder we wouldn't throb the right view. To get this to work I changed the order of when we apply edits (change the model) to before the bubble is closed. Previously we closed the bubble, then applied the edits. We need to apply the edits first as bookmark bar stops throbbing when the bubble is closed. BUG=41082 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6677050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78585 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception wrapper to the WindowProc functions sorvargas@google.com2011-03-171-2/+3
| | | | | | | | | | | that we receive crash reports when something goes wrong. BUG=63702 TEST=base_unittests Review URL: http://codereview.chromium.org/6697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78475 0039d316-1c4b-4281-b951-d872f2087c98
* Moving over to other folder button while opening folder menu should open the ↵oshima@google.com2011-03-162-18/+36
| | | | | | | | | | | | | | | folder menu. It was failing with DCHECK instead. This CL fix this issue by Canceling menu only when the menu has x grab. I also separated grk grab broke and X grab broke because gtk broke require releasing x grab for this case. BUG=chromium-os:13151 TEST=see bug description. Review URL: http://codereview.chromium.org/6676032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78447 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder some views::View overrides & other functions.msw@chromium.org2011-03-1614-485/+451
| | | | | | | | | | | | | Follow base class ordering and access specifiers. Add OVERRIDE keyword where applicable. Define BaseTab::set_animation_container out of line, update includes. Limit RenderWidgetHostViewViews::OnTouchEvent to TOUCH_UI. Make RenderWidgetHostViewViews::GetCursorForPoint a virtual override. Review URL: http://codereview.chromium.org/6673070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78416 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands:ben@chromium.org2011-03-163-20/+19
| | | | | | | | | | | | Add native capture API to Widget, and fix a bug in Window where we wouldn't let the window be closed from the X. BUG=72040 TEST=none R=sky Review URL: http://codereview.chromium.org/6670049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78394 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 12:04:30 +0000