summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Lands http://codereview.chromium.org/211002 for Charlie:sky@chromium.org2009-09-175-0/+448
| | | | | | | | | | | | Add touchpad speed factor setting to Chrome OS touchpad settings page. Created slider widget with native gtk widget. TEST=none BUG=none Review URL: http://codereview.chromium.org/209016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26511 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing lame bug in radiobutton. oshima@chromium.org2009-09-161-1/+1
| | | | | | | | | The UsesNativeRatioButtonGropu condition was inverse. RadioButton should use its own grouping logic when native grouping is not used. (on windows) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26411 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/206025 for Charlie:sky@chromium.org2009-09-162-4/+9
| | | | | | | | | | | | Fix settings page transparent background issue Also comment out focus manager check due to bug: http://crbug.com/21378 TEST=none BUG=none Review URL: http://codereview.chromium.org/194128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26370 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/193032 for Charlie:sky@chromium.org2009-09-151-1/+3
| | | | | | | | | | | | | | | First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead NOTIMPLEMENTEDs and enables some code that no longersky@chromium.org2009-09-141-1/+0
| | | | | | | | | | | needs to be ifdef'd out. BUG=none TEST=none Review URL: http://codereview.chromium.org/196111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26177 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the focus remembered across tab switches for Chrome Linux with ↵jcampan@chromium.org2009-09-144-5/+41
| | | | | | | | | | | | | | | toolkit views. It also contains clean-ups and implementation of different minor focus related things. BUG=None TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab. Also test that deactivating/reactivating the browser window still restores focus properly. Review URL: http://codereview.chromium.org/194041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts linux font change again. Slow down isn't as bad as before. Butsky@chromium.org2009-09-142-2/+6
| | | | | | | | | | | | still not ideal. BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/194105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26141 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/200102 for Oshima:sky@chromium.org2009-09-147-27/+166
| | | | | | | | | | | | | | RadioButton implementation. - gtk implementation uses gkt's grouping mechanism, which was hard to replace. A small refactoring. - changed to use virtual functions instead of if/IsCheckbox - Removed checkbox's CallClicked BUG=none TEST=none Review URL: http://codereview.chromium.org/194102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26117 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at converting font from Skia to Pango. The slow down appears to be ↵sky@chromium.org2009-09-142-6/+2
| | | | | | | | | | | | entirely attributed to asking for the metrics. To get back the performance I did the following: . Only ask for the metrics when needed. We appear to create 6 or so fonts very early on without needing the metrics. This ensures we only take the metrics load hit when needed. . Keep a cache of the metrics around. This ensures that we only load the metrics once. I didn't dig through the Pango source to see why Pango is slow at getting metrics. I suspect it's the first person to ask for metrics incurs a penalty as Pango accesses the disk. The code we have now is the same as that as Gtk. Review URL: http://codereview.chromium.org/199101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26116 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r26015. It caused a startup regression:(sky@chromium.org2009-09-112-2/+6
| | | | | | | | | | BUG=20823 TEST=none TBR=agl Review URL: http://codereview.chromium.org/203041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26030 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes font_skia and converts font_gtk to use pango. This wassky@chromium.org2009-09-112-6/+2
| | | | | | | | | | | | | | | | | | | | | | necessitated by Pango and Skia differing on how the fonts are sized, resulting in lots of clipping in views. The only iffy part of this is I've made Font::nativeFont() win/mac only (it isn't used on Linux). I did this to avoid folks accidentally modifying the underlying font out from under Font. That said, I could certainly nuke GetPangoFontDescription in favor of nativeFont() and make it return the PangoFontDescription (not a copy). Let me know if you feel strongly about converting this. Assuming your ok with this, I'll watch the perf tests to make sure this doesn't impact startup. BUG=20823 TEST=none Review URL: http://codereview.chromium.org/195058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26015 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an extraneous NOTIMPLEMENTED in native_control_gtk.sky@chromium.org2009-09-101-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/202051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25938 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/194014 for Oshima:sky@chromium.org2009-09-103-8/+64
| | | | | | | | | | | | | | | * enable MessageBoxView convert wstring to string16 when necessary using WideToUTF16Hack, which is no-op on Windows. * updated checkbox to get state update working state handing is a bit hacky, esp. b/c gtk sends signal even when the state is changed via API. If there is better way, please let me know. BUG=none TEST=none Review URL: http://codereview.chromium.org/201079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25896 0039d316-1c4b-4281-b951-d872f2087c98
* Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce ↵jhawkins@chromium.org2009-09-102-7/+12
| | | | | | | | | | dependencies on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at implementation of FindBar for views / gtkdavemoore@chromium.org2009-09-094-48/+114
| | | | | | | Also had to implement change notification for TextField on views / gtk Review URL: http://codereview.chromium.org/200035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25819 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.jhawkins@chromium.org2009-09-091-14/+9
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/199070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25817 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.jhawkins@chromium.org2009-09-091-62/+38
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/199067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25799 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.jhawkins@chromium.org2009-09-091-6/+4
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25788 0039d316-1c4b-4281-b951-d872f2087c98
* Use RECT instead of CRect to reduce dependencies on ATL.jhawkins@chromium.org2009-09-091-20/+22
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25780 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/198010 for Oshima:sky@chromium.org2009-09-092-5/+14
| | | | | | | | | | | | * Fix seg fault in deleting view from RemoveTabAtIndex * move initialization of tabbed page to NativeControlCreated TEST=none BUG=none Review URL: http://codereview.chromium.org/196055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25730 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up drag and drop for bookmark menus and cleans up a couple ofsky@chromium.org2009-09-098-27/+67
| | | | | | | | | | | minor painting issues. BUG=none TEST=none Review URL: http://codereview.chromium.org/199050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25701 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-081-2/+3
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some gcc 4.4 issues when compiling with toolkit_views.craig.schlenter@chromium.org2009-09-071-2/+2
| | | | | | | | | | | | | | | | | | | | | Most of these squash harmless compiler warnings but the custom_button.cc change fixes a real problem with the accelerator key bitmask calculation (+ preceeds << in terms of operator precedence) The change to tab_strip.cc is ugly but it fixes the following error: chrome/browser/views/tabs/tab_strip.cc: In member function ‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’: chrome/browser/views/tabs/tab_strip.cc:201: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false As an added bonus, this makes the Linux shared build of toolkit_views work too. Review URL: http://codereview.chromium.org/199025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
* Removing ATL dependencies from two files.finnur@chromium.org2009-09-032-12/+7
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/201010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-036-21/+76
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* Uses POINT instead of CPoint to reduce the dependency in ATL.scherkus@chromium.org2009-09-037-14/+10
| | | | | | | | | | | | | Patch submitted by Thiago Farina: http://codereview.chromium.org/188017 BUG= http://crbug.com/2185 TEST=None Review URL: http://codereview.chromium.org/199009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Back and Forwards button broken in 23101idanan@chromium.org2009-09-031-4/+4
| | | | | | | | | | | | | | | | Issue 165318 was accepted but caused the back and forwards button to become unresponsive to middle-clicks. This should fix the issue but if there is a problem, we should revert 23101 because it causes a major regression while only providing a cosmetic enhancement. BUG=20323 TEST=none Review URL: http://codereview.chromium.org/199007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25313 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/185003 for Oshima:sky@chromium.org2009-09-022-0/+235
| | | | | | | | | | | | * gtk implemenation of tabbed pane * focus is not handled as Jay is working on it. BUG=none TEST=none Review URL: http://codereview.chromium.org/171120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25222 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/172098 for Oshima:sky@chromium.org2009-09-022-5/+8
| | | | | | | | | | | | * fix typo in WidgetGtk * re-organize method in combobox for chrome convention BUG=none TEST=none Review URL: http://codereview.chromium.org/188009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25186 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-013-0/+31
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-018-52/+84
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Make native button wrapper construction return the new wrapper rather thanbrettw@chromium.org2009-09-016-19/+30
| | | | | | | | | | | | | | | | | setting it on the class. I did this for the textbox and I think it's a bit better. The old way set it, but that function didn't add it to the view hierarchy. This means that the pointer is technically "unowned" when the CreateWrapper function returns. This new way makes pointer ownership more clear. It becomes the caller's problem, and the caller immediately inserts it into the view hierarchy which then manages the lifetime. TEST=none BUG=none Review URL: http://codereview.chromium.org/180041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25043 0039d316-1c4b-4281-b951-d872f2087c98
* Lands 176025 from Oshima:sky@chromium.org2009-08-315-15/+86
| | | | | | | | | | | | | Combobox implemenation for GTK Removed const from GetPreferredSize, as GTK implementation has cache to update. TEST=none BUG=none Review URL: http://codereview.chromium.org/183015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24904 0039d316-1c4b-4281-b951-d872f2087c98
* Make the views bookmark bubble work on GTK.brettw@chromium.org2009-08-284-7/+75
| | | | | | | | | | | The combobox still isn't implemented, but this makes TextBox work, and also does some changes around the info_bubble to make sure it get created properly. TEST=none BUG=none. Review URL: http://codereview.chromium.org/177026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for initiating drags from bookmark menus.sky@chromium.org2009-08-283-25/+6
| | | | | | | | | BUG=none TEST=make sure bookmark menus work on Windows. Review URL: http://codereview.chromium.org/176006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-3/+0
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-0/+3
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Reafactor Textfield to bring the native widget handling more in line with whatbrettw@chromium.org2009-08-284-20/+48
| | | | | | | | we do in button. We still don't have NativeTextfieldWin deriving from NativeControlWin, which is what the addition of the hack function works around. Review URL: http://codereview.chromium.org/173588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24783 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing bookmark menus.sky@chromium.org2009-08-2611-61/+222
| | | | | | | | | | | | | The build breakage was the result of a bad ifdef in MenuController, specifically around the OnKeyDown method. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts menu patch.sky@chromium.org2009-08-2611-222/+61
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-2611-61/+222
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Further refactoring of menus for GTK. I've now separated outsky@chromium.org2009-08-2423-4403/+1086
| | | | | | | | | | | | | | | | | everything and menus some what work on GTK. I need to get painting working and I'm sure there will be fine tuning, but I want to check in all this splitting of files before someone else needs change one of these files. Thankfully I wrote an interactive ui test that exercises much of this code, and it still passes:) BUG=none TEST=thoroughly test bookmark menus on windows to make sure I didn't break them. Review URL: http://codereview.chromium.org/174274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24098 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support and exposure of additional accessibility roles. Includes naming ↵klink@chromium.org2009-08-222-1/+19
| | | | | | | | | | of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars. BUG=13291,19982 TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document. Review URL: http://codereview.chromium.org/174252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
* Splits the menu classes into individual files in anticipation ofsky@chromium.org2009-08-209-0/+3954
| | | | | | | | | | | porting them. BUG=none TEST=make sure to thorougly test bookmark menus on windows. Review URL: http://codereview.chromium.org/173091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23645.jhawkins@chromium.org2009-08-181-22/+29
| | | | | | | Crashing the reliability bot. Review URL: http://codereview.chromium.org/174029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23674 0039d316-1c4b-4281-b951-d872f2087c98
* Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-181-29/+22
| | | | | | | | | | reduce a dependency on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/169015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23645 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out views::Combobox::Model so that it can be used cross-platform.mattm@chromium.org2009-08-183-16/+11
| | | | | | | | | | This removes the Combobox* source arg from the Model methods, which wasn't really used by anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/165514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23603 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-4/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/159838 for Pierre-Antoine. From him:sky@chromium.org2009-08-114-11/+41
| | | | | | | | | | | | | | | | | | | Right clicking the back and forward buttons is buggy. A single right click opens the drop down menu, however the button does not enter the PUSHED state. If you double right click then click on the tab content area, the button stays in a PUSHED state until you mouseover it. The fix should replicate the intuitive behavior. On a single right click, the button enters the PUSHED state and the drop down appears immediately. As soon as the user clicks on another View, the drop down closes and the button returns to the NORMAL state. Double right click behaves similarly. BUG=9717 TEST=none Review URL: http://codereview.chromium.org/165318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23101 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/165271 for tedoc. From tedoc:sky@chromium.org2009-08-111-1/+1
| | | | | | | | | | | Fix set_x to set_y for vertical scrolling BUG=NONE TEST=none Review URL: http://codereview.chromium.org/164321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23028 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 12:50:16 +0000