summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Fixes possible crash in showing bookmark menu. The problem occurredsky@chromium.org2009-11-102-21/+21
| | | | | | | | | | | | | | when you clicked on one top level menu on the bookmark bar, moused over another menu and then we loaded favicons for the first menu. The code needs to figure out which menu has the icon instead of invoking set icon on menu_. BUG=27067 TEST=make sure bookmark menus work ok. Review URL: http://codereview.chromium.org/388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-072-3/+3
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when GetOleInterface returns NULL. The replaced class, ↵jhawkins@chromium.org2009-11-061-2/+4
| | | | | | | | | | CComQIPtr, handles attaching to a NULL pointer, but ScopedComPtr does not, so check for a non-NULL ole_interface before calling QueryFrom. BUG=22829 TEST=none Review URL: http://codereview.chromium.org/374012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31271 0039d316-1c4b-4281-b951-d872f2087c98
* Converting the Cookies options page from a TableView to a TreeViewian@chromium.org2009-11-061-1/+20
| | | | | | | | | | | | so that we can add in Database, LocalStorage, and Appcache next to the cookies for an origin. BUG=26713 TEST=cookies_tree_model_unittest.cc Review URL: http://codereview.chromium.org/365005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31207 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in removing nodes from tree. Specifically if the root is notsky@chromium.org2009-11-041-4/+14
| | | | | | | | | | | | | | | | shown and you remove a node that is a child of the root, we silently fail as there is no tree item for the root. Not having a tree item for a node is typically fine (it usually means it hasn't been expanded), but in this case it's wrong. We need to special case removing from the root here. BUG=26606 TEST=see bug, but also make sure no regression in removing nodes from bookmark manager's tree. Review URL: http://codereview.chromium.org/360021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31022 0039d316-1c4b-4281-b951-d872f2087c98
* While changing the label class I added a DCHECK tofinnur@chromium.org2009-11-041-1/+6
| | | | | | | | | | | | | | | | | | | | | make sure the function I was changing was never called for multiline labels (it never was supposed to work for multiline labels, even before my change). Turns out, this flushed out a caller who calls it for multiline labels, and gets the wrong results. BUG=None TEST=Trigger a javascript alert with multiple lines. Make sure no DCHECK happens. If you set a breakpoint on the function I'm changing and hover over the label, when you step through the code, you'll see that it now correctly computes the bounds of the label based on the width and calls SetContainsMouse with true instead of false. Review URL: http://codereview.chromium.org/361001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30993 0039d316-1c4b-4281-b951-d872f2087c98
* Fullscreen Exit Bubble should not elide its label.finnur@chromium.org2009-11-031-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | When drawing a Label it is important to adjust for RTL not just when drawing, but also when computing the size of the string. Before this change, we'd compute using Font::GetStringWidth (which uses ::GetTextExtentPoint32 *without* adjusting the string for RTL) and draw using DoDrawText (which adjusts for RTL and then draws using ::DrawText). After this change, we now use SizeStringInt for computing (so we now compute and draw using the same ::DrawText function, thereby adjusting the string for RTL in both cases). BUG=17949 TEST=Run chrome with --lang=he, press F11 and the string in the bubble at the top should not be elided. Review URL: http://codereview.chromium.org/354014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30863 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression introduced in fixing 19597. This change effectivelysky@chromium.org2009-10-301-2/+6
| | | | | | | | | | | | | | reverts menu_button to what it was before the fix. This way 19597 is still fixed, and we don't have this crash. I'm working on a regression test for coverage of this, but I don't want to hold up anything with the fix. BUG=26279 TEST=see bug Review URL: http://codereview.chromium.org/344043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed view example. It was failing because some of view classes requires ↵oshima@chromium.org2009-10-301-1/+2
| | | | | | | | | | | | | | | | | | WidgetGTK in view hierarchy to call methods on it. * added ContainerExamlpeBase that defers the creation of such views after WidgetGTK available. minor fixes * replaced unnecessary includes with forward decls. * make sure we don't try to set negative hight to viewport. BUG=None TEST=build & run view_examples Review URL: http://codereview.chromium.org/347010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30586 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/291006 for Pierre:sky@chromium.org2009-10-272-3/+7
| | | | | | | | | | | | Open all bookmarks in a bookmark menu folder according to the window disposition derived from the event flags. This is currently only possible with a middle click on the top level bookmark bar button. BUG=19597 TEST=Control click a folder on your bookmark bar, and thorougly test bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/334047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30281 0039d316-1c4b-4281-b951-d872f2087c98
* Assertion failure fixoshima@chromium.org2009-10-261-3/+5
| | | | | | | | | | | | * Closing a submenu was hitting NOTREACHED in OnMenuHidden. * Changed to register OnMenuHidden callback only when we're about to open the menu, then disconnect it when closed. This is safer as the same menu can be used as submenu (although that's probably not great style) Review URL: http://codereview.chromium.org/328002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30061 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that when a folder is open on the bookmark bar and thesky@chromium.org2009-10-2611-84/+180
| | | | | | | | | | | | mouse moves over another folder, the menu for that folder is shown. BUG=355 TEST=thorougly test all possible permutations of bookmark menus you can think of, including drag and drop to the menus. Review URL: http://codereview.chromium.org/328012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98
* Previous change to label caused incorrect layout in Windows.davemoore@chromium.org2009-10-241-6/+1
| | | | | | Review URL: http://codereview.chromium.org/337018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30011 0039d316-1c4b-4281-b951-d872f2087c98
* Get the About panel to align its links correctly,davemoore@chromium.org2009-10-231-1/+6
| | | | | | | | but undo a previous change to the way we measure strings in pango. Review URL: http://codereview.chromium.org/338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
* The TableViewObserver::OnKeyDown method signature was changed recently andjcampan@chromium.org2009-10-233-2/+5
| | | | | | | | | | | | | | | | | the bookmark manager view had not been properly updated and was not called anymore, breaking the keyboard shortcuts. This was broken in the TaskManager as well. Also changed the TreeView to use the base::KeyboardCode. BUG=25533 TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE, ENTER...) work in the bookmark manager. Test that in the TaskManager, pressing ENTER activates the selected tab. Review URL: http://codereview.chromium.org/322006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29854 0039d316-1c4b-4281-b951-d872f2087c98
* Make gtk menu block on call to RunMenuAt.chocobo@google.com2009-10-214-6/+35
| | | | | | | | TEST=none BUG=25429 Review URL: http://codereview.chromium.org/293057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29711 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging icon for dragging bookmarks in views/gtk.skrul@google.com2009-10-211-0/+8
| | | | | | Review URL: http://codereview.chromium.org/270068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29692 0039d316-1c4b-4281-b951-d872f2087c98
* Change expectations for linux views multiline label tests to expect NO_ELLIPSIS.davemoore@chromium.org2009-10-191-0/+35
| | | | | | Review URL: http://codereview.chromium.org/294008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29454 0039d316-1c4b-4281-b951-d872f2087c98
* Do work necessary to make Views About panel work on Chrome OS. This is to be ↵davemoore@chromium.org2009-10-191-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | used for forcing Chrome OS updates. There were many things that needed to be fixed for this to work. Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows. Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls. Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused. Support gtk about panel in regular build, views in chrome os only. Fix WindowGtk to call WindowClosing() Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width Fix Label::ComputeMultiLineFlags() to turn off eliding. With eliding the pango routines always return 1 line. Enable focus manager in dialogs. Version loader crashed in debug. Review URL: http://codereview.chromium.org/282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29414 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flickering checkboxescpu@chromium.org2009-10-161-1/+1
| | | | | | | | | | | | | | | - Remove vestigial organ WS_EX_TRANSPARENT TEST=open option dialog|advanced and scroll, behold no flicker BUG=9974 TBR=ben Review URL: http://codereview.chromium.org/276056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29292 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu button. I converted a call from GetWidget tosky@chromium.org2009-10-141-2/+2
| | | | | | | | | | | | | GetWindow, the problem is in certain scenarios GetWindow can return null. I've changed the code back to GetWidget and converted Screen from taking a NativeWindow to a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/269076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28986 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 of getting blocked popups to work on views/gtk. My first attempt was ↵sky@chromium.org2009-10-131-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | not deleting the blocked popup container view views, which resulted in a reliability crash. This differs from the first patch in that BlockedPopupContainerViewViews::Destroy now does a delete this. From the original patch: I had to fix a couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/274019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28903 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a ↵nsylvain@chromium.org2009-10-131-3/+1
| | | | | | | | | | | | | | | | | | | | | | | couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/267069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-1211-41/+34
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* AppendText was appending twice due to bad merge happened in the past.oshima@chromium.org2009-10-121-4/+1
| | | | | | | | | | | Added append scenario to view_examples BUG=None TEST=run unit_tests and verify with view_examples. Review URL: http://codereview.chromium.org/271055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28724 0039d316-1c4b-4281-b951-d872f2087c98
* Gets blocked popups to work on views/gtk. I had to fix a couple ofsky@chromium.org2009-10-121-1/+3
| | | | | | | | | | | | | | | | | additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28716 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-1112-16/+15
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Partially revert r28629.craig.schlenter@chromium.org2009-10-101-1/+0
| | | | | | | | | | | | | | | | | | The chrome-os unit test 'TextField' is failing consistently after this commit: ViewTest.Textfield: /b/slave/chromium-rel-linux-chromeos/build/src/views/view_unittest.cc:644: Failure Value of: textfield->text() Actual: Reality is that which, when you stop believing it, doesn't go away.Pretty deep, Philip!Pretty deep, Philip! Expected: kText + kExtraText Which is: Reality is that which, when you stop believing it, doesn't go away.Pretty deep, Philip! TEST=commit and hope tree goes green. No try-bot to test on. Review URL: http://codereview.chromium.org/269047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28666 0039d316-1c4b-4281-b951-d872f2087c98
* The textfield's text was not updated when text is updated by input.oshima@chromium.org2009-10-091-0/+1
| | | | | | | | | BUG=None TEST=view_examples now has button to show & update textfield's text. Review URL: http://codereview.chromium.org/267040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28629 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gdk keycode to match base::KeyboardCode.oshima@chromium.org2009-10-091-1/+5
| | | | | | Review URL: http://codereview.chromium.org/268026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28568 0039d316-1c4b-4281-b951-d872f2087c98
* When a GtkWidget was destroyed the NVH would not be detached.jcampan@chromium.org2009-10-091-3/+3
| | | | | | | | | | | There was a hack in location_bar_view to prevent an assert, but it would cause an other assert. Also fixed a double delete with the find_bar_host. BUG=None TEST=Start Chrome Linux toolkit view. Close it. It should not assert. Review URL: http://codereview.chromium.org/266034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28556 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile error in NativeMenuGtk when building for 64 bit.sky@chromium.org2009-10-091-2/+2
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28544 0039d316-1c4b-4281-b951-d872f2087c98
* * Password style support for gtk's textfield impl.oshima@chromium.org2009-10-091-0/+7
| | | | | | | | | | | * Added x11 dependency to view_examples. Looks like dependency has changed a bit. BUG=none TEST=build & run view_examples target. Review URL: http://codereview.chromium.org/270032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28501 0039d316-1c4b-4281-b951-d872f2087c98
* Backspace should not be processed as an accelerator in textfield, so it ↵jcampan@chromium.org2009-10-081-3/+3
| | | | | | | | | | | really removes the previous character. BUG=11326 TEST=In Linux toolkit views, navigate few pages in a tab (so you have some history). Open the find box (Ctrl-F) type some text, then backspace. Pressing backspace should have the normal behavior and should not trigger a navigation back. Review URL: http://codereview.chromium.org/265038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28410 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the default button behavior on Linux toolkit_views.jcampan@chromium.org2009-10-082-13/+8
| | | | | | | | | | | | I had to make the KeyEvent constructor include the event flags. Also cleaned-up some unit-tests BUG=None TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/266012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28397 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor cros library code into central location and have the UI elements ↵chocobo@google.com2009-10-084-1/+19
| | | | | | | | | | | | | | observe changes. - implemented power menu button showing remaining battery info. - implemented clock menu button showing detailed clock info. - also implemented monitoring of network status change. - don't show highlighted state for these menu buttons BUG=23923 TEST=none Review URL: http://codereview.chromium.org/251099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28366 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-0712-14/+16
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Turns on the focus traversal unit-tests and fixed some focus traversal problem:jcampan@chromium.org2009-10-073-10/+6
| | | | | | | | | | | | | | | | - in TabbedPaneView, the focus traversable were not properly hooked-up - the NativeTextField was focusing the wrapper view instead of the actual Textfield view. Also in the FocusTraversal unit-test I had to select one of the radio-button that the test uses, as the behavior of focusing a disabled button is different on Windows (it forces any non disabled radio-button to become selected) than on Gtk. BUG=None TEST=Run the unit tests. Review URL: http://codereview.chromium.org/242163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28263 0039d316-1c4b-4281-b951-d872f2087c98
* Gets preferred size of views textfields on gtk to work. Also madesky@chromium.org2009-10-067-19/+66
| | | | | | | | | | | turning off border work. BUG=none TEST=none Review URL: http://codereview.chromium.org/256080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28172 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-0511-139/+95
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-032-5/+5
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple popup support to browser actions. This will create a popup HTML ↵erikkay@chromium.org2009-10-021-1/+1
| | | | | | | | | | | window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed. BUG=23596 TEST=none Review URL: http://codereview.chromium.org/258011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
* When installing/uninstalling the clip on native buttons they would not be ↵jcampan@chromium.org2009-10-021-2/+2
| | | | | | | | | | | | | | painted properly. This is the case for animations, such as the dangerous download item animation. (For some unclear reasons this would happen only in aero and only in a popup browser frames.) Explicitly asking for a repaint when setting the clip fixes it. BUG=23087 TEST=Start a dangerous download from a popup (sorry, I don't have any public URL to repro). The dangerous download should display properly in the download shelf. Review URL: http://codereview.chromium.org/259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27858 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding focus traversal on Linux toolkit views.jcampan@chromium.org2009-10-016-1/+34
| | | | | | | | | | | | | | | | | | | | | It was previously breaking the interactive UI tests. That was because I changed the button base class to be focusable by default which led to many button beings added to the tab traversal order. I now explicitly make these buttons non focusable. Also because of the way we clear the native focus on Gtk (by setting focus to NULL on the top level window), views now default to clearing the focus when focused (so that views non backed by a native window don't leave the native focus on the previously native window). On Windows we used to focus the WidgetWin's HWND, and now we focus the top-level HWND. The WidgetWin class had to be changed to forward the key events to the root view that contains the focused view because of that. (otherwise it would send it to the top-level root-view, and if the focused view was in a child root-view it would not recieve the keyboard messages). Note that the mouse wheel does not need that, as the mouse-wheel Windows messages are sent to the HWND under the cursor. See: http://codereview.chromium.org/246030/show TEST=Run the tests BUG=NONE Review URL: http://codereview.chromium.org/255008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27723 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-2911-95/+139
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* style fix. the header for .cc has to be the 1st include.oshima@chromium.org2009-09-291-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27537 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the header file not found issue of 222030. (The file has been renamed ↵oshima@chromium.org2009-09-293-2/+295
| | | | | | | | | | | | | after review) See http://codereview.chromium.org/222030 for the original review BUG=none TEST=compiled & tested chrome target on win/linux, view_examples target on linux. Review URL: http://codereview.chromium.org/242036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27513 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27504, it breaks the interactive ui tests on Windows.jcampan@chromium.org2009-09-295-23/+3
| | | | | | | TBR=oshima Review URL: http://codereview.chromium.org/243034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27512 0039d316-1c4b-4281-b951-d872f2087c98
* See original review atjcampan@chromium.org2009-09-295-3/+23
| | | | | | | | | | | | | | http://codereview.chromium.org/251001/show This CL hooks the focus traversal for the TabbedPaneView on Linux with toolkit views. It also has few focus related fixed (focus with buttons, clearing focus effectively in the focus manager). BUG=None TEST=Run the view_examples app. Press tab to move the focus. Try the different tabs. Review URL: http://codereview.chromium.org/246030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27504 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-2921-78/+81
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 05:36:54 +0000