summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Restricts the creation of RadioButton to specify an group-id.jcampan@chromium.org2009-06-102-8/+6
| | | | | | | | | | The API is dangerous without one, has it will probably collide with other non radio-button views. BUG=None TEST=None Review URL: http://codereview.chromium.org/120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18110 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in menu. It's possible for the WM_MENUSELECT to pass insky@chromium.org2009-06-101-0/+3
| | | | | | | | | | | | NULL as the menu on XP. I believe this only happens when closing the menu, so that it doesn't really matter what we do here. BUG=13759 TEST=see bug Review URL: http://codereview.chromium.org/119441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18084 0039d316-1c4b-4281-b951-d872f2087c98
* Gets linux2 to compile again.sky@chromium.org2009-06-102-1/+3
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/118515 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18069 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Menu2Delegate interface and fold methods onto Menu2Model instead.ben@chromium.org2009-06-099-50/+137
| | | | | | | | | | | | | Enhance SimpleMenuModel::Delegate interface to support additional options required by the above. Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu. Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it. BUG=none TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash! Review URL: http://codereview.chromium.org/118426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17996 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds some more FocusManager unit-tests.jcampan@chromium.org2009-06-096-1/+14
| | | | | | | | BUG=None TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/118413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17951 0039d316-1c4b-4281-b951-d872f2087c98
* forgot this file in last CLben@chromium.org2009-06-081-0/+44
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17896 0039d316-1c4b-4281-b951-d872f2087c98
* A new menu system for views.ben@chromium.org2009-06-088-0/+1210
| | | | | | | | This is all the functionality needed for the page, app menus and browser system menus. Review URL: http://codereview.chromium.org/119237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17895 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it possible for Widget's on GTK to have a transparentsky@chromium.org2009-06-081-5/+11
| | | | | | | | | | | | background. Additionally implements always on top and makes ImageView support borders. BUG=none TEST=none Review URL: http://codereview.chromium.org/119269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17878 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug introduced during menu refactoring. Specifically thesky@chromium.org2009-06-053-4/+16
| | | | | | | | | | | | owner_draw_ was not getting set correctly in one case, resulting in no icons in some menus (like back/forward). BUG=http://crbug.com/12847 TEST=see bug Review URL: http://codereview.chromium.org/112096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17760 0039d316-1c4b-4281-b951-d872f2087c98
* Replace HCURSOR usage in views::View with a new gfx::NativeCursor type that ↵ben@chromium.org2009-06-045-14/+26
| | | | | | | | | | | | | also supports GdkCursor*, and wires this up with the existing implementors of the GetCursorForPoint method. This allows us to get rid of one of the most annoying NOTIMPLEMENTED()s in views-gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/119150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17614 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of r17500:glen@chromium.org2009-06-042-3/+36
| | | | | | | | | | Theme our bookmark bar buttons. BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17587 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to theme our buttons.glen@chromium.org2009-06-042-1/+20
| | | | | | | | | BUG=12762 TEST=Verify that buttons can be themed. Review URL: http://codereview.chromium.org/119025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken separator sizing and positioning.ben@chromium.org2009-06-031-1/+2
| | | | | | | | | http://crbug.com/13273 TEST=open page info window for secure sites, see separators are correctly 2px tall. Review URL: http://codereview.chromium.org/118197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17564 0039d316-1c4b-4281-b951-d872f2087c98
* Some previous refactoring I did of the accelerator code had introduced ↵jcampan@chromium.org2009-06-034-12/+10
| | | | | | | | regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox) Review URL: http://codereview.chromium.org/119016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
* Recent refactoring of the combobox had broken focus.jcampan@chromium.org2009-06-032-0/+5
| | | | | | | | | BUG=13256 TEST=Open the option dialog. Move the focus around by pressing tab, make sure the combobox gets focused correctly. When the focus is on the combobox, activate another (non Chromium) window, then come back to the option dialog, the focus should still be on the combobox. Review URL: http://codereview.chromium.org/118175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17526 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r17500glen@chromium.org2009-06-032-36/+3
| | | | | | | | | TBR=slightlyoff BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17508 0039d316-1c4b-4281-b951-d872f2087c98
* Theme our bookmark bar buttons.glen@chromium.org2009-06-032-3/+36
| | | | | | | | | BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. Review URL: http://codereview.chromium.org/112092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17500 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in base/phajdan.jr@chromium.org2009-06-031-0/+1
| | | | | | | | Also adds more explicit #includes for needed things. Review URL: http://codereview.chromium.org/118162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
* Properly initialize the native wrapper to NULL to avoid a crash. Also ↵ben@chromium.org2009-06-021-1/+1
| | | | | | | | | | re-enables tests I disabled last night when trying to find this. http://crbug.com/13200 TEST=Start chrome with --first-run. Review URL: http://codereview.chromium.org/118136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17440 0039d316-1c4b-4281-b951-d872f2087c98
* Gets ComboBox to compile on linux.sky@chromium.org2009-06-022-0/+2
| | | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/118123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17422 0039d316-1c4b-4281-b951-d872f2087c98
* Make separator portable. Simpler than other native controls so no wrapper ↵ben@chromium.org2009-06-022-22/+99
| | | | | | | | | | | | interface. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17368 Review URL: http://codereview.chromium.org/118065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17389 0039d316-1c4b-4281-b951-d872f2087c98
* Make Combobox portableben@chromium.org2009-06-0212-268/+617
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17382 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17368.thestig@google.com2009-06-022-99/+22
| | | | | | | TBR=beng Review URL: http://codereview.chromium.org/119019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17375 0039d316-1c4b-4281-b951-d872f2087c98
* Make separator portable. Simpler than other native controls so no wrapper ↵ben@chromium.org2009-06-012-22/+99
| | | | | | | | | | interface. TEST=none BUG=none Review URL: http://codereview.chromium.org/118065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17368 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of related bugs:sky@chromium.org2009-06-011-10/+27
| | | | | | | | | | | | | | | | . gdk_display_get_pointer requires a display. . Don't do anything in NativeViewHostGtk if asked to remove and there is no native view. . Make NativeViewHostGtk deal with the native view already having the same parent. . Implement a couple of methods in NativeTabContentsContainerGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/115989 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17349 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the views table functions into separate header files. Many users onlybrettw@chromium.org2009-05-3111-217/+298
| | | | | | | | | | | | | | need either the view or model observers and that's it. I moved the model constructors to a .cc file so we don't have to include l10n_util.h for everybody. A surprising number of files were getting l10n_util from the table code, so I had to add it in a bunch of places. There should be no code change except I made the table column cosntructors take wstring references instead of copies. Review URL: http://codereview.chromium.org/115969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get gtk/views to bring up browser window w/out crashingdavemoore@chromium.org2009-05-303-4/+8
| | | | | | | TBR: beng Review URL: http://codereview.chromium.org/118051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17292 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk work: NativeViewPhotoboothGtk, adds a missing methodsky@chromium.org2009-05-291-0/+4
| | | | | | | | | | | to NativeViewHostGtk and location bar view colors. BUG=none TEST=none Review URL: http://codereview.chromium.org/115958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-291-1/+1
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the insert key so we don't switch into overtype mode (which surprises ↵pkasting@chromium.org2009-05-291-0/+4
| | | | | | | | | | users since there's no indicator of it). BUG=6856 TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type. Your text should prepend to the existing text instead of replacing it. Review URL: http://codereview.chromium.org/115934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17231 0039d316-1c4b-4281-b951-d872f2087c98
* Gets button_dropdown compiling on linux.sky@chromium.org2009-05-291-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak... the wrapped platform helper isn't a view, so it's not ↵ben@chromium.org2009-05-293-6/+7
| | | | | | | | | | auto-deleted... use a scoped_ptr instead! BUG=none TEST=none Review URL: http://codereview.chromium.org/118025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17220 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match ↵ben@chromium.org2009-05-2926-557/+674
| | | | | | | | | | the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView). BUG=none TEST=none Review URL: http://codereview.chromium.org/114059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98
* Get textfield to compile on linux.sky@chromium.org2009-05-292-1/+11
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/113981 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17153 0039d316-1c4b-4281-b951-d872f2087c98
* IE and Firefox always translate (alt+numpad 7) as an accelerator. We should ↵pkasting@chromium.org2009-05-281-4/+5
| | | | | | | | | | too. BUG=5372 TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7. You should navigate to your home page (by default, the new tab page). Review URL: http://codereview.chromium.org/113971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out textfield on GTKben@chromium.org2009-05-286-4/+135
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17133 0039d316-1c4b-4281-b951-d872f2087c98
* Make Textfield more portable.ben@chromium.org2009-05-286-1189/+1328
| | | | | | | | | | | | | Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface. The APIs aren't perfectly tidy yet but this is a good first pass. BUG=none TEST=make sure you can still edit text fields, run the view unit tests. Review URL: http://codereview.chromium.org/113940 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98
* Makes MenuButton compile and fixes bug in GtkWidget I happened upon.sky@chromium.org2009-05-271-1/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17018 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_field.cc and rename the class to Textfield in preparation for porting.ben@chromium.org2009-05-279-113/+110
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17014 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tyoshino patch.jcampan@chromium.org2009-05-271-0/+4
| | | | | | | | | See http://codereview.chromium.org/115768 TBR=tyoshino Review URL: http://codereview.chromium.org/115822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16999 0039d316-1c4b-4281-b951-d872f2087c98
* Make toolbar compile on linux.ben@chromium.org2009-05-272-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16997 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 11863 (Take 2).hbono@chromium.org2009-05-261-0/+16
| | | | | | | | | | | | This change is exactly the same change as <http://codereview.chromium.org/115353>. I would like to re-send this change because the PC that I created this original change has been dead and I have not been able to commit. This issue is caused by a stupid mistake of mine that I forgot adding a WM_IME_ENDCOMPOSITION handler to update the find results when a composition is finished (or canceled). This change adds a handler for WM_IME_ENDCOMPOSITION messages to update the find results. BUG=11863 "Korean find-in-page: Backspace all the way, Chrome will highlight all the characters that contain the first consonant" TEST=Open a Korean page, type Control+F keys, Switch the input language to Korean, type a right-alt key, type a 'w' key, type a 'k' key, type a 'a' key, type a backspace key, and verify there are not any highlited characters. Review URL: http://codereview.chromium.org/113847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16934 0039d316-1c4b-4281-b951-d872f2087c98
* Stubs out FocusManager and Menu so they compile on Linux.sky@chromium.org2009-05-262-0/+134
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115794 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16928 0039d316-1c4b-4281-b951-d872f2087c98
* Change the native type passed to Menu to get the system menu. The system menubrettw@chromium.org2009-05-262-2/+2
| | | | | | | | is associated with a window, so it should be a NativeWindow instead of NativeWidget. Review URL: http://codereview.chromium.org/113850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16895 0039d316-1c4b-4281-b951-d872f2087c98
* Gets link to compile on linux.sky@chromium.org2009-05-232-2/+21
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16831 0039d316-1c4b-4281-b951-d872f2087c98
* Makes FindBarWin buildable on linux. FindBarWin should be renamed tosky@chromium.org2009-05-231-4/+14
| | | | | | | | | | | FindBarViews, but I'm leaving it as is for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/113793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16830 0039d316-1c4b-4281-b951-d872f2087c98
* Some more porting of browser_views.brettw@chromium.org2009-05-221-6/+3
| | | | | | Review URL: http://codereview.chromium.org/113794 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16809 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dependencies on Windows-specific files in BrowserView. The usagebrettw@chromium.org2009-05-222-0/+9
| | | | | | | | of WindowWin was unnecessary so I removed it. I created a function in Menu go get the system menu so that can be ported inside views. Review URL: http://codereview.chromium.org/113785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16797 0039d316-1c4b-4281-b951-d872f2087c98
* Middle clicking on a bookmark from the bookmark manager nowbrettw@google.com2009-05-222-0/+24
| | | | | | | | | | opens that bookmark in a new foreground tab. http://crbug.com/7788 Checked in for Meelap Shah Original review = http://codereview.chromium.org/115665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16760 0039d316-1c4b-4281-b951-d872f2087c98
* Parts of my previous changelist didn't make it through.ben@chromium.org2009-05-215-5/+4
| | | | | | | http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16678 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 03:41:20 +0000