summaryrefslogtreecommitdiffstats
path: root/views/controls
Commit message (Collapse)AuthorAgeFilesLines
* Clone of issue 577015.twiz@chromium.org2010-02-121-3/+8
| | | | | | | | | | | See http://codereview.chromium.org/577015 for the review status of this CL. BUG=None TEST=ExtensionApiTest.Popup Review URL: http://codereview.chromium.org/600101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed alignment of button dropdowns for RTL languages.avayvod@chromium.org2010-02-113-10/+26
| | | | | | | | | | | BUG=none TEST=Run chrome with LANGUAGE=ar or with --lang=ar. Verify that all status area menus as well as main menu are aligned properly (go to the right, not to the left). Review URL: http://codereview.chromium.org/601032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38807 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-102-0/+16
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where if there are only localstorage nodes, but nocookies nodes, ↵ian@chromium.org2010-02-101-4/+4
| | | | | | | | | the Remove and Remove All buttons are disabled.BUG=34886 TEST=clear all cookies, go to www.ianfette.com/localstorage.html and open cookies dialog, check that remove button is enabled. Review URL: http://codereview.chromium.org/596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38640 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-107-15/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Disable lables for disabled checkboxes. Original patch by Philippe Beaudoin ↵pkasting@chromium.org2010-02-092-6/+13
| | | | | | | | | (see http://codereview.chromium.org/567026 ), r=ben,me. BUG=22982 TEST=Go to Options->Personal Stuff->Import data from another browser...->From "Google Toolbar". Labels for disabled checkboxes should also look disabled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38523 0039d316-1c4b-4281-b951-d872f2087c98
* Need to update enabled state of gtk wrapper even if native view hasn't been ↵davemoore@chromium.org2010-02-071-2/+0
| | | | | | | | | | | created Bug=None Test=None Review URL: http://codereview.chromium.org/577043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38321 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-061-3/+5
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-052-5/+5
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in disabling browser action from context menu onsky@chromium.org2010-02-023-5/+33
| | | | | | | | | | | | | | | | views/gtk. The crash occurred because on views we dispatch the menu action immediately (well, after the nested message loop exits), but on windows the action is posted after a delay. The code wasn't written to deal with immediate dispatch, so I changed the gtk code to post a task to dispatch activation. I've also added a warning that menu2 won't work on the stack, which has always been the case, just not stated. BUG=33619 TEST=see bug report. Review URL: http://codereview.chromium.org/557065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37835 0039d316-1c4b-4281-b951-d872f2087c98
* Get the initial selection work. and removed unnecessary initialization.oshima@chromium.org2010-02-023-6/+4
| | | | | | | | | BUG=33609 TEST=added the initial selected item in combobox example. Review URL: http://codereview.chromium.org/567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu leak in menu2.oshima@chromium.org2010-02-012-10/+34
| | | | | | | | | | | | Added "destroy" signal handler to delete menu2 only when the native gtk widget gets destroyed first. BUG=33475 TEST=chromeos valgrind tests passes without suppression. Review URL: http://codereview.chromium.org/557058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37708 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing a known leak erroroshima@chromium.org2010-01-291-0/+1
| | | | | | | | | | | | Seems like this was never executed in the test. TBR=viettrungluu@chromium.org BUG=33475 TEST=valgrind test should cycle green Review URL: http://codereview.chromium.org/553146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so deleting a bookmark from the context menu doesn't closesky@chromium.org2010-01-287-24/+108
| | | | | | | | | | | | | the bookmark menu. BUG=2469 TEST=click on a bookmark folder on the bookmark bar, right click on an item and chose delete. Make sure the folder stays up and still works correctly (and the item you deleted isn't there). Review URL: http://codereview.chromium.org/551178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37424 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes unintialized read in networkmenu. Menu's constructor calls intosky@chromium.org2010-01-271-0/+6
| | | | | | | | | | | | | the delegate, making using 'this' in the member intializer list for creating a menu problematic. I've changed it to a scoped_ptr and created as needed. BUG=none TEST=none Review URL: http://codereview.chromium.org/552187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37298 0039d316-1c4b-4281-b951-d872f2087c98
* implement infobars and delegates placeholders for translate feature.kuan@chromium.org2010-01-272-64/+84
| | | | | | Review URL: http://codereview.chromium.org/546132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37281 0039d316-1c4b-4281-b951-d872f2087c98
* Add overflow menu to the browser action container (part 2 offinnur@chromium.org2010-01-272-11/+21
| | | | | | | | | | | | | | | | | supporting resize for the container). Also improved RTL support a bit (the divider wasn't drawn on the right side of the container and resizing was reversed). BUG=32101 TEST=Overflow menu for browser action container should now work. Make sure to test also right-clicking on a menu item in the overflow menu to bring up a context menu for that item. And resizing the container in RTL locales should work. Review URL: http://codereview.chromium.org/557006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37232 0039d316-1c4b-4281-b951-d872f2087c98
* Don't emit focus event when moving focus around when re-creating fixed widget.oshima@chromium.org2010-01-271-5/+75
| | | | | | | | | | | | - This fixes the crash in compact navigation bar without a adjustment. - I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView. BUG=chromium-os:1010 TEST=manual: compact nav bar does not crash. Review URL: http://codereview.chromium.org/548151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
* Resize and overflow for browser actions (part 1).finnur@chromium.org2010-01-222-0/+145
| | | | | | | | | | | | | | | | | | | | | | | | | This changelist implements the following: - A resize gripper and chevron in the browser action container - Overflow when icons don't fit - Snap to multiple of icon size (no excess pixels) - Animation when resizing container / adding&removing icons (disable, enable). - Persists the last width of the browser action container. Known issues: - No menu (yes, the chevron button doesn't do anything yet). BUG=32101 TEST=Install and uninstall browser actions & make sure install bubble appears in the right location. Make sure browser action container does not expand if chevron is showing when you add browser action. Make sure container loses chevron when no overflow occurs. Make sure browser action icons never disappear due to shrinking when you release the mouse (when resizing). Make sure snapping works. Review URL: http://codereview.chromium.org/553039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where submenus weren't working on views/gtk. Submenus end upsky@chromium.org2010-01-213-12/+52
| | | | | | | | | | | | | creating nested menus. This means that the menu Run is invoked on isn't necessarily the selected menu. I need to push up state to the menu run is invoked on, otherwise nothing happens when a menu is selected. BUG=32662 TEST=see bug Review URL: http://codereview.chromium.org/545142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36782 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-2/+2
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus on views/gtk. The crash would happen ifsky@chromium.org2010-01-072-5/+21
| | | | | | | | | | | | | | | between the time we called into the model when the user selected an item and the time MessageLoop::Quit is processed the menu was destroyed, we would crash. As MessageLoop::Quit isn't immediate, and we really don't want to call out from a nested message loop, we wait until the quit is processed, then notify the model. CROS_BUG=1108 TEST=see bug Review URL: http://codereview.chromium.org/521063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35746 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts change to native_view_host_gtk. This fixes the bug, but isn'tsky@chromium.org2010-01-071-2/+0
| | | | | | | | | | | | the right fix. Current code is correct. BUG=31132 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/523141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that resulted in background tabs not getting sizedsky@chromium.org2010-01-071-1/+3
| | | | | | | | | | | | | correctly. When using fixed like we are we need to explicitly call allocate, otherwise the child won't get a size allocate and correctly update itself. BUG=31132 TEST=see bug Review URL: http://codereview.chromium.org/525093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35719 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-071-1/+19
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of unnecessary .c_str() calls.pkasting@chromium.org2010-01-061-22/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/527010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-062-0/+39
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-238-14/+36
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radio items in views::Menu2 for Linux.satorux@chromium.org2009-12-161-0/+10
| | | | | | | | | | | | | | | Suppose there are three radio items A, B, C, and A is now being checked. If you click C, commands associated with A and C are both executed. This is because A also receives the "activate" signal, before C receives it. We want only the command associated with A to get executed. BUG=30310 TEST=try; manually with view_examples Review URL: http://codereview.chromium.org/491076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34644 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-151-2/+6
| | | | | | | | | | | | | | | | | | | . Native buttons were adding 8 pixels to each side of the preferred size. This isn't necessary on Gtk as the preferred size already includes padding. . I changed WidgetGtk so that it no longer needs to explicitly set a size request. Explicitly setting a size request is a bit of pain because it means you can't ask for the widget real size request without unsetting the explicit size request. Instead I've subclassed GtkFixed so that you can either have the default behavior, or use the allocated size rather than current size. CHROME_OS_BUG=1003 TEST=see bug Review URL: http://codereview.chromium.org/504003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34564 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-052-11/+67
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in textfield on views/gtk where we weren't properlysky@chromium.org2009-12-042-21/+23
| | | | | | | | | | | | | accounting for border size if not specified by style. Also changes button on views/gtk not to fix the pref height at 29. There is no reason for us to do this. BUG=none TEST=none Review URL: http://codereview.chromium.org/462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33882 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0413-415/+54
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Implement keyboard access between bookmarks and main toolbar.mhm@chromium.org2009-12-042-0/+15
| | | | | | | | | | | | | | | | Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views. Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab. There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed: bool IsAccessibleViewTraversable(views::View* view) BUG=25625 TEST=Test to see if the main toolbar and bookmarks bar is traversable. Review URL: http://codereview.chromium.org/333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33793 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views not draw focus for native controls on Gtk. As Gtk renderssky@chromium.org2009-12-0314-12/+63
| | | | | | | | | | | the focus for us, this resulted in double the focus indicators. BUG=none TEST=none Review URL: http://codereview.chromium.org/468004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33739 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/449003/show for Thiago:sky@chromium.org2009-12-017-18/+20
| | | | | | | | | | | | | | views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS). Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues pointed by lint. BUG=none TEST=none Review URL: http://codereview.chromium.org/449075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the table view to Linux toolkit views.jcampan@chromium.org2009-12-016-30/+458
| | | | | | | | | | | | | | It is the initial implementation, it is still missing: - row focusing - resizable columns - autosize columns BUG=None TEST=Run the unit-tests, play with the TableView2 tab in the view examples. Review URL: http://codereview.chromium.org/434066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33400 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to bookmark bar that when clicked imports bookmarks. I alsosky@chromium.org2009-11-302-1/+8
| | | | | | | | | | | | added support for baselines to GridLayout. BUG=4374 TEST=On a new profile make sure the bookmark bar has a link to import bookmarks, click the link and make sure you can import your bookmarks. Review URL: http://codereview.chromium.org/440029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure gtk menus fit on screen before showing them.sky@chromium.org2009-11-301-4/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33328 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double freeing image list in TableView.mal@chromium.org2009-11-252-13/+0
| | | | | | | | | | | Committing http://codereview.chromium.org/387056 on behalf of Dan. BUG=27729 TEST=run NullModelTableViewTest.NullModel in app verifier or wine TBR= dank,jhawkins Review URL: http://codereview.chromium.org/437054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33055 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in tree view:sky@chromium.org2009-11-251-4/+9
| | | | | | | | | | | | | | | | | . Invoking SetRootShown before the tree was created resulted in updating internal structures with wrong info. This caused problems if you later tried to delete. I've added a DCHECK to make sure we don't hit this again. . Adding a node to the root when the root wasn't shown silently failed. BUG=none TEST=make sure bookmark manager doesn't have any problems when adding/removing nodes. Review URL: http://codereview.chromium.org/434053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33023 0039d316-1c4b-4281-b951-d872f2087c98
* Group Menu2Model::TYPE_RADIO menu items correctly. Currently an ↵yusukes@google.com2009-11-242-9/+26
| | | | | | | | | | | | | | implementation of the Menu2Model::GetGroupIdAt() interface seems to be ignored. This change is necessary in order to implement the menu for Chrome OS Text Input: https://sites.google.com/a/google.com/chromium-developer-central/chromiumos-1/chromiumos-design-docs/text-input/input.png?attredirects=0 BUG=none TEST=none Review URL: http://codereview.chromium.org/414031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32903 0039d316-1c4b-4281-b951-d872f2087c98
* views: remove some unnecessary static_cast<int>.maruel@chromium.org2009-11-232-6/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/429004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32837 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-202-5/+8
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-182-3/+33
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Make the char encoding indicator visible again on Windowsjshin@chromium.org2009-11-161-1/+2
| | | | | | | | | | | BUG=26438 TEST=Go to any web page and see if the character encoding is indicated in Page menu - Encoding. Patch by Satoshi.Matsuzaki with a slight modification.`(see the bug) Review URL: http://codereview.chromium.org/391066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32064 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32012-32017mhm@chromium.org2009-11-152-15/+0
| | | | | | | | | | | git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Review URL: http://codereview.chromium.org/396006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
* rebasemhm@chromium.org2009-11-152-0/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug where the textfield would paint outside of its boundsjcampan@chromium.org2009-11-131-1/+2
| | | | | | | | | | | when scrolled. BUG=26867 TEST=See steps in bug. Review URL: http://codereview.chromium.org/391055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31947 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in treeview. The code for removing a node was notsky@chromium.org2009-11-121-2/+3
| | | | | | | | | | | | | | correctly updating internal data structures, which could lead to a future crash. When recursively deleting items we need to get the next item before removing from the tree, otherwise the tree returns null. BUG=27290 TEST=make sure no problems in using bookmark manager, especially when adding/removing urls/folders. Review URL: http://codereview.chromium.org/384092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31850 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 12:11:10 +0000