summaryrefslogtreecommitdiffstats
path: root/views/drag_utils.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rename Paint() to PaintForDrag() in two cases.thakis@chromium.org2011-03-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | Both TextButton and MenuItemView called the method that implements their painting Paint(), which is also the name of the superclass's Paint() method. The painting stack currently looks: TextButton::Paint() TextButton::OnPaint() View::Paint() which is confusing. MenuButton overrides the method from TextButton, so rename it there, too. Also convert the 2nd parameter of this function from a bool to an enum. BUG=70465,72205 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6625023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77015 0039d316-1c4b-4281-b951-d872f2087c98
* Convert IconLoader and IconManager to deal with gfx::Image rather than SkBitmap.rsesek@chromium.org2011-03-031-1/+1
| | | | | | | | | | | | | | This allows loading of icons in the platform format, avoiding unnecessary conversions if the image is going to be used with the platform toolkit. In other cases, this just pushes image conversion to the callsite rather than the actual image load. BUG=19685 TEST=unit_tests and visual inspection of icons in the download shelf Review URL: http://codereview.chromium.org/6597043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76743 0039d316-1c4b-4281-b951-d872f2087c98
* De-wstringify OSExchangeData.evan@chromium.org2011-03-021-1/+1
| | | | | | | | | | | (Note that I didn't need to adjust many callers on the Windows side because wstring and string16 are compatible on Windows.) BUG=23581 Review URL: http://codereview.chromium.org/6596087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76563 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-051-2/+2
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: Remove much of ToWStringHack, adding a LossyDisplayName()evan@chromium.org2011-02-041-1/+1
| | | | | | | | | | | | | | | The reason we don't want a free conversion between FilePaths and Unicode is that it can be lossy. But when displaying a string to the user, we're ok if it's lossy when we have no other option. This change introduces a LossyDisplayName() method that returns a string16, and converts many of the users of ToWStringHack to use it. BUG=69467 Review URL: http://codereview.chromium.org/6246036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73840 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-201-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Move OSExchangeData from src/app to src/ui/base/dragdropben@chromium.org2011-01-121-1/+3
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71205 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71169 - Revert 71167 - Remove wstring from gfx.avi@chromium.org2011-01-121-1/+1
| | | | | | | | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6130008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71167 - Remove wstring from gfx.joi@chromium.org2011-01-121-1/+1
| | | | | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71169 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from gfx.avi@chromium.org2011-01-121-1/+1
| | | | | | | | | BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71167 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath.tfarina@chromium.org2010-12-231-3/+2
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6070008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70006 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-131-3/+3
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-311-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate more old filepath functions.evan@chromium.org2010-07-011-1/+1
| | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Review URL: http://codereview.chromium.org/2861042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51453 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-251-6/+3
| | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome/win: Show preview images when dragging images.thakis@chromium.org2010-06-251-0/+8
| | | | | | | | | BUG=11457 TEST=Go to google.com, drag logo around. Should be attached to cursor. Review URL: http://codereview.chromium.org/2870026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-241-2/+5
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-241-5/+2
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 2.ben@chromium.org2010-06-231-0/+3
| | | | | | | | | | | | - Rename Canvas to CanvasSkia. - Create a subclass Canvas that inherits from CanvasSkia for compatibility. BUG=none TEST=none Review URL: http://codereview.chromium.org/2862025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-231-2/+2
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-081-6/+6
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Implements file contents support in OSExchangeData and DropTargetsky@chromium.org2009-09-231-4/+7
| | | | | | | | | | | | | for gtk. Makes html and file contents support in OSExchangeData only for windows (as that is the only place we need it), and makes dragging files work. BUG=none TEST=none Review URL: http://codereview.chromium.org/232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26995 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors drag_utils.sky@chromium.org2009-05-281-74/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17080 0039d316-1c4b-4281-b951-d872f2087c98
* Parts of my previous changelist didn't make it through.ben@chromium.org2009-05-211-1/+1
| | | | | | | http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16678 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16567.ben@chromium.org2009-05-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16575 0039d316-1c4b-4281-b951-d872f2087c98
* views/ should use resources from app/resources. Move dependent images to ↵ben@chromium.org2009-05-211-1/+1
| | | | | | | | | this location. http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-151-7/+7
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-151-1/+1
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-081-1/+0
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-081-0/+160
standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 12:52:12 +0000