summaryrefslogtreecommitdiffstats
path: root/views/examples
Commit message (Collapse)AuthorAgeFilesLines
* TextStyles in TextfieldViewsoshima@google.com2011-06-012-2/+34
| | | | | | | | | | | | | | | | | | | | | - TextStyle class that specify the styles. - Model owns TextStyle object. No need for client to manage memory. - It updates style list each time new item is added and resolves overlap so that Paint method can simply iterate and paint them. - I changed selection so that it simply changes background of the selected text. This seems to be how webkit does and is much simpler. URL decoration in omnibox Renamed ClearCompositionText -> CancelCompositionText No need to review changes to range. (http://codereview.chromium.org/7039051/) BUG=none TEST=added tests for textfield views. Review URL: http://codereview.chromium.org/7047023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87552 0039d316-1c4b-4281-b951-d872f2087c98
* Changing Checkbox class to use NativeTheme class for rendering instead ofrogerta@chromium.org2011-06-012-6/+5
| | | | | | | | | | | | | native controls. The original Checkbox class is renamed to NativeCheckbox. BUG=None TEST=The affected locations are: chromeos EULA page, uninstall view, chromeos wifi config, and create application shortcut view. Should verify that checkboxes in these locations look and behave as they did before. Review URL: http://codereview.chromium.org/7082041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87484 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a basic NativeWindowViews.ben@chromium.org2011-05-253-0/+128
| | | | | | | | http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/7069022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86736 0039d316-1c4b-4281-b951-d872f2087c98
* Chromeos: virtual destructors should have virtual keyword (part 4).hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | Nu functionality change: virtual is only added to destructors that are already implicitly virtual. BUG=83408 TEST=chromiumos clang bot goes green TBR=battre Review URL: http://codereview.chromium.org/7031049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86620 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of the NativeWidgetViews.ben@chromium.org2011-05-241-3/+46
| | | | | | | | | | | - Move NativeWidgetView to its own file. - Enhances the example to contain a button. http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/7065042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86527 0039d316-1c4b-4281-b951-d872f2087c98
* Add NativeWidgetViews. This is a stub implementation that mostly just defers ↵ben@chromium.org2011-05-243-0/+72
| | | | | | | | | | to its parent NativeWidget. http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/6990048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86488 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome to use the new native themed radio button.rogerta@chromium.org2011-05-232-18/+28
| | | | | | | | | | | | | | | | | | While testing the chromeos password changed dialog, I noticed that the dialog was clipped at the bottom, so that the text field to enter the old password was not fully visible. This was with and without my change. To fix, I increase the height of the dialog, hence the locale_settings.grd change. BUG=None TEST=Make sure all uses of radio buttons in chrome, on all platforms including chromeos, work as expected. The look may be slightly different, but the behaviour should be the same. To test the password changed dialog on chromeos, login and then logout with a given account. Change the password of that account (with another computer for example) and then log back in using the new password. The text field at the bottom should not be clipped. Review URL: http://codereview.chromium.org/6955002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86283 0039d316-1c4b-4281-b951-d872f2087c98
* Move RootView to the internal namespace.ben@chromium.org2011-05-201-2/+2
| | | | | | | | | | | Most people should not be using the RootView type. The few cases that do should static_cast for now, until I can find a way to expose the functionality they need on Widget. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/7040018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86084 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WidgetWin/Gtk -> NativeWidgetWin/Gtk.ben@chromium.org2011-05-191-2/+2
| | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/7039050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85910 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land:ben@chromium.org2011-05-131-3/+3
| | | | | | | | | | | | Split the hierarchy. Now with AutocompletePopup implementing SupportsWeakPtr as before. This fixes the Windows XP crashes in browser_tests. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7015051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85269 - Split the hierarchy. ben@chromium.org2011-05-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7011038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85283 0039d316-1c4b-4281-b951-d872f2087c98
* Split the hierarchy. ben@chromium.org2011-05-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85269 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the unintentional change.oshima@google.com2011-05-111-4/+0
| | | | | | | | | | | | I accidentally included the change that I didn't intend, sorry about that. TBR=msw@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7002021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84907 0039d316-1c4b-4281-b951-d872f2087c98
* Undo Redo for Textfield Viewsoshima@google.com2011-05-113-0/+10
| | | | | | | | | | | | | | | Added Edit and its subclass that represents a change that can be undone/redone. Set TestViewsDelegates in examples_main.cc to make cut&copy work in views_examples. I'll refactor this soon so that text change is always done by an edit object. BUG=none TEST=unit tests for undo/redo Review URL: http://codereview.chromium.org/6937002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84902 0039d316-1c4b-4281-b951-d872f2087c98
* Enable TestViewsDelegates for views unittests and views_examples by defaultoshima@google.com2011-05-101-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6980004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84720 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi-line support to TextButtonBase since this is needed by the derivedrogerta@chromium.org2011-05-061-7/+18
| | | | | | | | | | | | | checkbox and radio button classes. BUG=None TEST=There should be no visible changes to existing text buttons, since this option is off by default. It will be turned on for some radio buttons and checkboxes in a future CL. Review URL: http://codereview.chromium.org/6927023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84471 0039d316-1c4b-4281-b951-d872f2087c98
* Use single command line flag for all pure Views situations,saintlou@chromium.org2011-05-031-0/+7
| | | | | | | | | | | rather than enabling case by case BUG=none TEST=none Review URL: http://codereview.chromium.org/6911018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error: 'comparison between signed and unsigned integer ↵sadrul@chromium.org2011-04-291-4/+4
| | | | | | | | expressions.' (regressed in r83535) TBR=rogerta@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83574 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change to fix a build break in the clang builder. A virtualrogerta@chromium.org2011-04-299-21/+187
| | | | | | | | | | | | | | | | | | | | | method in a derived class was not marked as virtual. Resubmitting change to fix a build break in the arm builder. The only change from the original code is in text_button.cc, line 402, where text_x is initialized to 0. Add classes for native themed push buttons, radio buttons, and checkboxes. These controls expose the same public interface and the existing controls of the same type to make it easier to change between the implementations. BUG=None TEST=The new controls should look and feel like native platform controls R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83373 Review URL: http://codereview.chromium.org/6853015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83535 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83373 - Resubmitting change to fix a build break in the arm builder. ↵rogerta@chromium.org2011-04-289-187/+21
| | | | | | | | | The only changefrom the original code is in text_button.cc, line 402, where text_x isinitialized to 0.Add classes for native themed push buttons, radio buttons, and checkboxes.These controls expose the same public interface and the existing controlsof the same type to make it easier to change between the implementations.BUG=NoneTEST=The new controls should look and feel like native platform controlsR=ben@chromium.orgReview URL: http://codereview.chromium.org/6853015 TBR=rogerta@chromium.org Review URL: http://codereview.chromium.org/6902119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83378 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change to fix a build break in the arm builder. The only changerogerta@chromium.org2011-04-289-21/+187
| | | | | | | | | | | | | | | | | from the original code is in text_button.cc, line 402, where text_x is initialized to 0. Add classes for native themed push buttons, radio buttons, and checkboxes. These controls expose the same public interface and the existing controls of the same type to make it easier to change between the implementations. BUG=None TEST=The new controls should look and feel like native platform controls R=ben@chromium.org Review URL: http://codereview.chromium.org/6853015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83373 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83110 - Add classes for native themed push buttons, radio buttons, ↵rogerta@chromium.org2011-04-279-187/+21
| | | | | | | | | and checkboxes.These controls expose the same public interface and the existing controlsof the same type to make it easier to change between the implementations.BUG=NoneTEST=The new controls should look and feel like native platform controlsR=ben@chromium.orgReview URL: http://codereview.chromium.org/6853015 TBR=rogerta@chromium.org Review URL: http://codereview.chromium.org/6904040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83111 0039d316-1c4b-4281-b951-d872f2087c98
* Add classes for native themed push buttons, radio buttons, and checkboxes.rogerta@chromium.org2011-04-279-21/+187
| | | | | | | | | | | | | These controls expose the same public interface and the existing controls of the same type to make it easier to change between the implementations. BUG=None TEST=The new controls should look and feel like native platform controls R=ben@chromium.org Review URL: http://codereview.chromium.org/6853015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83110 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CreateParams to InitParams.ben@chromium.org2011-04-261-2/+2
| | | | | | | | | http://crbug.com/72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6901034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83057 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way Widget::Init works:ben@chromium.org2011-04-261-9/+12
| | | | | | | | | | | | | - Remove SetCreateParams from the public Widget API. - Add parent/bounds fields to CreateParams - Make Widget::Init be the canonical init method (vs. WidgetWin/Gtk Init) and have it take a CreateParams. - NativeWidget now has a InitNativeWidget method, which subclasses can override. Everyone must call Widget::Init via Widget* (not WidgetWin* as this will be ambiguous to WindowImpl::Init). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6881107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83037 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move LinkController into its own header file.tfarina@chromium.org2011-04-252-6/+7
| | | | | | | | | | | | | | | | | | | While I'm here, did some changes: - Rename the LinkController interface to LinkListener. - Move the interface to link_listener.h - Rename the event from LinkActivated to LinkClicked. - Changed the get/set accessors to listener()/set_listener(). - Add OVERRIDE to LinkClicked methods. BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6881099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add Link example.tfarina@chromium.org2011-04-253-0/+80
| | | | | | | | | | | | BUG=None TEST=compile with toolkit_views=1, run out/Debug/views_examples. You should see a link tab, and a link with "Click me!" and make sure it works. R=oshima@chromium.org,sky@chromium.org Review URL: http://codereview.chromium.org/6883122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82870 0039d316-1c4b-4281-b951-d872f2087c98
* remove unused classsaintlou@chromium.org2011-04-213-88/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6880081 Patch from Emmanuel Saint-Loubert <saintlou@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82488 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile by initializing a variable.sadrul@chromium.org2011-04-111-1/+1
| | | | | | TBR=rogerta@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81139 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change because original caused build breaks:rogerta@chromium.org2011-04-113-0/+371
| | | | | | | | | | | | | | | | | - clang build requires destructor in complex classes - chromeos build requires newline at end of files Adding a native theme painter, to allow Views to use NativeTheme to draw their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. BUG=None TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6820007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81128 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r80952, http://codereview.chromium.org/6771056dmichael@chromium.org2011-04-083-364/+0
| | | | | | | | | BUG=None TEST=None TBR=rogerta Review URL: http://codereview.chromium.org/6823011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80957 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a native theme painter, to allow Views to use NativeTheme to drawrogerta@chromium.org2011-04-083-0/+364
| | | | | | | | | | | | | | | their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. This CL depends on changes currently being made to native theme, see http://codereview.chromium.org/6728029/ for details. BUG=None TEST=None Review URL: http://codereview.chromium.org/6771056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80952 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more WidgetWin/WidgetGtk creations to use a new cross-platform ↵ben@chromium.org2011-03-281-9/+5
| | | | | | | | | | static ctor on Widget: CreateWidget(). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6732028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79586 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move MessageBoxView into the namespace views.tfarina@chromium.org2011-03-222-3/+7
| | | | | | | | | | | BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6715020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78994 0039d316-1c4b-4281-b951-d872f2087c98
* Add CreateParams to Widget, and replace CreatePopupWidget with CreateParams.ben@chromium.org2011-03-212-28/+17
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6712008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78893 0039d316-1c4b-4281-b951-d872f2087c98
* views: Cleanup TabbedPane class.tfarina@chromium.org2011-03-184-24/+36
| | | | | | | | | | | BUG=None TEST=views_examples, and existing views_unittests R=sky@chromium.org Review URL: http://codereview.chromium.org/6685039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix final nits on linux_viewserg@google.com2011-03-102-3/+12
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6612047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77584 0039d316-1c4b-4281-b951-d872f2087c98
* views: Moves TextfieldController/TextRange into their own headers.tfarina@chromium.org2011-03-102-5/+6
| | | | | | | | | BUG=None TEST=existing unit_tests Review URL: http://codereview.chromium.org/6628037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77571 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix the MenuExample so it doesn't crash.tfarina@chromium.org2011-03-071-1/+1
| | | | | | | | | | | | | | Instead of -1 (which is wrong and led us to crash) we need to pass 0. BUG=None TEST=run out/Debug/views_examples, go to the "Menu" tab, click on the menu, it should open and not crash. TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/6621035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile for views_examples after GetBounds removal.sadrul@chromium.org2011-03-031-2/+1
| | | | | | | | BUG=none TEST=views_examples compiles TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76776 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of MenuExample to the source file.tfarina@chromium.org2011-02-252-181/+228
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6548001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76025 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up RTL methods.ben@chromium.org2011-02-081-1/+1
| | | | | | | | | | | | | | No one used the non-RTL version of GetBounds(), so I renamed it GetMirroredBounds() and got rid of the enum. Same for GetX(), consolidated with MirroredX() into GetMirroredX(). GetPosition() already took into account mirroring, so renamed GetMirroredPosition() for symmetry. Renamed the other functions to be getters. De-inlined a few that were doing complex looking stuff. http://crbug.com/72040 TEST=none Review URL: http://codereview.chromium.org/6334152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74087 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of WidgetExample to the source file.tfarina@chromium.org2011-02-072-150/+198
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6368122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74041 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of more examples from header to source file.tfarina@chromium.org2011-02-019-299/+415
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6347030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73276 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of ButtonExample from the header to the ↵tfarina@chromium.org2011-01-292-20/+49
| | | | | | | | | | | source file. BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6288017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73049 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move grid_layout files into layout directory. Final Part.tfarina@chromium.org2011-01-275-7/+7
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6382009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compileisherman@chromium.org2011-01-252-2/+1
| | | | | | | | | | BUG=none TEST=green tree TBR=tfarina Review URL: http://codereview.chromium.org/6264014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72449 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move fill_layout.[cc,h] into layout directory.tfarina@chromium.org2011-01-255-10/+9
| | | | | | | | | | | The other layout files under views directory will be moved later. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6360014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72428 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move implementations of ComboboxExample and SliderExample to source file.tfarina@chromium.org2011-01-244-72/+126
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6366008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72328 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add table2_example to views_examples target.tfarina@chromium.org2011-01-232-150/+194
| | | | | | | | | | | Also move the implementation from header to the source file. BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6264010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72300 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 17:42:33 +0000