summaryrefslogtreecommitdiffstats
path: root/views/focus
Commit message (Collapse)AuthorAgeFilesLines
* Add DidChangeFocus to FocusChangeListener.alicet@chromium.org2011-11-107-11/+24
| | | | | | | | | | | | | | | Rename FocusChangeListener interface to OnWillChangeFocus and OnDidChangeFocus Move location bar focus interaction from AccessibilityPaneView to ToolBarView. BUG=101940 TEST=None Review URL: http://codereview.chromium.org/8416058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109482 0039d316-1c4b-4281-b951-d872f2087c98
* Convert View::HasFocus() to be const. Required adding const versions of ↵pkasting@chromium.org2011-10-261-1/+2
| | | | | | | | | | some accessors which in turn prompted me to make some uses of these accessors be a bit more const-correct. BUG=none TEST=none Review URL: http://codereview.chromium.org/8393024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107403 0039d316-1c4b-4281-b951-d872f2087c98
* Support keyboard navigation in avatar menusail@chromium.org2011-10-261-2/+3
| | | | | | | | | | | Added support for up arrow, down arrow, and tabbing. BUG=75782 TEST= Review URL: http://codereview.chromium.org/8363014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107379 0039d316-1c4b-4281-b951-d872f2087c98
* rename Run in MessageLoopForUI to RunWithDispatcheroshima@google.com2011-10-241-8/+8
| | | | | | | | | BUG=99471 TEST=none Review URL: http://codereview.chromium.org/8343023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106896 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change TextButton API to string16.tfarina@chromium.org2011-10-191-13/+16
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8346013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106302 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change Checkbox API to string16.tfarina@chromium.org2011-10-121-6/+6
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105088 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change RadioButton API to string16.tfarina@chromium.org2011-10-121-4/+4
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8229017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105067 0039d316-1c4b-4281-b951-d872f2087c98
* Change std::wstring to string16 for views::Label and views::Labelyosin@chromium.org2011-10-071-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | Redo for CR=8113031, it failed on linux_chromeos_clang. Following files are missed in CR=8113031 1 chrome/browser/chromeos/drop_shadow_label.cc 2 chrome/browser/chromeos/drop_shadow_label.h 3 chrome/browser/ui/views/cookie_info_view.cc 4 chrome/browser/ui/views/database_info_view.cc 5 chrome/browser/ui/views/hung_renderer_view.cccc 6 chrome/browser/ui/views/importer/import_lock_dialog_view.cc 7 chrome/browser/ui/views/task_manager_view.cc 8 ui/aura_shell/examples/bubble.cc 9 views/examples/bubble_example.cc 10 views/examples/link_example.cc 11 views/examples/native_theme_button_example.cc 12 views/examples/text_example.cc 13 views/examples/textfield_example.cc BUG=68267 TEST=no user visible changes Review URL: http://codereview.chromium.org/8162013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104445 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104076 - Change std::wstring to string16 for views::Linkhbono@chromium.org2011-10-051-15/+16
| | | | | | | | | | | | | | | Change wst::string to string16 for view::Label and views::Link BUG=68267 TEST=no user visible changes Review URL: http://codereview.chromium.org/8113031 TBR=yosin@chromium.org Review URL: http://codereview.chromium.org/8142026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104084 0039d316-1c4b-4281-b951-d872f2087c98
* Change std::wstring to string16 for views::Linkyosin@chromium.org2011-10-051-16/+15
| | | | | | | | | | | | Change wst::string to string16 for view::Label and views::Link BUG=68267 TEST=no user visible changes Review URL: http://codereview.chromium.org/8113031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104076 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change TabbedPane::AddTab() to string16.tfarina@chromium.org2011-09-291-6/+6
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8068009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103218 0039d316-1c4b-4281-b951-d872f2087c98
* Update TouchEvent initialize for USE_XI2_MT according tosadrul@chromium.org2011-09-281-3/+1
| | | | | | | | | | | http://codereview.chromium.org/7942004/ refactoring. BUG= TEST=build with touchui=1 use_xi2_mt=1 Review URL: http://codereview.chromium.org/8060002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103116 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix --touch-devices flag.sadrul@chromium.org2011-09-272-12/+7
| | | | | | | | | | | | This fixes the --touch-devices command-line flag, which can be used to create touch-events from a normal mouse device. BUG=none TEST=none Review URL: http://codereview.chromium.org/8048015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102936 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate/cleanup event cracking code; single out GdkEvents; saves ~850 lines.msw@chromium.org2011-09-261-16/+14
| | | | | | | | | | | | | | | | | | | | | Move ui::NativeEvent typdefs and common functions to ui/base/events.h. Remove NativeEvent2 typedef, single out GdkEvent* uses that should be removed. Implement platform specific ui/base/[platform]/events_[platform].cc. Revise views::NativeEvent definitions (to support Aura abstraction). Consolidate Event[Type/Flags/Location]FromNative(), GetMouseWheelOffset(), etc. Remove GetRepeatCount(), GetWindowsFlags(), IsExtendedKey(), etc. Add IsMouseEvent(), KeyboardCodeFromNative(), EF_EXTENDED flag, etc. Localize GetFlagsFromGdkEvent(), move some file locals to new helpers files. Move views/touchui/touch_factory.h|cc to ui/base/touch. Stop mixing Windows mouse events' MK_*BUTTON into their wParams. BUG=93945 TEST=No build breaks (many configs...), no mouse/key behavior changes. Review URL: http://codereview.chromium.org/7942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102815 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: support XInput2 multitouchsadrul@chromium.org2011-09-251-2/+22
| | | | | | | | | | | | | | Use XI2 multitouch events instead of mouse events as touch event input for touchui build. Note: XI MT will be supported in X server 1.12 and XI2.2. Please use build switch "use_xi2_mt=<minor version number>" to specify the minimum XI2 minor version. It is useful to test on experimental XI2.1 with MT support (e.g. build with use_xi2_mt=1). BUG=95150 TEST=(1) build with touchui=1 use_xi2_mt=1 (2) test on ubuntu 11.04 (X server 1.10 and XI2.1 with experimental MT support). (3) manually test if touch works on browser UI and JS touch events. Review URL: http://codereview.chromium.org/7792094 Patch from Ningxin Hu <ningxin.hu@intel.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102668 0039d316-1c4b-4281-b951-d872f2087c98
* These are the changes necessary for views to be able to build w/ use_aura ↵davemoore@chromium.org2011-09-221-1/+1
| | | | | | | | | | | implying no gtk. BUG=97131 TEST=views_unittests Review URL: http://codereview.chromium.org/7996008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102335 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aura Windows bustage.ben@chromium.org2011-09-191-1/+1
| | | | | | | | | BUG=none TEST=none TBR=saintlou Review URL: http://codereview.chromium.org/7950002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101772 0039d316-1c4b-4281-b951-d872f2087c98
* Aura under Linux is enabled with:saintlou@chromium.org2011-09-182-2/+7
| | | | | | | | | | | 'use_aura': 1, BUG=none TEST=none Review URL: http://codereview.chromium.org/7850026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views_aura_desktop build on Linux.tfarina@chromium.org2011-09-162-3/+8
| | | | | | | | | R=sky@chromium.org,sadrul@chromium.org,ben@chromium.org TEST=build with GYP_DEFINES="toolkit_views=1 use_aura=1", notice that the target views_aura_desktop builds and runs. Review URL: http://codereview.chromium.org/7887039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101506 0039d316-1c4b-4281-b951-d872f2087c98
* views: Export AutoNativeNotificationDisabler to fix the win builder.tfarina@chromium.org2011-09-141-1/+1
| | | | | | | | TBR=sky@chromium.org Review URL: http://codereview.chromium.org/7891029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101005 0039d316-1c4b-4281-b951-d872f2087c98
* views: Factor WidgetFocusManager out of FocusManager class.tfarina@chromium.org2011-09-144-109/+133
| | | | | | | | | | This moves WidgetFocusManager into its source/header files avoiding the use of nested classes. R=sky@chromium.org Review URL: http://codereview.chromium.org/7885001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101002 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove unused include of gtk/gtk.h from focus_manager.cctfarina@chromium.org2011-09-131-6/+1
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7870014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100845 0039d316-1c4b-4281-b951-d872f2087c98
* Get views_unittests to compile (but not run).ben@chromium.org2011-09-021-5/+19
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7824021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99278 0039d316-1c4b-4281-b951-d872f2087c98
* Move the mouse wheel utils from views to ui\base\win, to get rid of some ↵jam@chromium.org2011-08-262-158/+0
| | | | | | | | views dependencies in content. Review URL: http://codereview.chromium.org/7753025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98479 0039d316-1c4b-4281-b951-d872f2087c98
* Wayland support for views. views_desktop on Wayland.backer@chromium.org2011-08-262-1/+23
| | | | | | | | | | | | | | | | | | | | This CL depends on: * http://codereview.chromium.org/7457023 * http://codereview.chromium.org/7467007 * http://codereview.chromium.org/7473010 Wayland requires newer libraries than Ubuntu currently provides. I've created a list of required dependencies: https://sites.google.com/a/google.com/chrome_on_wayland/home/wayland-build-dependencies BUG= TEST=Built Chrome to verify that Wayland dependencies and changes don't interfere with the usual build. Review URL: http://codereview.chromium.org/7464027 Patch from Daniel Nicoara <dnicoara@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98453 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Create a new views_aura_desktop.ben@chromium.org2011-08-251-0/+20
| | | | | | | | | | | | Get views::Widget rendering working against an aura::Window NativeWidget. http://crbug.com/93944 TEST=none Original review URL: http://codereview.chromium.org/7741027 Review URL: http://codereview.chromium.org/7747032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98331 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98306 - Create a new views_aura_desktop.ben@chromium.org2011-08-251-20/+0
| | | | | | | | | | | | | Get views::Widget rendering working against an aura::Window NativeWidget. http://crbug.com/93944 TEST=none Review URL: http://codereview.chromium.org/7741027 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7749020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98312 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new views_aura_desktop.ben@chromium.org2011-08-251-0/+20
| | | | | | | | | | Get views::Widget rendering working against an aura::Window NativeWidget. http://crbug.com/93944 TEST=none Review URL: http://codereview.chromium.org/7741027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98306 0039d316-1c4b-4281-b951-d872f2087c98
* Add Aura support to views:ben@chromium.org2011-08-251-1/+1
| | | | | | | | | | | | | - change aura GYP_DEFINE to use_aura to be consistent with other switches - add gfx::NativeView/Window typedefs - add NativeWidgetAura/etc. - update some ifdefs and includes to build on windows. http://crbug.com/93944 TEST=none Review URL: http://codereview.chromium.org/7741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98234 0039d316-1c4b-4281-b951-d872f2087c98
* Get views_unittests pass on touch buildoshima@google.com2011-08-241-17/+11
| | | | | | | | | | | | | | | | * Changed views test to use ViewsTestBase. * Always calls ViewsTestBase::SetUp/TearDown. Added flags to check if this is enforced. * Excluded tests that does not make sense on touch/pure views build. BUG=none TEST=views_unittets now passes on touch build, with a few exceptions below. WidgetTest.GrabUngrab: assigned to sadrul NativeTextfieldViewsTest.DragAndDrop_XXX: msw will look into it. Review URL: http://codereview.chromium.org/7720020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98128 0039d316-1c4b-4281-b951-d872f2087c98
* Move input_method to widgetoshima@google.com2011-08-233-40/+150
| | | | | | | | | BUG=none TEST=none. no new functionality. all tests should pass. Review URL: http://codereview.chromium.org/7371007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97819 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression (and crash) in instant. The crash would happen ifsky@chromium.org2011-08-222-1/+10
| | | | | | | | | | | | | | | instant is enabled, you go to a page with an auth dialog, then click on one of the login buttons. This previously worked because focus was going to either the widget for the TabContentsView or RWHV (not sure which). Now that focus always goes to the topmost widget, it broke. BUG=89439 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7706003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97734 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Purify and Quantify.Doing so will reduce substantially the size of ↵jeanluc@chromium.org2011-08-172-2/+2
| | | | | | | | | the project files. BUG=92102 Review URL: http://codereview.chromium.org/7528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
* Rename VIEWS_API to VIEWS_EXPORT.darin@chromium.org2011-08-056-14/+15
| | | | | | | R=rvargas@chromium.org Review URL: http://codereview.chromium.org/7550038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95651 0039d316-1c4b-4281-b951-d872f2087c98
* Nix GetFocusManagerForNativeView|Window.msw@chromium.org2011-08-024-50/+30
| | | | | | | | | | | | Use Widget|View::GetFocusManager instead. Use Widget::Get[TopLevel]WidgetForNativeView|Window as necessary. BUG=88718 TEST=none Review URL: http://codereview.chromium.org/7532015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95111 0039d316-1c4b-4281-b951-d872f2087c98
* Use VIEWS_API in a few places to fix component build for chromeos and touchui.sadrul@chromium.org2011-07-281-2/+2
| | | | | | | | | BUG=none TEST=manually, build works with 'chromeos=1 touchui=1 component=shared_library' Review URL: http://codereview.chromium.org/7524028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94498 0039d316-1c4b-4281-b951-d872f2087c98
* Create views.dll / libviews.sodarin@chromium.org2011-07-286-15/+16
| | | | | | | R=sky@chromium.org,rvargas@chromium.org Review URL: http://codereview.chromium.org/7493017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94428 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused NativeButton codesaintlou@chromium.org2011-07-261-30/+25
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94114 0039d316-1c4b-4281-b951-d872f2087c98
* Views views_unittests FocusManagerTest.FocusNativeControls use after freedhollowa@chromium.org2011-07-251-1/+0
| | | | | | | | | | | | | | | Fixes issue where NativeTabbedPaneGtk gets retained by the top-level FocusManager during the Widget::Close tear-down sequence. This fix clears focus before proceeding with the tear-down. This avoids redundant operations with the FocusManger as views get deleted, specifically in the FocusManager::ViewRemoved() call. Caught by Valgrind as a use after free violation: sh tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls BUG=89596 TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls Review URL: http://codereview.chromium.org/7468037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93894 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Always expect XInput2 availability.sadrul@chromium.org2011-07-222-22/+0
| | | | | | | | | BUG=80790 TEST=touch compiles Review URL: http://codereview.chromium.org/6975045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93621 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some more view methods to the ui/views style.ben@chromium.org2011-07-151-6/+4
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7349021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92705 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up FocusManageroshima@google.com2011-07-144-83/+28
| | | | | | | | | | | | | | Use Widget API to get FocusManager for native_view/window. Move FocusNatieView to native widget impl. This is necessary for NativeWidgetX BUG=none TEST=none Review URL: http://codereview.chromium.org/7351008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92497 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add unittests for View::GetViewsWithGroup() method.tfarina@chromium.org2011-07-131-2/+1
| | | | | | | | | | | | | Also, rename it to GetViewsInGroup(). BUG=72040 TEST=views_unittests --gtest_filter=ViewTest.GetViewByID R=ben@chromium.org,sky@chromium.org Review URL: http://codereview.chromium.org/7328031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92430 0039d316-1c4b-4281-b951-d872f2087c98
* ClearNativeFocus: Do it from widget, with appropriate native-widget ↵sadrul@chromium.org2011-07-133-11/+7
| | | | | | | | | | | implementation. BUG=none TEST=none Review URL: http://codereview.chromium.org/7353007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92303 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91716 - Temporarily disable these tests while I repro the crashes.ben@chromium.org2011-07-071-4/+4
| | | | | | | TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7307038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91719 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable these tests while I repro the crashes.ben@chromium.org2011-07-071-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91716 0039d316-1c4b-4281-b951-d872f2087c98
* Switch FocusManager to using ObserverList instead of keeping its listeners ↵pkasting@chromium.org2011-06-292-52/+16
| | | | | | | | | | in a simple vector. BUG=none TEST=none Review URL: http://codereview.chromium.org/7280013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91052 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the glib message-pump, and use it as the base for a gtk message ↵sadrul@chromium.org2011-06-242-11/+12
| | | | | | | | | | | | | | | | | | | pump and an X message pump. The changes: * Rename MessagePumpGlibX to MessagePumpX. * Rename MessagePumpForUI to MessagePumpGlib. * Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX. * Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher. MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work. BUG=none TEST=existing message-pump tests. Review URL: http://codereview.chromium.org/7250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix even more crashes. To help identify remaining crashes now and in the ↵ben@chromium.org2011-06-161-3/+9
| | | | | | | | | | future, I have made the GetWidget methods on WidgetDelegate pure virtual. This will cause classes that don't define them to fail compile instead of crashing at run time. http://crbug.com/86119 TEST=none Review URL: http://codereview.chromium.org/7189019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89409 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 00:10:33 +0000