summaryrefslogtreecommitdiffstats
path: root/views/view.h
Commit message (Collapse)AuthorAgeFilesLines
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-041-1/+9
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to bookmark bar that when clicked imports bookmarks. I alsosky@chromium.org2009-11-301-0/+4
| | | | | | | | | | | | added support for baselines to GridLayout. BUG=4374 TEST=On a new profile make sure the bookmark bar has a link to import bookmarks, click the link and make sure you can import your bookmarks. Review URL: http://codereview.chromium.org/440029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in showing bookmark menus where the wrong menu wouldsky@chromium.org2009-11-111-1/+1
| | | | | | | | | | | appear when rtl. BUG=26376 TEST=see bug Review URL: http://codereview.chromium.org/384021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-071-3/+5
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* CompactLocationBar 1st step:oshima@chromium.org2009-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | * Added OnMouseXXXTab methods to BrowserExtender to handle on tabs. * Changed tab to call above methods. * Added GetSelectedTab to TabStrip Minor changes along with the major changes above * Removed unnecessary file entries in chrome.gyp * Fixed a few method's const. * Removed unnecessary class declarations and includes. Know issue: keyboard focus is not working. In 2nd step, I'm going to eliminate popup and use whatever that FindBar is using to show compact location bar. I'll fix the issue above after this migration. (if it still persists) BUG=None Test=None Review URL: http://codereview.chromium.org/341008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30386 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu button. I converted a call from GetWidget tosky@chromium.org2009-10-141-0/+3
| | | | | | | | | | | | | GetWindow, the problem is in certain scenarios GetWindow can return null. I've changed the code back to GetWidget and converted Screen from taking a NativeWindow to a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/269076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28986 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-1/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a NOTIMPLEMENTED in GoButton.sky@chromium.org2009-09-221-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/216045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26832 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few tiny things I noticed.pkasting@chromium.org2009-09-141-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/196110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26144 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/201102 for Oshima:sky@chromium.org2009-09-141-0/+2
| | | | | | | | | | | | | Don't allow updating group id once it's set. BUG=none TEST=none Review URL: http://codereview.chromium.org/205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26132 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-7/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-1/+7
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Relands drop support:sky@chromium.org2009-08-191-8/+20
| | | | | | | | | | | | Adds drop support for views on gtk. As X lazily provides drop data I needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/173025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23690 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts recent patch as broke build on toolkit_views.sky@chromium.org2009-08-181-20/+8
| | | | | | | | | TBR=ben BUG=none TEST=none Review URL: http://codereview.chromium.org/174023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds drop support for views on gtk. As X lazily provides drop data Isky@chromium.org2009-08-181-8/+20
| | | | | | | | | | | needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/165407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23653 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a couple of by value return types to const ref returnssky@chromium.org2009-07-171-4/+3
| | | | | | | | | | | types. Also expands on the documentation of GetViewForPoint. BUG=none TEST=none Review URL: http://codereview.chromium.org/149723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20969 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6103 -- Individual download items on the download shelf ↵xji@chromium.org2009-06-121-0/+13
| | | | | | | | | | | | | | | | | are not mirrored on RTL locales, and issue 13217 -- Dangerous File warning on the shelf in RTL seems to misplace the buttons Enable UI mirroring for DownloadItemView. During painting each download items, for those items without corresponding mirrored images, flip the canvas to paint the mirrored image. And flip canvas back to normal to paint others. BUG=http://crbug.com/6103 BUG=http://crbug.com/13217 Test=Open Hebrew Chrome, go to "http://build.chromium.org/buildbot/continuous/LATEST/", download mini_installer.exe, the layout of the warning should be "cancel_button ok_button warning_message warning_icon" from left to right. Click "ok" to download, the layout of the download item in download shelf should be "drop_down_icon download_file_name(or download_file_name with download_status) download_progress_animation and download icon" from left to right. Review URL: http://codereview.chromium.org/118260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18292 0039d316-1c4b-4281-b951-d872f2087c98
* A new menu system for views.ben@chromium.org2009-06-081-1/+1
| | | | | | | | This is all the functionality needed for the page, app menus and browser system menus. Review URL: http://codereview.chromium.org/119237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix keyboard accelerator registration issue in views::View.yutak@chromium.org2009-06-061-4/+9
| | | | | | | | | | View should not register the same accelerator target multiple times. BUG=13275 TEST=None Review URL: http://codereview.chromium.org/118242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17810 0039d316-1c4b-4281-b951-d872f2087c98
* Replace HCURSOR usage in views::View with a new gfx::NativeCursor type that ↵ben@chromium.org2009-06-041-6/+8
| | | | | | | | | | | | | also supports GdkCursor*, and wires this up with the existing implementors of the GetCursorForPoint method. This allows us to get rid of one of the most annoying NOTIMPLEMENTED()s in views-gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/119150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17614 0039d316-1c4b-4281-b951-d872f2087c98
* Some previous refactoring I did of the accelerator code had introduced ↵jcampan@chromium.org2009-06-031-9/+0
| | | | | | | | regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox) Review URL: http://codereview.chromium.org/119016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
* Gets button_dropdown compiling on linux.sky@chromium.org2009-05-291-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17229 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-151-11/+11
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-141-6/+4
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-141-17/+15
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 15965. I wasn't supposed to check that in since it still doesn't ↵maruel@chromium.org2009-05-131-4/+6
| | | | | | | | | compile on linux and mac! TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-131-6/+4
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15965 0039d316-1c4b-4281-b951-d872f2087c98
* Removing floating views, they are not used anymore.jcampan@chromium.org2009-05-111-146/+0
| | | | | | | | | BUG=None TEST=Run unit_tests, ui_tests, interactive ui_tests. Make sure focus traversal still works. Review URL: http://codereview.chromium.org/113215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15817 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-091-0/+4
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-081-1/+1
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-081-0/+7
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-0/+1351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 07:00:51 +0000